]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
20 months agoalways allocate track, even when replicating
Alan T. DeKok [Fri, 29 Nov 2024 14:56:55 +0000 (09:56 -0500)] 
always allocate track, even when replicating

20 months agoensure cbor_guess_type() always returns a type
Alan T. DeKok [Fri, 29 Nov 2024 14:21:55 +0000 (09:21 -0500)] 
ensure cbor_guess_type() always returns a type

and push error messages to that function

20 months agoremove replication-specific functions
Alan T. DeKok [Thu, 28 Nov 2024 20:20:52 +0000 (15:20 -0500)] 
remove replication-specific functions

request_mux_replicate() is now just 3 lines in request_mux()

20 months agoremove unused code
Alan T. DeKok [Thu, 28 Nov 2024 18:57:35 +0000 (13:57 -0500)] 
remove unused code

the status checks are handled separately, and not by the main
request_mux() code.

20 months agomove rlm_radius to using the unlang retry functionality
Alan T. DeKok [Thu, 28 Nov 2024 18:50:12 +0000 (13:50 -0500)] 
move rlm_radius to using the unlang retry functionality

20 months agoevents are parented from the "state" in the stack frame
Alan T. DeKok [Thu, 28 Nov 2024 18:39:56 +0000 (13:39 -0500)] 
events are parented from the "state" in the stack frame

so that they are cleaned up when the stack frame exits.

20 months agopush more things to rlm_radius_udp
Alan T. DeKok [Wed, 27 Nov 2024 19:39:25 +0000 (14:39 -0500)] 
push more things to rlm_radius_udp

in preparation for BIO handling

20 months agoPacify Coverity (CID #1634587)
Nick Porter [Fri, 29 Nov 2024 13:39:55 +0000 (13:39 +0000)] 
Pacify Coverity (CID #1634587)

Coverity doesn't see that the fixed arguments aways have variadic set,
so thought the loop would walk beyond the end of the argument list.

20 months agoCorrect comment on free ID range
Nick Porter [Fri, 29 Nov 2024 12:35:19 +0000 (12:35 +0000)] 
Correct comment on free ID range

20 months agoCatch failure returned by cbor_guess_type() (CID #1634805)
Nick Porter [Fri, 29 Nov 2024 12:34:45 +0000 (12:34 +0000)] 
Catch failure returned by cbor_guess_type() (CID #1634805)

20 months agoAdd support for inline BEGIN keyword for protocols
Arran Cudbard-Bell [Fri, 29 Nov 2024 02:01:03 +0000 (20:01 -0600)] 
Add support for inline BEGIN keyword for protocols

20 months agoRename BEGIN-TLV and END-TLV to BEGIN and END, and make them work for TLVs too
Arran Cudbard-Bell [Thu, 28 Nov 2024 23:17:16 +0000 (17:17 -0600)] 
Rename BEGIN-TLV and END-TLV to BEGIN and END, and make them work for TLVs too

20 months agoRework nest values so its a bit field
Arran Cudbard-Bell [Thu, 28 Nov 2024 20:34:17 +0000 (14:34 -0600)] 
Rework nest values so its a bit field

20 months agoFix clang analyzer builds
Arran Cudbard-Bell [Thu, 28 Nov 2024 20:33:00 +0000 (14:33 -0600)] 
Fix clang analyzer builds

20 months agoIntegrate the nesting type when we push frames onto the stack
Arran Cudbard-Bell [Thu, 28 Nov 2024 17:28:21 +0000 (11:28 -0600)] 
Integrate the nesting type when we push frames onto the stack

20 months agoVarious dict_tokenize renames
Arran Cudbard-Bell [Thu, 28 Nov 2024 17:07:22 +0000 (11:07 -0600)] 
Various dict_tokenize renames

20 months agoRun finalise when we're done processing the file also
Arran Cudbard-Bell [Thu, 28 Nov 2024 16:23:21 +0000 (10:23 -0600)] 
Run finalise when we're done processing the file also

20 months agoMove member processing to the keyword dispatch
Arran Cudbard-Bell [Thu, 28 Nov 2024 16:17:03 +0000 (10:17 -0600)] 
Move member processing to the keyword dispatch

20 months agoAlternative method to set fake DB conneciton handle
Nick Porter [Thu, 28 Nov 2024 09:00:06 +0000 (09:00 +0000)] 
Alternative method to set fake DB conneciton handle

May pacify Coverity...

20 months agoBreak out more parsing functions
Arran Cudbard-Bell [Thu, 28 Nov 2024 02:24:08 +0000 (20:24 -0600)] 
Break out more parsing functions

20 months agoStart breaking out keyword parsers in dict_tokenize
Arran Cudbard-Bell [Thu, 28 Nov 2024 02:20:12 +0000 (20:20 -0600)] 
Start breaking out keyword parsers in dict_tokenize

20 months agorest: Add xlat argument for headers
Arran Cudbard-Bell [Thu, 28 Nov 2024 01:07:31 +0000 (19:07 -0600)] 
rest: Add xlat argument for headers

20 months agoHave fr_sbuff_extend_lowat check the eof state of the sbuff. Fixes #5462
Arran Cudbard-Bell [Wed, 27 Nov 2024 23:36:29 +0000 (17:36 -0600)] 
Have fr_sbuff_extend_lowat check the eof state of the sbuff.  Fixes #5462

Don't extend the sbuff in the fr_sbuff_terminal_search function

20 months agoRealign fields
Arran Cudbard-Bell [Wed, 27 Nov 2024 23:10:36 +0000 (17:10 -0600)] 
Realign fields

20 months agoAdd test case from https://github.com/FreeRADIUS/freeradius-server/issues/5462
Arran Cudbard-Bell [Wed, 27 Nov 2024 23:33:35 +0000 (17:33 -0600)] 
Add test case from https://github.com/FreeRADIUS/freeradius-server/issues/5462

20 months agoUse memory safe functions when searching for needles
Arran Cudbard-Bell [Wed, 27 Nov 2024 23:08:37 +0000 (17:08 -0600)] 
Use memory safe functions when searching for needles

Probably slightly higher performance

20 months agopass the current sbuff, not the parent one
Alan T. DeKok [Wed, 27 Nov 2024 16:36:28 +0000 (11:36 -0500)] 
pass the current sbuff, not the parent one

20 months agoreset the input pointer if it changes. Fixex #5462
Alan T. DeKok [Wed, 27 Nov 2024 16:30:29 +0000 (11:30 -0500)] 
reset the input pointer if it changes.  Fixex #5462

There are larger underlying problems, though.  The API to
fr_sbuff_terminal_search() is wrong.  It accepts an input pointer
"p", which points to somewhere in the middle of the sbuff.

As a result, if the sbuff is shifted due to reads, the sbuff->p
pointer changes, and the "cached" p passed to fr_sbuff_terminal_search()
points to somewhere wild.

As a result, most _callers_ of fr_sbuff_terminal_search() are
likely wrong, too, as they cache p = sbuff->p, and don't expect
that pointer to change under them.

20 months agohelper macro for laziness
Alan T. DeKok [Wed, 27 Nov 2024 16:30:13 +0000 (11:30 -0500)] 
helper macro for laziness

20 months agoBuild eap round data if needed
Nick Porter [Wed, 27 Nov 2024 15:34:36 +0000 (15:34 +0000)] 
Build eap round data if needed

If eap is called in `send Access-Reject` and the reject is caused by
something before the eap module is called, then the eap round data has
not been built.

Without this data, the fake eap Failure message can't be correctly
constructed.

20 months agoCorrect freeing of Cassandra results
Nick Porter [Wed, 27 Nov 2024 12:30:06 +0000 (12:30 +0000)] 
Correct freeing of Cassandra results

20 months agoIn-progress eap returns ok or updated
Nick Porter [Wed, 27 Nov 2024 12:03:21 +0000 (12:03 +0000)] 
In-progress eap returns ok or updated

Adjust default policy to reflect that - usually it makes no sense to
call data stores etc part way through eap.

20 months agoFree Cassandra statement after executing
Nick Porter [Wed, 27 Nov 2024 12:01:33 +0000 (12:01 +0000)] 
Free Cassandra statement after executing

20 months agoEnsure arg is initialised
Nick Porter [Wed, 27 Nov 2024 08:47:18 +0000 (08:47 +0000)] 
Ensure arg is initialised

20 months agoDoxygen fix ups
Nick Porter [Wed, 27 Nov 2024 08:47:01 +0000 (08:47 +0000)] 
Doxygen fix ups

20 months agoUpdate sample SQL module config now all drivers use trunks
Nick Porter [Tue, 26 Nov 2024 21:03:03 +0000 (21:03 +0000)] 
Update sample SQL module config now all drivers use trunks

20 months agoRemove pool from SQL instance data
Nick Porter [Tue, 26 Nov 2024 17:44:26 +0000 (17:44 +0000)] 
Remove pool from SQL instance data

20 months agoRemove un-used code
Nick Porter [Tue, 26 Nov 2024 17:42:23 +0000 (17:42 +0000)] 
Remove un-used code

20 months agoRemove rlm_sql_handle_t
Nick Porter [Tue, 26 Nov 2024 17:41:13 +0000 (17:41 +0000)] 
Remove rlm_sql_handle_t

20 months agoRemove legacy query functions
Nick Porter [Tue, 26 Nov 2024 17:35:27 +0000 (17:35 +0000)] 
Remove legacy query functions

20 months agoRemove legacy functions from sql driver data
Nick Porter [Tue, 26 Nov 2024 13:50:07 +0000 (13:50 +0000)] 
Remove legacy functions from sql driver data

20 months agoRemove SQL pool connection function
Nick Porter [Tue, 26 Nov 2024 17:27:56 +0000 (17:27 +0000)] 
Remove SQL pool connection function

20 months agoConvert rlm_sql_null to trunk connections
Nick Porter [Tue, 26 Nov 2024 13:47:15 +0000 (13:47 +0000)] 
Convert rlm_sql_null to trunk connections

20 months agoRemove handle from sql_escape_uctx_t
Nick Porter [Tue, 26 Nov 2024 17:19:00 +0000 (17:19 +0000)] 
Remove handle from sql_escape_uctx_t

20 months agoRemove handle from sqlippool ctxs
Nick Porter [Tue, 26 Nov 2024 13:36:39 +0000 (13:36 +0000)] 
Remove handle from sqlippool ctxs

20 months agoRemove handle from sql_group_xlat_ctx_t
Nick Porter [Tue, 26 Nov 2024 13:32:25 +0000 (13:32 +0000)] 
Remove handle from sql_group_xlat_ctx_t

20 months agoRemove handle from sql_redundant_ctx_t
Nick Porter [Tue, 26 Nov 2024 13:30:59 +0000 (13:30 +0000)] 
Remove handle from sql_redundant_ctx_t

20 months agoRemove handle from sql_autz_ctx_t
Nick Porter [Tue, 26 Nov 2024 17:17:47 +0000 (17:17 +0000)] 
Remove handle from sql_autz_ctx_t

20 months agoRemove handle from fr_sql_query_t
Nick Porter [Tue, 26 Nov 2024 13:25:32 +0000 (13:25 +0000)] 
Remove handle from fr_sql_query_t

20 months agoRemove transitional uses_trunks flag and associated code paths
Nick Porter [Tue, 26 Nov 2024 12:48:47 +0000 (12:48 +0000)] 
Remove transitional uses_trunks flag and associated code paths

All drivers now use trunks

20 months agoRemove defunct EAP policies
Arran Cudbard-Bell [Tue, 26 Nov 2024 15:43:43 +0000 (09:43 -0600)] 
Remove defunct EAP policies

20 months agoUse sqlcli1.h to access connection attribute setting API
Nick Porter [Tue, 26 Nov 2024 12:33:03 +0000 (12:33 +0000)] 
Use sqlcli1.h to access connection attribute setting API

20 months agoRe-work rlm_sql_db2 to use trunks
Nick Porter [Tue, 26 Nov 2024 12:12:59 +0000 (12:12 +0000)] 
Re-work rlm_sql_db2 to use trunks

The client library doesn't support async

20 months agoFix db2 build errors
Nick Porter [Tue, 26 Nov 2024 11:07:49 +0000 (11:07 +0000)] 
Fix db2 build errors

20 months agoencode and decode interface definitions with prefix and scope ID
Alan T. DeKok [Mon, 25 Nov 2024 20:31:32 +0000 (15:31 -0500)] 
encode and decode interface definitions with prefix and scope ID

20 months agoadd test for known vendor and unknown attribute
Alan T. DeKok [Mon, 25 Nov 2024 20:10:09 +0000 (15:10 -0500)] 
add test for known vendor and unknown attribute

20 months agoset prefix for IPs
Alan T. DeKok [Mon, 25 Nov 2024 19:33:18 +0000 (14:33 -0500)] 
set prefix for IPs

20 months agoSimplify sql_error_t
Nick Porter [Mon, 25 Nov 2024 17:05:53 +0000 (17:05 +0000)] 
Simplify sql_error_t

No driver uses the SQL module config when fetching error messages.

20 months agoRe-work rlm_sql_cassandra to work async and use trunks
Nick Porter [Mon, 25 Nov 2024 15:39:00 +0000 (15:39 +0000)] 
Re-work rlm_sql_cassandra to work async and use trunks

20 months agoOnly re-parent query_ctx if there is a cancel mux function
Nick Porter [Mon, 25 Nov 2024 15:33:30 +0000 (15:33 +0000)] 
Only re-parent query_ctx if there is a cancel mux function

20 months agoRemove reference to ancient deprecated function call
Nick Porter [Mon, 25 Nov 2024 14:56:13 +0000 (14:56 +0000)] 
Remove reference to ancient deprecated function call

20 months agoAdd a uctx to fr_sql_query_t
Nick Porter [Mon, 25 Nov 2024 14:33:58 +0000 (14:33 +0000)] 
Add a uctx to fr_sql_query_t

Allowing additional driver specific data needs to be held against a
query ctx.

20 months agoAdd SQL driver flag to allow mulitple queries per connection
Nick Porter [Mon, 25 Nov 2024 14:32:49 +0000 (14:32 +0000)] 
Add SQL driver flag to allow mulitple queries per connection

Whilst most SQL drivers don't allow this, Cassandra does

20 months agoWS
Nick Porter [Mon, 25 Nov 2024 11:36:32 +0000 (11:36 +0000)] 
WS

20 months agoFree old result before looking for the next
Nick Porter [Sat, 23 Nov 2024 15:01:09 +0000 (15:01 +0000)] 
Free old result before looking for the next

Otherwise, the NO_MORE_ROWS response still has the previous result in
query_ctx->row

20 months agoCreate mutable data for Cassandra module instance
Nick Porter [Sat, 23 Nov 2024 14:46:07 +0000 (14:46 +0000)] 
Create mutable data for Cassandra module instance

Module instance data cannot be modified after instantiation - so the
indicator and mutex for initial connection need to be moved to a mutable
structure.

20 months agomod_instantiate doesn't return RLM_SQL_*
Nick Porter [Sat, 23 Nov 2024 13:45:43 +0000 (13:45 +0000)] 
mod_instantiate doesn't return RLM_SQL_*

20 months agoDon't create tls conf section if it's not in the config
Nick Porter [Sat, 23 Nov 2024 13:08:37 +0000 (13:08 +0000)] 
Don't create tls conf section if it's not in the config

20 months agoRemove libcassandra driver options deprecated over 5 years ago
Nick Porter [Sat, 23 Nov 2024 12:06:22 +0000 (12:06 +0000)] 
Remove libcassandra driver options deprecated over 5 years ago

20 months agopop any log we pushed for a virtual server
Alan T. DeKok [Mon, 25 Nov 2024 14:19:15 +0000 (09:19 -0500)] 
pop any log we pushed for a virtual server

20 months agoquiet clang scan
Alan T. DeKok [Mon, 25 Nov 2024 12:57:54 +0000 (07:57 -0500)] 
quiet clang scan

20 months agonote triple-quoted strings, and word smithing
Alan T. DeKok [Sat, 23 Nov 2024 20:19:10 +0000 (15:19 -0500)] 
note triple-quoted strings, and word smithing

20 months agoadd and document "log = ..." in a virtual server.
Alan T. DeKok [Sat, 23 Nov 2024 17:31:51 +0000 (12:31 -0500)] 
add and document "log = ..." in a virtual server.

so each virtual server can add a diffeent logging destination
for all requests which get processed through it

20 months agodon't mash log->file. Or, set it from the input file
Alan T. DeKok [Sat, 23 Nov 2024 17:25:48 +0000 (12:25 -0500)] 
don't mash log->file.  Or, set it from the input file

20 months agotypo
Alan T. DeKok [Sat, 23 Nov 2024 14:37:27 +0000 (09:37 -0500)] 
typo

20 months agotypo
Alan T. DeKok [Sat, 23 Nov 2024 14:36:09 +0000 (09:36 -0500)] 
typo

20 months agowe don't need these tests any more
Alan T. DeKok [Sat, 23 Nov 2024 14:26:36 +0000 (09:26 -0500)] 
we don't need these tests any more

20 months agoremove back-ticks
Alan T. DeKok [Sat, 23 Nov 2024 14:24:26 +0000 (09:24 -0500)] 
remove back-ticks

20 months agomacro to return better errors
Alan T. DeKok [Sat, 23 Nov 2024 14:06:40 +0000 (09:06 -0500)] 
macro to return better errors

20 months agouse num_elements() to get more deterministic encoding
Alan T. DeKok [Sat, 23 Nov 2024 13:51:08 +0000 (08:51 -0500)] 
use num_elements() to get more deterministic encoding

20 months agoit helps to set "triple"
Alan T. DeKok [Fri, 22 Nov 2024 20:55:11 +0000 (15:55 -0500)] 
it helps to set "triple"

20 months agoUpdate sample Oracle driver config
Nick Porter [Fri, 22 Nov 2024 15:18:25 +0000 (15:18 +0000)] 
Update sample Oracle driver config

20 months agoRe-work rlm_sql_oracle to work async with trunks
Nick Porter [Fri, 22 Nov 2024 15:17:35 +0000 (15:17 +0000)] 
Re-work rlm_sql_oracle to work async with trunks

20 months agoParse SQL trunk config before instantiating the driver
Nick Porter [Tue, 19 Nov 2024 17:25:21 +0000 (17:25 +0000)] 
Parse SQL trunk config before instantiating the driver

So the driver can use the parsed options

20 months agoparse triple-quoted strings in expressions
Alan T. DeKok [Fri, 22 Nov 2024 19:17:42 +0000 (14:17 -0500)] 
parse triple-quoted strings in expressions

20 months agoadd terminals and parse rules for triple-quoted strings
Alan T. DeKok [Fri, 22 Nov 2024 19:13:43 +0000 (14:13 -0500)] 
add terminals and parse rules for triple-quoted strings

20 months agoadd missing file
Alan T. DeKok [Fri, 22 Nov 2024 15:44:03 +0000 (10:44 -0500)] 
add missing file

20 months agoadd and document support for tripled-quoted strings
Alan T. DeKok [Fri, 22 Nov 2024 15:38:33 +0000 (10:38 -0500)] 
add and document support for tripled-quoted strings

secret = """foo " bar " baz ! """

20 months agoMove sample certificate checking policy
Nick Porter [Fri, 22 Nov 2024 08:47:27 +0000 (08:47 +0000)] 
Move sample certificate checking policy

The virtual server referenced in mods-available/eap is now "tls-cache",
with certificate verification done in the "verify certificate" section
rather than through the "check-eap-tls" virtual server.

The old sample code gives useful hints as to what could be done in this
section and why.

20 months agoUse v4 section names
Nick Porter [Fri, 22 Nov 2024 08:19:54 +0000 (08:19 +0000)] 
Use v4 section names

20 months agobetter error messages
Alan T. DeKok [Thu, 21 Nov 2024 18:54:55 +0000 (13:54 -0500)] 
better error messages

If I run into a problem because of a typo, and the error message
isn't clear enough to me, then it should be clarified for others, too

20 months agoadd and document aliases which make MS-CHAP easier to configure
Alan T. DeKok [Thu, 21 Nov 2024 18:49:59 +0000 (13:49 -0500)] 
add and document aliases which make MS-CHAP easier to configure

20 months agorefresh after changes
Alan T. DeKok [Thu, 21 Nov 2024 18:47:13 +0000 (13:47 -0500)] 
refresh after changes

20 months agoupdate comments and documentation
Alan T. DeKok [Thu, 21 Nov 2024 18:46:08 +0000 (13:46 -0500)] 
update comments and documentation

20 months agocorrect encoding / decode of prefixes
Alan T. DeKok [Thu, 21 Nov 2024 16:16:23 +0000 (11:16 -0500)] 
correct encoding / decode of prefixes

and add tests

20 months agouse correct values for string / octets
Alan T. DeKok [Thu, 21 Nov 2024 16:15:04 +0000 (11:15 -0500)] 
use correct values for string / octets

they were swapped :(

20 months agoensure that shutdowns are called appropriately, and work
Alan T. DeKok [Wed, 20 Nov 2024 20:25:23 +0000 (15:25 -0500)] 
ensure that shutdowns are called appropriately, and work

the BIO which has produced the fatal error calls the shutdown
routine

20 months agoadd and use OOM error
Alan T. DeKok [Wed, 20 Nov 2024 19:59:54 +0000 (14:59 -0500)] 
add and use OOM error

20 months agofirst try at fr_bio_fd_accept()
Alan T. DeKok [Tue, 19 Nov 2024 20:16:47 +0000 (15:16 -0500)] 
first try at fr_bio_fd_accept()

which creates a new BIO from a parent of type LISTEN

20 months agorework the write_blocked() handlers
Alan T. DeKok [Tue, 19 Nov 2024 19:30:26 +0000 (14:30 -0500)] 
rework the write_blocked() handlers

to match the EOF handlers, so I'm more convinced taht they're
correct.