]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
23 months agolocal dictionaries. too
Alan T. DeKok [Sun, 24 Sep 2023 13:58:53 +0000 (09:58 -0400)] 
local dictionaries. too

23 months agoif we have local dict, look up next by name, too
Alan T. DeKok [Sun, 24 Sep 2023 13:49:55 +0000 (09:49 -0400)] 
if we have local dict, look up next by name, too

23 months agomark up local dictionaries as local
Alan T. DeKok [Sun, 24 Sep 2023 13:49:24 +0000 (09:49 -0400)] 
mark up local dictionaries as local

and try harder to avoid number overlaps

23 months agotest that local variables can be expanded
Alan T. DeKok [Sun, 24 Sep 2023 13:45:45 +0000 (09:45 -0400)] 
test that local variables can be expanded

23 months agoadd fr_dict_t to the top-level CONF_SECTION
Alan T. DeKok [Sun, 24 Sep 2023 12:32:42 +0000 (08:32 -0400)] 
add fr_dict_t to the top-level CONF_SECTION

23 months agodon't use update, and do use local variables
Alan T. DeKok [Sun, 24 Sep 2023 12:04:51 +0000 (08:04 -0400)] 
don't use update, and do use local variables

23 months agoword smithing
Alan T. DeKok [Sat, 23 Sep 2023 13:30:53 +0000 (09:30 -0400)] 
word smithing

23 months agopretty much all of this is done
Alan T. DeKok [Sat, 23 Sep 2023 13:29:35 +0000 (09:29 -0400)] 
pretty much all of this is done

23 months agoFix Antora examples to not use update
Jorge Pereira [Sat, 23 Sep 2023 01:02:32 +0000 (22:02 -0300)] 
Fix Antora examples to not use update

23 months agooops. Let's delete typos
Alan T. DeKok [Sat, 23 Sep 2023 12:09:35 +0000 (08:09 -0400)] 
oops.  Let's delete typos

23 months agocreate local variable list, and put local variables into it
Alan T. DeKok [Sat, 23 Sep 2023 11:55:45 +0000 (07:55 -0400)] 
create local variable list, and put local variables into it

23 months agodocumentation for local variables
Alan T. DeKok [Mon, 28 Nov 2022 20:05:19 +0000 (15:05 -0500)] 
documentation for local variables

23 months agobrute-force delete local variables when leaving scope
Alan T. DeKok [Thu, 21 Sep 2023 21:51:00 +0000 (17:51 -0400)] 
brute-force delete local variables when leaving scope

we will later move them to their own list, which will help a lot.

23 months agoadd function to iterate over only the leaf nodes
Alan T. DeKok [Thu, 21 Sep 2023 18:06:12 +0000 (14:06 -0400)] 
add function to iterate over only the leaf nodes

so that python, perl, detail, etc. can still work with "flat"
things

23 months agoensure frame->retry doesn't leave a dangling pointer
Alan T. DeKok [Wed, 20 Sep 2023 21:07:37 +0000 (17:07 -0400)] 
ensure frame->retry doesn't leave a dangling pointer

23 months agomaps cannot have local variables
Alan T. DeKok [Wed, 20 Sep 2023 21:05:03 +0000 (17:05 -0400)] 
maps cannot have local variables

because the underlying map doesn't deal well with them :(

23 months agoenforce locations for local variables, and use correct t_rules
Alan T. DeKok [Wed, 20 Sep 2023 21:04:13 +0000 (17:04 -0400)] 
enforce locations for local variables, and use correct t_rules

23 months agoadd and use unlang_interpret_push_children()
Alan T. DeKok [Wed, 20 Sep 2023 20:51:14 +0000 (16:51 -0400)] 
add and use unlang_interpret_push_children()

which pushes the children of the current frame.  This wrapper
function simplifies a bunch of keyword code.

subrequest does not use this, as it pushes another frame
before pushing the children.  Perhaps that should instead be a
resume function?

23 months agomake sure that the section with local variables is run
Alan T. DeKok [Wed, 20 Sep 2023 20:46:04 +0000 (16:46 -0400)] 
make sure that the section with local variables is run

23 months agocannot delete local variables
Alan T. DeKok [Wed, 20 Sep 2023 19:45:44 +0000 (15:45 -0400)] 
cannot delete local variables

23 months agomove variables to unlang_group_t
Alan T. DeKok [Fri, 9 Dec 2022 19:30:44 +0000 (14:30 -0500)] 
move variables to unlang_group_t

so that they can all be defined when the group is entered, and
cleaned up when the group leaves.

This also allows the variables to be used in statements such as
"switch" or "load-balance"

23 months agoadd "local" flag to attributes and glue into tmpl parser
Alan T. DeKok [Mon, 28 Nov 2022 00:23:10 +0000 (19:23 -0500)] 
add "local" flag to attributes and glue into tmpl parser

they current are put into the request list, due to the tmpl
code not supporting PAIR_LIST_ROOT.  As the PAIR_LIST will be
going away soon

23 months agoDetermine number of workers if value is set to zero
Arran Cudbard-Bell [Sat, 23 Sep 2023 04:02:31 +0000 (00:02 -0400)] 
Determine number of workers if value is set to zero

23 months agoci: Check nested attributes are created correctly from LDAP attriubtes
Nick Porter [Fri, 22 Sep 2023 15:14:33 +0000 (16:14 +0100)] 
ci: Check nested attributes are created correctly from LDAP attriubtes

23 months agoUse map_to_request in place of map_to_vp to handle nested attributes
Nick Porter [Fri, 22 Sep 2023 15:13:40 +0000 (16:13 +0100)] 
Use map_to_request in place of map_to_vp to handle nested attributes

This allows for nested attributes to be handled in the rlm_ldap module
update map such that

update {
&control += "radiusControlAttribute"
}

with a directory entry containting

radiusControlAttribute: Vendor-Specific.Cisco.AVPair += 'foo=bar'

will result in the correct nested structure being built.

23 months agoHandle possilble snprintf value truncation
Nick Porter [Fri, 22 Sep 2023 14:44:59 +0000 (15:44 +0100)] 
Handle possilble snprintf value truncation

23 months agoci: Use different data in each LDAP user profile
Nick Porter [Fri, 22 Sep 2023 12:59:27 +0000 (13:59 +0100)] 
ci: Use different data in each LDAP user profile

So we are sure the right thing happened

23 months agoldap: Add debug level 3 summary of search results
Nick Porter [Fri, 22 Sep 2023 12:34:37 +0000 (13:34 +0100)] 
ldap: Add debug level 3 summary of search results

23 months agoTainted data doesn't work here
Nick Porter [Fri, 22 Sep 2023 09:19:36 +0000 (10:19 +0100)] 
Tainted data doesn't work here

- the escape function expects a URI, not just a DN
- escaping cn= makes cn\3d - so the DN becomes invalid

23 months agoPrint errors when LDAP URI fails to escape
Nick Porter [Fri, 22 Sep 2023 09:08:05 +0000 (10:08 +0100)] 
Print errors when LDAP URI fails to escape

23 months agoxlat: Switch base64 functions to final form
Arran Cudbard-Bell [Thu, 21 Sep 2023 20:31:37 +0000 (16:31 -0400)] 
xlat: Switch base64 functions to final form

23 months agoAdd exec test which uses xlat function in its arguments
Nick Porter [Thu, 21 Sep 2023 11:10:00 +0000 (12:10 +0100)] 
Add exec test which uses xlat function in its arguments

23 months agoBootstrap xlats produced when parsing TMPL_TYPE_EXEC tmpls
Nick Porter [Thu, 21 Sep 2023 11:07:48 +0000 (12:07 +0100)] 
Bootstrap xlats produced when parsing TMPL_TYPE_EXEC tmpls

23 months agoBetter comment for LDAP profile xlat
Nick Porter [Thu, 21 Sep 2023 16:30:39 +0000 (17:30 +0100)] 
Better comment for LDAP profile xlat

23 months agoRe-enable ldap_sync tests and improve error reporting
Nick Porter [Thu, 21 Sep 2023 09:33:02 +0000 (10:33 +0100)] 
Re-enable ldap_sync tests and improve error reporting

23 months agoCorrect expansion of LDAP attributes
Nick Porter [Thu, 21 Sep 2023 08:29:14 +0000 (09:29 +0100)] 
Correct expansion of LDAP attributes

23 months agoldap: Fix process the generic attribute in profiles
Arran Cudbard-Bell [Wed, 20 Sep 2023 23:17:45 +0000 (19:17 -0400)] 
ldap: Fix process the generic attribute in profiles

23 months agoAdd radiusProfileSuspendedDN
Arran Cudbard-Bell [Wed, 20 Sep 2023 19:06:26 +0000 (15:06 -0400)] 
Add radiusProfileSuspendedDN

23 months agouse the correct list
Alan T. DeKok [Wed, 20 Sep 2023 00:47:37 +0000 (20:47 -0400)] 
use the correct list

23 months agodon't write to buffer we're reading from
Alan T. DeKok [Wed, 20 Sep 2023 00:25:33 +0000 (20:25 -0400)] 
don't write to buffer we're reading from

23 months ago"original" CONF_PAIR always exists
Alan T. DeKok [Wed, 20 Sep 2023 00:19:45 +0000 (20:19 -0400)] 
"original" CONF_PAIR always exists

23 months agoaddress more corner cases as caught by the keyword tests
Alan T. DeKok [Tue, 19 Sep 2023 22:01:52 +0000 (18:01 -0400)] 
address more corner cases as caught by the keyword tests

23 months agofix rewrite_update and add debug
Alan T. DeKok [Tue, 19 Sep 2023 20:42:46 +0000 (16:42 -0400)] 
fix rewrite_update and add debug

we likely need more tests for rewrite_update.

But it now prints out in debug mode how to convert from an "update"
entry to an edit section.

23 months agonote that RHS of edits can now be expressions
Alan T. DeKok [Tue, 19 Sep 2023 20:42:08 +0000 (16:42 -0400)] 
note that RHS of edits can now be expressions

23 months agoword smithing
Alan T. DeKok [Tue, 19 Sep 2023 20:41:22 +0000 (16:41 -0400)] 
word smithing

23 months agocatch nested attributes accidentally being added to the top-level list
Alan T. DeKok [Tue, 19 Sep 2023 12:39:58 +0000 (08:39 -0400)] 
catch nested attributes accidentally being added to the top-level list

23 months agoenforce parent / child relationships for structural pairs
Alan T. DeKok [Tue, 19 Sep 2023 12:20:55 +0000 (08:20 -0400)] 
enforce parent / child relationships for structural pairs

so that if we have nested TLVs, the children have to go into the
parent, subject to some limitations.

This requirement helps to enforce correct structure.

Note that children can still go into "internal" group attributes,
which means that they can still go into the top-level request list.

This isn't ideal, but it's not clear how to fix that without also
breaking it for control and session-state

23 months agotypo
Alan T. DeKok [Mon, 18 Sep 2023 21:02:00 +0000 (17:02 -0400)] 
typo

23 months agoonce again remove tmpl_tokenize_all_nested
Alan T. DeKok [Mon, 18 Sep 2023 20:58:29 +0000 (16:58 -0400)] 
once again remove tmpl_tokenize_all_nested

23 months agoforce tmpl_tokenize_all_nested
Alan T. DeKok [Mon, 18 Sep 2023 16:59:20 +0000 (12:59 -0400)] 
force tmpl_tokenize_all_nested

23 months agoenable tmpl_tokenize_all_nested for all module tests
Alan T. DeKok [Mon, 18 Sep 2023 13:05:22 +0000 (09:05 -0400)] 
enable tmpl_tokenize_all_nested for all module tests

23 months agouse nesting when creating SQL pairs
Alan T. DeKok [Mon, 18 Sep 2023 12:32:24 +0000 (08:32 -0400)] 
use nesting when creating SQL pairs

23 months agomore migrations. Only SQL is left
Alan T. DeKok [Mon, 18 Sep 2023 11:46:17 +0000 (07:46 -0400)] 
more migrations. Only SQL is left

23 months agoadd more migrations
Alan T. DeKok [Mon, 18 Sep 2023 00:39:58 +0000 (20:39 -0400)] 
add more migrations

23 months agomore migration for modules
Alan T. DeKok [Mon, 18 Sep 2023 00:23:46 +0000 (20:23 -0400)] 
more migration for modules

23 months agoframework for per-module migration flags
Alan T. DeKok [Sun, 17 Sep 2023 21:55:57 +0000 (17:55 -0400)] 
framework for per-module migration flags

23 months agoRevert "force tmpl_tokenize_all_nested"
Alan T. DeKok [Sun, 17 Sep 2023 21:50:51 +0000 (17:50 -0400)] 
Revert "force tmpl_tokenize_all_nested"

This reverts commit 5dc2aac671c609dbfc36ec19cddbec357c5a4c5f.

Well, no.  Too late on a weekend.

23 months agoRevert "remove tmpl_tokenize_all_nested"
Alan T. DeKok [Sun, 17 Sep 2023 21:37:52 +0000 (17:37 -0400)] 
Revert "remove tmpl_tokenize_all_nested"

This reverts commit 861c6a07630b4b6c32bcbc4994b07803e0ed84a8.

let's see if this causes CI to pass?

23 months agotypo
Alan T. DeKok [Sun, 17 Sep 2023 21:13:35 +0000 (17:13 -0400)] 
typo

23 months agotry to created nested VPs
Alan T. DeKok [Sun, 17 Sep 2023 20:18:48 +0000 (16:18 -0400)] 
try to created nested VPs

This likely won't work perfectly due to the fact that converting
attrs to Perl doesn't do nesting properly.

23 months agodisable Perl tests until such time as it creates nested attrs
Alan T. DeKok [Sun, 17 Sep 2023 20:16:26 +0000 (16:16 -0400)] 
disable Perl tests until such time as it creates nested attrs

23 months agoremove tmpl_tokenize_all_nested
Alan T. DeKok [Sun, 17 Sep 2023 19:57:03 +0000 (15:57 -0400)] 
remove tmpl_tokenize_all_nested

23 months agoforce tmpl_tokenize_all_nested
Alan T. DeKok [Sun, 17 Sep 2023 16:55:47 +0000 (12:55 -0400)] 
force tmpl_tokenize_all_nested

23 months agoupdate to use correct syntax for -=
Alan T. DeKok [Sun, 17 Sep 2023 14:38:57 +0000 (10:38 -0400)] 
update to use correct syntax for -=

23 months agobe a bit smarter about it
Alan T. DeKok [Sun, 17 Sep 2023 14:29:13 +0000 (10:29 -0400)] 
be a bit smarter about it

23 months agorelax test a bit
Alan T. DeKok [Sun, 17 Sep 2023 14:23:11 +0000 (10:23 -0400)] 
relax test a bit

23 months agoremove assertion
Alan T. DeKok [Sun, 17 Sep 2023 13:57:38 +0000 (09:57 -0400)] 
remove assertion

memdup_shallow() is sometimes called with non-talloc'd memory

in some cases the calls are wrong, and this causes a later assert
in the verify functions.  In other cases, the calls are correct.

23 months agocatch corner case for -=
Alan T. DeKok [Sun, 17 Sep 2023 13:46:41 +0000 (09:46 -0400)] 
catch corner case for -=

&control -= {
&Password.Cleartext == 'oracle01' # ERROR
 }

the edit code doesn't do this correctly (yet).  Add a test case
which catches it and complains, instead of dogn the wrong thing.
It's also not clear what is meant by the above.  Do we need to
delete &Password, too?

23 months agouse correct escaping
Alan T. DeKok [Sun, 17 Sep 2023 13:26:26 +0000 (09:26 -0400)] 
use correct escaping

now that we've fixed fr_asprint() in commit b10640, and the
escaping in 41193841eb, this test also needs fixing.  In order to
pass \' to a shell which takes a string in ' quotes, the config
file string must use one layer of escaping for FR, and a second
layer of escaping for the shell.

this issue highlights the fact that we likely need a "q" operator
ala Perl.

23 months agotemporarily stop ldap_sync until the failing test is fixed
Alan T. DeKok [Sun, 17 Sep 2023 12:59:36 +0000 (08:59 -0400)] 
temporarily stop ldap_sync until the failing test is fixed

23 months agomanually redo commit 0c6d48394867e2d2
Alan T. DeKok [Sat, 16 Sep 2023 19:40:16 +0000 (15:40 -0400)] 
manually redo commit 0c6d48394867e2d2

gettoken() parses the RHS of a CONF_PAIR, but that function only
unescapes the \", and doesn't unescape anything else.  Therefore
we do the unescaping here.

23 months agofr_asprint() takes a quotation 'char', not a fr_token_t
Alan T. DeKok [Sat, 16 Sep 2023 17:55:57 +0000 (13:55 -0400)] 
fr_asprint() takes a quotation 'char', not a fr_token_t

23 months agoallow T_HASH for edit sections. See map_afrom_cp()
Alan T. DeKok [Sat, 16 Sep 2023 15:15:04 +0000 (11:15 -0400)] 
allow T_HASH for edit sections.  See map_afrom_cp()

23 months agoAnnotate fr_nbo_to_uint{16,24}() at function level
James Jones [Fri, 15 Sep 2023 19:21:05 +0000 (14:21 -0500)] 
Annotate fr_nbo_to_uint{16,24}() at function level

CIDs: #1419883, #1520415, #1503954, #14516665, #1519002

This should keep coverity from tainting the pointer to data
being converted to host order.

23 months agocheck return codes to quiet static analyzer
Alan T. DeKok [Sat, 16 Sep 2023 01:25:39 +0000 (21:25 -0400)] 
check return codes to quiet static analyzer

23 months agoforce tmpl_tokenize_all_nested here, too
Alan T. DeKok [Fri, 15 Sep 2023 17:51:14 +0000 (13:51 -0400)] 
force tmpl_tokenize_all_nested here, too

23 months agoensure that the buffers are talloc'd
Alan T. DeKok [Fri, 15 Sep 2023 17:36:45 +0000 (13:36 -0400)] 
ensure that the buffers are talloc'd

the memdup_shallow() call will just assign the ptr to the
value-box.  But the added talloc_get_name() fails, because the
ptr isn't talloced.

23 months agomove legacy function to the only place which uses it
Alan T. DeKok [Fri, 15 Sep 2023 16:41:36 +0000 (12:41 -0400)] 
move legacy function to the only place which uses it

23 months agoremove legacy print nested, and old "unflatten" code
Alan T. DeKok [Fri, 15 Sep 2023 16:37:29 +0000 (12:37 -0400)] 
remove legacy print nested, and old "unflatten" code

23 months agoAttempt to ignore spurios LeakSanitizer fatal errors
Nick Porter [Fri, 15 Sep 2023 13:20:24 +0000 (14:20 +0100)] 
Attempt to ignore spurios LeakSanitizer fatal errors

23 months agoPlacate coverity with excessive buffer_len (CID #1503922, #1503986)
James Jones [Thu, 14 Sep 2023 19:06:59 +0000 (14:06 -0500)] 
Placate coverity with excessive buffer_len (CID #1503922, #1503986)

open_buffer_as_file() is a wrapper aound the fmemopen() function.
The example shown on fmemopen()'s man page passes a string as buffer
and strlen(<string>) as length, and open_buffer_as_file() calls did the
same thing--but coverity gives it an alloc_strlen defect with the
comment "allocating insufficient memory for the terminating null of
the string".

At least one other project using coverity and calling fmemopen()
in conformity with "man fmemopen" also gets this defect and ended
up passing strlen(<string>) + 1 to deal with it. Making the analogous
change here passes tests and should quiet coverity.

23 months agostart removing "update"
Alan T. DeKok [Fri, 15 Sep 2023 12:52:01 +0000 (08:52 -0400)] 
start removing "update"

23 months agonote "please don't use %{expr:..}"
Alan T. DeKok [Fri, 15 Sep 2023 12:44:25 +0000 (08:44 -0400)] 
note "please don't use %{expr:..}"

23 months agoadd in-line expressions with add
Alan T. DeKok [Fri, 15 Sep 2023 12:38:12 +0000 (08:38 -0400)] 
add in-line expressions with add

23 months agoclean up handling of Acct-Delay-Time
Alan T. DeKok [Fri, 15 Sep 2023 12:33:51 +0000 (08:33 -0400)] 
clean up handling of Acct-Delay-Time

use new edit expressions, and check for sane Event-Timestamp

23 months agodecode unknown extended VSAs as nested
Alan T. DeKok [Fri, 15 Sep 2023 11:01:00 +0000 (07:01 -0400)] 
decode unknown extended VSAs as nested

23 months agodecode WiMAX as nested
Alan T. DeKok [Thu, 14 Sep 2023 19:25:34 +0000 (15:25 -0400)] 
decode WiMAX as nested

23 months agodecode RADIUS structs as nested
Alan T. DeKok [Thu, 14 Sep 2023 19:11:39 +0000 (15:11 -0400)] 
decode RADIUS structs as nested

23 months agodecode extended VSAs as nested
Alan T. DeKok [Thu, 14 Sep 2023 19:06:08 +0000 (15:06 -0400)] 
decode extended VSAs as nested

23 months agoremove migrate command
Alan T. DeKok [Thu, 14 Sep 2023 18:47:04 +0000 (14:47 -0400)] 
remove migrate command

we no longer use it for anything.

23 months agoalways decode RADIUS VSAs as nested
Alan T. DeKok [Thu, 14 Sep 2023 13:58:54 +0000 (09:58 -0400)] 
always decode RADIUS VSAs as nested

not sure why this wasn't done before.  But now we're happy.

23 months agomore comments on antora and asciidoc
Alan T. DeKok [Thu, 14 Sep 2023 13:49:40 +0000 (09:49 -0400)] 
more comments on antora and asciidoc

23 months agono need for macro, just rename the struct fields
Alan T. DeKok [Thu, 14 Sep 2023 13:27:21 +0000 (09:27 -0400)] 
no need for macro, just rename the struct fields

23 months agoallow raw.Vendor-Specific = 0xabcdef
Alan T. DeKok [Thu, 14 Sep 2023 12:08:52 +0000 (08:08 -0400)] 
allow raw.Vendor-Specific = 0xabcdef

which parses it as a Vendor-Specific, then sees the 0x..., and
converts it to type 'octets'.

Note that the attribute MUST already be marked up as "raw"

23 months agoset a default type size and length for unknown attributes
Alan T. DeKok [Thu, 14 Sep 2023 00:44:54 +0000 (20:44 -0400)] 
set a default type size and length for unknown attributes

Which lets us create unknown vendors

23 months agodon't print nested if parent is key field
Alan T. DeKok [Thu, 14 Sep 2023 00:44:25 +0000 (20:44 -0400)] 
don't print nested if parent is key field

23 months agomake arp always decode as nested
Alan T. DeKok [Wed, 13 Sep 2023 22:52:15 +0000 (18:52 -0400)] 
make arp always decode as nested

23 months agoremove pair_legacy_nested
Alan T. DeKok [Wed, 13 Sep 2023 22:49:12 +0000 (18:49 -0400)] 
remove pair_legacy_nested

23 months agoFix small leak in rlm_pap load (#5176)
Jorge Pereira [Thu, 14 Sep 2023 02:18:53 +0000 (23:18 -0300)] 
Fix small leak in rlm_pap load (#5176)

23 months agoremove flatten / unflatten APIs
Alan T. DeKok [Wed, 13 Sep 2023 22:43:36 +0000 (18:43 -0400)] 
remove flatten / unflatten APIs