]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoadd function to prepend logging destination
Alan T. DeKok [Tue, 21 Nov 2023 19:57:48 +0000 (14:57 -0500)] 
add function to prepend logging destination

2 years agocache log level in log_dst_t and use it to skip logging destinations.
Alan T. DeKok [Tue, 21 Nov 2023 19:55:39 +0000 (14:55 -0500)] 
cache log level in log_dst_t and use it to skip logging destinations.

The idea is that we can add a debug destination, where debug messages
go.  But normal messages still get passed through to *both* the
debug destination, and to the normal destination.

That we can add debug logging, and still have normal messages
go to the normal log destination

2 years agoforbid %{func:...} and do the last few updates on the tests
Alan T. DeKok [Tue, 21 Nov 2023 13:29:40 +0000 (08:29 -0500)] 
forbid %{func:...} and do the last few updates on the tests

2 years agotypo
Alan T. DeKok [Tue, 21 Nov 2023 13:00:44 +0000 (08:00 -0500)] 
typo

2 years agobe more careful about freeing head
Alan T. DeKok [Tue, 21 Nov 2023 12:53:50 +0000 (07:53 -0500)] 
be more careful about freeing head

2 years agothis doesn't need to be public
Alan T. DeKok [Tue, 21 Nov 2023 12:51:34 +0000 (07:51 -0500)] 
this doesn't need to be public

2 years agowhitespace
Alan T. DeKok [Tue, 21 Nov 2023 12:51:06 +0000 (07:51 -0500)] 
whitespace

2 years agosql_inst -> sql.
Alan T. DeKok [Tue, 21 Nov 2023 12:40:17 +0000 (07:40 -0500)] 
sql_inst -> sql.

As part of cleaning up redundant names

2 years agoHoist mutex lock above check of client->ht (CID #1551708)
James Jones [Mon, 20 Nov 2023 21:24:08 +0000 (15:24 -0600)] 
Hoist mutex lock above check of client->ht (CID #1551708)

Other checks of client->ht are so guarded.

2 years agodon't use the same function typedef name for two different things
Alan T. DeKok [Mon, 20 Nov 2023 19:54:29 +0000 (14:54 -0500)] 
don't use the same function typedef name for two different things

2 years agoreturn correct data type
Alan T. DeKok [Mon, 20 Nov 2023 19:50:55 +0000 (14:50 -0500)] 
return correct data type

2 years agotry moving to the new syntax again
Alan T. DeKok [Mon, 20 Nov 2023 19:45:17 +0000 (14:45 -0500)] 
try moving to the new syntax again

2 years agoHandle subst == NULL (CID #1551707)
Nick Porter [Mon, 20 Nov 2023 12:29:55 +0000 (12:29 +0000)] 
Handle subst == NULL (CID #1551707)

2 years agodocument clang 16+ suppressions
Alan T. DeKok [Sun, 19 Nov 2023 22:47:28 +0000 (17:47 -0500)] 
document clang 16+ suppressions

-Wunsafe-buffer-usage is useless for C code, as it complains
about essentially every use of pointers.

-Wcast-function-type-strict complains about casting functions
which take (void*) to functions which take a typed pointer.  This
pattern is used extensively in the dlist wrappers.

-Wreserved-identifier complains about identifiers which begin
with "_".  This is used all over the place in our code, but is
generally forbidden in C.

-Wc2x-extensions complains about initializers like "foo = {}"
which is fine, but which isn't C99.

-Wextra-semi-stmt complains about ";;" at the end of lines.
Our code is clean, but some system header files are crap.

2 years agoreturn correct value
Alan T. DeKok [Sun, 19 Nov 2023 22:14:47 +0000 (17:14 -0500)] 
return correct value

2 years agouse correct data types, and check for overflow
Alan T. DeKok [Sun, 19 Nov 2023 14:17:49 +0000 (09:17 -0500)] 
use correct data types, and check for overflow

2 years agoclean up and check for subst==NULL
Alan T. DeKok [Sun, 19 Nov 2023 14:15:19 +0000 (09:15 -0500)] 
clean up and check for subst==NULL

2 years agowe don't care about the results of dhcpv4_decode
Alan T. DeKok [Sun, 19 Nov 2023 12:56:50 +0000 (07:56 -0500)] 
we don't care about the results of dhcpv4_decode

and print the correct pair list we just decoded :(

2 years agoadd support for uncompressed dns labels
Alan T. DeKok [Sat, 18 Nov 2023 19:18:47 +0000 (14:18 -0500)] 
add support for uncompressed dns labels

2 years agoignore temporary editor files
Alan T. DeKok [Sat, 18 Nov 2023 19:18:30 +0000 (14:18 -0500)] 
ignore temporary editor files

2 years agoallow for password longer than 128 characters
Alan T. DeKok [Sat, 18 Nov 2023 14:12:56 +0000 (09:12 -0500)] 
allow for password longer than 128 characters

and update aruba dictionary for encrypted attribute

Manual port of commit 12a2cf4a6f8

2 years agoRename CONF_PARSER to conf_parser_t to match call_env_parser_t
Arran Cudbard-Bell [Fri, 17 Nov 2023 19:11:43 +0000 (14:11 -0500)] 
Rename CONF_PARSER to conf_parser_t to match call_env_parser_t

2 years agotypo
Alan T. DeKok [Fri, 17 Nov 2023 19:00:26 +0000 (14:00 -0500)] 
typo

2 years agomove more functions to new syntax
Alan T. DeKok [Fri, 17 Nov 2023 18:44:57 +0000 (13:44 -0500)] 
move more functions to new syntax

2 years agomore move functions to new syntax
Alan T. DeKok [Fri, 17 Nov 2023 15:53:13 +0000 (10:53 -0500)] 
more move functions to new syntax

2 years agofixes
Alan T. DeKok [Fri, 17 Nov 2023 15:51:50 +0000 (10:51 -0500)] 
fixes

2 years agogo back until we can do more tests
Alan T. DeKok [Fri, 17 Nov 2023 15:37:53 +0000 (10:37 -0500)] 
go back until we can do more tests

2 years agoquote things
Alan T. DeKok [Fri, 17 Nov 2023 15:11:11 +0000 (10:11 -0500)] 
quote things

2 years agomore move to new function syntax
Alan T. DeKok [Fri, 17 Nov 2023 15:09:32 +0000 (10:09 -0500)] 
more move to new function syntax

2 years agomove to new function syntax
Alan T. DeKok [Fri, 17 Nov 2023 14:24:14 +0000 (09:24 -0500)] 
move to new function syntax

2 years agoskip whitespace for comma-separated argv
Alan T. DeKok [Fri, 17 Nov 2023 14:16:57 +0000 (09:16 -0500)] 
skip whitespace for comma-separated argv

2 years agomark up when we parsed an xlat with an xlat wrapper
Alan T. DeKok [Thu, 16 Nov 2023 22:24:58 +0000 (17:24 -0500)] 
mark up when we parsed an xlat with an xlat wrapper

so that the print routines can print something sane

2 years agoClean up modeling file (#5222)
James Jones [Thu, 16 Nov 2023 23:06:21 +0000 (17:06 -0600)] 
Clean up modeling file (#5222)

Remove models that don't work, replace our leading comment with
one that is commonly used in open source modeling files (slightly
edited).

2 years agowe can't have an empty xlat expansion.
Alan T. DeKok [Thu, 16 Nov 2023 22:05:03 +0000 (17:05 -0500)] 
we can't have an empty xlat expansion.

2 years agoupdate CC_HINT for removed argument
Alan T. DeKok [Thu, 16 Nov 2023 15:09:09 +0000 (10:09 -0500)] 
update CC_HINT for removed argument

2 years agoremove alternation from defaults, too
Alan T. DeKok [Thu, 16 Nov 2023 13:39:10 +0000 (08:39 -0500)] 
remove alternation from defaults, too

2 years agoRevert "Copy, don't link, schemas"
Alan T. DeKok [Thu, 16 Nov 2023 13:24:51 +0000 (08:24 -0500)] 
Revert "Copy, don't link, schemas"

This reverts commit 823ad7a63550597682582c4d70010f536db4b7be.

this breaks CI

2 years agomove xlat printing to new function syntax
Alan T. DeKok [Thu, 16 Nov 2023 13:05:14 +0000 (08:05 -0500)] 
move xlat printing to new function syntax

2 years agoremove XLAT_ALTERNATE from the source
Alan T. DeKok [Thu, 16 Nov 2023 12:49:23 +0000 (07:49 -0500)] 
remove XLAT_ALTERNATE from the source

2 years agoremove old comment
Alan T. DeKok [Wed, 15 Nov 2023 21:46:18 +0000 (16:46 -0500)] 
remove old comment

2 years agoenumvs always have names. Look for ones with values
Alan T. DeKok [Wed, 15 Nov 2023 18:56:49 +0000 (13:56 -0500)] 
enumvs always have names.  Look for ones with values

2 years agoRename some call env structures in preparation for additional changes
Arran Cudbard-Bell [Wed, 15 Nov 2023 22:04:11 +0000 (16:04 -0600)] 
Rename some call env structures in preparation for additional changes

2 years agoCopy, don't link, schemas
Arran Cudbard-Bell [Wed, 15 Nov 2023 22:05:48 +0000 (16:05 -0600)] 
Copy, don't link, schemas

This lets us add extra custom schemas later

2 years agorun through codespell, and regenerate antora
Alan T. DeKok [Wed, 15 Nov 2023 17:10:11 +0000 (12:10 -0500)] 
run through codespell, and regenerate antora

there isn't much point in updating the antora (outout) docs when
the raddb (input) files haven't been updated

2 years agouse local dictionary
Alan T. DeKok [Wed, 15 Nov 2023 15:30:53 +0000 (10:30 -0500)] 
use local dictionary

2 years agouse local variable
Alan T. DeKok [Wed, 15 Nov 2023 15:27:43 +0000 (10:27 -0500)] 
use local variable

2 years agomore "remove Tmp-*"
Alan T. DeKok [Wed, 15 Nov 2023 15:25:00 +0000 (10:25 -0500)] 
more "remove Tmp-*"

2 years agoRemove needless annotation. (#5220)
James Jones [Wed, 15 Nov 2023 00:18:41 +0000 (18:18 -0600)] 
Remove needless annotation. (#5220)

2 years agoFix typos in documentation (#5219)
Dimitri Papadopoulos Orfanos [Tue, 14 Nov 2023 23:10:34 +0000 (01:10 +0200)] 
Fix typos in documentation (#5219)

Misspellings found by codespell.

2 years agoAvoid fr_nbo_to_uint16() to get EAP packet length (CID #1243443)
James Jones [Tue, 14 Nov 2023 19:58:02 +0000 (13:58 -0600)] 
Avoid fr_nbo_to_uint16() to get EAP packet length (CID #1243443)

Moved to talloc_array_length() instead, which worked much better
after I looked at the source and saw it's a macro that uses
the type of the argument, so it requires casting to pointer to
the type it was allocated with.

2 years agocache: Move key resolution to callenv
Arran Cudbard-Bell [Tue, 14 Nov 2023 01:05:40 +0000 (19:05 -0600)] 
cache: Move key resolution to callenv

...weird intractable problems trying to get an old DHCPv4 config, easier to fix the code than debug it.

2 years agoLess confusing error
Arran Cudbard-Bell [Tue, 14 Nov 2023 00:06:15 +0000 (18:06 -0600)] 
Less confusing error

2 years agoCopy ldap config over to base dir
Arran Cudbard-Bell [Fri, 10 Nov 2023 18:41:07 +0000 (12:41 -0600)] 
Copy ldap config over to base dir

2 years agoDon't immediately overwrite the specified socketpath
Arran Cudbard-Bell [Fri, 10 Nov 2023 17:39:42 +0000 (11:39 -0600)] 
Don't immediately overwrite the specified socketpath

2 years agoAllow overriding the socket path to work around weird permissions issues
Arran Cudbard-Bell [Thu, 9 Nov 2023 23:29:20 +0000 (17:29 -0600)] 
Allow overriding the socket path to work around weird permissions issues

2 years agotouching the socket just produces another error
Arran Cudbard-Bell [Thu, 9 Nov 2023 22:03:02 +0000 (16:03 -0600)] 
touching the socket just produces another error

2 years agoPre-create ldap socket file
Arran Cudbard-Bell [Thu, 9 Nov 2023 21:36:35 +0000 (15:36 -0600)] 
Pre-create ldap socket file

2 years agoRemove comment
Arran Cudbard-Bell [Thu, 9 Nov 2023 21:18:37 +0000 (15:18 -0600)] 
Remove comment

2 years agoBuild and scan with all available cores
Arran Cudbard-Bell [Thu, 9 Nov 2023 21:18:19 +0000 (15:18 -0600)] 
Build and scan with all available cores

2 years agoldap: Add extra schemas for tacacs
Arran Cudbard-Bell [Thu, 9 Nov 2023 16:41:02 +0000 (10:41 -0600)] 
ldap: Add extra schemas for tacacs

2 years agojson: Add nested encoding tests
Arran Cudbard-Bell [Thu, 9 Nov 2023 16:37:21 +0000 (10:37 -0600)] 
json: Add nested encoding tests

2 years agouse radius_pairmove(), which does the same thing and more
Alan T. DeKok [Wed, 8 Nov 2023 15:17:56 +0000 (16:17 +0100)] 
use radius_pairmove(), which does the same thing and more

in an attempt to get rid of old / duplicate APIs

2 years agoRemove autosave file
Nick Porter [Wed, 8 Nov 2023 10:27:06 +0000 (10:27 +0000)] 
Remove autosave file

2 years agoInst is const when used in the xlat function
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:35:50 +0000 (19:35 -0600)] 
Inst is const when used in the xlat function

2 years agoCan't have more than one local variable!
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:33:41 +0000 (19:33 -0600)] 
Can't have more than one local variable!

2 years agoAdd test for using local attributes in eval
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:18:13 +0000 (19:18 -0600)] 
Add test for using local attributes in eval

2 years agoAllow local attributes to be referenced in eval xlats
Arran Cudbard-Bell [Wed, 8 Nov 2023 00:57:47 +0000 (18:57 -0600)] 
Allow local attributes to be referenced in eval xlats

2 years agoRemove dict from xlat_exp_head_t
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:11:56 +0000 (19:11 -0600)] 
Remove dict from xlat_exp_head_t

It's already in the nodes it needs to be in

2 years agoRemove async from name of instantiate set functions
Arran Cudbard-Bell [Wed, 8 Nov 2023 01:10:58 +0000 (19:10 -0600)] 
Remove async from name of instantiate set functions

2 years agoRename xlat instance registration functions
Arran Cudbard-Bell [Tue, 7 Nov 2023 23:34:46 +0000 (17:34 -0600)] 
Rename xlat instance registration functions

Bootstrap is a distinct phase for modules, and calling the registration phase "bootstrap" is confusing as there's no bootstrap function available to xlats...

2 years agoDisable performance tests on FreeBSD
Nick Porter [Fri, 3 Nov 2023 17:13:24 +0000 (17:13 +0000)] 
Disable performance tests on FreeBSD

It's a VM inside a VM so not going to be consistent / fast

2 years agoSwitch hypervisors for FreeBSD tests
Nick Porter [Fri, 3 Nov 2023 15:59:40 +0000 (15:59 +0000)] 
Switch hypervisors for FreeBSD tests

2 years agoDon't print undefined string
Nick Porter [Fri, 3 Nov 2023 13:39:21 +0000 (13:39 +0000)] 
Don't print undefined string

2 years agoluajit 2.0 is deprecated, 2.1 is current
Nick Porter [Fri, 3 Nov 2023 13:00:33 +0000 (13:00 +0000)] 
luajit 2.0 is deprecated, 2.1 is current

2 years agolua tests: pairs is a field in fr.request
Nick Porter [Fri, 3 Nov 2023 11:29:14 +0000 (11:29 +0000)] 
lua tests: pairs is a field in fr.request

2 years agoWe don't marshal structured attributes to lua yet
Nick Porter [Fri, 3 Nov 2023 11:28:09 +0000 (11:28 +0000)] 
We don't marshal structured attributes to lua yet

2 years agolua ffi.load doesn't search multiple paths
Nick Porter [Fri, 3 Nov 2023 09:43:45 +0000 (09:43 +0000)] 
lua ffi.load doesn't search multiple paths

2 years agoFix compiler warnings on FreeBSD
Nick Porter [Thu, 2 Nov 2023 20:43:33 +0000 (20:43 +0000)] 
Fix compiler warnings on FreeBSD

2 years agoUse cross-platform actions for FreeBSD tests
Nick Porter [Thu, 2 Nov 2023 12:14:02 +0000 (12:14 +0000)] 
Use cross-platform actions for FreeBSD tests

This action appears to be under more active development / maintenance than vmactions/freebsd-vm

2 years agoCheck for node == NULL in xlat_validate_function_arg() (CID #1548367) (#5213)
James Jones [Thu, 2 Nov 2023 15:11:45 +0000 (10:11 -0500)] 
Check for node == NULL in xlat_validate_function_arg() (CID #1548367) (#5213)

2 years agoNo point evaluating SQL-User-Name after the query has been built
Nick Porter [Thu, 2 Nov 2023 11:40:49 +0000 (11:40 +0000)] 
No point evaluating SQL-User-Name after the query has been built

To use SQL-User-Name in an SQL map, it needs to be populated before the
value box list of the query is created.

2 years agoUse taloc_typed_strdup when xlat_eval returns no values
Nick Porter [Thu, 2 Nov 2023 11:17:54 +0000 (11:17 +0000)] 
Use taloc_typed_strdup when xlat_eval returns no values

Otherwise using the resulting string in
fr_pair_value_bstrdup_buffer_shallow() or other functions which check
the talloc type will fail.

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:47 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:41 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:34 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:26 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:23 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Thu, 2 Nov 2023 09:34:11 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoremove manual fr_extend_lowat()
Alan T. DeKok [Wed, 1 Nov 2023 23:58:55 +0000 (19:58 -0400)] 
remove manual fr_extend_lowat()

2 years agoadd missing function
Alan T. DeKok [Wed, 1 Nov 2023 23:58:29 +0000 (19:58 -0400)] 
add missing function

2 years agoremove unnecessary ; after function
Alan T. DeKok [Wed, 1 Nov 2023 23:57:13 +0000 (19:57 -0400)] 
remove unnecessary ; after function

2 years agoxlat: Don't leave dangling marker
Arran Cudbard-Bell [Wed, 1 Nov 2023 22:35:22 +0000 (16:35 -0600)] 
xlat: Don't leave dangling marker

2 years agoInitialise max
Arran Cudbard-Bell [Wed, 1 Nov 2023 22:28:03 +0000 (16:28 -0600)] 
Initialise max

2 years agosbuff: When performing prefix matches, always extend by the longest needle
Arran Cudbard-Bell [Wed, 1 Nov 2023 21:20:06 +0000 (15:20 -0600)] 
sbuff: When performing prefix matches, always extend by the longest needle

2 years agotypo
Alan T. DeKok [Wed, 1 Nov 2023 20:40:09 +0000 (16:40 -0400)] 
typo

2 years agoRevert "move extend out of users_file.c to sbuff.c"
Alan T. DeKok [Wed, 1 Nov 2023 20:24:51 +0000 (16:24 -0400)] 
Revert "move extend out of users_file.c to sbuff.c"

This reverts commit 02ec7cdac5cbaa13305eb2503a23210d3af9084d.

it turns out extending things in the sbuff code causes other
problems.  So we leave some hacks in the users_file parser.

2 years agomove to RADIUS attributes
Alan T. DeKok [Wed, 1 Nov 2023 20:02:38 +0000 (16:02 -0400)] 
move to RADIUS attributes