]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
21 months agoMinor error message fixes
Arran Cudbard-Bell [Mon, 14 Oct 2024 01:36:07 +0000 (21:36 -0400)] 
Minor error message fixes

22 months agoTypo (CID #1632387)
Nick Porter [Fri, 11 Oct 2024 21:17:13 +0000 (22:17 +0100)] 
Typo (CID #1632387)

22 months agoAdd a default for query_timeout
Nick Porter [Fri, 11 Oct 2024 13:58:33 +0000 (14:58 +0100)] 
Add a default for query_timeout

Ensures we have something set for unixodbc where this is used in
calculating the upper bound for polling intervals

22 months agoOnly set rcode if it's currently OK
Nick Porter [Fri, 11 Oct 2024 13:52:19 +0000 (14:52 +0100)] 
Only set rcode if it's currently OK

22 months agoDon't attempt to close connections which never opened
Nick Porter [Fri, 11 Oct 2024 12:13:12 +0000 (13:13 +0100)] 
Don't attempt to close connections which never opened

22 months agoUpdate rlm_sql_unixodbc to use trunk connections and async where possible
Nick Porter [Wed, 9 Oct 2024 18:13:47 +0000 (19:13 +0100)] 
Update rlm_sql_unixodbc to use trunk connections and async where possible

Async support is driver specific, so some will run synchronous and some
async.

Tested with:
 - Microsoft ODBC Driver 18 for SQL Server
 - FreeTDS driver (Sybase/MS SQL)
 - MariaDB Connector/ODBC(Unicode)
 - MySQL ODBC 9.0 Unicode Driver
 - PostgreSQL Unicode

of which only Microsoft ODBC provided async support.

22 months agoRemove unused argument
Nick Porter [Mon, 7 Oct 2024 09:15:50 +0000 (10:15 +0100)] 
Remove unused argument

22 months agoFix up MS SQL ippool queries
Nick Porter [Wed, 9 Oct 2024 18:09:52 +0000 (19:09 +0100)] 
Fix up MS SQL ippool queries

22 months agoMake field name comparisons case insensitive for SQL maps
Nick Porter [Wed, 9 Oct 2024 13:01:57 +0000 (14:01 +0100)] 
Make field name comparisons case insensitive for SQL maps

22 months agoCorrect group attribute queries
Nick Porter [Wed, 9 Oct 2024 11:40:54 +0000 (12:40 +0100)] 
Correct group attribute queries

22 months agoUse macros to reduce boilerplate
Nick Porter [Mon, 7 Oct 2024 08:45:36 +0000 (09:45 +0100)] 
Use macros to reduce boilerplate

22 months agoUse parse rules when parsing call_env data
Nick Porter [Fri, 11 Oct 2024 09:25:58 +0000 (10:25 +0100)] 
Use parse rules when parsing call_env data

Otherwise we don't properly unescape fixed values (e.g. \" in a double quoted string remains \" rather than becoming ")

22 months agoRemove level of annoying indirection and copying things from the fr_dict_protocol_t...
Arran Cudbard-Bell [Thu, 10 Oct 2024 22:24:10 +0000 (18:24 -0400)] 
Remove level of annoying indirection and copying things from the fr_dict_protocol_t to the dict

From comments this seems mostly to avoid cleaning up all the references to default_type_size and subtype_table.

Load the protocol symbol directly using dlsym, as this'll run every time the library is referenced and not just the first time.

Allocate a dictionary attribute extension for protocol specific data if requested to by the fr_dict_protocol_t

22 months agoUse common talloc_bstr_tolower function
Arran Cudbard-Bell [Thu, 10 Oct 2024 21:11:11 +0000 (17:11 -0400)] 
Use common talloc_bstr_tolower function

22 months agostruct fr_dict should be fr_dict_s
Arran Cudbard-Bell [Thu, 10 Oct 2024 19:15:29 +0000 (15:15 -0400)] 
struct fr_dict should be fr_dict_s

22 months agoWhitespace
Arran Cudbard-Bell [Thu, 10 Oct 2024 19:14:42 +0000 (15:14 -0400)] 
Whitespace

22 months agoand more "shut up static analyzer"
Alan T. DeKok [Thu, 10 Oct 2024 15:02:28 +0000 (11:02 -0400)] 
and more "shut up static analyzer"

22 months agosave reason for stopping in the fr_retry_t
Alan T. DeKok [Thu, 10 Oct 2024 14:54:26 +0000 (10:54 -0400)] 
save reason for stopping in the fr_retry_t

22 months agomore "quiet clang scan"
Alan T. DeKok [Thu, 10 Oct 2024 14:44:15 +0000 (10:44 -0400)] 
more "quiet clang scan"

22 months agomake clang scan happy
Alan T. DeKok [Thu, 10 Oct 2024 14:24:24 +0000 (10:24 -0400)] 
make clang scan happy

for some reason, it thinks that fr_fault_setup() sets its first
argument to NULL.

22 months agocompiler warning cleanups
Alan T. DeKok [Thu, 10 Oct 2024 14:10:07 +0000 (10:10 -0400)] 
compiler warning cleanups

22 months agotry this instead to make it build without OpenSSL
Alan T. DeKok [Thu, 10 Oct 2024 13:33:43 +0000 (09:33 -0400)] 
try this instead to make it build without OpenSSL

22 months agoRevert "add more OpenSSL magic"
Alan T. DeKok [Thu, 10 Oct 2024 13:30:34 +0000 (09:30 -0400)] 
Revert "add more OpenSSL magic"

This reverts commit 801ae0311868e6e26688db856d432313aa56894e.

22 months agoadd more OpenSSL magic
Alan T. DeKok [Thu, 10 Oct 2024 13:07:31 +0000 (09:07 -0400)] 
add more OpenSSL magic

22 months agoalways build radclient-ng
Alan T. DeKok [Thu, 10 Oct 2024 12:18:58 +0000 (08:18 -0400)] 
always build radclient-ng

22 months agoMove table search functions into table.h, and add new macros to return pointers to...
Arran Cudbard-Bell [Thu, 10 Oct 2024 03:20:42 +0000 (23:20 -0400)] 
Move table search functions into table.h, and add new macros to return pointers to values

This lets us create one line search function definitions for custom array types

22 months agoadd radius-bio library
Alan T. DeKok [Wed, 9 Oct 2024 19:52:08 +0000 (15:52 -0400)] 
add radius-bio library

22 months agoremove unnecessary defines
Alan T. DeKok [Wed, 9 Oct 2024 19:24:47 +0000 (15:24 -0400)] 
remove unnecessary defines

22 months agomove bio to separate makefile
Alan T. DeKok [Wed, 9 Oct 2024 19:08:04 +0000 (15:08 -0400)] 
move bio to separate makefile

22 months agoAdd test for Relay-Agent-Information encoding at the end of a packet
Nick Porter [Wed, 9 Oct 2024 09:22:44 +0000 (10:22 +0100)] 
Add test for Relay-Agent-Information encoding at the end of a packet

22 months agoThis can be simplified now attribute lists are nested
Nick Porter [Wed, 9 Oct 2024 09:21:04 +0000 (10:21 +0100)] 
This can be simplified now attribute lists are nested

22 months agoIf attr > 255 then it can't be 82
Nick Porter [Wed, 9 Oct 2024 08:12:56 +0000 (09:12 +0100)] 
If attr > 255 then it can't be 82

22 months agoDon't print error when skipping Message-Type
Nick Porter [Wed, 9 Oct 2024 08:11:19 +0000 (09:11 +0100)] 
Don't print error when skipping Message-Type

22 months agoSimplify and add comment
Nick Porter [Wed, 9 Oct 2024 07:59:51 +0000 (08:59 +0100)] 
Simplify and add comment

22 months agoCorrect query
Nick Porter [Tue, 8 Oct 2024 17:14:19 +0000 (18:14 +0100)] 
Correct query

22 months agoAllow for PGRES_TUPLES_CHUNK when checking PostgreSQL status codes
Nick Porter [Tue, 8 Oct 2024 15:01:26 +0000 (16:01 +0100)] 
Allow for PGRES_TUPLES_CHUNK when checking PostgreSQL status codes

22 months agoRevert "one more attempt to build the bio for RADIUS"
Alan T. DeKok [Tue, 8 Oct 2024 17:48:07 +0000 (13:48 -0400)] 
Revert "one more attempt to build the bio for RADIUS"

This reverts commit 24240010727d0484755b8be0acc0a712d9a2f07d.

22 months agoone more attempt to build the bio for RADIUS
Alan T. DeKok [Tue, 8 Oct 2024 17:20:59 +0000 (13:20 -0400)] 
one more attempt to build the bio for RADIUS

22 months agowe don't need an intermediate file
Alan T. DeKok [Tue, 8 Oct 2024 15:24:47 +0000 (11:24 -0400)] 
we don't need an intermediate file

22 months agoAnd this return
Nick Porter [Tue, 8 Oct 2024 14:23:14 +0000 (15:23 +0100)] 
And this return

22 months agoRevert "let's always build with BIOs"
Alan T. DeKok [Tue, 8 Oct 2024 14:23:59 +0000 (10:23 -0400)] 
Revert "let's always build with BIOs"

This reverts commit 360c2ecd751854b2f033d00a2fbfe838d54af90d.

22 months agoand this
Alan T. DeKok [Tue, 8 Oct 2024 14:17:00 +0000 (10:17 -0400)] 
and this

22 months agoCorrect return
Nick Porter [Tue, 8 Oct 2024 14:11:30 +0000 (15:11 +0100)] 
Correct return

22 months agoFix up DHCP packet sorting for nested attributes
Nick Porter [Tue, 8 Oct 2024 13:42:55 +0000 (14:42 +0100)] 
Fix up DHCP packet sorting for nested attributes

22 months agoNo need for a trailing zero byte after DHCPv4 end of options
Nick Porter [Mon, 7 Oct 2024 15:56:04 +0000 (16:56 +0100)] 
No need for a trailing zero byte after DHCPv4 end of options

22 months agoMark request as runnable if query fails
Nick Porter [Mon, 7 Oct 2024 13:54:21 +0000 (14:54 +0100)] 
Mark request as runnable if query fails

22 months agoit helps to commit files
Alan T. DeKok [Tue, 8 Oct 2024 14:10:13 +0000 (10:10 -0400)] 
it helps to commit files

22 months agoreturn error
Alan T. DeKok [Tue, 8 Oct 2024 14:04:05 +0000 (10:04 -0400)] 
return error

22 months agolet's always build with BIOs
Alan T. DeKok [Tue, 8 Oct 2024 13:52:30 +0000 (09:52 -0400)] 
let's always build with BIOs

22 months agouse UUIDv4 format for configuration file
Alan T. DeKok [Thu, 3 Oct 2024 15:25:52 +0000 (11:25 -0400)] 
use UUIDv4 format for configuration file

22 months agoadd fr_bio_fd_reopen() API
Alan T. DeKok [Thu, 3 Oct 2024 14:29:52 +0000 (10:29 -0400)] 
add fr_bio_fd_reopen() API

so that we can re-open a file BIO

22 months agoadd provisions for making directories when doing fopen()
Alan T. DeKok [Thu, 3 Oct 2024 14:06:21 +0000 (10:06 -0400)] 
add provisions for making directories when doing fopen()

22 months agoadd function for common case of mkdir
Alan T. DeKok [Thu, 3 Oct 2024 14:02:52 +0000 (10:02 -0400)] 
add function for common case of mkdir

22 months agouse shutdown() on connected sockets
Alan T. DeKok [Thu, 3 Oct 2024 13:27:54 +0000 (09:27 -0400)] 
use shutdown() on connected sockets

22 months agoEnsure query rcode is set if MySQL actions return immediately
Nick Porter [Fri, 4 Oct 2024 16:03:42 +0000 (17:03 +0100)] 
Ensure query rcode is set if MySQL actions return immediately

22 months agoWS
Nick Porter [Fri, 4 Oct 2024 16:01:58 +0000 (17:01 +0100)] 
WS

22 months agoMissing conn->result is not always an error
Nick Porter [Fri, 4 Oct 2024 15:00:54 +0000 (16:00 +0100)] 
Missing conn->result is not always an error

It either indicates no results returned, or an error - depending on the
error code reported by mysql_errno()

22 months agoOnly increment counter if error is populated
Nick Porter [Fri, 4 Oct 2024 14:45:17 +0000 (15:45 +0100)] 
Only increment counter if error is populated

22 months agoCorrect handling of MySQL call to stored proc returning no data
Nick Porter [Fri, 4 Oct 2024 13:16:45 +0000 (14:16 +0100)] 
Correct handling of MySQL call to stored proc returning no data

22 months agoAvoid reporting empty error messages
Nick Porter [Fri, 4 Oct 2024 12:59:54 +0000 (13:59 +0100)] 
Avoid reporting empty error messages

22 months agoTest data actually contains options after padding
Nick Porter [Fri, 4 Oct 2024 10:41:22 +0000 (11:41 +0100)] 
Test data actually contains options after padding

which were not correctly decoded before

22 months agoPadding is correctly handled by fr_dhcpv4_decode_option()
Nick Porter [Fri, 4 Oct 2024 10:11:25 +0000 (11:11 +0100)] 
Padding is correctly handled by fr_dhcpv4_decode_option()

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Fri, 4 Oct 2024 09:35:14 +0000 (09:35 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Fri, 4 Oct 2024 09:35:07 +0000 (09:35 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:52 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:49 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:34 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

22 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Fri, 4 Oct 2024 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

22 months agoUse a Python virtual env
Nick Porter [Thu, 3 Oct 2024 18:47:32 +0000 (19:47 +0100)] 
Use a Python virtual env

Ubuntu 24 really doesn't like running pip as root

22 months agoCheck %dhcpv4.decode and encode with VSAs
Nick Porter [Thu, 3 Oct 2024 13:50:53 +0000 (14:50 +0100)] 
Check %dhcpv4.decode and encode with VSAs

22 months agoencode_vsio can be called with the da_stack built
Nick Porter [Thu, 3 Oct 2024 13:32:12 +0000 (14:32 +0100)] 
encode_vsio can be called with the da_stack built

When called from %dhcpv4.encode()

This is almost a revert of d6d160a, but with the option header and
length handled in encode_vsio()

22 months agofr_md5_ctx_free takes a fr_md5_ctx_t **
Nick Porter [Thu, 3 Oct 2024 09:05:35 +0000 (10:05 +0100)] 
fr_md5_ctx_free takes a fr_md5_ctx_t **

22 months agoAdd tests of multiple vendors inside DHCPv4 V-I-Vendor-Specific
Nick Porter [Wed, 2 Oct 2024 16:46:25 +0000 (17:46 +0100)] 
Add tests of multiple vendors inside DHCPv4 V-I-Vendor-Specific

22 months agoCorrect encoding of DHCPv4 vendor specific options
Nick Porter [Wed, 2 Oct 2024 16:12:35 +0000 (17:12 +0100)] 
Correct encoding of DHCPv4 vendor specific options

So that all children of V-I-Vendor-Specific will just create one option
rather than one per vendor.

22 months agoRemove DHCPv4 encoder for flat list VSAs
Nick Porter [Wed, 2 Oct 2024 16:07:12 +0000 (17:07 +0100)] 
Remove DHCPv4 encoder for flat list VSAs

22 months agotrack configuration versions
Alan T. DeKok [Wed, 2 Oct 2024 20:17:26 +0000 (16:17 -0400)] 
track configuration versions

so we can tell if someone mangles the config, and claims otherwise

22 months agolinelog: Add option to fsync on every write
Arran Cudbard-Bell [Tue, 1 Oct 2024 20:34:38 +0000 (22:34 +0200)] 
linelog: Add option to fsync on every write

22 months agoMove decode failure reasons
Arran Cudbard-Bell [Mon, 30 Sep 2024 19:11:45 +0000 (21:11 +0200)] 
Move decode failure reasons

22 months agounit_test_attribute: Allow setting the current attribute root passed to the decoder
Arran Cudbard-Bell [Mon, 30 Sep 2024 16:32:39 +0000 (18:32 +0200)] 
unit_test_attribute: Allow setting the current attribute root passed to the decoder

22 months agoMove dictionary selection to common code
Arran Cudbard-Bell [Fri, 27 Sep 2024 08:16:46 +0000 (10:16 +0200)] 
Move dictionary selection to common code

22 months agoOnly FR_TYPE_STRUCT need sorted children
Nick Porter [Tue, 24 Sep 2024 11:05:50 +0000 (12:05 +0100)] 
Only FR_TYPE_STRUCT need sorted children

22 months agoRe-enable testing of nested attributes from Perl
Nick Porter [Mon, 23 Sep 2024 10:56:55 +0000 (11:56 +0100)] 
Re-enable testing of nested attributes from Perl

22 months agoDecode nested hashes from Perl to nested attributes
Nick Porter [Thu, 19 Sep 2024 18:36:20 +0000 (19:36 +0100)] 
Decode nested hashes from Perl to nested attributes

22 months agoMore testing of nested attribute data in Perl
Nick Porter [Thu, 19 Sep 2024 14:29:43 +0000 (15:29 +0100)] 
More testing of nested attribute data in Perl

22 months agoCheck passing of octet data
Nick Porter [Thu, 19 Sep 2024 14:28:27 +0000 (15:28 +0100)] 
Check passing of octet data

22 months agoCheck multiple instances of an attribute appear as an array
Nick Porter [Thu, 19 Sep 2024 14:27:56 +0000 (15:27 +0100)] 
Check multiple instances of an attribute appear as an array

22 months agoAdd debugging of nested attributes to sample Perl
Nick Porter [Thu, 19 Sep 2024 14:17:54 +0000 (15:17 +0100)] 
Add debugging of nested attributes to sample Perl

22 months agoConvert structural data into Perl hashes
Nick Porter [Thu, 19 Sep 2024 13:32:54 +0000 (14:32 +0100)] 
Convert structural data into Perl hashes

22 months agoMake Perl variable debug output optional
Nick Porter [Thu, 19 Sep 2024 10:57:52 +0000 (11:57 +0100)] 
Make Perl variable debug output optional

In preparation for nested attributes - the nested structure is printed
out at the top level, so no need to print again at each child level.

22 months agoSimplify Perl debug output building
Nick Porter [Thu, 19 Sep 2024 10:34:21 +0000 (11:34 +0100)] 
Simplify Perl debug output building

22 months agoRemove unused argument
Nick Porter [Thu, 19 Sep 2024 10:24:37 +0000 (11:24 +0100)] 
Remove unused argument

22 months agoVerify that list changes aren't copied back
Nick Porter [Thu, 19 Sep 2024 09:29:56 +0000 (10:29 +0100)] 
Verify that list changes aren't copied back

22 months agoBy default don't replace attribute lists after perl module calls
Nick Porter [Thu, 19 Sep 2024 09:20:31 +0000 (10:20 +0100)] 
By default don't replace attribute lists after perl module calls

22 months agoUpdate CI status badge
Nick Porter [Fri, 20 Sep 2024 20:42:59 +0000 (21:42 +0100)] 
Update CI status badge

22 months agoSet correct depth on cloned child attributes
Nick Porter [Fri, 20 Sep 2024 16:03:59 +0000 (17:03 +0100)] 
Set correct depth on cloned child attributes

22 months agoDownload PGP key from inkbridgenetworks.com
Nick Porter [Fri, 20 Sep 2024 13:34:49 +0000 (14:34 +0100)] 
Download PGP key from inkbridgenetworks.com

22 months agoAdd support for Linux SLL2 link type to radsniff
Nick Porter [Fri, 20 Sep 2024 12:47:17 +0000 (13:47 +0100)] 
Add support for Linux SLL2 link type to radsniff