]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agorlm_detail listener can't take the short cut when adding to a network
Nick Porter [Wed, 18 Oct 2023 14:46:26 +0000 (15:46 +0100)] 
rlm_detail listener can't take the short cut when adding to a network

2 years agoIf poll_interval is set don't open a dummy file
Nick Porter [Tue, 17 Oct 2023 10:20:47 +0000 (11:20 +0100)] 
If poll_interval is set don't open a dummy file

Avoids a libkqueue issue which caused a crash on exit.

2 years agoHide inactive mod_write
Nick Porter [Tue, 17 Oct 2023 10:15:10 +0000 (11:15 +0100)] 
Hide inactive mod_write

2 years agoAdd option to allow for non-socket listeners
Nick Porter [Tue, 17 Oct 2023 10:11:59 +0000 (11:11 +0100)] 
Add option to allow for non-socket listeners

2 years agoMore consistent naming with other xlats
Nick Porter [Wed, 18 Oct 2023 07:49:36 +0000 (08:49 +0100)] 
More consistent naming with other xlats

2 years agoTweaks to the new radius_request_verify function
Arran Cudbard-Bell [Wed, 18 Oct 2023 01:37:15 +0000 (19:37 -0600)] 
Tweaks to the new radius_request_verify function

Rename to radius_secret_verify, as that's what it's doing.  The request has already been verified, we're trying different secrets against the request.

2 years agoUse the same codepath to trigger an exit as the signal handlers
Arran Cudbard-Bell [Wed, 18 Oct 2023 01:17:22 +0000 (19:17 -0600)] 
Use the same codepath to trigger an exit as the signal handlers

This allows other I/O callbacks to complete, so when the server exits, pending I/O events for proto_detail_file should've fired.  This mnay help with the crash on exit

2 years agoInclude missing header
Arran Cudbard-Bell [Tue, 17 Oct 2023 23:37:56 +0000 (17:37 -0600)] 
Include missing header

2 years agoModules should NEVER signal an event loop to exit
Arran Cudbard-Bell [Tue, 17 Oct 2023 23:36:39 +0000 (17:36 -0600)] 
Modules should NEVER signal an event loop to exit

2 years agoAdd %radius_request_verify() xlat
Nick Porter [Mon, 16 Oct 2023 08:39:59 +0000 (09:39 +0100)] 
Add %radius_request_verify() xlat

For verifying dynamic clients against a know shared secret

2 years agoallow relative attributes after DEFINEs
Alan T. DeKok [Tue, 17 Oct 2023 12:15:18 +0000 (08:15 -0400)] 
allow relative attributes after DEFINEs

2 years agomake the tests depend on the RADIUS dictionary
Alan T. DeKok [Tue, 17 Oct 2023 12:13:32 +0000 (08:13 -0400)] 
make the tests depend on the RADIUS dictionary

2 years agoBetter error message
Nick Porter [Tue, 17 Oct 2023 10:31:44 +0000 (11:31 +0100)] 
Better error message

2 years agouse sbuff API to quiet Coverity. CID #1547825
Alan T. DeKok [Mon, 16 Oct 2023 22:30:31 +0000 (18:30 -0400)] 
use sbuff API to quiet Coverity.  CID #1547825

Coverity is too dumb to notice that the buffer is initialized.
However, if we use the sbuff API, then it thinks everything is
fine.

2 years agomove to %file.exists()
Alan T. DeKok [Mon, 16 Oct 2023 22:14:24 +0000 (18:14 -0400)] 
move to %file.exists()

fix typo in deletion of old log file

just use "wc -l FILE", there's no need to "cat" everything

2 years agoremove "hoist vpt->xlat into xlat" in tokenize expression
Alan T. DeKok [Mon, 16 Oct 2023 22:10:58 +0000 (18:10 -0400)] 
remove "hoist vpt->xlat into xlat" in tokenize expression

the hoisting would put the expansion into an XLAT_GROUP, which
meant that any output value-boxes were wrapped in a value-box
group.  Which was distinctly unexpected.

2 years agoadded count argument to %file.tail(). and use it in tests
Alan T. DeKok [Mon, 16 Oct 2023 16:49:49 +0000 (12:49 -0400)] 
added count argument to %file.tail(). and use it in tests

2 years agouse %file.tail()
Alan T. DeKok [Mon, 16 Oct 2023 15:17:06 +0000 (11:17 -0400)] 
use %file.tail()

we haven't implemented "-n2" yet

2 years agoadd %file.tail(), along with tests and bug fixes
Alan T. DeKok [Mon, 16 Oct 2023 15:12:18 +0000 (11:12 -0400)] 
add %file.tail(), along with tests and bug fixes

2 years agomove to using internal file functions
Alan T. DeKok [Mon, 16 Oct 2023 13:13:24 +0000 (09:13 -0400)] 
move to using internal file functions

2 years agomove more functions to their own files
Alan T. DeKok [Mon, 16 Oct 2023 13:04:08 +0000 (09:04 -0400)] 
move more functions to their own files

2 years agomove protocol things to their own file
Alan T. DeKok [Mon, 16 Oct 2023 12:38:39 +0000 (08:38 -0400)] 
move protocol things to their own file

2 years agoadd and document log.warn() and log.err()
Alan T. DeKok [Mon, 16 Oct 2023 12:34:10 +0000 (08:34 -0400)] 
add and document log.warn() and log.err()

2 years agosplit up builtin functions, as there are many of them
Alan T. DeKok [Mon, 16 Oct 2023 12:28:09 +0000 (08:28 -0400)] 
split up builtin functions, as there are many of them

2 years agoadd file handling functions
Alan T. DeKok [Mon, 16 Oct 2023 12:20:49 +0000 (08:20 -0400)] 
add file handling functions

2 years agoadd a number of file-based functions
Alan T. DeKok [Sun, 15 Oct 2023 22:16:53 +0000 (18:16 -0400)] 
add a number of file-based functions

2 years agoRevert "we don't need to do "cat X | foo" when we can do "foo X""
Alan T. DeKok [Sun, 15 Oct 2023 19:07:29 +0000 (15:07 -0400)] 
Revert "we don't need to do "cat X | foo" when we can do "foo X""

This reverts commit 7771539fb4397a7831b07fe0330536e6a55a7356.

revert until we have time to track it down a bit more

2 years agowe don't need to do "cat X | foo" when we can do "foo X"
Alan T. DeKok [Sun, 15 Oct 2023 18:48:43 +0000 (14:48 -0400)] 
we don't need to do "cat X | foo" when we can do "foo X"

2 years agoremove accidental character
Alan T. DeKok [Sun, 15 Oct 2023 18:08:22 +0000 (14:08 -0400)] 
remove accidental character

2 years agovoid malloc / free
Alan T. DeKok [Sun, 15 Oct 2023 18:03:02 +0000 (14:03 -0400)] 
void malloc / free

just use local buffer, which is big enough for IPv6 prefixes,
floats, etc.

2 years agouse correct API
Alan T. DeKok [Sun, 15 Oct 2023 17:44:56 +0000 (13:44 -0400)] 
use correct API

fr_value_box_aprint() does not print quotation characters around
strings, even if escaping rules are passed to it.

Instead, we need to call fr_value_box_aprint_quoted(), which
will do the right thing.

2 years agopassing a NULL escape rules doesn't mean "print integer value"
Alan T. DeKok [Sun, 15 Oct 2023 13:49:46 +0000 (09:49 -0400)] 
passing a NULL escape rules doesn't mean "print integer value"

we instead have to copy the box, and nuke the enum name from
the box.

While we're at it, refuse to print structural types, too

2 years agostart of cleaning up escaping rules
Alan T. DeKok [Sun, 15 Oct 2023 13:35:37 +0000 (09:35 -0400)] 
start of cleaning up escaping rules

note that fr_value_box_print() does NOT respect tainting

fix a few callers to just re-implement print_quoted()

2 years agoremove %integer() from the tests
Alan T. DeKok [Sun, 15 Oct 2023 12:54:34 +0000 (08:54 -0400)] 
remove %integer() from the tests

2 years agono need to pass T_BARE_WORD to print_quoted. Just call print
Alan T. DeKok [Sun, 15 Oct 2023 13:25:59 +0000 (09:25 -0400)] 
no need to pass T_BARE_WORD to print_quoted.  Just call print

2 years agoremove unnecessary header
Alan T. DeKok [Sun, 15 Oct 2023 12:23:45 +0000 (08:23 -0400)] 
remove unnecessary header

2 years agovalidate oddities in casting
Alan T. DeKok [Thu, 12 Oct 2023 20:16:29 +0000 (16:16 -0400)] 
validate oddities in casting

(string) &foo[*] returnis a list of value-boxes, each cast
to a string

(string) (&foo[*]) return one string, which is all of the
value-boxes concatenated together

and update documentation

2 years agoUpdate inline docs for builtin xlats
Nick Porter [Fri, 13 Oct 2023 14:55:04 +0000 (15:55 +0100)] 
Update inline docs for builtin xlats

2 years agoDon't delete .work file if there are outstanding requests
Nick Porter [Fri, 13 Oct 2023 11:16:37 +0000 (12:16 +0100)] 
Don't delete .work file if there are outstanding requests

2 years agojust use %l or %c directly
Alan T. DeKok [Thu, 12 Oct 2023 20:04:03 +0000 (16:04 -0400)] 
just use %l or %c directly

there's no need to convert them to dates, and then cast them to
integers.  Those expansions are already integers

2 years agotypo
Alan T. DeKok [Thu, 12 Oct 2023 18:35:42 +0000 (14:35 -0400)] 
typo

2 years agostop on empty buffer, too.
Alan T. DeKok [Thu, 12 Oct 2023 17:57:09 +0000 (13:57 -0400)] 
stop on empty buffer, too.

The fr_pair_list_afrom_str() function should really be converted
to sbuffs, but that isn't immediately trivial.

It expect to see NUL-terminated C strings, and will misbehave
if given bad data.  Happily, all of the stgring value-boxes in
the server are zero-terminated, so this isn't much of an issue.

The same goes for input from unit_test_attribute.

2 years agoadd assertion for paranoia
Alan T. DeKok [Thu, 12 Oct 2023 16:53:35 +0000 (12:53 -0400)] 
add assertion for paranoia

2 years agodocs corrections
Nick Porter [Thu, 12 Oct 2023 15:36:21 +0000 (16:36 +0100)] 
docs corrections

2 years agoadd end check to loop limit
Alan T. DeKok [Thu, 12 Oct 2023 15:29:14 +0000 (11:29 -0400)] 
add end check to loop limit

and remove end check inside of loop.

The fr_struct_from_network() function will also enforce "end"

2 years agodocument "retransmit=no"
Alan T. DeKok [Thu, 12 Oct 2023 14:11:13 +0000 (10:11 -0400)] 
document "retransmit=no"

2 years agoretry.count is incremented by fr_retry_next()
Nick Porter [Thu, 12 Oct 2023 14:18:06 +0000 (15:18 +0100)] 
retry.count is incremented by fr_retry_next()

2 years agoif we're not retransmitting, mark done even on failure
Alan T. DeKok [Thu, 12 Oct 2023 14:08:56 +0000 (10:08 -0400)] 
if we're not retransmitting, mark done even on failure

2 years agonote limitations
Alan T. DeKok [Wed, 11 Oct 2023 20:01:17 +0000 (16:01 -0400)] 
note limitations

2 years agoDebug output correction
Nick Porter [Wed, 11 Oct 2023 21:27:36 +0000 (22:27 +0100)] 
Debug output correction

2 years agolist overrides are not allowed
Alan T. DeKok [Wed, 11 Oct 2023 19:55:47 +0000 (15:55 -0400)] 
list overrides are not allowed

The edit.c code calls fr_pair_list_afrom_str(), which does NOT
handle list over-rides.

Plus, we are assigning to a list as

&list += "pairs = value"

so having a list override does not make sense.

2 years agobetter error messages, so that we know what's going on
Alan T. DeKok [Wed, 11 Oct 2023 19:53:44 +0000 (15:53 -0400)] 
better error messages, so that we know what's going on

2 years agojust use the right comparison
Alan T. DeKok [Wed, 11 Oct 2023 14:37:50 +0000 (10:37 -0400)] 
just use the right comparison

2 years agoempty lists are equal when compared via ==
Alan T. DeKok [Wed, 11 Oct 2023 14:06:20 +0000 (10:06 -0400)] 
empty lists are equal when compared via ==

2 years agoadd %test.fail() which always returns XLAT_ACTION_FAIL
Alan T. DeKok [Wed, 11 Oct 2023 14:04:39 +0000 (10:04 -0400)] 
add %test.fail() which always returns XLAT_ACTION_FAIL

2 years agomake !(a == b) the same as (a != b)
Alan T. DeKok [Wed, 11 Oct 2023 12:26:28 +0000 (08:26 -0400)] 
make !(a == b) the same as (a != b)

2 years agoclarify error
Alan T. DeKok [Wed, 11 Oct 2023 12:18:26 +0000 (08:18 -0400)] 
clarify error

2 years agoupdate antora config
Matthew Newton [Tue, 10 Oct 2023 16:16:35 +0000 (17:16 +0100)] 
update antora config

2 years agodon't always try and be clever with the package version
Matthew Newton [Tue, 10 Oct 2023 14:01:25 +0000 (15:01 +0100)] 
don't always try and be clever with the package version

2 years agoadd dist version checks from v3
Matthew Newton [Tue, 10 Oct 2023 14:00:00 +0000 (15:00 +0100)] 
add dist version checks from v3

2 years agoupdate version.sh to cope with a prerelease
Matthew Newton [Tue, 10 Oct 2023 13:39:24 +0000 (14:39 +0100)] 
update version.sh to cope with a prerelease

2 years agofix version.sh output when we're on a tag
Matthew Newton [Tue, 10 Oct 2023 11:20:16 +0000 (12:20 +0100)] 
fix version.sh output when we're on a tag

2 years agouse commas in function args and other cleanups
Alan T. DeKok [Tue, 10 Oct 2023 00:53:19 +0000 (20:53 -0400)] 
use commas in function args and other cleanups

2 years agoallow &foo := {} to mean "delete leaf attributes"
Alan T. DeKok [Tue, 10 Oct 2023 00:45:53 +0000 (20:45 -0400)] 
allow &foo := {} to mean "delete leaf attributes"

because if the RHS is a dynamic expansion which returns no values,
that's what it means there

2 years agouse the correct array offsets.
Alan T. DeKok [Mon, 9 Oct 2023 19:40:23 +0000 (15:40 -0400)] 
use the correct array offsets.

Perhaps these changes should stop

2 years agoquiet static analyzer
Alan T. DeKok [Mon, 9 Oct 2023 19:25:20 +0000 (15:25 -0400)] 
quiet static analyzer

if we didn't find any match, return false

2 years agoread the debug output a bit more and fix the tests
Alan T. DeKok [Mon, 9 Oct 2023 19:23:32 +0000 (15:23 -0400)] 
read the debug output a bit more and fix the tests

2 years agomove this back to before &&/|| changes
Alan T. DeKok [Mon, 9 Oct 2023 17:59:29 +0000 (13:59 -0400)] 
move this back to before &&/|| changes

2 years agotry to quiet clang scan
Alan T. DeKok [Mon, 9 Oct 2023 17:41:58 +0000 (13:41 -0400)] 
try to quiet clang scan

2 years agoseparate out && and || code, and clean up tests
Alan T. DeKok [Mon, 9 Oct 2023 17:22:26 +0000 (13:22 -0400)] 
separate out && and || code, and clean up tests

2 years agomove %(foo:) to new syntax
Alan T. DeKok [Mon, 9 Oct 2023 16:32:24 +0000 (12:32 -0400)] 
move %(foo:) to new syntax

2 years agomove to new syntax
Alan T. DeKok [Mon, 9 Oct 2023 16:11:21 +0000 (12:11 -0400)] 
move to new syntax

perl -p -i -e 's/%\(([a-zA-Z0-0._-]+):([a-zA-Z0-9.]+)\)/%$1\($2\)/g'   $(git grep -lE '%\([a-z]+:' src/tests/keywords/)

perl -p -i -e 's/%\(([a-zA-Z0-0._-]+):%{([^%{}]+)}\)/%$1\(%{$2}\)/g'   $(git grep -lE '%\([a-z]+:' src/tests/keywords/)

2 years agoconver to new function syntax
Alan T. DeKok [Mon, 9 Oct 2023 16:04:49 +0000 (12:04 -0400)] 
conver to new function syntax

2 years agomore remove alternation :-
Alan T. DeKok [Mon, 9 Oct 2023 15:49:01 +0000 (11:49 -0400)] 
more remove alternation :-

2 years agocatch corner cases of && and ||
Alan T. DeKok [Mon, 9 Oct 2023 15:14:32 +0000 (11:14 -0400)] 
catch corner cases of && and ||

where there's no input, so the output shouldn't exist, either

2 years agoremove alternation
Alan T. DeKok [Mon, 9 Oct 2023 13:22:52 +0000 (09:22 -0400)] 
remove alternation

2 years agoAlign xlat function debug with new function call format
Nick Porter [Mon, 9 Oct 2023 15:04:10 +0000 (16:04 +0100)] 
Align xlat function debug with new function call format

2 years agoUpdate LDAP tests
Nick Porter [Mon, 9 Oct 2023 14:28:53 +0000 (15:28 +0100)] 
Update LDAP tests

2 years agoRemove unnecessary ""
Nick Porter [Mon, 9 Oct 2023 14:00:53 +0000 (15:00 +0100)] 
Remove unnecessary ""

2 years agoRevert "auto-convert LDAP"
Alan T. DeKok [Mon, 9 Oct 2023 13:18:40 +0000 (09:18 -0400)] 
Revert "auto-convert LDAP"

This reverts commit b4af84428990140af855f5ca7a6ecbc7790cc4bf.

Nope.  LDAP tests fail.  Reverting until we do the conversion
manually.

2 years agoauto-convert functions with fixed string arguments
Alan T. DeKok [Mon, 9 Oct 2023 13:09:33 +0000 (09:09 -0400)] 
auto-convert functions with fixed string arguments

perl -p -i -e "s/%{([a-zA-Z0-9._-]+):([^&%{}=']+)}/%\$1('\$2')/g"  $(git grep -lE '%\{[a-z0-9.-]+:' src/tests/keywords/ src/tests/modules)

2 years agoauto-convert LDAP
Alan T. DeKok [Mon, 9 Oct 2023 13:06:08 +0000 (09:06 -0400)] 
auto-convert LDAP

perl -p -i -e 's/"%{ldap:(.*?)}"/%ldap("$1")/' $(git grep -lE '%\{[a-z]+:' src/tests/modules/)

2 years agoauto-convert SQL
Alan T. DeKok [Mon, 9 Oct 2023 13:04:03 +0000 (09:04 -0400)] 
auto-convert SQL

perl -p -i -e 's/"%{sql:(.*?)}"/%sql("$1")/' $(git grep -lE '%\{[a-z]+:' src/tests/modules/)

2 years agomore auto-conversion
Alan T. DeKok [Mon, 9 Oct 2023 13:00:36 +0000 (09:00 -0400)] 
more auto-conversion

perl -p -i -e "s/%{([a-zA-Z0-9._-]+):([a-zA-Z0-9.]+)}/%\$1('\$2')/g"  $(git grep -lE '%\{[a-z0-9.-]+:' src/tests/keywords/ src/tests/modules)

2 years agoauto-convert to new syntax
Alan T. DeKok [Mon, 9 Oct 2023 12:52:10 +0000 (08:52 -0400)] 
auto-convert to new syntax

perl -p -i -e 's/%{([a-zA-Z0-9._-]+):%{([a-zA-Z0-9._-]+)}}/%$1(%{$2})/g'  $(git grep -lE '%\{[a-z]+:' src/tests/keywords/)

2 years agoCoverity #1547098
Alan T. DeKok [Mon, 9 Oct 2023 12:37:00 +0000 (08:37 -0400)] 
Coverity #1547098

2 years agoadd missing case
Alan T. DeKok [Sun, 8 Oct 2023 17:18:08 +0000 (13:18 -0400)] 
add missing case

2 years agoadd log.debug() and log.info()
Alan T. DeKok [Sun, 8 Oct 2023 16:37:48 +0000 (12:37 -0400)] 
add log.debug() and log.info()

so that we can log to the normal request log in unlang

2 years agoadd "request" destination for linelog
Alan T. DeKok [Sun, 8 Oct 2023 16:37:26 +0000 (12:37 -0400)] 
add "request" destination for linelog

so that it can log to the normal request log

2 years agoremove old text
Alan T. DeKok [Sun, 8 Oct 2023 13:32:00 +0000 (09:32 -0400)] 
remove old text

2 years agostupid local compiler misses things
Alan T. DeKok [Sun, 8 Oct 2023 13:25:19 +0000 (09:25 -0400)] 
stupid local compiler misses things

2 years agoremove %expr()
Alan T. DeKok [Sun, 8 Oct 2023 13:15:03 +0000 (09:15 -0400)] 
remove %expr()

2 years agomore typos
Alan T. DeKok [Sun, 8 Oct 2023 13:13:08 +0000 (09:13 -0400)] 
more typos

2 years agoshow which condition failed to parse
Alan T. DeKok [Sun, 8 Oct 2023 13:11:40 +0000 (09:11 -0400)] 
show which condition failed to parse

2 years agotypo
Alan T. DeKok [Sun, 8 Oct 2023 12:57:16 +0000 (08:57 -0400)] 
typo

2 years agoupdate redis tests to not use %expr
Alan T. DeKok [Sun, 8 Oct 2023 12:37:39 +0000 (08:37 -0400)] 
update redis tests to not use %expr

2 years agoquiet static analyzer
Alan T. DeKok [Sun, 8 Oct 2023 12:37:07 +0000 (08:37 -0400)] 
quiet static analyzer

2 years agomore "get rid of expr"
Alan T. DeKok [Sun, 8 Oct 2023 12:03:26 +0000 (08:03 -0400)] 
more "get rid of expr"

2 years agoget rid of backticks in tests
Alan T. DeKok [Sun, 8 Oct 2023 12:03:57 +0000 (08:03 -0400)] 
get rid of backticks in tests

2 years agodon't pull casts into in-place expressions
Alan T. DeKok [Sun, 8 Oct 2023 12:00:32 +0000 (08:00 -0400)] 
don't pull casts into in-place expressions

because that would change how the text inside of the expression
is parsed, and we don't want that