]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
23 months agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:22 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

23 months agoRebuild docker images when the dock file changes
Arran Cudbard-Bell [Thu, 4 Jul 2024 20:42:37 +0000 (14:42 -0600)] 
Rebuild docker images when the dock file changes

23 months agoInstall some extra packages by default
Arran Cudbard-Bell [Thu, 4 Jul 2024 20:36:52 +0000 (14:36 -0600)] 
Install some extra packages by default

23 months agoDon't emit spurious global WARNs in rlm_cache
Arran Cudbard-Bell [Thu, 4 Jul 2024 15:30:40 +0000 (09:30 -0600)] 
Don't emit spurious global WARNs in rlm_cache

23 months agoAdd freeradiusClientGroupDN
Arran Cudbard-Bell [Thu, 4 Jul 2024 05:02:51 +0000 (23:02 -0600)] 
Add freeradiusClientGroupDN

23 months agoAllow the name of the instant client packages to be specified
Arran Cudbard-Bell [Tue, 2 Jul 2024 23:06:38 +0000 (17:06 -0600)] 
Allow the name of the instant client packages to be specified

23 months agoUse the new macro name
Arran Cudbard-Bell [Tue, 2 Jul 2024 20:53:29 +0000 (14:53 -0600)] 
Use the new macro name

23 months agoDon't set the oracle version by default
Arran Cudbard-Bell [Tue, 2 Jul 2024 20:16:21 +0000 (14:16 -0600)] 
Don't set the oracle version by default

23 months agoRevert "Take RPMBUILD_FLAGS in builddep too"
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:58:05 +0000 (12:58 -0600)] 
Revert "Take RPMBUILD_FLAGS in builddep too"

This reverts commit 675e4e3f41b326b4561ca89ee80bee444a7e019c.

23 months agoRevert "Pass in the oracle version explicitly"
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:57:48 +0000 (12:57 -0600)] 
Revert "Pass in the oracle version explicitly"

This reverts commit 2b1a72f8ffb1d7e526cd7c55c7319332b1733ff9.

23 months agoMove definitions to the top of the spec file
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:53:12 +0000 (12:53 -0600)] 
Move definitions to the top of the spec file

23 months agoPass in the oracle version explicitly
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:43:19 +0000 (12:43 -0600)] 
Pass in the oracle version explicitly

All the rpmbuild tools seem very broken

23 months agoTake RPMBUILD_FLAGS in builddep too
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:27:40 +0000 (12:27 -0600)] 
Take RPMBUILD_FLAGS in builddep too

23 months agorpmbuild doesn't like the separation
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:13:08 +0000 (12:13 -0600)] 
rpmbuild doesn't like the separation

23 months agoAccept --define _oracle_version
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:02:44 +0000 (12:02 -0600)] 
Accept --define _oracle_version

23 months agoRegenerate the _ORACLE_ configure script
Arran Cudbard-Bell [Tue, 2 Jul 2024 17:19:55 +0000 (11:19 -0600)] 
Regenerate the _ORACLE_ configure script

23 months agoUpdate rlm_sql_oracle configure scripts
Arran Cudbard-Bell [Mon, 1 Jul 2024 23:19:36 +0000 (17:19 -0600)] 
Update rlm_sql_oracle configure scripts

23 months agoConst
Arran Cudbard-Bell [Sun, 30 Jun 2024 22:33:55 +0000 (16:33 -0600)] 
Const

23 months agoWS
Arran Cudbard-Bell [Sun, 30 Jun 2024 20:00:27 +0000 (14:00 -0600)] 
WS

23 months agoRemove invalid assert that was triggered evaluating log messages
Arran Cudbard-Bell [Sun, 30 Jun 2024 19:33:28 +0000 (13:33 -0600)] 
Remove invalid assert that was triggered evaluating log messages

23 months agoSync require_message_authenticator field names, it's called three different things...
Arran Cudbard-Bell [Sat, 29 Jun 2024 03:55:50 +0000 (21:55 -0600)] 
Sync require_message_authenticator field names, it's called three different things at different places in the server

2 years agoSet a capacity for trunk backlog
Nick Porter [Fri, 28 Jun 2024 11:20:50 +0000 (12:20 +0100)] 
Set a capacity for trunk backlog

And allow requests to be allocated / enqueued even if the max
connections and requests per connection limit is reached, up to the
backlog limit.

Helps handle spikes in traffic, particularly where trunks are limited to
one request per connection, and there are server side limitations on the
number of connections that can be made - e.g. SQL servers.

2 years agoRun docker build on ubuntu-latest
Nick Porter [Fri, 28 Jun 2024 12:46:41 +0000 (13:46 +0100)] 
Run docker build on ubuntu-latest

Seems to resolve the issue with the debiansid container build hanging

2 years agoAlways mark trunk requests as complete when freeing query ctx
Nick Porter [Fri, 28 Jun 2024 09:43:12 +0000 (10:43 +0100)] 
Always mark trunk requests as complete when freeing query ctx

Due to query_ctx being re-used multiple times when running transactions
(e.g. allocating IPs in sqlippool) it is possible for the current query
to not be submitted, but there still to be a trunk request associated
with the query_ctx.

2 years agoTypo
Arran Cudbard-Bell [Fri, 28 Jun 2024 03:58:34 +0000 (21:58 -0600)] 
Typo

2 years agoRefactor LDAP URI xlat code so that we can call it easily from a future modify and...
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:44:00 +0000 (11:44 -0600)] 
Refactor LDAP URI xlat code so that we can call it easily from a future modify and delete xlats

2 years agoAdd API level support for deleting objects
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:43:20 +0000 (11:43 -0600)] 
Add API level support for deleting objects

This is just for completeness.  We don't currently have any use case for it, but it'll likely be called by a delete xlat in the near future.

2 years agoWhitespace fixes
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:42:12 +0000 (11:42 -0600)] 
Whitespace fixes

2 years agoFix struct names
Arran Cudbard-Bell [Thu, 27 Jun 2024 16:39:50 +0000 (10:39 -0600)] 
Fix struct names

2 years agos/memberof/group/g for group checking XLAT to allow redundant xlats over SQL and...
Arran Cudbard-Bell [Thu, 27 Jun 2024 16:19:05 +0000 (10:19 -0600)] 
s/memberof/group/g for group checking XLAT to allow redundant xlats over SQL and LDAP

2 years agoDo size calculation in appropriate type (CID #1604603)
James Jones [Thu, 27 Jun 2024 14:00:32 +0000 (09:00 -0500)] 
Do size calculation in appropriate type (CID #1604603)

In the error message in lst_expand(), the calculation of the size
has to be done in size_t. The cast of sizeof(void *) to uint32_t
causes it to be done in uint32_t, but that has the possibility of
overflow; note that n_capacity may be set to UINT_MAX, which would
guarantee it. The format conversion is changed to match.

2 years agocassandra start query is missing two escape characters
Stephen Blackwell [Wed, 26 Jun 2024 21:14:56 +0000 (15:14 -0600)] 
cassandra start query is missing two escape characters

2 years agoOnly add positive r values to total (CID #16046001)
James Jones [Wed, 26 Jun 2024 16:36:09 +0000 (11:36 -0500)] 
Only add positive r values to total (CID #16046001)

With the addition of r to total in the for loop header, the continue
for EINTR causes a negative value of r to be added to total. That's the
only thing that looks like it could cause an overflow and taint total.

2 years agoAdd open_query to MySQL queries.conf
Nick Porter [Wed, 26 Jun 2024 12:22:31 +0000 (13:22 +0100)] 
Add open_query to MySQL queries.conf

Particularly in the case of sqlippool use, it has been found that
setting the transaction isolation level to READ COMMITTED is needed to
avoid deadlocks.

2 years agoReinstate running open_query for MySQL
Nick Porter [Wed, 26 Jun 2024 12:17:15 +0000 (13:17 +0100)] 
Reinstate running open_query for MySQL

2 years agoCorrect enum case
Nick Porter [Wed, 26 Jun 2024 12:12:47 +0000 (13:12 +0100)] 
Correct enum case

2 years agoGuard allocation with MEM() (CID #1604618)
James Jones [Tue, 25 Jun 2024 16:37:32 +0000 (11:37 -0500)] 
Guard allocation with MEM() (CID #1604618)

2 years agoCorrect docs
Nick Porter [Tue, 25 Jun 2024 14:53:15 +0000 (15:53 +0100)] 
Correct docs

2 years agosqlippool query fixes
Nick Porter [Mon, 24 Jun 2024 18:23:34 +0000 (19:23 +0100)] 
sqlippool query fixes

2 years agoDon't attempt to run zero length queries
Nick Porter [Mon, 24 Jun 2024 17:35:32 +0000 (18:35 +0100)] 
Don't attempt to run zero length queries

Since these come from conf file entries it's all to easy for something
such as

alloc_requested = ''

to be set rather than commenting out the entry.

2 years agoAdd client_port to proto_dhcpv4_udp
Nick Porter [Mon, 24 Jun 2024 13:46:06 +0000 (14:46 +0100)] 
Add client_port to proto_dhcpv4_udp

2 years agoCorrect DHCP attribute sorting comparison function
Nick Porter [Fri, 21 Jun 2024 16:02:47 +0000 (17:02 +0100)] 
Correct DHCP attribute sorting comparison function

2 years agoadd more documentation
Alan T. DeKok [Fri, 21 Jun 2024 16:12:28 +0000 (12:12 -0400)] 
add more documentation

2 years agocorrect decode of length + offset fields in structs
Alan T. DeKok [Fri, 21 Jun 2024 16:04:41 +0000 (12:04 -0400)] 
correct decode of length + offset fields in structs

2 years agothe correct offset is 3
Alan T. DeKok [Fri, 21 Jun 2024 16:03:14 +0000 (12:03 -0400)] 
the correct offset is 3

2 years agothe offset here is 3
Alan T. DeKok [Fri, 21 Jun 2024 16:02:33 +0000 (12:02 -0400)] 
the offset here is 3

2 years agoadd tests for simple password auth type
Alan T. DeKok [Fri, 21 Jun 2024 14:53:44 +0000 (10:53 -0400)] 
add tests for simple password auth type

2 years agoRemove spurious debug message
Nick Porter [Fri, 21 Jun 2024 10:45:26 +0000 (11:45 +0100)] 
Remove spurious debug message

2 years agoFix error in dictionary documentation
Matthew Newton [Fri, 21 Jun 2024 09:06:39 +0000 (10:06 +0100)] 
Fix error in dictionary documentation

Fixes #5345

2 years agoMore const issues
Arran Cudbard-Bell [Fri, 21 Jun 2024 00:31:52 +0000 (18:31 -0600)] 
More const issues

2 years agoFix some missed renames
Arran Cudbard-Bell [Fri, 21 Jun 2024 00:06:36 +0000 (18:06 -0600)] 
Fix some missed renames

2 years agoConst issues
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:51:01 +0000 (17:51 -0600)] 
Const issues

2 years agoEvaluate all chained method groups when searching for methods or printing methods
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:36:01 +0000 (17:36 -0600)] 
Evaluate all chained method groups when searching for methods or printing methods

2 years agoCommon indent levels in module_rlm.h
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:18:02 +0000 (17:18 -0600)] 
Common indent levels in module_rlm.h

2 years agoRemove unused functions
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:16:42 +0000 (17:16 -0600)] 
Remove unused functions

2 years agoInitialise name
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:13:27 +0000 (17:13 -0600)] 
Initialise name

2 years agoCorrect example xlat calls
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:13:17 +0000 (17:13 -0600)] 
Correct example xlat calls

2 years agoFinal set of changes for making redundant xlat function registration not suck
Arran Cudbard-Bell [Thu, 20 Jun 2024 21:57:23 +0000 (15:57 -0600)] 
Final set of changes for making redundant xlat function registration not suck

We now group module xlats by name (all self-named module expansions are considered equal).

This allows:

redundant {
    sql
    linelog
}

Which would issue a query against SQL, and then log it to disk.

The instantiate code catches/disallows calls to incompatible module expansions in much the same way as C's _Generic does...

2 years agoTest attr_filter on reply list
Nick Porter [Thu, 20 Jun 2024 16:09:32 +0000 (17:09 +0100)] 
Test attr_filter on reply list

2 years agoUse correct context for pairs
Nick Porter [Thu, 20 Jun 2024 16:08:56 +0000 (17:08 +0100)] 
Use correct context for pairs

2 years agoAdd list name based methods to attr_filter
Nick Porter [Thu, 20 Jun 2024 15:53:26 +0000 (16:53 +0100)] 
Add list name based methods to attr_filter

2 years agoPython script to add an lldb command
James Jones [Tue, 4 Jun 2024 13:57:21 +0000 (08:57 -0500)] 
Python script to add an lldb command

This, once imported with an lldb "script" command, adds a "dd" command
to display certain types of values in an intelligible fashion using the
existing foo_debug() functions not only is it intelligible, it uses a
format people are used to.

The foo_debug() functions take a pointer to the structure. The dd command
will take names of variables that have the structure type as well, and
pass their address.

2 years agoAdd doc file for lldb
James Jones [Thu, 13 Jun 2024 21:47:26 +0000 (16:47 -0500)] 
Add doc file for lldb

Initially at least it concentrates on extending it with Python scripts,
though it does describe how to adapt the sample command line output
when a test fails to invoke lldb on the program being tested.

2 years agoDon't use MySQL read / write timeout options
Nick Porter [Thu, 20 Jun 2024 09:00:36 +0000 (10:00 +0100)] 
Don't use MySQL read / write timeout options

The model for async is different to the sync client.  Timeouts are
expected to be handled by the calling application rather than the client
library.

2 years agoBackticks
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:39:58 +0000 (14:39 -0600)] 
Backticks

2 years agoUse the correct context
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:37:35 +0000 (14:37 -0600)] 
Use the correct context

2 years agoPut the proxy reply in the right list...
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:11:52 +0000 (14:11 -0600)] 
Put the proxy reply in the right list...

2 years agoFix confusing name
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:11:40 +0000 (14:11 -0600)] 
Fix confusing name

2 years agoquiet coverity
Alan T. DeKok [Wed, 19 Jun 2024 12:49:17 +0000 (08:49 -0400)] 
quiet coverity

We can decode packets if there's no original request, but we
cannot verify the Response Authenticator

2 years agoStatus-Client has no definition and is never used
Alan T. DeKok [Wed, 19 Jun 2024 12:47:53 +0000 (08:47 -0400)] 
Status-Client has no definition and is never used

2 years agoadd connection_timeout to RADIUS client BIO
Alan T. DeKok [Wed, 12 Jun 2024 18:50:33 +0000 (14:50 -0400)] 
add connection_timeout to RADIUS client BIO

2 years agoremove UNUSED
Alan T. DeKok [Wed, 12 Jun 2024 18:08:30 +0000 (14:08 -0400)] 
remove UNUSED

variables are used.

2 years agofix compiler warning
Alan T. DeKok [Wed, 12 Jun 2024 18:07:05 +0000 (14:07 -0400)] 
fix compiler warning

2 years agoEnsure queries are freed before pool connection is released
Nick Porter [Tue, 18 Jun 2024 15:02:14 +0000 (16:02 +0100)] 
Ensure queries are freed before pool connection is released

2 years agoFix docs
Arran Cudbard-Bell [Tue, 18 Jun 2024 02:58:37 +0000 (20:58 -0600)] 
Fix docs

2 years agoFix "RADIUS checksum" mode in radsniff, when dealing with Access-Requests
Arran Cudbard-Bell [Tue, 18 Jun 2024 02:48:12 +0000 (20:48 -0600)] 
Fix "RADIUS checksum" mode in radsniff, when dealing with Access-Requests

2 years agoAdd 3GPP2 attributes
Nick Porter [Mon, 17 Jun 2024 16:04:18 +0000 (17:04 +0100)] 
Add 3GPP2 attributes

Found in 3GPP2 specification document A.S0008-C

2 years agoRecord which xlat registered the module instance
Arran Cudbard-Bell [Sun, 16 Jun 2024 04:53:42 +0000 (22:53 -0600)] 
Record which xlat registered the module instance

2 years agoNot supported by GCC
Arran Cudbard-Bell [Sun, 16 Jun 2024 04:39:00 +0000 (22:39 -0600)] 
Not supported by GCC

2 years agoWrap the module method array in a grouping structure
Arran Cudbard-Bell [Sun, 9 Jun 2024 22:46:00 +0000 (18:46 -0400)] 
Wrap the module method array in a grouping structure

2 years agoFix policy name
Nick Porter [Fri, 14 Jun 2024 11:56:54 +0000 (12:56 +0100)] 
Fix policy name

There is no preacct section or method any more

2 years agoRemove dangling symlink
Nick Porter [Fri, 14 Jun 2024 08:55:35 +0000 (09:55 +0100)] 
Remove dangling symlink

2 years agoPacify Coverity (CID #1598300)
Nick Porter [Tue, 11 Jun 2024 09:42:03 +0000 (10:42 +0100)] 
Pacify Coverity (CID #1598300)

2 years agoSatisfy both clang scan and Coverity (CID #1603335)
Nick Porter [Mon, 10 Jun 2024 07:40:28 +0000 (08:40 +0100)] 
Satisfy both clang scan and Coverity (CID #1603335)

2 years agoWhitespace
Arran Cudbard-Bell [Sun, 9 Jun 2024 22:02:46 +0000 (18:02 -0400)] 
Whitespace

2 years agoCorrect uninitialized scalar false positives (CID #1504037, #1503938)
James Jones [Mon, 6 May 2024 17:24:50 +0000 (12:24 -0500)] 
Correct uninitialized scalar false positives (CID #1504037, #1503938)

Coverity doesn't realize that uninitialized char arrays used as
buffer space for sbuffs are in fact set by sbuff functions that
write to the sbuff. (Yes, we tried modeling, but it didn't work.)
The solution is to keep the sbuff FR_SBUFF_OUT() creates around
long enough to use fr_sbuff_start(&sbuff) "instead of" the array
(even though it really is the array); that satisfies coverity.

2 years agos/idle/reapable/ in trunk code
Arran Cudbard-Bell [Sat, 8 Jun 2024 20:03:47 +0000 (16:03 -0400)] 
s/idle/reapable/ in trunk code

Idle is a little ambiguous.  Reapable describes more or less the exact behaviour that's implemented... treq finishes, and then hangs around in the trunk waiting for something to collect its status code, and other outputs.

2 years agoThese are attribute numbers...
Arran Cudbard-Bell [Sat, 8 Jun 2024 20:01:59 +0000 (16:01 -0400)] 
These are attribute numbers...

2 years agoFix conflict between pub/private function
Arran Cudbard-Bell [Sat, 8 Jun 2024 20:01:40 +0000 (16:01 -0400)] 
Fix conflict between pub/private function

2 years agoWrap trunk allocations in MEM()
Arran Cudbard-Bell [Sat, 8 Jun 2024 19:53:07 +0000 (15:53 -0400)] 
Wrap trunk allocations in MEM()

2 years agoFix enums
Arran Cudbard-Bell [Sat, 8 Jun 2024 19:51:13 +0000 (15:51 -0400)] 
Fix enums

2 years agoRemove fr_ prefix from trunk and connection
Arran Cudbard-Bell [Sat, 8 Jun 2024 19:47:19 +0000 (15:47 -0400)] 
Remove fr_ prefix from trunk and connection

2 years agoNot needed, we always sort the bindings now
Arran Cudbard-Bell [Sat, 8 Jun 2024 19:40:48 +0000 (15:40 -0400)] 
Not needed, we always sort the bindings now

2 years agoClear references to markers in fr_sbuff_reset_talloc
Arran Cudbard-Bell [Fri, 7 Jun 2024 21:00:00 +0000 (17:00 -0400)] 
Clear references to markers in fr_sbuff_reset_talloc

2 years agoQuiet compiler
Arran Cudbard-Bell [Fri, 7 Jun 2024 01:32:48 +0000 (21:32 -0400)] 
Quiet compiler

2 years agoUse new module method resolution function
Arran Cudbard-Bell [Fri, 7 Jun 2024 00:30:52 +0000 (20:30 -0400)] 
Use new module method resolution function

This supports static and dynamic modules
Pass in call_env_ctx_t to parsing callbacks instead of the section name, module instance data directly

2 years agoMethod names need to match section names exactly
Arran Cudbard-Bell [Fri, 7 Jun 2024 00:23:14 +0000 (20:23 -0400)] 
Method names need to match section names exactly

2 years agoUse correct type for cf_pair_debug
Arran Cudbard-Bell [Sat, 1 Jun 2024 01:32:41 +0000 (19:32 -0600)] 
Use correct type for cf_pair_debug

2 years agoFixes to section cmp functions
Arran Cudbard-Bell [Sat, 1 Jun 2024 01:32:27 +0000 (19:32 -0600)] 
Fixes to section cmp functions

2 years agoMove module xlat registrations into the module code
Arran Cudbard-Bell [Sat, 1 Jun 2024 01:29:04 +0000 (19:29 -0600)] 
Move module xlat registrations into the module code