]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoUse attributes from packet in LDAP map tests
Nick Porter [Thu, 18 Jul 2024 09:10:18 +0000 (10:10 +0100)] 
Use attributes from packet in LDAP map tests

2 years agoLiterals in map sources are marked safe, so LDAP uri can be escaped
Nick Porter [Wed, 17 Jul 2024 11:50:17 +0000 (12:50 +0100)] 
Literals in map sources are marked safe, so LDAP uri can be escaped

2 years agoUse defined value for LDAPS_PORT
Nick Porter [Thu, 18 Jul 2024 08:17:31 +0000 (09:17 +0100)] 
Use defined value for LDAPS_PORT

2 years agoOnly set LDAP TLS options if TLS is in use
Nick Porter [Thu, 18 Jul 2024 08:17:13 +0000 (09:17 +0100)] 
Only set LDAP TLS options if TLS is in use

2 years agoSet the default port to LDAPS_PORT if scheme is ldaps://
Nick Porter [Thu, 18 Jul 2024 08:07:58 +0000 (09:07 +0100)] 
Set the default port to LDAPS_PORT if scheme is ldaps://

2 years agoSet tls_mode if LDAP scheme is ldaps://
Nick Porter [Thu, 18 Jul 2024 08:06:57 +0000 (09:06 +0100)] 
Set tls_mode if LDAP scheme is ldaps://

Allows for ldaps:// connections on ports other than 636 to be correctly
identified as using SSL

2 years agoTypo
Nick Porter [Thu, 18 Jul 2024 08:05:29 +0000 (09:05 +0100)] 
Typo

2 years agoMark attribute containing SQL query as safe
Nick Porter [Wed, 17 Jul 2024 16:11:49 +0000 (17:11 +0100)] 
Mark attribute containing SQL query as safe

Previously the query in an SQL map was not being escaped.
Now it is, the ' in the query will be escaped if the string is not
marked as safe.

2 years agoAdd %sql.safe() xlat
Nick Porter [Wed, 17 Jul 2024 16:07:37 +0000 (17:07 +0100)] 
Add %sql.safe() xlat

2 years agoAdd %sql.escape() xlat
Nick Porter [Wed, 17 Jul 2024 16:07:13 +0000 (17:07 +0100)] 
Add %sql.escape() xlat

2 years agoUse macro for SQL "safe for" value
Nick Porter [Wed, 17 Jul 2024 15:09:47 +0000 (16:09 +0100)] 
Use macro for SQL "safe for" value

2 years agoCopy "safe_for" from tmpl rules to value box when resolving data
Nick Porter [Wed, 17 Jul 2024 13:23:06 +0000 (14:23 +0100)] 
Copy "safe_for" from tmpl rules to value box when resolving data

2 years agoEscape boxes in SQL map queries
Nick Porter [Wed, 17 Jul 2024 11:51:18 +0000 (12:51 +0100)] 
Escape boxes in SQL map queries

2 years agoReturn correct type for "safe for"
Nick Porter [Wed, 17 Jul 2024 10:54:31 +0000 (11:54 +0100)] 
Return correct type for "safe for"

2 years agoNo need to escape boxes containing inherently safe data
Nick Porter [Wed, 17 Jul 2024 07:27:57 +0000 (08:27 +0100)] 
No need to escape boxes containing inherently safe data

2 years agoEnsure that all SQL queries have correct, driver specific escaping
Nick Porter [Tue, 16 Jul 2024 17:33:11 +0000 (18:33 +0100)] 
Ensure that all SQL queries have correct, driver specific escaping

2 years agoFreeBSD 13.2 has moved to Python 3.11
Nick Porter [Wed, 17 Jul 2024 07:52:59 +0000 (08:52 +0100)] 
FreeBSD 13.2 has moved to Python 3.11

2 years agoUpdate 3gpp2 dictionary
Nick Porter [Fri, 12 Jul 2024 13:40:38 +0000 (14:40 +0100)] 
Update 3gpp2 dictionary

According to https://frp.3gpp2.org/Public_html/X/VSA-VSE.cfm and packets
seen in the wild

2 years agoCorrect sort sequence for requests in runnable heap
Nick Porter [Fri, 12 Jul 2024 08:32:25 +0000 (09:32 +0100)] 
Correct sort sequence for requests in runnable heap

2 years agoSet request priority from channel data priority
Nick Porter [Fri, 12 Jul 2024 08:30:41 +0000 (09:30 +0100)] 
Set request priority from channel data priority

2 years agoSet inst->parent first in proto_load_step.c
Arran Cudbard-Bell [Thu, 11 Jul 2024 19:21:50 +0000 (15:21 -0400)] 
Set inst->parent first in proto_load_step.c

2 years agoAvoid unused variable warning when WITH_VERIFY_PTR not set
Nick Porter [Wed, 10 Jul 2024 12:44:58 +0000 (13:44 +0100)] 
Avoid unused variable warning when WITH_VERIFY_PTR not set

2 years ago"min" returns the oldest requests
Nick Porter [Wed, 10 Jul 2024 11:03:14 +0000 (12:03 +0100)] 
"min" returns the oldest requests

And don't remove from the heap unless the request is actually being
stopped.

2 years agoconst
Nick Porter [Tue, 9 Jul 2024 16:38:50 +0000 (17:38 +0100)] 
const

2 years agoblastradius mitigations
Arran Cudbard-Bell [Sun, 30 Jun 2024 20:03:17 +0000 (14:03 -0600)] 
blastradius mitigations

- Adds require_message_authenticator for responses from upstream proxies.
- Adds require_message_authenticator in radius listen sections.
- Adds require_message_authenticator == auto - Which automatically requires Message-Authenticator after on is received.
- Adds limit_proxy_state to client definitions and radius listen sections.  limit_proxy_state restricts whether Proxy-State can be present in a request without a Message-Authenitcator attribute.  It too has an auto mode, where if the first packet from a client does not contain Proxy-State, all subsequent packets from that client must either contain Message-Authenticator, or must not contain Proxy-State.

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:46 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:40 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:34 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:25 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sun, 7 Jul 2024 09:34:22 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoRebuild docker images when the dock file changes
Arran Cudbard-Bell [Thu, 4 Jul 2024 20:42:37 +0000 (14:42 -0600)] 
Rebuild docker images when the dock file changes

2 years agoInstall some extra packages by default
Arran Cudbard-Bell [Thu, 4 Jul 2024 20:36:52 +0000 (14:36 -0600)] 
Install some extra packages by default

2 years agoDon't emit spurious global WARNs in rlm_cache
Arran Cudbard-Bell [Thu, 4 Jul 2024 15:30:40 +0000 (09:30 -0600)] 
Don't emit spurious global WARNs in rlm_cache

2 years agoAdd freeradiusClientGroupDN
Arran Cudbard-Bell [Thu, 4 Jul 2024 05:02:51 +0000 (23:02 -0600)] 
Add freeradiusClientGroupDN

2 years agoAllow the name of the instant client packages to be specified
Arran Cudbard-Bell [Tue, 2 Jul 2024 23:06:38 +0000 (17:06 -0600)] 
Allow the name of the instant client packages to be specified

2 years agoUse the new macro name
Arran Cudbard-Bell [Tue, 2 Jul 2024 20:53:29 +0000 (14:53 -0600)] 
Use the new macro name

2 years agoDon't set the oracle version by default
Arran Cudbard-Bell [Tue, 2 Jul 2024 20:16:21 +0000 (14:16 -0600)] 
Don't set the oracle version by default

2 years agoRevert "Take RPMBUILD_FLAGS in builddep too"
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:58:05 +0000 (12:58 -0600)] 
Revert "Take RPMBUILD_FLAGS in builddep too"

This reverts commit 675e4e3f41b326b4561ca89ee80bee444a7e019c.

2 years agoRevert "Pass in the oracle version explicitly"
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:57:48 +0000 (12:57 -0600)] 
Revert "Pass in the oracle version explicitly"

This reverts commit 2b1a72f8ffb1d7e526cd7c55c7319332b1733ff9.

2 years agoMove definitions to the top of the spec file
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:53:12 +0000 (12:53 -0600)] 
Move definitions to the top of the spec file

2 years agoPass in the oracle version explicitly
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:43:19 +0000 (12:43 -0600)] 
Pass in the oracle version explicitly

All the rpmbuild tools seem very broken

2 years agoTake RPMBUILD_FLAGS in builddep too
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:27:40 +0000 (12:27 -0600)] 
Take RPMBUILD_FLAGS in builddep too

2 years agorpmbuild doesn't like the separation
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:13:08 +0000 (12:13 -0600)] 
rpmbuild doesn't like the separation

2 years agoAccept --define _oracle_version
Arran Cudbard-Bell [Tue, 2 Jul 2024 18:02:44 +0000 (12:02 -0600)] 
Accept --define _oracle_version

2 years agoRegenerate the _ORACLE_ configure script
Arran Cudbard-Bell [Tue, 2 Jul 2024 17:19:55 +0000 (11:19 -0600)] 
Regenerate the _ORACLE_ configure script

2 years agoUpdate rlm_sql_oracle configure scripts
Arran Cudbard-Bell [Mon, 1 Jul 2024 23:19:36 +0000 (17:19 -0600)] 
Update rlm_sql_oracle configure scripts

2 years agoConst
Arran Cudbard-Bell [Sun, 30 Jun 2024 22:33:55 +0000 (16:33 -0600)] 
Const

2 years agoWS
Arran Cudbard-Bell [Sun, 30 Jun 2024 20:00:27 +0000 (14:00 -0600)] 
WS

2 years agoRemove invalid assert that was triggered evaluating log messages
Arran Cudbard-Bell [Sun, 30 Jun 2024 19:33:28 +0000 (13:33 -0600)] 
Remove invalid assert that was triggered evaluating log messages

2 years agoSync require_message_authenticator field names, it's called three different things...
Arran Cudbard-Bell [Sat, 29 Jun 2024 03:55:50 +0000 (21:55 -0600)] 
Sync require_message_authenticator field names, it's called three different things at different places in the server

2 years agoSet a capacity for trunk backlog
Nick Porter [Fri, 28 Jun 2024 11:20:50 +0000 (12:20 +0100)] 
Set a capacity for trunk backlog

And allow requests to be allocated / enqueued even if the max
connections and requests per connection limit is reached, up to the
backlog limit.

Helps handle spikes in traffic, particularly where trunks are limited to
one request per connection, and there are server side limitations on the
number of connections that can be made - e.g. SQL servers.

2 years agoRun docker build on ubuntu-latest
Nick Porter [Fri, 28 Jun 2024 12:46:41 +0000 (13:46 +0100)] 
Run docker build on ubuntu-latest

Seems to resolve the issue with the debiansid container build hanging

2 years agoAlways mark trunk requests as complete when freeing query ctx
Nick Porter [Fri, 28 Jun 2024 09:43:12 +0000 (10:43 +0100)] 
Always mark trunk requests as complete when freeing query ctx

Due to query_ctx being re-used multiple times when running transactions
(e.g. allocating IPs in sqlippool) it is possible for the current query
to not be submitted, but there still to be a trunk request associated
with the query_ctx.

2 years agoTypo
Arran Cudbard-Bell [Fri, 28 Jun 2024 03:58:34 +0000 (21:58 -0600)] 
Typo

2 years agoRefactor LDAP URI xlat code so that we can call it easily from a future modify and...
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:44:00 +0000 (11:44 -0600)] 
Refactor LDAP URI xlat code so that we can call it easily from a future modify and delete xlats

2 years agoAdd API level support for deleting objects
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:43:20 +0000 (11:43 -0600)] 
Add API level support for deleting objects

This is just for completeness.  We don't currently have any use case for it, but it'll likely be called by a delete xlat in the near future.

2 years agoWhitespace fixes
Arran Cudbard-Bell [Thu, 27 Jun 2024 17:42:12 +0000 (11:42 -0600)] 
Whitespace fixes

2 years agoFix struct names
Arran Cudbard-Bell [Thu, 27 Jun 2024 16:39:50 +0000 (10:39 -0600)] 
Fix struct names

2 years agos/memberof/group/g for group checking XLAT to allow redundant xlats over SQL and...
Arran Cudbard-Bell [Thu, 27 Jun 2024 16:19:05 +0000 (10:19 -0600)] 
s/memberof/group/g for group checking XLAT to allow redundant xlats over SQL and LDAP

2 years agoDo size calculation in appropriate type (CID #1604603)
James Jones [Thu, 27 Jun 2024 14:00:32 +0000 (09:00 -0500)] 
Do size calculation in appropriate type (CID #1604603)

In the error message in lst_expand(), the calculation of the size
has to be done in size_t. The cast of sizeof(void *) to uint32_t
causes it to be done in uint32_t, but that has the possibility of
overflow; note that n_capacity may be set to UINT_MAX, which would
guarantee it. The format conversion is changed to match.

2 years agocassandra start query is missing two escape characters
Stephen Blackwell [Wed, 26 Jun 2024 21:14:56 +0000 (15:14 -0600)] 
cassandra start query is missing two escape characters

2 years agoOnly add positive r values to total (CID #16046001)
James Jones [Wed, 26 Jun 2024 16:36:09 +0000 (11:36 -0500)] 
Only add positive r values to total (CID #16046001)

With the addition of r to total in the for loop header, the continue
for EINTR causes a negative value of r to be added to total. That's the
only thing that looks like it could cause an overflow and taint total.

2 years agoAdd open_query to MySQL queries.conf
Nick Porter [Wed, 26 Jun 2024 12:22:31 +0000 (13:22 +0100)] 
Add open_query to MySQL queries.conf

Particularly in the case of sqlippool use, it has been found that
setting the transaction isolation level to READ COMMITTED is needed to
avoid deadlocks.

2 years agoReinstate running open_query for MySQL
Nick Porter [Wed, 26 Jun 2024 12:17:15 +0000 (13:17 +0100)] 
Reinstate running open_query for MySQL

2 years agoCorrect enum case
Nick Porter [Wed, 26 Jun 2024 12:12:47 +0000 (13:12 +0100)] 
Correct enum case

2 years agoGuard allocation with MEM() (CID #1604618)
James Jones [Tue, 25 Jun 2024 16:37:32 +0000 (11:37 -0500)] 
Guard allocation with MEM() (CID #1604618)

2 years agoCorrect docs
Nick Porter [Tue, 25 Jun 2024 14:53:15 +0000 (15:53 +0100)] 
Correct docs

2 years agosqlippool query fixes
Nick Porter [Mon, 24 Jun 2024 18:23:34 +0000 (19:23 +0100)] 
sqlippool query fixes

2 years agoDon't attempt to run zero length queries
Nick Porter [Mon, 24 Jun 2024 17:35:32 +0000 (18:35 +0100)] 
Don't attempt to run zero length queries

Since these come from conf file entries it's all to easy for something
such as

alloc_requested = ''

to be set rather than commenting out the entry.

2 years agoAdd client_port to proto_dhcpv4_udp
Nick Porter [Mon, 24 Jun 2024 13:46:06 +0000 (14:46 +0100)] 
Add client_port to proto_dhcpv4_udp

2 years agoCorrect DHCP attribute sorting comparison function
Nick Porter [Fri, 21 Jun 2024 16:02:47 +0000 (17:02 +0100)] 
Correct DHCP attribute sorting comparison function

2 years agoadd more documentation
Alan T. DeKok [Fri, 21 Jun 2024 16:12:28 +0000 (12:12 -0400)] 
add more documentation

2 years agocorrect decode of length + offset fields in structs
Alan T. DeKok [Fri, 21 Jun 2024 16:04:41 +0000 (12:04 -0400)] 
correct decode of length + offset fields in structs

2 years agothe correct offset is 3
Alan T. DeKok [Fri, 21 Jun 2024 16:03:14 +0000 (12:03 -0400)] 
the correct offset is 3

2 years agothe offset here is 3
Alan T. DeKok [Fri, 21 Jun 2024 16:02:33 +0000 (12:02 -0400)] 
the offset here is 3

2 years agoadd tests for simple password auth type
Alan T. DeKok [Fri, 21 Jun 2024 14:53:44 +0000 (10:53 -0400)] 
add tests for simple password auth type

2 years agoRemove spurious debug message
Nick Porter [Fri, 21 Jun 2024 10:45:26 +0000 (11:45 +0100)] 
Remove spurious debug message

2 years agoFix error in dictionary documentation
Matthew Newton [Fri, 21 Jun 2024 09:06:39 +0000 (10:06 +0100)] 
Fix error in dictionary documentation

Fixes #5345

2 years agoMore const issues
Arran Cudbard-Bell [Fri, 21 Jun 2024 00:31:52 +0000 (18:31 -0600)] 
More const issues

2 years agoFix some missed renames
Arran Cudbard-Bell [Fri, 21 Jun 2024 00:06:36 +0000 (18:06 -0600)] 
Fix some missed renames

2 years agoConst issues
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:51:01 +0000 (17:51 -0600)] 
Const issues

2 years agoEvaluate all chained method groups when searching for methods or printing methods
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:36:01 +0000 (17:36 -0600)] 
Evaluate all chained method groups when searching for methods or printing methods

2 years agoCommon indent levels in module_rlm.h
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:18:02 +0000 (17:18 -0600)] 
Common indent levels in module_rlm.h

2 years agoRemove unused functions
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:16:42 +0000 (17:16 -0600)] 
Remove unused functions

2 years agoInitialise name
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:13:27 +0000 (17:13 -0600)] 
Initialise name

2 years agoCorrect example xlat calls
Arran Cudbard-Bell [Thu, 20 Jun 2024 23:13:17 +0000 (17:13 -0600)] 
Correct example xlat calls

2 years agoFinal set of changes for making redundant xlat function registration not suck
Arran Cudbard-Bell [Thu, 20 Jun 2024 21:57:23 +0000 (15:57 -0600)] 
Final set of changes for making redundant xlat function registration not suck

We now group module xlats by name (all self-named module expansions are considered equal).

This allows:

redundant {
    sql
    linelog
}

Which would issue a query against SQL, and then log it to disk.

The instantiate code catches/disallows calls to incompatible module expansions in much the same way as C's _Generic does...

2 years agoTest attr_filter on reply list
Nick Porter [Thu, 20 Jun 2024 16:09:32 +0000 (17:09 +0100)] 
Test attr_filter on reply list

2 years agoUse correct context for pairs
Nick Porter [Thu, 20 Jun 2024 16:08:56 +0000 (17:08 +0100)] 
Use correct context for pairs

2 years agoAdd list name based methods to attr_filter
Nick Porter [Thu, 20 Jun 2024 15:53:26 +0000 (16:53 +0100)] 
Add list name based methods to attr_filter

2 years agoPython script to add an lldb command
James Jones [Tue, 4 Jun 2024 13:57:21 +0000 (08:57 -0500)] 
Python script to add an lldb command

This, once imported with an lldb "script" command, adds a "dd" command
to display certain types of values in an intelligible fashion using the
existing foo_debug() functions not only is it intelligible, it uses a
format people are used to.

The foo_debug() functions take a pointer to the structure. The dd command
will take names of variables that have the structure type as well, and
pass their address.

2 years agoAdd doc file for lldb
James Jones [Thu, 13 Jun 2024 21:47:26 +0000 (16:47 -0500)] 
Add doc file for lldb

Initially at least it concentrates on extending it with Python scripts,
though it does describe how to adapt the sample command line output
when a test fails to invoke lldb on the program being tested.

2 years agoDon't use MySQL read / write timeout options
Nick Porter [Thu, 20 Jun 2024 09:00:36 +0000 (10:00 +0100)] 
Don't use MySQL read / write timeout options

The model for async is different to the sync client.  Timeouts are
expected to be handled by the calling application rather than the client
library.

2 years agoBackticks
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:39:58 +0000 (14:39 -0600)] 
Backticks

2 years agoUse the correct context
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:37:35 +0000 (14:37 -0600)] 
Use the correct context

2 years agoPut the proxy reply in the right list...
Arran Cudbard-Bell [Wed, 19 Jun 2024 20:11:52 +0000 (14:11 -0600)] 
Put the proxy reply in the right list...