]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoAdd modeling to indicate when functions actually write data
James Jones [Wed, 24 May 2023 18:52:44 +0000 (13:52 -0500)] 
Add modeling to indicate when functions actually write data

These assure coverity that the modeled functions on success
actually write to the intended output parameter.

2 years agoNo need to persist the default Python path
Nick Porter [Thu, 25 May 2023 08:27:08 +0000 (09:27 +0100)] 
No need to persist the default Python path

2 years agoForce Python to 3.8 on RHEL < 9
Nick Porter [Wed, 24 May 2023 15:40:12 +0000 (16:40 +0100)] 
Force Python to 3.8 on RHEL < 9

Default Python on RHEL 8 is 3.6.
RHEL 9 has Python 3.9 as default.

2 years agoRemove old Python 2 specific module config
Nick Porter [Tue, 23 May 2023 17:37:32 +0000 (18:37 +0100)] 
Remove old Python 2 specific module config

2 years agoRemove module config for python path
Nick Porter [Tue, 23 May 2023 17:35:59 +0000 (18:35 +0100)] 
Remove module config for python path

2 years agoMove python path setting to library init
Nick Porter [Tue, 23 May 2023 17:33:29 +0000 (18:33 +0100)] 
Move python path setting to library init

2 years agoRework libpython initialization to use PyConfig
Nick Porter [Tue, 23 May 2023 15:43:53 +0000 (16:43 +0100)] 
Rework libpython initialization to use PyConfig

Makes minimum Python version required 3.8

2 years agoReplace mod_load and mod_unload with global init / free functions
Nick Porter [Tue, 23 May 2023 15:16:32 +0000 (16:16 +0100)] 
Replace mod_load and mod_unload with global init / free functions

2 years agoAdd a global config for libpython
Nick Porter [Tue, 23 May 2023 15:10:57 +0000 (16:10 +0100)] 
Add a global config for libpython

2 years agoRemove pre Python 3.7 code
Nick Porter [Tue, 23 May 2023 14:46:14 +0000 (15:46 +0100)] 
Remove pre Python 3.7 code

2 years agomake SoH use flat or nested attributes
Jorge Pereira [Thu, 18 May 2023 18:14:34 +0000 (15:14 -0300)] 
make SoH use flat or nested attributes

2 years agomake WiMAX use flat or nested attributes.
Jorge Pereira [Thu, 18 May 2023 17:56:44 +0000 (14:56 -0300)] 
make WiMAX use flat or nested attributes.

2 years agoradhttpcheck: Typo
Arran Cudbard-Bell [Wed, 24 May 2023 05:45:40 +0000 (01:45 -0400)] 
radhttpcheck: Typo

2 years agoradhttpcheck: Fix doc link
Arran Cudbard-Bell [Wed, 24 May 2023 02:15:56 +0000 (22:15 -0400)] 
radhttpcheck: Fix doc link

2 years agoradhttpcheck: Tweak systemd unit
Arran Cudbard-Bell [Wed, 24 May 2023 02:10:41 +0000 (22:10 -0400)] 
radhttpcheck: Tweak systemd unit

2 years agoradhttpcheck: Catch broken pipe error
Arran Cudbard-Bell [Wed, 24 May 2023 01:48:32 +0000 (21:48 -0400)] 
radhttpcheck: Catch broken pipe error

2 years agoradhttpcheck: Allow config path to be specified
Arran Cudbard-Bell [Wed, 24 May 2023 01:21:26 +0000 (21:21 -0400)] 
radhttpcheck: Allow config path to be specified

2 years agoradhttpcheck: Add default NAS-Identifier
Arran Cudbard-Bell [Tue, 23 May 2023 23:00:16 +0000 (19:00 -0400)] 
radhttpcheck: Add default NAS-Identifier

2 years agoradhttpcheck: Bind interface is called ipaddr not server
Arran Cudbard-Bell [Tue, 23 May 2023 22:50:08 +0000 (18:50 -0400)] 
radhttpcheck: Bind interface is called ipaddr not server

2 years agoDocument server
Arran Cudbard-Bell [Tue, 23 May 2023 22:38:10 +0000 (18:38 -0400)] 
Document server

2 years agoradhttpcheck: slightly clearer
Arran Cudbard-Bell [Tue, 23 May 2023 22:36:49 +0000 (18:36 -0400)] 
radhttpcheck: slightly clearer

2 years agoAdd HTTP <-> RADIUS healthcheck gateway
Arran Cudbard-Bell [Tue, 23 May 2023 22:29:22 +0000 (18:29 -0400)] 
Add HTTP <-> RADIUS healthcheck gateway

2 years agoLDAP_MAX_CACHEABLE only applies to name to DN and DN to name resolution
Nick Porter [Tue, 23 May 2023 13:36:54 +0000 (14:36 +0100)] 
LDAP_MAX_CACHEABLE only applies to name to DN and DN to name resolution

2 years agorlm_mschap is also already built if we're doing package tests
Nick Porter [Tue, 23 May 2023 09:49:04 +0000 (10:49 +0100)] 
rlm_mschap is also already built if we're doing package tests

2 years agoPackage tests already have the modules built
Nick Porter [Tue, 23 May 2023 08:28:39 +0000 (09:28 +0100)] 
Package tests already have the modules built

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Tue, 23 May 2023 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoOnly call query->parser if there are valid results. Fix for CID #1529242
Nick Porter [Tue, 23 May 2023 07:18:06 +0000 (08:18 +0100)] 
Only call query->parser if there are valid results. Fix for CID #1529242

2 years agoCorrect return
Nick Porter [Tue, 23 May 2023 07:17:18 +0000 (08:17 +0100)] 
Correct return

2 years agoAdd Calix vendor dictionary
Arran Cudbard-Bell [Mon, 22 May 2023 21:50:36 +0000 (17:50 -0400)] 
Add Calix vendor dictionary

2 years agotry to quiet clang scan
Alan T. DeKok [Mon, 22 May 2023 21:06:41 +0000 (17:06 -0400)] 
try to quiet clang scan

2 years agomake rlm_eap_mschapv2 use flat or nested attributes
Alan T. DeKok [Mon, 22 May 2023 20:25:11 +0000 (16:25 -0400)] 
make rlm_eap_mschapv2 use flat or nested attributes

2 years agomake EAP tests depend on the source modules
Alan T. DeKok [Mon, 22 May 2023 20:07:07 +0000 (16:07 -0400)] 
make EAP tests depend on the source modules

2 years agoadd test.eap.help target
Alan T. DeKok [Mon, 22 May 2023 19:55:25 +0000 (15:55 -0400)] 
add test.eap.help target

2 years agoremove RAD_REQUEST_OPTION_PROXY_EAP
Alan T. DeKok [Mon, 22 May 2023 19:52:02 +0000 (15:52 -0400)] 
remove RAD_REQUEST_OPTION_PROXY_EAP

this is a v3 thing, and won't work in v4.  We will need a new
way to convert EAP-MSCHAPv2 to MS-CHAPv2 and vice-versa.  Likely
with an xlat.

2 years agomore cleanups
Alan T. DeKok [Mon, 22 May 2023 19:50:02 +0000 (15:50 -0400)] 
more cleanups

2 years agoremove duplicate code, and use MEM()
Alan T. DeKok [Mon, 22 May 2023 19:45:04 +0000 (15:45 -0400)] 
remove duplicate code, and use MEM()

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sun, 21 May 2023 09:34:49 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sun, 21 May 2023 09:34:46 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sun, 21 May 2023 09:34:43 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sun, 21 May 2023 09:34:40 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sun, 21 May 2023 09:34:34 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sun, 21 May 2023 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sun, 21 May 2023 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sun, 21 May 2023 09:34:25 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agodepend on libkqueue define, not __linux__.
Alan T. DeKok [Sat, 20 May 2023 22:04:13 +0000 (18:04 -0400)] 
depend on libkqueue define, not __linux__.

As some versions of libkqueue might not have the define

2 years agomake fr_pair_update_by_da_parent() do nested attributes
Alan T. DeKok [Thu, 18 May 2023 21:02:07 +0000 (17:02 -0400)] 
make fr_pair_update_by_da_parent() do nested attributes

which automatically means that modules like mschap will create
attributes with the correct hierarchy.

Note that ALL callers of pair_update_request() and pair_update_reply()
will be affected.  However, most of them create attributes at the
"root", and will not be affected by this change.

2 years agoremove unused argument to fr_pair_update_by_da()
Alan T. DeKok [Thu, 18 May 2023 20:47:57 +0000 (16:47 -0400)] 
remove unused argument to fr_pair_update_by_da()

2 years agorequest / reply are VPs, so just use that
Alan T. DeKok [Thu, 18 May 2023 20:44:08 +0000 (16:44 -0400)] 
request / reply are VPs, so just use that

2 years agowhitespace
Alan T. DeKok [Thu, 18 May 2023 20:43:34 +0000 (16:43 -0400)] 
whitespace

2 years agodon't use fr_pair_update_by_da()
Alan T. DeKok [Thu, 18 May 2023 20:39:32 +0000 (16:39 -0400)] 
don't use fr_pair_update_by_da()

instead just define short macros locally.

Because radclient doesn't put the request / reply pairs into
VPs.

2 years agomove text to top-level README
Alan T. DeKok [Thu, 18 May 2023 14:38:16 +0000 (10:38 -0400)] 
move text to top-level README

2 years agodon't need semi-colons
Alan T. DeKok [Thu, 18 May 2023 13:12:36 +0000 (09:12 -0400)] 
don't need semi-colons

2 years agoRemove sychnronous path from fr_ldap_trunk_search()
Nick Porter [Tue, 9 May 2023 17:04:33 +0000 (18:04 +0100)] 
Remove sychnronous path from fr_ldap_trunk_search()

2 years agoRemove remaining tmpl_t from rlm_ldap_t
Nick Porter [Tue, 9 May 2023 16:56:16 +0000 (17:56 +0100)] 
Remove remaining tmpl_t from rlm_ldap_t

2 years agoRemove synchronous LDAP user find
Nick Porter [Tue, 9 May 2023 16:53:00 +0000 (17:53 +0100)] 
Remove synchronous LDAP user find

2 years agoFix for CID #1529242 and improve comment about query freeing
Nick Porter [Sat, 20 May 2023 19:54:46 +0000 (20:54 +0100)] 
Fix for CID #1529242 and improve comment about query freeing

2 years agoldap: Verify we have an entry before trying to print the DN
Arran Cudbard-Bell [Sat, 20 May 2023 18:46:52 +0000 (14:46 -0400)] 
ldap: Verify we have an entry before trying to print the DN

2 years agoldap: We also need to load the new policy schema
Arran Cudbard-Bell [Sat, 20 May 2023 18:40:22 +0000 (14:40 -0400)] 
ldap: We also need to load the new policy schema

2 years agoldap: s/radiusObjectProfile/freeradiusPolicy/g
Arran Cudbard-Bell [Sat, 20 May 2023 18:23:04 +0000 (14:23 -0400)] 
ldap: s/radiusObjectProfile/freeradiusPolicy/g

2 years agomake ldapadd verbose
Arran Cudbard-Bell [Sat, 20 May 2023 18:11:57 +0000 (14:11 -0400)] 
make ldapadd verbose

2 years agoldap: Fix WS
Arran Cudbard-Bell [Sat, 20 May 2023 17:50:06 +0000 (13:50 -0400)] 
ldap: Fix WS

2 years agoldap: Fix SASLless build
Arran Cudbard-Bell [Sat, 20 May 2023 17:38:07 +0000 (13:38 -0400)] 
ldap: Fix SASLless build

2 years agoldap: Fix LDAP setup secripts to correctly report failures
Arran Cudbard-Bell [Sat, 20 May 2023 17:37:24 +0000 (13:37 -0400)] 
ldap: Fix LDAP setup secripts to correctly report failures

2 years agokqueue: Enable kqueue debugging with debug level, not blindly at the start of every...
Arran Cudbard-Bell [Sat, 20 May 2023 16:00:09 +0000 (12:00 -0400)] 
kqueue: Enable kqueue debugging with debug level, not blindly at the start of every CI run

2 years agoFix references to freeradius-schema
Arran Cudbard-Bell [Sat, 20 May 2023 06:32:23 +0000 (02:32 -0400)] 
Fix references to freeradius-schema

2 years agoNope... that won't work
Arran Cudbard-Bell [Sat, 20 May 2023 06:22:17 +0000 (02:22 -0400)] 
Nope... that won't work

2 years agoCheck if LDAP started
Arran Cudbard-Bell [Sat, 20 May 2023 06:14:41 +0000 (02:14 -0400)] 
Check if LDAP started

2 years agoDon't allow tests to continue if the setup script fails
Arran Cudbard-Bell [Sat, 20 May 2023 06:03:24 +0000 (02:03 -0400)] 
Don't allow tests to continue if the setup script fails

2 years agoldap: Add tacacs client schema
Arran Cudbard-Bell [Sat, 20 May 2023 05:35:21 +0000 (01:35 -0400)] 
ldap: Add tacacs client schema

2 years agoFix tests to use split client definition
Arran Cudbard-Bell [Sat, 20 May 2023 04:15:24 +0000 (00:15 -0400)] 
Fix tests to use split client definition

2 years agoldap: reorganise schemas, and add additional structural objects for policies and...
Arran Cudbard-Bell [Sat, 20 May 2023 01:43:47 +0000 (21:43 -0400)] 
ldap: reorganise schemas, and add additional structural objects for policies and access devices

2 years agoldap: Better to specify a listener ID
Arran Cudbard-Bell [Fri, 19 May 2023 19:15:53 +0000 (15:15 -0400)] 
ldap: Better to specify a listener ID

2 years agoUpdate docs about LDAP group membership checks
Nick Porter [Fri, 19 May 2023 10:02:32 +0000 (11:02 +0100)] 
Update docs about LDAP group membership checks

2 years agoRework LDAP group membership tests to use %{ldap.memberof: }
Nick Porter [Wed, 3 May 2023 07:04:55 +0000 (08:04 +0100)] 
Rework LDAP group membership tests to use %{ldap.memberof: }

2 years agoAdd %{ldap.memberof: } xlat
Nick Porter [Fri, 28 Apr 2023 14:45:54 +0000 (15:45 +0100)] 
Add %{ldap.memberof: } xlat

As a replacement of the previous pair compare method to test user
membership of LDAP groups

2 years agoDefine call env for ldap group membership xlat
Nick Porter [Tue, 9 May 2023 15:59:48 +0000 (16:59 +0100)] 
Define call env for ldap group membership xlat

And reduce boilerplate

2 years agoRemove unused rlm_ldap_group_dn2name
Nick Porter [Fri, 28 Apr 2023 13:54:02 +0000 (14:54 +0100)] 
Remove unused rlm_ldap_group_dn2name

2 years agoRework rlm_ldap_check_userobj_dynamic to be async
Nick Porter [Fri, 28 Apr 2023 13:48:22 +0000 (14:48 +0100)] 
Rework rlm_ldap_check_userobj_dynamic to be async

2 years agoAdd fr_ldap_berval_strncasecmp()
Nick Porter [Fri, 19 May 2023 19:01:29 +0000 (20:01 +0100)] 
Add fr_ldap_berval_strncasecmp()

For case insensitive comparison of a berval and a string.

2 years agoRework rlm_ldap_check_groupobj_dynamic to be async
Nick Porter [Fri, 28 Apr 2023 13:39:31 +0000 (14:39 +0100)] 
Rework rlm_ldap_check_groupobj_dynamic to be async

2 years agoDefine context and call env for LDAP group membership xlat
Nick Porter [Fri, 28 Apr 2023 13:18:34 +0000 (14:18 +0100)] 
Define context and call env for LDAP group membership xlat

2 years agoEnsure LDAP group attribute exists
Nick Porter [Fri, 28 Apr 2023 13:15:59 +0000 (14:15 +0100)] 
Ensure LDAP group attribute exists

2 years agoRework rlm_ldap_check_cached to use a fr_value_box_t
Nick Porter [Fri, 28 Apr 2023 10:48:11 +0000 (11:48 +0100)] 
Rework rlm_ldap_check_cached to use a fr_value_box_t

2 years agoRemove LDAP-Group pair compare function
Nick Porter [Fri, 28 Apr 2023 10:40:10 +0000 (11:40 +0100)] 
Remove LDAP-Group pair compare function

The paircmp framework is not built for async calls.

Will be replaced by a "memberof" xlat which can do async LDAP calls.

2 years agoRegister instance specific module xlats as <instance>.<function>
Nick Porter [Fri, 19 May 2023 16:14:25 +0000 (17:14 +0100)] 
Register instance specific module xlats as <instance>.<function>

2 years agoCorrect registration of rlm_unpack xlat
Nick Porter [Fri, 19 May 2023 16:17:18 +0000 (17:17 +0100)] 
Correct registration of rlm_unpack xlat

2 years agoMove non instance-specific rlm_ldap xlats to mod_load
Nick Porter [Fri, 19 May 2023 15:57:36 +0000 (16:57 +0100)] 
Move non instance-specific rlm_ldap xlats to mod_load

2 years agoCorrect registration of rlm_test xlats
Nick Porter [Fri, 19 May 2023 15:50:07 +0000 (16:50 +0100)] 
Correct registration of rlm_test xlats

2 years agoMove rlm_yubikey xlat registration to mod_load
Nick Porter [Fri, 19 May 2023 15:49:06 +0000 (16:49 +0100)] 
Move rlm_yubikey xlat registration to mod_load

2 years agoMove non instance-specific rlm_json xlats to mod_load
Nick Porter [Fri, 19 May 2023 15:31:51 +0000 (16:31 +0100)] 
Move non instance-specific rlm_json xlats to mod_load

2 years agoMove rlm_dict xlats to mod_load
Nick Porter [Fri, 19 May 2023 15:21:44 +0000 (16:21 +0100)] 
Move rlm_dict xlats to mod_load

2 years agos/radiusClient/freeradiusClient/g
Arran Cudbard-Bell [Fri, 19 May 2023 18:33:48 +0000 (14:33 -0400)] 
s/radiusClient/freeradiusClient/g

2 years agoSpecifically model exfile_{open,close}_lock()
James Jones [Fri, 19 May 2023 18:12:23 +0000 (13:12 -0500)] 
Specifically model exfile_{open,close}_lock()

2 years agoldap-schema: Fix syntax for RADIUS accounting attributes
Arran Cudbard-Bell [Fri, 19 May 2023 16:55:37 +0000 (12:55 -0400)] 
ldap-schema: Fix syntax for RADIUS accounting attributes

2 years agoldap-schema: s/radiusClient/freeradiusClient/
Arran Cudbard-Bell [Fri, 19 May 2023 16:55:09 +0000 (12:55 -0400)] 
ldap-schema: s/radiusClient/freeradiusClient/

Now we support multiple protocols the clients aren't RADIUS specific

2 years agoSplit out locking version of exfile_{open, close}()
James Jones [Thu, 18 May 2023 20:09:38 +0000 (15:09 -0500)] 
Split out locking version of exfile_{open, close}()

We preserve the visible interface, but underneath split out the
locking flavor so we can model it for coverity. (As is, you'd
have to check an incoming parameter, and coverity does not appear
to allow that.)

2 years agoBe consistent in call environment comments
Nick Porter [Fri, 19 May 2023 08:35:11 +0000 (09:35 +0100)] 
Be consistent in call environment comments

2 years agoAllow for unlang_ctx->rules == NULL
Nick Porter [Fri, 19 May 2023 07:53:21 +0000 (08:53 +0100)] 
Allow for unlang_ctx->rules == NULL

2 years agoChange module environment to more generic call environment (#4998)
Nick Porter [Thu, 18 May 2023 16:14:57 +0000 (17:14 +0100)] 
Change module environment to more generic call environment (#4998)

* Move module_env_t to its own header and rename to call_env_t

* Move and rename module_env_parsed_t

* Rename module mod_env_ctx to call_env_ctx

* Move and rename module_method_env_t

* Move and rename module env helper macros

* Move and rename module env parsing functions and make more generic

* Rework expanding of call environments to make it generic

* Add a call_method_env to xlat_t

Along with associated registration function

* Add dictionary to xlat function call for resolving module env

* Parse xlat call env when allocating instance data

* Add env_data to xlat frame state, xlat_ctx_t and supporting macro

* Add expansion of call env to unlang_xlat_repeat

* Rename mod/module _env -> call_env in rlm_ldap

* Rename module / mod _env -> call_env in rlm_smtp

* Rename module_env -> call_env in rlm_files

2 years agomake MS-CHAP use flat or nested attributes.
Alan T. DeKok [Wed, 17 May 2023 12:11:51 +0000 (08:11 -0400)] 
make MS-CHAP use flat or nested attributes.

As a minor optimization, search for responses in the same group
as the challenge.  Having them in another location doesn't make
sense.

We also likely need to update the FreeRADIUS "MS-CHAP-Foo"
attributes which control the behavior of the MS-CHAP module.
Perhaps we could auto-define module-specific attributes?