]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoDon't pass dictpath from raduat
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:41:53 +0000 (14:41 -0600)] 
Don't pass dictpath from raduat

2 years agoInstall raduat
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:19:00 +0000 (14:19 -0600)] 
Install raduat

2 years agos/fr_packet_CODE_VALID/FR_RADIUS_PACKET_CODE_VALID/g
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:15:59 +0000 (14:15 -0600)] 
s/fr_packet_CODE_VALID/FR_RADIUS_PACKET_CODE_VALID/g

2 years agos/fr_radius_packet/fr_packet/g
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:12:07 +0000 (14:12 -0600)] 
s/fr_radius_packet/fr_packet/g

2 years agos/fr_radius_packet_t/fr_packet_t/g
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:10:48 +0000 (14:10 -0600)] 
s/fr_radius_packet_t/fr_packet_t/g

2 years agomove nonnull annotation to the right function
Alan T. DeKok [Wed, 6 Mar 2024 19:03:12 +0000 (14:03 -0500)] 
move nonnull annotation to the right function

2 years agoallow cancellation of last item in the timer tree
Alan T. DeKok [Wed, 6 Mar 2024 18:13:52 +0000 (13:13 -0500)] 
allow cancellation of last item in the timer tree

2 years agoCast more fr_sbuff_in_sprintf() calls for error messages to void (CID #1533664)
James Jones [Wed, 7 Feb 2024 18:24:21 +0000 (12:24 -0600)] 
Cast more fr_sbuff_in_sprintf() calls for error messages to void (CID #1533664)

2 years agoAnnotate the other missing_lock in connection_check() (CID #1551702)
James Jones [Thu, 8 Feb 2024 21:31:33 +0000 (15:31 -0600)] 
Annotate the other missing_lock in connection_check() (CID #1551702)

As with CID 1551700, Coverity doesn't know that all callers of
connection_check() have locked pool->mutex, so we need to annotate
the later reference to pool->pending_window.

2 years agoAsk for the right mutex (CID #1551705)
James Jones [Wed, 7 Feb 2024 22:04:11 +0000 (16:04 -0600)] 
Ask for the right mutex (CID #1551705)

Coverity message: "Accessing t->inst->list without holding lock
rlm_stats_t.mutex." rlm_stats_t, not rlm_stats_thread_t, so the
mutex to lock is t->inst->mutex, not t->mutex.

2 years agoDon't pass NULL rules to call_env_alloc() (CID #1530398)
James Jones [Thu, 15 Feb 2024 17:45:19 +0000 (11:45 -0600)] 
Don't pass NULL rules to call_env_alloc() (CID #1530398)

Coverity sees the nonnull attribute of call_env_alloc()'s t_rules
attribute, which compile_module() passes unlang_ctx->rules to.
Earlier unlang_ctx->rules is checked, so Coverity infers it can be
NULL and complains about the lack of checking on the call_env_alloc().

2 years agoMake sure modeling file is up to date
James Jones [Wed, 6 Mar 2024 15:21:14 +0000 (09:21 -0600)] 
Make sure modeling file is up to date

2 years agolet the application get the retry timers
Alan T. DeKok [Wed, 6 Mar 2024 16:28:53 +0000 (11:28 -0500)] 
let the application get the retry timers

2 years agouctx is used
Alan T. DeKok [Wed, 6 Mar 2024 16:28:35 +0000 (11:28 -0500)] 
uctx is used

2 years agocatch more corner cases
Alan T. DeKok [Wed, 6 Mar 2024 14:20:59 +0000 (09:20 -0500)] 
catch more corner cases

flush just goes to the next bio and flushes.

If the all retry timers are used, try to cancel the oldest one
and then use that.  This puts less work on the application to track
things.

2 years agoadd first / last API
Alan T. DeKok [Wed, 6 Mar 2024 14:18:47 +0000 (09:18 -0500)] 
add first / last API

2 years agoadd callback to set per-packet retry configuration
Alan T. DeKok [Tue, 5 Mar 2024 20:34:55 +0000 (15:34 -0500)] 
add callback to set per-packet retry configuration

so that one socket can do multiple different kinds of retries

2 years agosimplify more bio buffer functions
Alan T. DeKok [Tue, 5 Mar 2024 20:18:08 +0000 (15:18 -0500)] 
simplify more bio buffer functions

2 years agoadd Acct-Delay-Time if it doesn't exist
Alan T. DeKok [Tue, 5 Mar 2024 17:17:54 +0000 (12:17 -0500)] 
add Acct-Delay-Time if it doesn't exist

2 years agoFile names need to be double quoted to expand
Nick Porter [Wed, 6 Mar 2024 11:47:31 +0000 (11:47 +0000)] 
File names need to be double quoted to expand

2 years agoTidy up
Nick Porter [Wed, 28 Feb 2024 11:04:40 +0000 (11:04 +0000)] 
Tidy up

2 years agoUse call_env for filename in rlm_linelog
Nick Porter [Wed, 28 Feb 2024 10:50:02 +0000 (10:50 +0000)] 
Use call_env for filename in rlm_linelog

2 years agoIf call_env custom parser returns nothing, skip the current pair
Nick Porter [Wed, 28 Feb 2024 10:35:29 +0000 (10:35 +0000)] 
If call_env custom parser returns nothing, skip the current pair

2 years agoParse time in UTC if that's configured
Nick Porter [Tue, 5 Mar 2024 20:30:19 +0000 (20:30 +0000)] 
Parse time in UTC if that's configured

This reverts commit 70d449e48d1d0afe96dfc5d2b6c493a636292337.

2 years agoRevert "Handle occasional CI false failures of trunk tests"
Nick Porter [Tue, 5 Mar 2024 17:14:03 +0000 (17:14 +0000)] 
Revert "Handle occasional CI false failures of trunk tests"

This reverts commit 70d449e48d1d0afe96dfc5d2b6c493a636292337.
Shouldn't be needed with priority in test preq

2 years agoAdd priority to test protocol requests
Nick Porter [Tue, 5 Mar 2024 17:08:25 +0000 (17:08 +0000)] 
Add priority to test protocol requests

So that requests are handled in a deterministic manner

2 years agoAdd basic tests of rlm_detail
Nick Porter [Mon, 26 Feb 2024 17:16:58 +0000 (17:16 +0000)] 
Add basic tests of rlm_detail

2 years agoMove rlm_detail suppressed attributes to call_env
Nick Porter [Mon, 26 Feb 2024 17:16:33 +0000 (17:16 +0000)] 
Move rlm_detail suppressed attributes to call_env

2 years agoUse a call_env in rlm_detail for filename and header
Nick Porter [Mon, 26 Feb 2024 15:12:34 +0000 (15:12 +0000)] 
Use a call_env in rlm_detail for filename and header

2 years agoIncrement pointer after character is output
Nick Porter [Tue, 27 Feb 2024 15:49:36 +0000 (15:49 +0000)] 
Increment pointer after character is output

2 years agoCorrectly cast to print hex value of characters
Nick Porter [Tue, 27 Feb 2024 15:14:53 +0000 (15:14 +0000)] 
Correctly cast to print hex value of characters

2 years agoAdd value_box filename escape / make_safe functions
Nick Porter [Mon, 26 Feb 2024 15:11:19 +0000 (15:11 +0000)] 
Add value_box filename escape / make_safe functions

2 years agoMove time tracking to the server library to avoid circular dependencies
Arran Cudbard-Bell [Tue, 5 Mar 2024 19:09:04 +0000 (13:09 -0600)] 
Move time tracking to the server library to avoid circular dependencies

2 years agoLink unlang to the io library
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:30:46 +0000 (12:30 -0600)] 
Link unlang to the io library

2 years agoMore time tracking debug
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:12:51 +0000 (12:12 -0600)] 
More time tracking debug

Don't assert on detach if the detached request was yielded

2 years agoNote on backrefs
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:12:11 +0000 (12:12 -0600)] 
Note on backrefs

2 years agoPrint the actual states in assert messages for time tracking
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:11:31 +0000 (12:11 -0600)] 
Print the actual states in assert messages for time tracking

2 years agoAttempt to fix assert on timeout of subrequests
Arran Cudbard-Bell [Tue, 5 Mar 2024 16:48:31 +0000 (10:48 -0600)] 
Attempt to fix assert on timeout of subrequests

2 years agoTest cancellations within subrequests
Arran Cudbard-Bell [Tue, 5 Mar 2024 16:38:07 +0000 (10:38 -0600)] 
Test cancellations within subrequests

2 years agoHave cancel xlat execute immediately when timeout value is zero
Arran Cudbard-Bell [Tue, 5 Mar 2024 16:37:52 +0000 (10:37 -0600)] 
Have cancel xlat execute immediately when timeout value is zero

2 years agoupdate CC_HINT
Alan T. DeKok [Tue, 5 Mar 2024 15:00:56 +0000 (10:00 -0500)] 
update CC_HINT

2 years agotypos and fixes
Alan T. DeKok [Tue, 5 Mar 2024 14:54:18 +0000 (09:54 -0500)] 
typos and fixes

2 years agomore documentation
Alan T. DeKok [Tue, 5 Mar 2024 14:43:09 +0000 (09:43 -0500)] 
more documentation

2 years agoallow caller to cancel pending packets
Alan T. DeKok [Tue, 5 Mar 2024 14:42:55 +0000 (09:42 -0500)] 
allow caller to cancel pending packets

2 years agodocumentation updates
Alan T. DeKok [Tue, 5 Mar 2024 12:54:33 +0000 (07:54 -0500)] 
documentation updates

2 years agohoist error earlier
Alan T. DeKok [Tue, 5 Mar 2024 12:54:23 +0000 (07:54 -0500)] 
hoist error earlier

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Tue, 5 Mar 2024 09:35:07 +0000 (09:35 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:52 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:49 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:46 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:42 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:35 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoAdd tests of %bin() and multi valued %hex()
Nick Porter [Mon, 4 Mar 2024 19:42:58 +0000 (19:42 +0000)] 
Add tests of %bin() and multi valued %hex()

2 years agoUpdate %hex and %bin to work on lists of values
Nick Porter [Mon, 4 Mar 2024 18:20:12 +0000 (18:20 +0000)] 
Update %hex and %bin to work on lists of values

2 years agoremove extraneous semicolon
Alan T. DeKok [Mon, 4 Mar 2024 02:18:27 +0000 (21:18 -0500)] 
remove extraneous semicolon

2 years agoreturn correct value
Alan T. DeKok [Mon, 4 Mar 2024 02:18:19 +0000 (21:18 -0500)] 
return correct value

2 years agoadd API for retrying packets with timers
Alan T. DeKok [Mon, 4 Mar 2024 02:08:27 +0000 (21:08 -0500)] 
add API for retrying packets with timers

and associating responses with packets

2 years agorename fields for clarity
Alan T. DeKok [Mon, 4 Mar 2024 02:08:09 +0000 (21:08 -0500)] 
rename fields for clarity

2 years agoallow counting replies, too
Alan T. DeKok [Mon, 4 Mar 2024 02:07:35 +0000 (21:07 -0500)] 
allow counting replies, too

which makes other code easier to write and maintain

2 years agocleanups and clarifications
Alan T. DeKok [Mon, 4 Mar 2024 02:07:22 +0000 (21:07 -0500)] 
cleanups and clarifications

2 years agoif we don't retry, use MRD instead of IRT for timeout
Alan T. DeKok [Sun, 3 Mar 2024 15:34:14 +0000 (10:34 -0500)] 
if we don't retry, use MRD instead of IRT for timeout

which gies a better value for the timeout, as MRD is the only
one which matters.

2 years agoretry_init doesn't need to return anything
Alan T. DeKok [Sun, 3 Mar 2024 15:28:44 +0000 (10:28 -0500)] 
retry_init doesn't need to return anything

2 years agoit helps to have a TALLOC_CTX passed to the read / decode functions
Alan T. DeKok [Thu, 29 Feb 2024 16:53:17 +0000 (11:53 -0500)] 
it helps to have a TALLOC_CTX passed to the read / decode functions

2 years agotypo
Alan T. DeKok [Thu, 29 Feb 2024 16:52:52 +0000 (11:52 -0500)] 
typo

2 years agotypo
Alan T. DeKok [Thu, 29 Feb 2024 16:45:13 +0000 (11:45 -0500)] 
typo

2 years agotest and document date comparisons
Alan T. DeKok [Thu, 29 Feb 2024 14:31:33 +0000 (09:31 -0500)] 
test and document date comparisons

2 years agoAlways need a new timer event, unless we're exiting immediately
Nick Porter [Fri, 1 Mar 2024 14:14:58 +0000 (14:14 +0000)] 
Always need a new timer event, unless we're exiting immediately

Otherwise, after processing a file, if there are no more waiting to be
processed, future new files will not be handled.

2 years agoUpdate detail reader test to verify enumerated attributes are read
Nick Porter [Fri, 1 Mar 2024 12:25:33 +0000 (12:25 +0000)] 
Update detail reader test to verify enumerated attributes are read

2 years agoAdd rlm_brotli to stable modules list for RHEL packaging
Nick Porter [Fri, 1 Mar 2024 10:47:42 +0000 (10:47 +0000)] 
Add rlm_brotli to stable modules list for RHEL packaging

2 years agoCorrect terminals for parsing barewords
Nick Porter [Fri, 1 Mar 2024 10:29:04 +0000 (10:29 +0000)] 
Correct terminals for parsing barewords

Without "", the trailing '\0' gets included in enumerated values - then
the hash is different to that built when the dictionary was read.

2 years agoall.mk is built by configure
Nick Porter [Fri, 1 Mar 2024 10:26:27 +0000 (10:26 +0000)] 
all.mk is built by configure

2 years agoInclude brotli for FreeBSD CI hosts
Nick Porter [Thu, 29 Feb 2024 20:40:40 +0000 (20:40 +0000)] 
Include brotli for FreeBSD CI hosts

2 years agoLDAP-Sync.Directory-Root-DN has to be marked safe to use as a DN
Nick Porter [Thu, 29 Feb 2024 20:31:05 +0000 (20:31 +0000)] 
LDAP-Sync.Directory-Root-DN has to be marked safe to use as a DN

2 years agoTidy quoting in %unpack() tests
Nick Porter [Thu, 29 Feb 2024 17:40:32 +0000 (17:40 +0000)] 
Tidy quoting in %unpack() tests

2 years agoAdd optional `repeat` argument to %unpack()
Nick Porter [Thu, 29 Feb 2024 17:30:48 +0000 (17:30 +0000)] 
Add optional `repeat` argument to %unpack()

2 years agoSatisfy the pedants
Arran Cudbard-Bell [Thu, 29 Feb 2024 15:53:27 +0000 (09:53 -0600)] 
Satisfy the pedants

2 years agoAllow fr_value_box_mem_realloc to alloc zero size buffers
Arran Cudbard-Bell [Thu, 29 Feb 2024 06:12:54 +0000 (00:12 -0600)] 
Allow fr_value_box_mem_realloc to alloc zero size buffers

2 years agoDon't eval MEM() expressions twice
Arran Cudbard-Bell [Thu, 29 Feb 2024 06:09:59 +0000 (00:09 -0600)] 
Don't eval MEM() expressions twice

2 years agoAdd rlm_brotli
Arran Cudbard-Bell [Thu, 29 Feb 2024 06:09:34 +0000 (00:09 -0600)] 
Add rlm_brotli

2 years agoRADIUS client bio beginnings
Alan T. DeKok [Wed, 28 Feb 2024 15:47:19 +0000 (10:47 -0500)] 
RADIUS client bio beginnings

2 years agofr_bio_packet_t handlers
Alan T. DeKok [Mon, 26 Feb 2024 13:38:06 +0000 (08:38 -0500)] 
fr_bio_packet_t handlers

2 years agominor cleanups
Alan T. DeKok [Mon, 26 Feb 2024 19:08:56 +0000 (14:08 -0500)] 
minor cleanups

2 years agomove packet list to queue.c
Alan T. DeKok [Thu, 22 Feb 2024 13:45:43 +0000 (08:45 -0500)] 
move packet list to queue.c

2 years agorearrange so #fr_socket_t is the first element
Alan T. DeKok [Sun, 25 Feb 2024 12:40:29 +0000 (07:40 -0500)] 
rearrange so #fr_socket_t is the first element

2 years agoallow for empty write buffers
Alan T. DeKok [Sun, 25 Feb 2024 12:40:52 +0000 (07:40 -0500)] 
allow for empty write buffers

2 years agoclean up mem
Alan T. DeKok [Wed, 21 Feb 2024 16:37:38 +0000 (11:37 -0500)] 
clean up mem

and note that we can't buffer outgoing datagrams

2 years agomove verify to set_verify callback
Alan T. DeKok [Wed, 21 Feb 2024 16:21:46 +0000 (11:21 -0500)] 
move verify to set_verify callback

so that we can add verification to bios which have both read and
write buffers

2 years agothese functions should be private
Alan T. DeKok [Wed, 21 Feb 2024 15:51:50 +0000 (10:51 -0500)] 
these functions should be private

2 years agotypo
Alan T. DeKok [Wed, 21 Feb 2024 15:47:49 +0000 (10:47 -0500)] 
typo

2 years agodoxygen for bio read / write functions
Alan T. DeKok [Wed, 21 Feb 2024 16:07:45 +0000 (11:07 -0500)] 
doxygen for bio read / write functions

2 years agoremove unused functions
Alan T. DeKok [Wed, 21 Feb 2024 16:32:09 +0000 (11:32 -0500)] 
remove unused functions

2 years agoit helps to initialize the sockaddr
Alan T. DeKok [Sun, 25 Feb 2024 12:40:16 +0000 (07:40 -0500)] 
it helps to initialize the sockaddr

2 years agoNo-one should be using LM hashes to store passwords
Nick Porter [Tue, 27 Feb 2024 16:29:03 +0000 (16:29 +0000)] 
No-one should be using LM hashes to store passwords

Also removes use of xlat_eval in rlm_pap

2 years agoDocs correction
Nick Porter [Tue, 27 Feb 2024 15:59:58 +0000 (15:59 +0000)] 
Docs correction

2 years agoRework LDAP group filter expansion to remove xlat_eval()
Nick Porter [Fri, 23 Feb 2024 20:58:27 +0000 (20:58 +0000)] 
Rework LDAP group filter expansion to remove xlat_eval()

2 years agoAdd fr_ldap_box_escape()
Nick Porter [Fri, 23 Feb 2024 20:54:08 +0000 (20:54 +0000)] 
Add fr_ldap_box_escape()

2 years agoPass module instnce data to call_env_alloc when parsing xlat call_env
Nick Porter [Tue, 27 Feb 2024 13:29:28 +0000 (13:29 +0000)] 
Pass module instnce data to call_env_alloc when parsing xlat call_env

xi->data has only just been allocated at this point so doesn't contain
anything useful.