]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoInclude rlm_unbound in packaging
Nick Porter [Mon, 12 Feb 2024 10:34:58 +0000 (10:34 +0000)] 
Include rlm_unbound in packaging

Same as v3.2

2 years agoAllow for differing versions of ub_event_callback_type
Nick Porter [Mon, 12 Feb 2024 15:34:05 +0000 (15:34 +0000)] 
Allow for differing versions of ub_event_callback_type

2 years agoAdd tests of rlm_winbind
Nick Porter [Mon, 12 Feb 2024 11:44:58 +0000 (11:44 +0000)] 
Add tests of rlm_winbind

2 years agoThese are not errors
Nick Porter [Mon, 12 Feb 2024 10:32:25 +0000 (10:32 +0000)] 
These are not errors

2 years agoUse call_env in %winbind.group() xlat
Nick Porter [Mon, 12 Feb 2024 10:29:18 +0000 (10:29 +0000)] 
Use call_env in %winbind.group() xlat

2 years agoMore appropriate debug message types / levels
Nick Porter [Fri, 9 Feb 2024 18:10:07 +0000 (18:10 +0000)] 
More appropriate debug message types / levels

2 years agoRemove unused option
Nick Porter [Fri, 9 Feb 2024 17:51:43 +0000 (17:51 +0000)] 
Remove unused option

2 years agoUse custom call_env parser to handle automatic domain lookup
Nick Porter [Fri, 9 Feb 2024 17:51:21 +0000 (17:51 +0000)] 
Use custom call_env parser to handle automatic domain lookup

2 years agoUse call_env in winbind mod_authorize
Nick Porter [Fri, 9 Feb 2024 17:21:02 +0000 (17:21 +0000)] 
Use call_env in winbind mod_authorize

2 years agoUse new xlat function syntax
Nick Porter [Fri, 9 Feb 2024 16:32:54 +0000 (16:32 +0000)] 
Use new xlat function syntax

2 years agoxlat_arg_parser for winbind.group is static const
Nick Porter [Fri, 9 Feb 2024 16:30:49 +0000 (16:30 +0000)] 
xlat_arg_parser for winbind.group is static const

There is no escape function needing access to inst

2 years agoUse a call_env for rlm_winbind mod_authenticate
Nick Porter [Fri, 9 Feb 2024 16:24:35 +0000 (16:24 +0000)] 
Use a call_env for rlm_winbind mod_authenticate

2 years agoTidy up
Nick Porter [Fri, 9 Feb 2024 12:43:46 +0000 (12:43 +0000)] 
Tidy up

2 years agoMove loading of rlm_files data to call_env
Nick Porter [Fri, 9 Feb 2024 12:36:17 +0000 (12:36 +0000)] 
Move loading of rlm_files data to call_env

2 years agoCorrect comment
Nick Porter [Fri, 9 Feb 2024 12:06:28 +0000 (12:06 +0000)] 
Correct comment

2 years agoFormatting
Nick Porter [Fri, 9 Feb 2024 09:32:04 +0000 (09:32 +0000)] 
Formatting

2 years agoTemporary &users list is not talloced, only its members are
Nick Porter [Fri, 9 Feb 2024 09:29:59 +0000 (09:29 +0000)] 
Temporary &users list is not talloced, only its members are

2 years agoAlign sample configuration with rlm_files only having one filename
Nick Porter [Fri, 9 Feb 2024 09:24:06 +0000 (09:24 +0000)] 
Align sample configuration with rlm_files only having one filename

2 years agoJust use a single filename in rlm_files
Nick Porter [Wed, 7 Feb 2024 20:01:57 +0000 (20:01 +0000)] 
Just use a single filename in rlm_files

If different data is used in different contexts, use multiple instances
of the module

2 years agonope. header length is 4
Alan T. DeKok [Fri, 9 Feb 2024 14:52:14 +0000 (09:52 -0500)] 
nope.  header length is 4

2 years agocheck for fragment with insufficient room for header
Alan T. DeKok [Fri, 9 Feb 2024 14:49:50 +0000 (09:49 -0500)] 
check for fragment with insufficient room for header

2 years agoadd test and example for eval
Alan T. DeKok [Wed, 7 Feb 2024 17:56:03 +0000 (12:56 -0500)] 
add test and example for eval

2 years agoadd output from fuzzer
Alan T. DeKok [Wed, 7 Feb 2024 13:56:15 +0000 (08:56 -0500)] 
add output from fuzzer

hopefully we can get a better error message running the normal
tests.

2 years agoRemove protocol prefixes from attribute references
Nick Porter [Wed, 7 Feb 2024 08:11:33 +0000 (08:11 +0000)] 
Remove protocol prefixes from attribute references

2 years agoUpdate sqlippool docs
Nick Porter [Fri, 2 Feb 2024 17:53:13 +0000 (17:53 +0000)] 
Update sqlippool docs

2 years agosqlippool should be called in `accounting ...` sections
Nick Porter [Fri, 2 Feb 2024 17:52:53 +0000 (17:52 +0000)] 
sqlippool should be called in `accounting ...` sections

So that the correct method is used.

2 years agoAdd tests of rlm_sqlippool
Nick Porter [Fri, 2 Feb 2024 14:50:19 +0000 (14:50 +0000)] 
Add tests of rlm_sqlippool

2 years agoConvert remaining sqlippool methods to use call_env
Nick Porter [Fri, 2 Feb 2024 14:37:32 +0000 (14:37 +0000)] 
Convert remaining sqlippool methods to use call_env

2 years agoMove the rest of sqlippool alloc to use call_env
Nick Porter [Fri, 2 Feb 2024 14:35:29 +0000 (14:35 +0000)] 
Move the rest of sqlippool alloc to use call_env

2 years agoAdd alloc queries to call_env
Nick Porter [Fri, 2 Feb 2024 14:25:06 +0000 (14:25 +0000)] 
Add alloc queries to call_env

2 years agoUpdate sqlippool query functions to expect pre-expanded queries and take an rlm_sql_t
Nick Porter [Fri, 2 Feb 2024 14:23:07 +0000 (14:23 +0000)] 
Update sqlippool query functions to expect pre-expanded queries and take an rlm_sql_t

2 years agoAdd sql escape uctx alloc / free functions for SQL IP Pool queries
Nick Porter [Fri, 2 Feb 2024 14:07:35 +0000 (14:07 +0000)] 
Add sql escape uctx alloc / free functions for SQL IP Pool queries

2 years agoDefine custom call_env parser for SQL IP Pool queries
Nick Porter [Fri, 2 Feb 2024 14:03:53 +0000 (14:03 +0000)] 
Define custom call_env parser for SQL IP Pool queries

2 years agoAdd box_escape_func to SQL module instance
Nick Porter [Fri, 2 Feb 2024 13:01:57 +0000 (13:01 +0000)] 
Add box_escape_func to SQL module instance

2 years agoMake module / xlat instance data available when parsing call_env
Nick Porter [Fri, 2 Feb 2024 13:00:36 +0000 (13:00 +0000)] 
Make module / xlat instance data available when parsing call_env

And pass it to the custom parsing function.

2 years agoAdd uctx for SQL escape functions
Nick Porter [Thu, 1 Feb 2024 17:56:55 +0000 (17:56 +0000)] 
Add uctx for SQL escape functions

Allows for passing of an exising connection handle

2 years agoPass safe_for to xlat_tokenize_input
Nick Porter [Thu, 1 Feb 2024 17:48:46 +0000 (17:48 +0000)] 
Pass safe_for to xlat_tokenize_input

2 years agoAdd rules for parsing literals in tmpls
Nick Porter [Tue, 6 Feb 2024 18:31:50 +0000 (18:31 +0000)] 
Add rules for parsing literals in tmpls

2 years agoUpdate sqlippool rcodes to match those returned by redis_ippool
Nick Porter [Mon, 22 Jan 2024 12:12:04 +0000 (12:12 +0000)] 
Update sqlippool rcodes to match those returned by redis_ippool

2 years agoMore helpful debug messages
Nick Porter [Fri, 19 Jan 2024 18:23:21 +0000 (18:23 +0000)] 
More helpful debug messages

2 years agoMove requested_address to call env
Nick Porter [Fri, 19 Jan 2024 18:17:27 +0000 (18:17 +0000)] 
Move requested_address to call env

2 years agoMove pool_name to call env
Nick Porter [Fri, 19 Jan 2024 17:32:29 +0000 (17:32 +0000)] 
Move pool_name to call env

2 years agoAdd initial call_env to sqlippool
Nick Porter [Fri, 19 Jan 2024 16:35:35 +0000 (16:35 +0000)] 
Add initial call_env to sqlippool

Just for allocated_address_attr to start with

2 years agoAdd tests of if using nested && and ||
Nick Porter [Wed, 7 Feb 2024 10:27:57 +0000 (10:27 +0000)] 
Add tests of if using nested && and ||

2 years agoReturn XLAT_ACTION_DONE on logical false
Nick Porter [Wed, 7 Feb 2024 09:50:00 +0000 (09:50 +0000)] 
Return XLAT_ACTION_DONE on logical false

XLAT_ACTION_FAIL is only when there is a failure, not when the return
from real evaluations is false

2 years agoadd test case to prevent regression
Alan T. DeKok [Tue, 6 Feb 2024 14:56:13 +0000 (09:56 -0500)] 
add test case to prevent regression

2 years agobetter catch malformed attributes
Alan T. DeKok [Tue, 6 Feb 2024 14:06:42 +0000 (09:06 -0500)] 
better catch malformed attributes

2 years agoremove -n and -p
Alan T. DeKok [Mon, 5 Feb 2024 14:02:43 +0000 (09:02 -0500)] 
remove -n and -p

2 years agoremove coa functionality
Alan T. DeKok [Mon, 5 Feb 2024 13:57:55 +0000 (08:57 -0500)] 
remove coa functionality

in the quest to get bios, we simply delete old code, which will be
eventually replaced with new code

2 years agouse correct function type to quiet ubsan complaints
Alan T. DeKok [Mon, 5 Feb 2024 13:44:10 +0000 (08:44 -0500)] 
use correct function type to quiet ubsan complaints

2 years agowe didn't call xlat init, so we don't call xlat free
Alan T. DeKok [Mon, 5 Feb 2024 02:31:15 +0000 (21:31 -0500)] 
we didn't call xlat init, so we don't call xlat free

2 years agoreference count init/free instead of using boolean
Alan T. DeKok [Mon, 5 Feb 2024 02:22:03 +0000 (21:22 -0500)] 
reference count init/free instead of using boolean

2 years agowe didn't call xlat init, we shouldn't call xlat free.
Alan T. DeKok [Mon, 5 Feb 2024 02:14:24 +0000 (21:14 -0500)] 
we didn't call xlat init, we shouldn't call xlat free.

2 years agonormalize names
Alan T. DeKok [Mon, 5 Feb 2024 02:00:37 +0000 (21:00 -0500)] 
normalize names

foo_global_init() and foo_global_free()

2 years agofor helping with fuzzer issues
Alan T. DeKok [Sun, 4 Feb 2024 21:39:49 +0000 (16:39 -0500)] 
for helping with fuzzer issues

2 years agoI do have loathing for compilers which don't produce error messages
Alan T. DeKok [Sun, 4 Feb 2024 17:28:28 +0000 (12:28 -0500)] 
I do have loathing for compilers which don't produce error messages

2 years agocomment out assertion to see if fuzzer will produce better error
Alan T. DeKok [Sun, 4 Feb 2024 17:17:35 +0000 (12:17 -0500)] 
comment out assertion to see if fuzzer will produce better error

2 years agomake sure to free tag ctx, too
Alan T. DeKok [Sun, 4 Feb 2024 16:12:44 +0000 (11:12 -0500)] 
make sure to free tag ctx, too

2 years agomake sure that we call library init / free
Alan T. DeKok [Sun, 4 Feb 2024 16:09:33 +0000 (11:09 -0500)] 
make sure that we call library init / free

2 years agofree tag ctx, too
Alan T. DeKok [Sun, 4 Feb 2024 15:46:41 +0000 (10:46 -0500)] 
free tag ctx, too

2 years agono longer any need to call init.
Alan T. DeKok [Sun, 4 Feb 2024 15:27:51 +0000 (10:27 -0500)] 
no longer any need to call init.

Missed in commit f7778c55206db

2 years agoAdd foreign tests to DHCPv6
Alan T. DeKok [Sun, 4 Feb 2024 15:24:09 +0000 (10:24 -0500)] 
Add foreign tests to DHCPv6

2 years agoclean up autofree
Alan T. DeKok [Sun, 4 Feb 2024 15:15:35 +0000 (10:15 -0500)] 
clean up autofree

The only remaining errors are:

test.unit.dns, which fails to clean up the DNS dictionaries.
All of the other protocols are fine, so there's some extra magic
here.

test.keywords: fr_dict_free() is asked to remove a dependency
which doesn't exist.  That _should_ be an assertion, but for now
it's a recoverable error which lets other people get work done.

2 years agojust call common function
Alan T. DeKok [Sun, 4 Feb 2024 13:11:15 +0000 (08:11 -0500)] 
just call common function

2 years agoadd dependency if we load the dictionary
Alan T. DeKok [Sun, 4 Feb 2024 13:10:28 +0000 (08:10 -0500)] 
add dependency if we load the dictionary

and thus we can call dict->proto->free()

2 years agoadd debug printing for dependencies
Alan T. DeKok [Sun, 4 Feb 2024 13:09:29 +0000 (08:09 -0500)] 
add debug printing for dependencies

2 years agodon't free dictionaries until we track down reference issues
Alan T. DeKok [Sun, 4 Feb 2024 03:17:29 +0000 (22:17 -0500)] 
don't free dictionaries until we track down reference issues

There are issues with calling proto->free() in the destructor
for the dictionaries

there are issues with foreign references.

2 years agoset loaded flag before calling proto->init()
Alan T. DeKok [Sun, 4 Feb 2024 03:16:29 +0000 (22:16 -0500)] 
set loaded flag before calling proto->init()

to prevent recursion

2 years agoadd assertion
Alan T. DeKok [Sun, 4 Feb 2024 03:16:16 +0000 (22:16 -0500)] 
add assertion

2 years agoremove unused code
Alan T. DeKok [Sun, 4 Feb 2024 02:58:56 +0000 (21:58 -0500)] 
remove unused code

2 years agoMove to init/free for library, and not for each test case
Alan T. DeKok [Sat, 3 Feb 2024 20:47:21 +0000 (15:47 -0500)] 
Move to init/free for library, and not for each test case

now that we (mostly) have library-based init/free, we do not need
to do that for every test case.  Either the library is properly
initialized and it works, or the library isn't initialized, and
the tests fail.

Some protocols still need to be converted to use fr_dict_protocol_t

ethernet, tacacs, tftp, vmps

2 years agodon't add the dependency twice
Alan T. DeKok [Sat, 3 Feb 2024 16:05:20 +0000 (11:05 -0500)] 
don't add the dependency twice

2 years agosome protocols don't have init/free
Alan T. DeKok [Sat, 3 Feb 2024 15:27:13 +0000 (10:27 -0500)] 
some protocols don't have init/free

2 years agodict may be NULL
Alan T. DeKok [Sat, 3 Feb 2024 14:51:37 +0000 (09:51 -0500)] 
dict may be NULL

2 years agoallow for loops in foreign dictionaries
Alan T. DeKok [Sat, 3 Feb 2024 14:05:14 +0000 (09:05 -0500)] 
allow for loops in foreign dictionaries

by adding two flags, "loading", which is set in begin-proto,
and cleared when the dictionary is done.  And "loaded" which is
set by fr_protocol_afrom_file(), to indicate that it has loaded
the dictionary file. and initialized the protocol library.

The dict routines now call proto->init() and proto->free(), so that
when a protocol library is loaded, everything it needs is also
loaded and initialized.

2 years agoremove internal dictionary last.
Alan T. DeKok [Sat, 3 Feb 2024 14:04:08 +0000 (09:04 -0500)] 
remove internal dictionary last.

Many protocol dictionaries reference it.  If we try to remove it
first, it will still be referenced by them.  Instead, we want to
remove the protocol dictionaries first, and only then remove the
internal dictionary.

2 years agoremove extraneous asserts
Alan T. DeKok [Thu, 1 Feb 2024 19:25:57 +0000 (14:25 -0500)] 
remove extraneous asserts

2 years agoturn "load protocol ref" into stand-along function
Alan T. DeKok [Thu, 1 Feb 2024 19:12:52 +0000 (14:12 -0500)] 
turn "load protocol ref" into stand-along function

which only loads foreign protocols, and not local refs

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:40 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:35 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:29 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:25 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:23 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:19 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sat, 3 Feb 2024 09:34:16 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoReport what database file is being created
Nick Porter [Fri, 2 Feb 2024 14:50:54 +0000 (14:50 +0000)] 
Report what database file is being created

2 years agoInclude sqlite3 in FreeBSD CI build
Nick Porter [Fri, 2 Feb 2024 15:49:26 +0000 (15:49 +0000)] 
Include sqlite3 in FreeBSD CI build

2 years agoMore GitHub action updates
Nick Porter [Fri, 2 Feb 2024 15:48:13 +0000 (15:48 +0000)] 
More GitHub action updates

Just for allocated_address_attr to start with

2 years agoAttempt to placate Coverity in rs_packet_process() (CID #1587345)
James Jones [Mon, 29 Jan 2024 20:28:05 +0000 (14:28 -0600)] 
Attempt to placate Coverity in rs_packet_process() (CID #1587345)

Coverity infers from the check of original->expect in the call to
fr_radius_decode_simple() that original->expect can be NULL, and
hence the later call to rs_stats_update_latency() call that
dereferences original->expect may fail. It may be that if original
and original->linked are non-NULL, one can infer original->expect
is non-NULL. Coverity can't; hence the added check on that call to
rs_stats_update_latency()..

2 years agoDeal with remaining missing locks (CIDs listed below)
James Jones [Tue, 21 Nov 2023 21:53:47 +0000 (15:53 -0600)] 
Deal with remaining missing locks (CIDs listed below)

CIDs: 1551700155170115517041551705

2 years agoSQL driver config can't refer to ...pool
Nick Porter [Wed, 31 Jan 2024 17:54:44 +0000 (17:54 +0000)] 
SQL driver config can't refer to ...pool

since it is included before the pool section.

2 years agoMinor Oracle fixes
Nick Porter [Wed, 31 Jan 2024 17:51:19 +0000 (17:51 +0000)] 
Minor Oracle fixes

2 years agoAlign Oracle spool.max parsing with pool.max
Nick Porter [Wed, 31 Jan 2024 17:50:41 +0000 (17:50 +0000)] 
Align Oracle spool.max parsing with pool.max

If not set, matches the number of worker threads

2 years agoFix oracle query issue
Nick Porter [Wed, 31 Jan 2024 17:49:31 +0000 (17:49 +0000)] 
Fix oracle query issue

2 years agominor copy editing
Alan T. DeKok [Thu, 1 Feb 2024 14:03:10 +0000 (09:03 -0500)] 
minor copy editing

commas, etc.

2 years agoupdate and clarify
Alan T. DeKok [Thu, 1 Feb 2024 13:48:39 +0000 (08:48 -0500)] 
update and clarify

2 years agoNo need for begin / commit for independent UPDATE queries
Nick Porter [Thu, 1 Feb 2024 13:58:43 +0000 (13:58 +0000)] 
No need for begin / commit for independent UPDATE queries

Whilst Oracle had these set to "COMMIT", queries are actually run with
OCI_COMMIT_ON_SUCCESS so no need for a separate COMMIT

2 years agorefresh antora raddb pages
Matthew Newton [Wed, 31 Jan 2024 17:44:26 +0000 (17:44 +0000)] 
refresh antora raddb pages