]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoUse MEM() in more places
Arran Cudbard-Bell [Tue, 12 Mar 2024 23:13:14 +0000 (17:13 -0600)] 
Use MEM() in more places

2 years agoDon't use sendto if ifindex is specified
Arran Cudbard-Bell [Tue, 12 Mar 2024 15:36:42 +0000 (09:36 -0600)] 
Don't use sendto if ifindex is specified

2 years agoBetter debug message
Nick Porter [Tue, 12 Mar 2024 14:54:48 +0000 (14:54 +0000)] 
Better debug message

2 years agoParse FreeRADIUS-Client-Src-IP-Address when creating dynamic clients
Nick Porter [Tue, 12 Mar 2024 14:54:21 +0000 (14:54 +0000)] 
Parse FreeRADIUS-Client-Src-IP-Address when creating dynamic clients

And copy the resulting field back when the client is created.

Makes dynamic clients consistent with static clients.

2 years agoReturn how many bytes we actually wrote (and errors)
Arran Cudbard-Bell [Mon, 11 Mar 2024 21:26:01 +0000 (15:26 -0600)] 
Return how many bytes we actually wrote (and errors)

2 years agoFormatting
Arran Cudbard-Bell [Mon, 11 Mar 2024 21:25:48 +0000 (15:25 -0600)] 
Formatting

2 years agoRemove DHCP package from debian packaging
Arran Cudbard-Bell [Fri, 8 Mar 2024 21:03:21 +0000 (15:03 -0600)] 
Remove DHCP package from debian packaging

it has no external dependencies, and we need the libraries to load the dictionaries

2 years agomove bio stuff to compile flag
Alan T. DeKok [Sat, 9 Mar 2024 15:43:40 +0000 (10:43 -0500)] 
move bio stuff to compile flag

until such time as we ca n figure out why it works for gcc in CI,
but doesn't work for clang in CI, but does work with clang locally

2 years agoremove unused macros
Alan T. DeKok [Sat, 9 Mar 2024 15:32:40 +0000 (10:32 -0500)] 
remove unused macros

2 years agothis isn't needed, and was never used
Alan T. DeKok [Fri, 8 Mar 2024 19:15:28 +0000 (14:15 -0500)] 
this isn't needed, and was never used

2 years agolean up structure and remove unused fields
Alan T. DeKok [Fri, 8 Mar 2024 19:15:10 +0000 (14:15 -0500)] 
lean up structure and remove unused fields

re-organize it for future needs and deletions

2 years agoupdate packet bio and start trying to use retry bio
Alan T. DeKok [Fri, 8 Mar 2024 15:43:31 +0000 (10:43 -0500)] 
update packet bio and start trying to use retry bio

2 years agodon't update packet_ctx on read connected datagram
Alan T. DeKok [Thu, 7 Mar 2024 14:01:32 +0000 (09:01 -0500)] 
don't update packet_ctx on read connected datagram

the reader already knows what the socket information is

2 years agoallocate tracking table at the start
Alan T. DeKok [Wed, 6 Mar 2024 21:22:10 +0000 (16:22 -0500)] 
allocate tracking table at the start

2 years agoBundle radict in debian packages
Arran Cudbard-Bell [Fri, 8 Mar 2024 20:19:53 +0000 (14:19 -0600)] 
Bundle radict in debian packages

2 years agoAdd doxygen comment
Nick Porter [Fri, 8 Mar 2024 18:16:32 +0000 (18:16 +0000)] 
Add doxygen comment

2 years agoUpdate sample template notes now auth logging has changed
Nick Porter [Fri, 8 Mar 2024 18:09:52 +0000 (18:09 +0000)] 
Update sample template notes now auth logging has changed

2 years agoUse linelog for auth logging in TTLS
Nick Porter [Fri, 8 Mar 2024 14:07:08 +0000 (14:07 +0000)] 
Use linelog for auth logging in TTLS

2 years agoUse linelog for auth logging in TACACS
Nick Porter [Fri, 8 Mar 2024 13:53:05 +0000 (13:53 +0000)] 
Use linelog for auth logging in TACACS

2 years agoTACACS config comment typos
Nick Porter [Fri, 8 Mar 2024 11:28:15 +0000 (11:28 +0000)] 
TACACS config comment typos

2 years agoReplace builtin auth logging with calls to linelog
Nick Porter [Fri, 8 Mar 2024 11:06:44 +0000 (11:06 +0000)] 
Replace builtin auth logging with calls to linelog

Removes use of xlat_eval and adds flexibility.

2 years agoTidy up after tests
Nick Porter [Fri, 8 Mar 2024 10:43:22 +0000 (10:43 +0000)] 
Tidy up after tests

2 years agoCorrect comments
Nick Porter [Fri, 8 Mar 2024 10:38:21 +0000 (10:38 +0000)] 
Correct comments

2 years agoUse a consistent destination name for writing logs to a file
Nick Porter [Fri, 8 Mar 2024 10:37:30 +0000 (10:37 +0000)] 
Use a consistent destination name for writing logs to a file

Linelog uses `file`, logging used `files`
Make `file` the normal, but allow `files` as well to avoid breaking existing configs

2 years agoSimultaneous use checking is now done in policy so msg_denied is not used
Nick Porter [Fri, 8 Mar 2024 09:13:14 +0000 (09:13 +0000)] 
Simultaneous use checking is now done in policy so msg_denied is not used

2 years agoTypos
James Jones [Fri, 8 Mar 2024 16:47:22 +0000 (10:47 -0600)] 
Typos

2 years agor->rt MUST be set by fr_retry_init
Arran Cudbard-Bell [Fri, 8 Mar 2024 06:19:25 +0000 (00:19 -0600)] 
r->rt MUST be set by fr_retry_init

It gets used in a bunch of debug messages

2 years agoFix some more overzealous renaming
Arran Cudbard-Bell [Thu, 7 Mar 2024 15:54:12 +0000 (09:54 -0600)] 
Fix some more overzealous renaming

2 years agoRemove clang scan hack
Arran Cudbard-Bell [Wed, 6 Mar 2024 21:53:44 +0000 (15:53 -0600)] 
Remove clang scan hack

2 years agoAdd support for CoA reply and filters to raduat
Arran Cudbard-Bell [Wed, 6 Mar 2024 21:44:12 +0000 (15:44 -0600)] 
Add support for CoA reply and filters to raduat

2 years agoQuiet compiler
Arran Cudbard-Bell [Wed, 6 Mar 2024 21:12:20 +0000 (15:12 -0600)] 
Quiet compiler

2 years agoReturn nested mismatch, not parents
Arran Cudbard-Bell [Wed, 6 Mar 2024 21:02:24 +0000 (15:02 -0600)] 
Return nested mismatch, not parents

2 years agoNo need for context
Arran Cudbard-Bell [Wed, 6 Mar 2024 21:00:51 +0000 (15:00 -0600)] 
No need for context

2 years agoPrint the pairs
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:59:00 +0000 (14:59 -0600)] 
Print the pairs

2 years agoFix quoting
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:58:00 +0000 (14:58 -0600)] 
Fix quoting

2 years agoDon't pass dictpath from raduat
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:41:53 +0000 (14:41 -0600)] 
Don't pass dictpath from raduat

2 years agoInstall raduat
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:19:00 +0000 (14:19 -0600)] 
Install raduat

2 years agos/fr_packet_CODE_VALID/FR_RADIUS_PACKET_CODE_VALID/g
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:15:59 +0000 (14:15 -0600)] 
s/fr_packet_CODE_VALID/FR_RADIUS_PACKET_CODE_VALID/g

2 years agos/fr_radius_packet/fr_packet/g
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:12:07 +0000 (14:12 -0600)] 
s/fr_radius_packet/fr_packet/g

2 years agos/fr_radius_packet_t/fr_packet_t/g
Arran Cudbard-Bell [Wed, 6 Mar 2024 20:10:48 +0000 (14:10 -0600)] 
s/fr_radius_packet_t/fr_packet_t/g

2 years agomove nonnull annotation to the right function
Alan T. DeKok [Wed, 6 Mar 2024 19:03:12 +0000 (14:03 -0500)] 
move nonnull annotation to the right function

2 years agoallow cancellation of last item in the timer tree
Alan T. DeKok [Wed, 6 Mar 2024 18:13:52 +0000 (13:13 -0500)] 
allow cancellation of last item in the timer tree

2 years agoCast more fr_sbuff_in_sprintf() calls for error messages to void (CID #1533664)
James Jones [Wed, 7 Feb 2024 18:24:21 +0000 (12:24 -0600)] 
Cast more fr_sbuff_in_sprintf() calls for error messages to void (CID #1533664)

2 years agoAnnotate the other missing_lock in connection_check() (CID #1551702)
James Jones [Thu, 8 Feb 2024 21:31:33 +0000 (15:31 -0600)] 
Annotate the other missing_lock in connection_check() (CID #1551702)

As with CID 1551700, Coverity doesn't know that all callers of
connection_check() have locked pool->mutex, so we need to annotate
the later reference to pool->pending_window.

2 years agoAsk for the right mutex (CID #1551705)
James Jones [Wed, 7 Feb 2024 22:04:11 +0000 (16:04 -0600)] 
Ask for the right mutex (CID #1551705)

Coverity message: "Accessing t->inst->list without holding lock
rlm_stats_t.mutex." rlm_stats_t, not rlm_stats_thread_t, so the
mutex to lock is t->inst->mutex, not t->mutex.

2 years agoDon't pass NULL rules to call_env_alloc() (CID #1530398)
James Jones [Thu, 15 Feb 2024 17:45:19 +0000 (11:45 -0600)] 
Don't pass NULL rules to call_env_alloc() (CID #1530398)

Coverity sees the nonnull attribute of call_env_alloc()'s t_rules
attribute, which compile_module() passes unlang_ctx->rules to.
Earlier unlang_ctx->rules is checked, so Coverity infers it can be
NULL and complains about the lack of checking on the call_env_alloc().

2 years agoMake sure modeling file is up to date
James Jones [Wed, 6 Mar 2024 15:21:14 +0000 (09:21 -0600)] 
Make sure modeling file is up to date

2 years agolet the application get the retry timers
Alan T. DeKok [Wed, 6 Mar 2024 16:28:53 +0000 (11:28 -0500)] 
let the application get the retry timers

2 years agouctx is used
Alan T. DeKok [Wed, 6 Mar 2024 16:28:35 +0000 (11:28 -0500)] 
uctx is used

2 years agocatch more corner cases
Alan T. DeKok [Wed, 6 Mar 2024 14:20:59 +0000 (09:20 -0500)] 
catch more corner cases

flush just goes to the next bio and flushes.

If the all retry timers are used, try to cancel the oldest one
and then use that.  This puts less work on the application to track
things.

2 years agoadd first / last API
Alan T. DeKok [Wed, 6 Mar 2024 14:18:47 +0000 (09:18 -0500)] 
add first / last API

2 years agoadd callback to set per-packet retry configuration
Alan T. DeKok [Tue, 5 Mar 2024 20:34:55 +0000 (15:34 -0500)] 
add callback to set per-packet retry configuration

so that one socket can do multiple different kinds of retries

2 years agosimplify more bio buffer functions
Alan T. DeKok [Tue, 5 Mar 2024 20:18:08 +0000 (15:18 -0500)] 
simplify more bio buffer functions

2 years agoadd Acct-Delay-Time if it doesn't exist
Alan T. DeKok [Tue, 5 Mar 2024 17:17:54 +0000 (12:17 -0500)] 
add Acct-Delay-Time if it doesn't exist

2 years agoFile names need to be double quoted to expand
Nick Porter [Wed, 6 Mar 2024 11:47:31 +0000 (11:47 +0000)] 
File names need to be double quoted to expand

2 years agoTidy up
Nick Porter [Wed, 28 Feb 2024 11:04:40 +0000 (11:04 +0000)] 
Tidy up

2 years agoUse call_env for filename in rlm_linelog
Nick Porter [Wed, 28 Feb 2024 10:50:02 +0000 (10:50 +0000)] 
Use call_env for filename in rlm_linelog

2 years agoIf call_env custom parser returns nothing, skip the current pair
Nick Porter [Wed, 28 Feb 2024 10:35:29 +0000 (10:35 +0000)] 
If call_env custom parser returns nothing, skip the current pair

2 years agoParse time in UTC if that's configured
Nick Porter [Tue, 5 Mar 2024 20:30:19 +0000 (20:30 +0000)] 
Parse time in UTC if that's configured

This reverts commit 70d449e48d1d0afe96dfc5d2b6c493a636292337.

2 years agoRevert "Handle occasional CI false failures of trunk tests"
Nick Porter [Tue, 5 Mar 2024 17:14:03 +0000 (17:14 +0000)] 
Revert "Handle occasional CI false failures of trunk tests"

This reverts commit 70d449e48d1d0afe96dfc5d2b6c493a636292337.
Shouldn't be needed with priority in test preq

2 years agoAdd priority to test protocol requests
Nick Porter [Tue, 5 Mar 2024 17:08:25 +0000 (17:08 +0000)] 
Add priority to test protocol requests

So that requests are handled in a deterministic manner

2 years agoAdd basic tests of rlm_detail
Nick Porter [Mon, 26 Feb 2024 17:16:58 +0000 (17:16 +0000)] 
Add basic tests of rlm_detail

2 years agoMove rlm_detail suppressed attributes to call_env
Nick Porter [Mon, 26 Feb 2024 17:16:33 +0000 (17:16 +0000)] 
Move rlm_detail suppressed attributes to call_env

2 years agoUse a call_env in rlm_detail for filename and header
Nick Porter [Mon, 26 Feb 2024 15:12:34 +0000 (15:12 +0000)] 
Use a call_env in rlm_detail for filename and header

2 years agoIncrement pointer after character is output
Nick Porter [Tue, 27 Feb 2024 15:49:36 +0000 (15:49 +0000)] 
Increment pointer after character is output

2 years agoCorrectly cast to print hex value of characters
Nick Porter [Tue, 27 Feb 2024 15:14:53 +0000 (15:14 +0000)] 
Correctly cast to print hex value of characters

2 years agoAdd value_box filename escape / make_safe functions
Nick Porter [Mon, 26 Feb 2024 15:11:19 +0000 (15:11 +0000)] 
Add value_box filename escape / make_safe functions

2 years agoMove time tracking to the server library to avoid circular dependencies
Arran Cudbard-Bell [Tue, 5 Mar 2024 19:09:04 +0000 (13:09 -0600)] 
Move time tracking to the server library to avoid circular dependencies

2 years agoLink unlang to the io library
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:30:46 +0000 (12:30 -0600)] 
Link unlang to the io library

2 years agoMore time tracking debug
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:12:51 +0000 (12:12 -0600)] 
More time tracking debug

Don't assert on detach if the detached request was yielded

2 years agoNote on backrefs
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:12:11 +0000 (12:12 -0600)] 
Note on backrefs

2 years agoPrint the actual states in assert messages for time tracking
Arran Cudbard-Bell [Tue, 5 Mar 2024 18:11:31 +0000 (12:11 -0600)] 
Print the actual states in assert messages for time tracking

2 years agoAttempt to fix assert on timeout of subrequests
Arran Cudbard-Bell [Tue, 5 Mar 2024 16:48:31 +0000 (10:48 -0600)] 
Attempt to fix assert on timeout of subrequests

2 years agoTest cancellations within subrequests
Arran Cudbard-Bell [Tue, 5 Mar 2024 16:38:07 +0000 (10:38 -0600)] 
Test cancellations within subrequests

2 years agoHave cancel xlat execute immediately when timeout value is zero
Arran Cudbard-Bell [Tue, 5 Mar 2024 16:37:52 +0000 (10:37 -0600)] 
Have cancel xlat execute immediately when timeout value is zero

2 years agoupdate CC_HINT
Alan T. DeKok [Tue, 5 Mar 2024 15:00:56 +0000 (10:00 -0500)] 
update CC_HINT

2 years agotypos and fixes
Alan T. DeKok [Tue, 5 Mar 2024 14:54:18 +0000 (09:54 -0500)] 
typos and fixes

2 years agomore documentation
Alan T. DeKok [Tue, 5 Mar 2024 14:43:09 +0000 (09:43 -0500)] 
more documentation

2 years agoallow caller to cancel pending packets
Alan T. DeKok [Tue, 5 Mar 2024 14:42:55 +0000 (09:42 -0500)] 
allow caller to cancel pending packets

2 years agodocumentation updates
Alan T. DeKok [Tue, 5 Mar 2024 12:54:33 +0000 (07:54 -0500)] 
documentation updates

2 years agohoist error earlier
Alan T. DeKok [Tue, 5 Mar 2024 12:54:23 +0000 (07:54 -0500)] 
hoist error earlier

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Tue, 5 Mar 2024 09:35:07 +0000 (09:35 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:52 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:49 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:46 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:42 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:37 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/bfd.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:35 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:31 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Tue, 5 Mar 2024 09:34:28 +0000 (09:34 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoAdd tests of %bin() and multi valued %hex()
Nick Porter [Mon, 4 Mar 2024 19:42:58 +0000 (19:42 +0000)] 
Add tests of %bin() and multi valued %hex()

2 years agoUpdate %hex and %bin to work on lists of values
Nick Porter [Mon, 4 Mar 2024 18:20:12 +0000 (18:20 +0000)] 
Update %hex and %bin to work on lists of values

2 years agoremove extraneous semicolon
Alan T. DeKok [Mon, 4 Mar 2024 02:18:27 +0000 (21:18 -0500)] 
remove extraneous semicolon

2 years agoreturn correct value
Alan T. DeKok [Mon, 4 Mar 2024 02:18:19 +0000 (21:18 -0500)] 
return correct value

2 years agoadd API for retrying packets with timers
Alan T. DeKok [Mon, 4 Mar 2024 02:08:27 +0000 (21:08 -0500)] 
add API for retrying packets with timers

and associating responses with packets

2 years agorename fields for clarity
Alan T. DeKok [Mon, 4 Mar 2024 02:08:09 +0000 (21:08 -0500)] 
rename fields for clarity

2 years agoallow counting replies, too
Alan T. DeKok [Mon, 4 Mar 2024 02:07:35 +0000 (21:07 -0500)] 
allow counting replies, too

which makes other code easier to write and maintain

2 years agocleanups and clarifications
Alan T. DeKok [Mon, 4 Mar 2024 02:07:22 +0000 (21:07 -0500)] 
cleanups and clarifications

2 years agoif we don't retry, use MRD instead of IRT for timeout
Alan T. DeKok [Sun, 3 Mar 2024 15:34:14 +0000 (10:34 -0500)] 
if we don't retry, use MRD instead of IRT for timeout

which gies a better value for the timeout, as MRD is the only
one which matters.

2 years agoretry_init doesn't need to return anything
Alan T. DeKok [Sun, 3 Mar 2024 15:28:44 +0000 (10:28 -0500)] 
retry_init doesn't need to return anything