]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoLook for ldap_interactive_sasl_bind, else we never build with sasl...
Arran Cudbard-Bell [Thu, 17 Nov 2022 22:57:09 +0000 (16:57 -0600)] 
Look for ldap_interactive_sasl_bind, else we never build with sasl...

2 years agofr_time_elapsed_fprint(): Fix tab space calculation (#4805)
Max Khon [Thu, 17 Nov 2022 22:39:54 +0000 (22:39 +0000)] 
fr_time_elapsed_fprint(): Fix tab space calculation (#4805)

Without the fix the output sometimes is improperly indented:
time.requests.100ms             28
time.requests.1s                        918
time.requests.10s               2408

2 years agoAdd support for recv_buff parameter (#4807)
Max Khon [Thu, 17 Nov 2022 22:38:00 +0000 (22:38 +0000)] 
Add support for recv_buff parameter (#4807)

2 years agoProduce an error if the initial search failed
Arran Cudbard-Bell [Thu, 17 Nov 2022 21:34:48 +0000 (15:34 -0600)] 
Produce an error if the initial search failed

2 years agoremove unnecessary assignment
Alan T. DeKok [Thu, 17 Nov 2022 21:09:35 +0000 (16:09 -0500)] 
remove unnecessary assignment

2 years agoModules have prefixes other than rlm_ now 🙄
Arran Cudbard-Bell [Thu, 17 Nov 2022 20:52:26 +0000 (14:52 -0600)] 
Modules have prefixes other than rlm_ now ðŸ™„

2 years agoallow attr names in update to have list references
Alan T. DeKok [Thu, 17 Nov 2022 18:07:13 +0000 (13:07 -0500)] 
allow attr names in update to have list references

because "update request" just changes the default list, it doesn't
require that list be used.

2 years agostart of cleanup
Alan T. DeKok [Thu, 17 Nov 2022 17:46:33 +0000 (12:46 -0500)] 
start of cleanup

2 years agoclean up and remove intermediate buffers
Alan T. DeKok [Thu, 17 Nov 2022 17:41:16 +0000 (12:41 -0500)] 
clean up and remove intermediate buffers

2 years agono parallel for you
Alan T. DeKok [Thu, 17 Nov 2022 15:09:18 +0000 (10:09 -0500)] 
no parallel for you

2 years agoRevert "We don't need this explicit linkage"
Arran Cudbard-Bell [Thu, 17 Nov 2022 19:56:37 +0000 (13:56 -0600)] 
Revert "We don't need this explicit linkage"

This reverts commit 99fd88ca8cd750654fdd661772b8d37ca469c1e7.

2 years agoWe don't need this explicit linkage
Arran Cudbard-Bell [Thu, 17 Nov 2022 19:42:52 +0000 (13:42 -0600)] 
We don't need this explicit linkage

2 years agoMore fixes
Arran Cudbard-Bell [Thu, 17 Nov 2022 19:27:25 +0000 (13:27 -0600)] 
More fixes

2 years agoRemove git marker from changelog
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:58:27 +0000 (12:58 -0600)] 
Remove git marker from changelog

2 years agoFix LDAP sync linking
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:23:40 +0000 (12:23 -0600)] 
Fix LDAP sync linking

2 years agoAdd the git market in to keep debian happy
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:19:34 +0000 (12:19 -0600)] 
Add the git market in to keep debian happy

2 years agoTypo
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:10:32 +0000 (12:10 -0600)] 
Typo

2 years agoClever short circuiting tricks don't seem to work everywhere
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:10:07 +0000 (12:10 -0600)] 
Clever short circuiting tricks don't seem to work everywhere

2 years agoQuiet ubsan
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:04:52 +0000 (12:04 -0600)] 
Quiet ubsan

2 years agoset email so we don't get prompted
Arran Cudbard-Bell [Thu, 17 Nov 2022 18:02:48 +0000 (12:02 -0600)] 
set email so we don't get prompted

2 years agoSpecify the debian package version using dch
Arran Cudbard-Bell [Thu, 17 Nov 2022 17:55:25 +0000 (11:55 -0600)] 
Specify the debian package version using dch

2 years agoTypo
Arran Cudbard-Bell [Thu, 17 Nov 2022 17:39:35 +0000 (11:39 -0600)] 
Typo

2 years agoDon't need to print the version string twice.
Arran Cudbard-Bell [Thu, 17 Nov 2022 17:34:49 +0000 (11:34 -0600)] 
Don't need to print the version string twice.

2 years agoUpdate versioning scheme to use commit depth for incrimental component
Arran Cudbard-Bell [Thu, 17 Nov 2022 17:30:05 +0000 (11:30 -0600)] 
Update versioning scheme to use commit depth for incrimental component

2 years agoFix return of xlat failure
Arran Cudbard-Bell [Thu, 17 Nov 2022 16:29:41 +0000 (10:29 -0600)] 
Fix return of xlat failure

2 years agoSimplify release parsing, add +git into git package versions
Arran Cudbard-Bell [Thu, 17 Nov 2022 16:24:54 +0000 (10:24 -0600)] 
Simplify release parsing, add +git into git package versions

2 years agoProduce git versioned .deb files
Arran Cudbard-Bell [Thu, 17 Nov 2022 16:09:29 +0000 (10:09 -0600)] 
Produce git versioned .deb files

2 years agoAdd explicit return types for xlat functions
Arran Cudbard-Bell [Thu, 17 Nov 2022 15:14:20 +0000 (09:14 -0600)] 
Add explicit return types for xlat functions

2 years agomore corner cases, as caught by ASAN
Alan T. DeKok [Thu, 17 Nov 2022 14:34:37 +0000 (09:34 -0500)] 
more corner cases, as caught by ASAN

2 years agomore cleanups
Alan T. DeKok [Thu, 17 Nov 2022 13:56:05 +0000 (08:56 -0500)] 
more cleanups

require that attributes always have leading &, and deal with the
consequences

2 years agobump up buffer size to shut up compiler
Alan T. DeKok [Wed, 16 Nov 2022 20:14:35 +0000 (15:14 -0500)] 
bump up buffer size to shut up compiler

2 years agoremove unused assignment
Alan T. DeKok [Wed, 16 Nov 2022 20:13:41 +0000 (15:13 -0500)] 
remove unused assignment

2 years agorun some edits under the new regime
Alan T. DeKok [Wed, 16 Nov 2022 18:44:20 +0000 (13:44 -0500)] 
run some edits under the new regime

The behavior which isn't yet converted is:

* giving "update list { ... }" and then a *different* list for
  an attribute inside of the update section.
  The new code doesn't like this, for good reason.

* assigning &request += &control[*]
  the new code doesn't expect to see the [*], and therefore
  just ignores the assignment.

* creating empty attributes if the RHS of an evaluate fails.
  The new code does nothing.

* using array indexes in LHS of assignment for sub-list,
  update foo { bar[1] = baz}.
  The new code doesn't allow it.

* some compile-time errors are produced at different locations

2 years agonotes on what needs fixing for new "auto-convert to edit"
Alan T. DeKok [Wed, 16 Nov 2022 18:43:55 +0000 (13:43 -0500)] 
notes on what needs fixing for new "auto-convert to edit"

2 years agomore cleanups and fixes for corner cases
Alan T. DeKok [Wed, 16 Nov 2022 18:13:04 +0000 (13:13 -0500)] 
more cleanups and fixes for corner cases

2 years agoforbid array references in sublists
Alan T. DeKok [Wed, 16 Nov 2022 18:02:40 +0000 (13:02 -0500)] 
forbid array references in sublists

&list := {
&foo[1] = "bar"
}

The edit code does not support this, because it doesn't really
make a lot of sense.  If we do need to support it, then the edit
code needs to be updated to support it.

Note that we can already do

&list.foo[1] = "bar"

so this limitation isn't much of an issue.  The problem comes when
doing multiple attribute assignments, and those using array indexes
inside of a sublist.  What does it mean when we do

&list := {
&foo[0] = "bar"
&foo[1] = "baz"
&foo[0] = "ugh"
}

What the heck is going on here?  The real answer is "don't do that"

2 years agoprint attributes in debug, not info level
Alan T. DeKok [Wed, 16 Nov 2022 17:50:54 +0000 (12:50 -0500)] 
print attributes in debug, not info level

2 years agodon't need " \" at EOL any more
Alan T. DeKok [Wed, 16 Nov 2022 15:11:25 +0000 (10:11 -0500)] 
don't need " \" at EOL any more

2 years agouse test_fail instead of "fail"
Alan T. DeKok [Wed, 16 Nov 2022 15:07:35 +0000 (10:07 -0500)] 
use test_fail instead of "fail"

2 years agocatch more corner cases
Alan T. DeKok [Wed, 16 Nov 2022 14:43:31 +0000 (09:43 -0500)] 
catch more corner cases

update {
&Foo = bar
}

should use "list_def"

2 years agothis depends on edit, too
Alan T. DeKok [Wed, 16 Nov 2022 13:48:39 +0000 (08:48 -0500)] 
this depends on edit, too

2 years agoforbid update in most places
Alan T. DeKok [Wed, 16 Nov 2022 12:57:40 +0000 (07:57 -0500)] 
forbid update in most places

except tests which actually use update

The bext step is to take all of the update tests, and run them
twice.  once as normal, and once with "-S rewrite_update=yes"

2 years agoadd migration configuration to forbid the use of "update"
Alan T. DeKok [Wed, 16 Nov 2022 12:57:23 +0000 (07:57 -0500)] 
add migration configuration to forbid the use of "update"

2 years agoauto-convert update sections.
Alan T. DeKok [Wed, 16 Nov 2022 12:36:12 +0000 (07:36 -0500)] 
auto-convert update sections.

via some pretty disgusting methods.  But it's not a lot of code,
and it catches the common use-cases.

2 years agobetter error messages
Alan T. DeKok [Wed, 16 Nov 2022 11:43:31 +0000 (06:43 -0500)] 
better error messages

2 years agobetter error message
Alan T. DeKok [Wed, 16 Nov 2022 11:42:24 +0000 (06:42 -0500)] 
better error message

2 years agotemporary hack to set name2_quote
Alan T. DeKok [Wed, 16 Nov 2022 11:42:06 +0000 (06:42 -0500)] 
temporary hack to set name2_quote

2 years agoquit coverity. Fixes CID #1516908
Alan T. DeKok [Tue, 15 Nov 2022 20:45:43 +0000 (15:45 -0500)] 
quit coverity.  Fixes CID #1516908

2 years agoadd main_config_migrate_option_get()
Alan T. DeKok [Tue, 15 Nov 2022 15:11:04 +0000 (10:11 -0500)] 
add main_config_migrate_option_get()

so that various things in the code can query what they should do,
without having global variables all over the place

2 years agoadd cf_item_insert_after()
Alan T. DeKok [Tue, 15 Nov 2022 15:10:36 +0000 (10:10 -0500)] 
add cf_item_insert_after()

for use with automagically rewriting edit sections

2 years agoPackage process_dhcp*.so with dhcp module
Nick Porter [Thu, 17 Nov 2022 10:05:21 +0000 (10:05 +0000)] 
Package process_dhcp*.so with dhcp module

2 years agoEnsure module specific process_foo*.so are not packaged in freeradius package
Nick Porter [Thu, 17 Nov 2022 09:48:23 +0000 (09:48 +0000)] 
Ensure module specific process_foo*.so are not packaged in freeradius package

2 years agorlm_sql_foo goes in package freeradius-foo not freeradius-sql-foo
Nick Porter [Thu, 17 Nov 2022 09:47:34 +0000 (09:47 +0000)] 
rlm_sql_foo goes in package freeradius-foo not freeradius-sql-foo

2 years agoAdd recv_buff option to proto_ldap_sync
Nick Porter [Wed, 16 Nov 2022 09:04:18 +0000 (09:04 +0000)] 
Add recv_buff option to proto_ldap_sync

2 years agoAdd more ldap sync stuff to debian packages
Arran Cudbard-Bell [Wed, 16 Nov 2022 23:28:15 +0000 (17:28 -0600)] 
Add more ldap sync stuff to debian packages

2 years agoPackage libfreeradius-ldap
Arran Cudbard-Bell [Wed, 16 Nov 2022 22:42:30 +0000 (16:42 -0600)] 
Package libfreeradius-ldap

2 years agoAdd XLAT_ARGS helper macro to pull xlat arguments from the input list
Arran Cudbard-Bell [Tue, 15 Nov 2022 19:15:51 +0000 (13:15 -0600)] 
Add XLAT_ARGS helper macro to pull xlat arguments from the input list

2 years agoAdd type specific dcursors for value boxes
Arran Cudbard-Bell [Tue, 15 Nov 2022 14:22:55 +0000 (08:22 -0600)] 
Add type specific dcursors for value boxes

Doesn't perform any refactoring, just defines the types

2 years agoFail on internal exec error
Arran Cudbard-Bell [Tue, 15 Nov 2022 14:20:43 +0000 (08:20 -0600)] 
Fail on internal exec error

2 years agoreorganization
Alan T. DeKok [Tue, 15 Nov 2022 11:24:35 +0000 (06:24 -0500)] 
reorganization

2 years agotypo
Alan T. DeKok [Tue, 15 Nov 2022 11:12:53 +0000 (06:12 -0500)] 
typo

2 years agoadd documentation for limit and timeout
Alan T. DeKok [Tue, 15 Nov 2022 11:01:39 +0000 (06:01 -0500)] 
add documentation for limit and timeout

2 years agoonly insert instructions which have thread alloc / instantiate
Alan T. DeKok [Tue, 15 Nov 2022 10:40:09 +0000 (05:40 -0500)] 
only insert instructions which have thread alloc / instantiate

2 years agoMore verbose sanity checks
Arran Cudbard-Bell [Tue, 15 Nov 2022 00:06:31 +0000 (18:06 -0600)] 
More verbose sanity checks

2 years agoUse type safe functions for value box lists
Arran Cudbard-Bell [Mon, 14 Nov 2022 23:04:00 +0000 (17:04 -0600)] 
Use type safe functions for value box lists

2 years agoadd "limit" keyword
Alan T. DeKok [Mon, 14 Nov 2022 22:13:27 +0000 (17:13 -0500)] 
add "limit" keyword

2 years agoinsert instructions into the unlang_instruction_tree
Alan T. DeKok [Mon, 14 Nov 2022 22:06:28 +0000 (17:06 -0500)] 
insert instructions into the unlang_instruction_tree

2 years agoadd unlang_thread_instance()
Alan T. DeKok [Mon, 14 Nov 2022 21:40:56 +0000 (16:40 -0500)] 
add unlang_thread_instance()

which for now is only called from the "limit" keyword.

The thread instance data could arguably go into the stack frame,
but 99.9% of the stack frames won't use it.  So for now we just
make the users call it manually

2 years agothread_instantiate may be NULL
Alan T. DeKok [Mon, 14 Nov 2022 21:39:51 +0000 (16:39 -0500)] 
thread_instantiate may be NULL

but we may still have thread instance data, which is just
counters

2 years agoremove unnecessary debug message
Alan T. DeKok [Mon, 14 Nov 2022 20:25:09 +0000 (15:25 -0500)] 
remove unnecessary debug message

2 years agoclose sockfd on error. Fixes CID #1516897
Alan T. DeKok [Mon, 14 Nov 2022 20:23:09 +0000 (15:23 -0500)] 
close sockfd on error.  Fixes CID #1516897

2 years agoallow tmpls as arguments for timeout
Alan T. DeKok [Mon, 14 Nov 2022 15:34:04 +0000 (10:34 -0500)] 
allow tmpls as arguments for timeout

2 years agoadd timeout keyword
Alan T. DeKok [Mon, 14 Nov 2022 15:09:13 +0000 (10:09 -0500)] 
add timeout keyword

2 years agoAlways initialise the output PID even on error
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:57:57 +0000 (10:57 -0600)] 
Always initialise the output PID even on error

2 years agoFix the exec legacy header to stop vscode complaining
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:50:19 +0000 (10:50 -0600)] 
Fix the exec legacy header to stop vscode complaining

2 years agoEnsure we use all the arguments
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:45:58 +0000 (10:45 -0600)] 
Ensure we use all the arguments

2 years agoQuiet deprecated warnings for macos
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:45:07 +0000 (10:45 -0600)] 
Quiet deprecated warnings for macos

2 years agoMore uncommitted sbuff notes
Arran Cudbard-Bell [Mon, 14 Nov 2022 16:44:40 +0000 (10:44 -0600)] 
More uncommitted sbuff notes

2 years agoCheck return from fr_dict_unknown_attr_afrom_num() (CID #1503891) (#4748)
James Jones [Mon, 14 Nov 2022 15:24:24 +0000 (09:24 -0600)] 
Check return from fr_dict_unknown_attr_afrom_num() (CID #1503891) (#4748)

2 years agoMake correct changes to deal with toctou issues (CIDs below) (#4793)
James Jones [Mon, 14 Nov 2022 15:22:53 +0000 (09:22 -0600)] 
Make correct changes to deal with toctou issues (CIDs below) (#4793)

12713071445217: use *at() calls to work around toctou

2 years agoDon't compare with bounds in SBUFF_PARSE_[U]INT_DEF (CIDs 15040045, 1504004) (#4794)
James Jones [Mon, 14 Nov 2022 15:01:11 +0000 (09:01 -0600)] 
Don't compare with bounds in SBUFF_PARSE_[U]INT_DEF (CIDs 150400451504004) (#4794)

Explicit comparison with the bounds makes sense but when you hit
the type the underlying conversion function uses, it's pointless,
and when it's part of a larger expression, coverity considers it
a possible coding error.

So... rather than doing an explicit comparison, we use the following
characterization: it's an error if the cast to the desired type changes
the value. To distinguish between overflow and underflow for signed
integer types, overflow happens if the cast value is less than the
return from strtoll(), underflow if it's greater.

2 years agoallow digits, in name2, too.
Alan T. DeKok [Mon, 14 Nov 2022 14:52:37 +0000 (09:52 -0500)] 
allow digits, in name2, too.

mostly for "timeout"

2 years agomove counters to callbacks
Alan T. DeKok [Mon, 14 Nov 2022 14:52:26 +0000 (09:52 -0500)] 
move counters to callbacks

where they're correct, rather than using ad-hoc and in-line things

2 years agoexpose frame_signal for use in timeout keyword
Alan T. DeKok [Mon, 14 Nov 2022 14:51:38 +0000 (09:51 -0500)] 
expose frame_signal for use in timeout keyword

2 years agoif max_rtx_foo is defined, it has to be >0 time duration
Alan T. DeKok [Mon, 14 Nov 2022 12:06:53 +0000 (07:06 -0500)] 
if max_rtx_foo is defined, it has to be >0 time duration

2 years agodocument actions and retries
Alan T. DeKok [Mon, 14 Nov 2022 11:58:03 +0000 (06:58 -0500)] 
document actions and retries

2 years agoflag TBD
Alan T. DeKok [Sun, 13 Nov 2022 18:52:19 +0000 (13:52 -0500)] 
flag TBD

2 years agodon't use "update"
Alan T. DeKok [Thu, 27 Oct 2022 20:09:36 +0000 (16:09 -0400)] 
don't use "update"

2 years agoFix redis_ippool behaviour on DHCPv6 solicit
Arran Cudbard-Bell [Mon, 14 Nov 2022 05:46:12 +0000 (23:46 -0600)] 
Fix redis_ippool behaviour on DHCPv6 solicit

2 years agoAlign trigger_exec() prototype with function definition
Nick Porter [Wed, 9 Nov 2022 15:45:23 +0000 (15:45 +0000)] 
Align trigger_exec() prototype with function definition

2 years agoEnsure rate limited triggers are fired on first occurrence
Nick Porter [Wed, 9 Nov 2022 15:43:34 +0000 (15:43 +0000)] 
Ensure rate limited triggers are fired on first occurrence

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:28 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:25 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:21 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:19 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:15 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:13 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:10 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Sat, 5 Nov 2022 09:40:06 +0000 (09:40 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoHandle timeout from ldap_results() when performing persistent searches
Nick Porter [Fri, 4 Nov 2022 16:52:11 +0000 (16:52 +0000)] 
Handle timeout from ldap_results() when performing persistent searches