]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 years agoCI: remove debugging
Matthew Newton [Fri, 14 Oct 2022 16:48:25 +0000 (17:48 +0100)] 
CI: remove debugging

2 years agoCI: install git-lfs early, too
Matthew Newton [Fri, 14 Oct 2022 14:47:04 +0000 (15:47 +0100)] 
CI: install git-lfs early, too

2 years agoExplicitly ignore fr_event_timer_in() return value (CID #1503936) (#4769)
James Jones [Fri, 14 Oct 2022 14:14:44 +0000 (09:14 -0500)] 
Explicitly ignore fr_event_timer_in() return value (CID #1503936) (#4769)

fr_event_timer_in() (actually _fr_event_timer_at()) reuses events
where possible, and being in the idle timeout means that there is
such an event available for reuse.

2 years agoCI: Tidy home directory in Docker
Matthew Newton [Fri, 14 Oct 2022 12:32:05 +0000 (13:32 +0100)] 
CI: Tidy home directory in Docker

2 years agoCI: ruby/setup-ruby broken in GitHub container right now
Matthew Newton [Thu, 13 Oct 2022 16:18:40 +0000 (17:18 +0100)] 
CI: ruby/setup-ruby broken in GitHub container right now

2 years agoCI: for the time being run on both GitHub and self-hosted
Matthew Newton [Thu, 13 Oct 2022 14:45:22 +0000 (15:45 +0100)] 
CI: for the time being run on both GitHub and self-hosted

2 years agoCI: fixups to use 389ds in Docker container
Matthew Newton [Wed, 12 Oct 2022 23:03:50 +0000 (00:03 +0100)] 
CI: fixups to use 389ds in Docker container

2 years agoCI: use vars to set llvm/gcc versions
Matthew Newton [Mon, 10 Oct 2022 13:34:35 +0000 (14:34 +0100)] 
CI: use vars to set llvm/gcc versions

2 years agoCI: move fuzzer tests to separate composite action
Matthew Newton [Thu, 13 Oct 2022 14:02:19 +0000 (15:02 +0100)] 
CI: move fuzzer tests to separate composite action

2 years agoCI: move main tests to separate composite action
Matthew Newton [Thu, 13 Oct 2022 11:33:47 +0000 (12:33 +0100)] 
CI: move main tests to separate composite action

2 years agoCI: move build process to separate composite action
Matthew Newton [Wed, 12 Oct 2022 22:47:02 +0000 (23:47 +0100)] 
CI: move build process to separate composite action

2 years agoCI: prepare Docker image more like GitHub runner
Matthew Newton [Wed, 12 Oct 2022 22:54:22 +0000 (23:54 +0100)] 
CI: prepare Docker image more like GitHub runner

2 years agoCI: run in Docker and add test service containers
Matthew Newton [Wed, 12 Oct 2022 21:52:15 +0000 (22:52 +0100)] 
CI: run in Docker and add test service containers

- mariadb
- postgres
- redis
- 389ds

2 years agoCI: add matrix.os to set where jobs run
Matthew Newton [Wed, 12 Oct 2022 19:58:37 +0000 (20:58 +0100)] 
CI: add matrix.os to set where jobs run

2 years agoCI: move macOS to a separate job
Matthew Newton [Wed, 12 Oct 2022 19:57:40 +0000 (20:57 +0100)] 
CI: move macOS to a separate job

2 years agoCI: actions/setup-ruby is deprecated
Matthew Newton [Thu, 13 Oct 2022 13:48:03 +0000 (14:48 +0100)] 
CI: actions/setup-ruby is deprecated

2 years agoCI: explicitly enable developer mode
Matthew Newton [Mon, 10 Oct 2022 15:18:00 +0000 (16:18 +0100)] 
CI: explicitly enable developer mode

2 years agoCI: fix YAML whitespace
Matthew Newton [Thu, 13 Oct 2022 09:58:42 +0000 (10:58 +0100)] 
CI: fix YAML whitespace

2 years agorlm_sql_oracle: Fix typo (#4765)
Jorge Pereira [Thu, 13 Oct 2022 02:16:34 +0000 (23:16 -0300)] 
rlm_sql_oracle: Fix typo (#4765)

2 years agoSuppress MacOS ld warning from native compilation (#4766)
Jorge Pereira [Wed, 12 Oct 2022 12:50:00 +0000 (09:50 -0300)] 
Suppress MacOS ld warning from native compilation (#4766)

Add the option '-Wl,-w' as suggested in https://issues.guix.gnu.org/issue/57849

2 years agoImprove queries for processing radacct into periodic usage data
Nick Porter [Wed, 12 Oct 2022 10:37:17 +0000 (11:37 +0100)] 
Improve queries for processing radacct into periodic usage data

Removing `OR` from the query allows better index usage

2 years agoTypo
Nick Porter [Wed, 12 Oct 2022 10:32:55 +0000 (11:32 +0100)] 
Typo

2 years agoFix typo (#4763)
Jorge Pereira [Tue, 11 Oct 2022 20:54:30 +0000 (17:54 -0300)] 
Fix typo (#4763)

2 years agoeapol_test: Add paths for Brew on OSX/M1 (#4757)
Jorge Pereira [Thu, 6 Oct 2022 17:45:37 +0000 (14:45 -0300)] 
eapol_test: Add paths for Brew on OSX/M1 (#4757)

Needed for the Brew running on OSX/M1 due to the new base path is in /opt/homebrew
as described on https://earthly.dev/blog/homebrew-on-m1/

2 years agoMake plain 'autoconf' 'autoheader' 'autoupdate' invocations work again
Arran Cudbard-Bell [Thu, 6 Oct 2022 04:02:52 +0000 (00:02 -0400)] 
Make plain 'autoconf' 'autoheader' 'autoupdate' invocations work again

Reading the autoconf docs the preferred way to do includes is to set `AC_CONFIG_MACRO_DIR([m4])` then run aclocal to figure out which .m4 files need including.

Check the size of time_t so we can determine if we're going to overflow it...

2 years agofr_perror should accept a NULL fmt string
Arran Cudbard-Bell [Wed, 5 Oct 2022 14:15:44 +0000 (10:15 -0400)] 
fr_perror should accept a NULL fmt string

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar
github-actions[bot] [Wed, 5 Oct 2022 09:49:16 +0000 (09:49 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv4.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar
github-actions[bot] [Wed, 5 Oct 2022 09:49:13 +0000 (09:49 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/radius.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar
github-actions[bot] [Wed, 5 Oct 2022 09:49:03 +0000 (09:49 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/vmps.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar
github-actions[bot] [Wed, 5 Oct 2022 09:49:01 +0000 (09:49 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tacacs.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar
github-actions[bot] [Wed, 5 Oct 2022 09:48:57 +0000 (09:48 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dns.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar
github-actions[bot] [Wed, 5 Oct 2022 09:48:55 +0000 (09:48 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/dhcpv6.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar
github-actions[bot] [Wed, 5 Oct 2022 09:48:46 +0000 (09:48 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/util.tar

2 years agoScheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar
github-actions[bot] [Wed, 5 Oct 2022 09:48:43 +0000 (09:48 +0000)] 
Scheduled fuzzing: Update src/tests/fuzzer-corpus/tftp.tar

2 years agoAlways pass in line numbers
Arran Cudbard-Bell [Wed, 5 Oct 2022 03:55:32 +0000 (23:55 -0400)] 
Always pass in line numbers

2 years agoActually commit the strerror functions.
Arran Cudbard-Bell [Wed, 5 Oct 2022 03:44:25 +0000 (23:44 -0400)] 
Actually commit the strerror functions.

2 years agoConvert more TLS functions to strerror style
Arran Cudbard-Bell [Wed, 5 Oct 2022 03:37:16 +0000 (23:37 -0400)] 
Convert more TLS functions to strerror style

2 years agotry to quiet compiler
Alan T. DeKok [Tue, 4 Oct 2022 14:10:20 +0000 (10:10 -0400)] 
try to quiet compiler

2 years agoAdd "strerror" variants of more logging functions
Arran Cudbard-Bell [Tue, 4 Oct 2022 05:12:19 +0000 (01:12 -0400)] 
Add "strerror" variants of more logging functions

This means the TLS library functions can integrate better with the different logging facilities, allowing us to print chain errors in the context of a conf item (for example)

2 years agoNot enabled if we don't have any request
Arran Cudbard-Bell [Tue, 4 Oct 2022 04:47:46 +0000 (00:47 -0400)] 
Not enabled if we don't have any request

2 years agoThe less awful method of getting src information from OpenSSL
Arran Cudbard-Bell [Tue, 4 Oct 2022 03:05:36 +0000 (23:05 -0400)] 
The less awful method of getting src information from OpenSSL

2 years agoRecord the file and line for strerror calls
Arran Cudbard-Bell [Tue, 4 Oct 2022 03:03:18 +0000 (23:03 -0400)] 
Record the file and line for strerror calls

Only accessible via the debugger for now

2 years agoJust use the printf functions to produce tls errors
Arran Cudbard-Bell [Tue, 4 Oct 2022 01:26:22 +0000 (21:26 -0400)] 
Just use the printf functions to produce tls errors

2 years agoAdd 'v' variants to strerror logging functions
Arran Cudbard-Bell [Tue, 4 Oct 2022 00:27:32 +0000 (20:27 -0400)] 
Add 'v' variants to strerror logging functions

2 years agoMore "update {....}" to edit against src/tests/modules/* (#4735)
Jorge Pereira [Mon, 3 Oct 2022 13:04:32 +0000 (15:04 +0200)] 
More "update {....}" to edit against src/tests/modules/* (#4735)

2 years agoremove use of locate(1) from configure scripts
Matthew Newton [Mon, 3 Oct 2022 12:34:49 +0000 (13:34 +0100)] 
remove use of locate(1) from configure scripts

2 years agoRemove extra semicolons at ends of statements and declarations (#4751)
James Jones [Mon, 3 Oct 2022 12:43:50 +0000 (07:43 -0500)] 
Remove extra semicolons at ends of statements and declarations (#4751)

Found one while looking through coverity defects, and decided to
take a few minutes with grep and an editor to get rid of them all.

2 years agorefresh configure scripts
Matthew Newton [Sun, 2 Oct 2022 17:07:59 +0000 (18:07 +0100)] 
refresh configure scripts

2 years agoshow optional module build features in configure report
Matthew Newton [Sat, 1 Oct 2022 16:28:14 +0000 (17:28 +0100)] 
show optional module build features in configure report

2 years agouse m4 macro to set module fail state
Matthew Newton [Sat, 1 Oct 2022 15:29:55 +0000 (16:29 +0100)] 
use m4 macro to set module fail state

2 years agotidy and standardise format of module configure.ac files
Matthew Newton [Sat, 1 Oct 2022 10:43:50 +0000 (11:43 +0100)] 
tidy and standardise format of module configure.ac files

2 years agorework all whitespace in module configure.ac files
Matthew Newton [Sat, 1 Oct 2022 10:41:49 +0000 (11:41 +0100)] 
rework all whitespace in module configure.ac files

2 years agomodule autoconf depends on toplevel m4 macros
Matthew Newton [Sat, 1 Oct 2022 09:31:01 +0000 (10:31 +0100)] 
module autoconf depends on toplevel m4 macros

2 years agoupdate configure.ac and nice report for libraries, too
Matthew Newton [Sat, 1 Oct 2022 13:05:19 +0000 (14:05 +0100)] 
update configure.ac and nice report for libraries, too

2 years agoautoconf macros for tidying module config
Matthew Newton [Fri, 30 Sep 2022 15:53:07 +0000 (16:53 +0100)] 
autoconf macros for tidying module config

Add a nice report at the _end_ of configure, so there's no excuse
of missing a "silently unconfigured" module any more.

2 years agoexpand missing variables
Matthew Newton [Fri, 30 Sep 2022 20:36:28 +0000 (21:36 +0100)] 
expand missing variables

2 years agoinitial attempt at statistics handling
Alan T. DeKok [Thu, 29 Sep 2022 21:29:29 +0000 (17:29 -0400)] 
initial attempt at statistics handling

2 years agorename "is_counter" to "counter"
Alan T. DeKok [Thu, 29 Sep 2022 21:15:41 +0000 (17:15 -0400)] 
rename "is_counter" to "counter"

and add it to the flags being printed

2 years agoadd fr_value_box_memcpy_in()
Alan T. DeKok [Thu, 29 Sep 2022 13:34:38 +0000 (09:34 -0400)] 
add fr_value_box_memcpy_in()

which mirrors fr_value_box_memcpy_out()

2 years agotime_delta can be counter, too
Alan T. DeKok [Mon, 26 Sep 2022 16:24:42 +0000 (12:24 -0400)] 
time_delta can be counter, too

2 years agorefresh configure.ac files suggested by autoupdate
Matthew Newton [Thu, 29 Sep 2022 15:50:11 +0000 (16:50 +0100)] 
refresh configure.ac files suggested by autoupdate

2 years agorefresh configure scripts
Matthew Newton [Thu, 29 Sep 2022 12:18:01 +0000 (13:18 +0100)] 
refresh configure scripts

2 years agomake target to force refresh of all configure scripts
Matthew Newton [Thu, 29 Sep 2022 11:53:50 +0000 (12:53 +0100)] 
make target to force refresh of all configure scripts

2 years agoforce build autoconf files
Matthew Newton [Thu, 29 Sep 2022 11:46:14 +0000 (12:46 +0100)] 
force build autoconf files

so make sees updated timestamps, even if nothing actually changed

2 years agofix make reconfig so it rebuilds all.mk files
Matthew Newton [Thu, 29 Sep 2022 11:46:54 +0000 (12:46 +0100)] 
fix make reconfig so it rebuilds all.mk files

2 years agoaclocal.m4 and acinclude.m4 are now gone
Matthew Newton [Thu, 29 Sep 2022 11:33:27 +0000 (12:33 +0100)] 
aclocal.m4 and acinclude.m4 are now gone

2 years agofix autoconf underquoted warning
Matthew Newton [Thu, 29 Sep 2022 10:38:02 +0000 (11:38 +0100)] 
fix autoconf underquoted warning

2 years agoadjust all AC_PREREQ
Matthew Newton [Thu, 29 Sep 2022 10:36:30 +0000 (11:36 +0100)] 
adjust all AC_PREREQ

nobody should be using anything before 2.69 now, it's 10 years
old, and 2.71 isn't available on all systems yet

2 years agoadd FR_INIT_MODULE autoconf macro
Matthew Newton [Thu, 29 Sep 2022 09:21:39 +0000 (10:21 +0100)] 
add FR_INIT_MODULE autoconf macro

helps with consistency and saves duplication

2 years agomove module m4 macros to top-level m4 directory
Matthew Newton [Thu, 29 Sep 2022 08:45:55 +0000 (09:45 +0100)] 
move module m4 macros to top-level m4 directory

2 years agosplit acinclude.m4 into separate files in m4/
Matthew Newton [Thu, 29 Sep 2022 08:44:44 +0000 (09:44 +0100)] 
split acinclude.m4 into separate files in m4/

2 years agore-add the rule that actually lets make reconfig work for modules
Matthew Newton [Thu, 29 Sep 2022 09:03:01 +0000 (10:03 +0100)] 
re-add the rule that actually lets make reconfig work for modules

2 years agouse aclocal to regenerate aclocal.m4 on the fly
Matthew Newton [Thu, 29 Sep 2022 09:08:57 +0000 (10:08 +0100)] 
use aclocal to regenerate aclocal.m4 on the fly

this means we can also remove m4_include, as aclocal will search
for all required macros

2 years agoshouldn't need this hack any more
Matthew Newton [Thu, 29 Sep 2022 08:35:15 +0000 (09:35 +0100)] 
shouldn't need this hack any more

2 years agoWork around for debian sid not reporting codename with lsb_release
Nick Porter [Wed, 28 Sep 2022 10:27:03 +0000 (11:27 +0100)] 
Work around for debian sid not reporting codename with lsb_release

There is a known debian bug #1020893

2 years agoEnsure consistent llvm version is installed on MacOS
Nick Porter [Wed, 28 Sep 2022 09:51:53 +0000 (10:51 +0100)] 
Ensure consistent llvm version is installed on MacOS

2 years agoRemove unnecessary ;
Nick Porter [Wed, 28 Sep 2022 09:09:53 +0000 (10:09 +0100)] 
Remove unnecessary ;

2 years agodocs
Nick Porter [Tue, 27 Sep 2022 15:55:43 +0000 (16:55 +0100)] 
docs

2 years agoAdd type specific dcursors (#4747)
Nick Porter [Tue, 27 Sep 2022 13:41:25 +0000 (14:41 +0100)] 
Add type specific dcursors (#4747)

* Add macros to generate type-safe wrappers for dcursor functions

* Add tests for type-safe dcursors

2 years agoAdd tests of fr_dcursor_set_current() and fr_dcursor_free_item()
Nick Porter [Tue, 27 Sep 2022 09:45:05 +0000 (10:45 +0100)] 
Add tests of fr_dcursor_set_current() and fr_dcursor_free_item()

2 years agoAnnotated two false positive dereferences (CIDS #1506638, #1506635) (#4741)
James Jones [Mon, 26 Sep 2022 23:33:12 +0000 (18:33 -0500)] 
Annotated two false positive dereferences (CIDS #1506638, #1506635) (#4741)

Two overlooked cases in which the caller knows that the dlist
entries in fact exist.

2 years agoCheck fr_openssl_init() return in fr_aka_sim_init() (CID #1504435) (#4746)
James Jones [Mon, 26 Sep 2022 23:32:52 +0000 (18:32 -0500)] 
Check fr_openssl_init() return in fr_aka_sim_init() (CID #1504435) (#4746)

Curiously, coverity is no longer noticing this defect, but it
seems like a real bug nonetheless.

2 years agotrack currently running / yielded instructions
Alan T. DeKok [Mon, 26 Sep 2022 16:20:49 +0000 (12:20 -0400)] 
track currently running / yielded instructions

2 years agorework perf calls
Alan T. DeKok [Sun, 25 Sep 2022 13:27:41 +0000 (09:27 -0400)] 
rework perf calls

to catch cases of retry / yield / abort / etc.

2 years agodon't shift by 64. Fixes Coverity #1515536 and #1515537
Alan T. DeKok [Sat, 24 Sep 2022 22:48:06 +0000 (18:48 -0400)] 
don't shift by 64.  Fixes Coverity #1515536 and #1515537

2 years agodo time tracking per frame
Alan T. DeKok [Sat, 24 Sep 2022 12:34:30 +0000 (08:34 -0400)] 
do time tracking per frame

and only add it to the instruction totals when the frame is done

2 years agouse fr_time_tracking for the time tracking.
Alan T. DeKok [Fri, 23 Sep 2022 16:30:49 +0000 (12:30 -0400)] 
use fr_time_tracking for the time tracking.

if it's good enough for modules, it's good enough for the interpreter

Which now lets it track yielded time, too.

We still have some @todo, which is to track parent frames, so
that when a child yields, we mark the parent as yielded too

2 years agowe don't need a parent for time tracking.
Alan T. DeKok [Fri, 23 Sep 2022 16:29:42 +0000 (12:29 -0400)] 
we don't need a parent for time tracking.

2 years agofix compiler errors
Alan T. DeKok [Fri, 23 Sep 2022 14:15:05 +0000 (10:15 -0400)] 
fix compiler errors

2 years agoAdd benchmark for fr_time
Arran Cudbard-Bell [Fri, 23 Sep 2022 14:01:10 +0000 (10:01 -0400)] 
Add benchmark for fr_time

2 years agoclean up integer calculations
Alan T. DeKok [Thu, 22 Sep 2022 18:46:00 +0000 (14:46 -0400)] 
clean up integer calculations

simplify the process of hinting, and always upcast intermediate
integers to int64_t or uint64_t.  That way the result is much more
likely to be representable

2 years agoMake sure we don't overrun implib_file (CID #1504299) (#4739)
James Jones [Fri, 23 Sep 2022 11:45:35 +0000 (06:45 -0500)] 
Make sure we don't overrun implib_file (CID #1504299) (#4739)

def_file wasn't the only fixed-size buffer in jlibtool.

2 years agoCheck fr_unlink() return in radsniff (CID #1504435&) (#4740)
James Jones [Fri, 23 Sep 2022 11:45:17 +0000 (06:45 -0500)] 
Check fr_unlink() return in radsniff (CID #1504435&) (#4740)

2 years agoinitialize buff to placate coverity (CIDs #1503942, #1504042) (#4738)
James Jones [Fri, 23 Sep 2022 11:45:02 +0000 (06:45 -0500)] 
initialize buff to placate coverity (CIDs #1503942, #1504042) (#4738)

Coverity doesn't realize that fr_sbuff_out_bstrncpy_allowed()
will put something in buff, if only a NUL terminator. Until
coverity sees annotations in macro definitions, the only way
I know of to avoid the false positive "uninit_use_in_call"
defects in SBUFF_PARSE_FLOAT_DEF()-generated functions is to
actually initialize buff.

2 years agominor rearrangement
Alan T. DeKok [Thu, 22 Sep 2022 12:53:40 +0000 (08:53 -0400)] 
minor rearrangement

2 years agoupdate operator precedence (and tests)
Alan T. DeKok [Thu, 22 Sep 2022 12:42:53 +0000 (08:42 -0400)] 
update operator precedence (and tests)

2 years agoMore convert 'update' to 'edit' (#4724)
Jorge Pereira [Wed, 21 Sep 2022 18:18:37 +0000 (19:18 +0100)] 
More convert 'update' to 'edit' (#4724)

* More convert 'update' to 'edit' against EAPOL tests

* More convert 'update' to 'edit' against bin tests

* More convert 'update' to 'edit' against TACACS tests

* More convert 'update' to 'edit' against AUTH tests

* More convert 'update' to 'edit' against DIGEST tests

* More convert 'update' to 'edit' against PERFORMANCE tests

* More convert 'update' to 'edit' against RADCLIENT tests

* More convert 'update' to 'edit' against VMPS tests

* More convert 'update' to 'edit' against XLAT tests

2 years agoAnnotate calls we know won't fail (CID #1503939) (#4722)
James Jones [Wed, 21 Sep 2022 13:53:39 +0000 (08:53 -0500)] 
Annotate calls we know won't fail (CID #1503939) (#4722)

The individual tests in edit_tests all operate on a three-element
pair list they get from add_pairs(), freeing it after they're done.
fr_pair_afrom_da() only returns NULL if it runs out of memory--
unlikely in this context, so we annotate the calls that add items
to the list.

2 years agoAnnotate false positive tainted data in fr_udp_header_check() (CID #1504068) (#4728)
James Jones [Wed, 21 Sep 2022 13:53:21 +0000 (08:53 -0500)] 
Annotate false positive tainted data in fr_udp_header_check() (CID #1504068) (#4728)

Coverity doesn't recognize the check that diff == 0 as a check of
udp_len.

2 years agoCheck def file name against def_file size (CID #1504299) (#4731)
James Jones [Wed, 21 Sep 2022 13:53:04 +0000 (08:53 -0500)] 
Check def file name against def_file size (CID #1504299) (#4731)

The check needed to be there... if coverity doesn't realize that
we are now checking, it will still need annotation.