]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 years agoIgnore compile commands (it's system specific)
Arran Cudbard-Bell [Mon, 27 Jun 2022 20:16:26 +0000 (15:16 -0500)] 
Ignore compile commands (it's system specific)

3 years ago-4 is a number, not a function unary_minus(4)
Alan T. DeKok [Mon, 27 Jun 2022 18:21:51 +0000 (14:21 -0400)] 
-4 is a number, not a function unary_minus(4)

Which helps a bit with optimization.

3 years agosimplification
Alan T. DeKok [Sat, 25 Jun 2022 13:43:25 +0000 (09:43 -0400)] 
simplification

3 years agocomplain about poorly formed expressions
Alan T. DeKok [Fri, 24 Jun 2022 12:32:32 +0000 (08:32 -0400)] 
complain about poorly formed expressions

!foo == bar

is really

(!foo) == bar

due to operator precedence rules.  So we complain about this,
and force the user to be clearer, and to use the parantheses

3 years agoclear errors before each command
Alan T. DeKok [Fri, 24 Jun 2022 12:31:47 +0000 (08:31 -0400)] 
clear errors before each command

to avoid spurious errors which are left over from previous commands

3 years agohoist casts when hoisting xlats
Alan T. DeKok [Thu, 23 Jun 2022 19:50:38 +0000 (15:50 -0400)] 
hoist casts when hoisting xlats

and update tests which now have casts all over the place

3 years agosave the rcode for consumption by the xlat expressions
Alan T. DeKok [Thu, 23 Jun 2022 13:50:39 +0000 (09:50 -0400)] 
save the rcode for consumption by the xlat expressions

3 years agoQuiet issue with sign comparisons
Arran Cudbard-Bell [Mon, 27 Jun 2022 14:06:30 +0000 (09:06 -0500)] 
Quiet issue with sign comparisons

3 years agogit-archive submodules when creating source tarball (#4586)
Max Khon [Mon, 27 Jun 2022 12:35:17 +0000 (15:35 +0300)] 
git-archive submodules when creating source tarball (#4586)

3 years agoSync "git for-each-ref" output parsing with other Dockerfile.deps (#4584)
Max Khon [Mon, 27 Jun 2022 12:34:58 +0000 (15:34 +0300)] 
Sync "git for-each-ref" output parsing with other Dockerfile.deps (#4584)

3 years ago- Allow to specify additional rpmbuild flags (RPMBUILD_FLAGS) (#4585)
Max Khon [Sun, 26 Jun 2022 15:27:27 +0000 (18:27 +0300)] 
- Allow to specify additional rpmbuild flags (RPMBUILD_FLAGS) (#4585)

- Allow non-root builds (by specifying SUDO)

3 years agoCorrect coverity annotations (#4581)
James Jones [Fri, 24 Jun 2022 21:03:42 +0000 (16:03 -0500)] 
Correct coverity annotations (#4581)

3 years agoAnnotate SBUFF_PARSE_[U]INT_DEF() bounds checking (CID #1504004, #1504045) (#4582)
James Jones [Fri, 24 Jun 2022 21:03:27 +0000 (16:03 -0500)] 
Annotate SBUFF_PARSE_[U]INT_DEF() bounds checking (CID #1504004, #1504045) (#4582)

For signed or unsigned long long, the bounds checking will have
tests that always have the same result, which triggers coverity.
The fiddling with _Generic() required to avoid this is excessive,
and the macros as they stand pass tests. We therefore annotate
those comparisons to placate coverity.

3 years agoRemove NULLness check
Arran Cudbard-Bell [Fri, 24 Jun 2022 20:19:44 +0000 (15:19 -0500)] 
Remove NULLness check

3 years agoPrint request refs correctly
Arran Cudbard-Bell [Fri, 24 Jun 2022 20:12:47 +0000 (15:12 -0500)] 
Print request refs correctly

3 years agoRemove duplicate extern
Arran Cudbard-Bell [Fri, 24 Jun 2022 19:04:31 +0000 (14:04 -0500)] 
Remove duplicate extern

3 years agoRemove whitespace
Arran Cudbard-Bell [Fri, 24 Jun 2022 18:51:45 +0000 (13:51 -0500)] 
Remove whitespace

3 years agoSupport multiple levels of request qualifiers
Arran Cudbard-Bell [Fri, 24 Jun 2022 18:51:35 +0000 (13:51 -0500)] 
Support multiple levels of request qualifiers

3 years agorespect casts
Alan T. DeKok [Wed, 22 Jun 2022 18:25:10 +0000 (14:25 -0400)] 
respect casts

3 years agotypo
Alan T. DeKok [Wed, 22 Jun 2022 18:25:01 +0000 (14:25 -0400)] 
typo

3 years agoescape tainted values when processing regular expressions
Alan T. DeKok [Wed, 22 Jun 2022 15:29:10 +0000 (11:29 -0400)] 
escape tainted values when processing regular expressions

3 years agotypo
Alan T. DeKok [Wed, 22 Jun 2022 15:28:53 +0000 (11:28 -0400)] 
typo

3 years agorespect escape rules for tainted inputs
Alan T. DeKok [Wed, 22 Jun 2022 15:22:22 +0000 (11:22 -0400)] 
respect escape rules for tainted inputs

when concatenating a value-box list to a string

3 years agoallow for single-quoted strings in regular expressions
Alan T. DeKok [Wed, 22 Jun 2022 13:57:58 +0000 (09:57 -0400)] 
allow for single-quoted strings in regular expressions

3 years agoFix rlm_rest all.mk file Closes #4580
Arran Cudbard-Bell [Wed, 22 Jun 2022 23:10:10 +0000 (18:10 -0500)] 
Fix rlm_rest all.mk file Closes #4580

3 years agoBuild doesn't exist either...
Arran Cudbard-Bell [Wed, 22 Jun 2022 21:31:14 +0000 (16:31 -0500)] 
Build doesn't exist either...

3 years agoCreate relative symlinks so that the source tree can be shared (#4574)
Max Khon [Wed, 22 Jun 2022 21:40:27 +0000 (00:40 +0300)] 
Create relative symlinks so that the source tree can be shared (#4574)

across several hosts to be accessed remotely

3 years agoIgnore Visual Studio Code project files (#4579)
Max Khon [Wed, 22 Jun 2022 21:32:18 +0000 (00:32 +0300)] 
Ignore Visual Studio Code project files (#4579)

3 years agoAnnotate issues Coverity see that we have decided to ignore. (#4553)
James Jones [Wed, 22 Jun 2022 21:12:01 +0000 (16:12 -0500)] 
Annotate issues Coverity see that we have decided to ignore. (#4553)

This change deals with the following CIDs:
1503889150390115039081503916150393615040241504280,
1504282150389415038991504013

Most of these are sbuff/dbuff operations that can only fail if
the buffers can't be reallocated or have reached their specified
maximum size.

In 1503899, we know, but Coverity doesn't, that no log_keyword
passed to _make_vlog() will overrun the fixed-size buffer it uses.

1503894 is what Coverity thinks is a copy/paste error that clearly
makes sense as written.

3 years agoAnnotate calls that as used will not return NULL (CID #1503961) (#4577)
James Jones [Wed, 22 Jun 2022 21:11:40 +0000 (16:11 -0500)] 
Annotate calls that as used will not return NULL (CID #1503961) (#4577)

The calls in question are those in pair_list_init() that iterate
over a pair list built up from a string. As long as the string
is non-empty, the pair list won't be empty. As long as perc (the
percentage) is no larger than 100, the code won't pass NULL to
fr_pair_copy()... and one can see that's the case for all calls
to pair_list_init(). Coverity apparently doesn't look at that
context.

3 years agoPlacate Coverity for mschap_xlat() (CID #1503902) (#4556)
James Jones [Wed, 22 Jun 2022 21:10:03 +0000 (16:10 -0500)] 
Placate Coverity for mschap_xlat() (CID #1503902) (#4556)

3 years agoWrap unchecked value box calls in xlat_idna() in MEM() (CID #1503962) (#4578)
James Jones [Wed, 22 Jun 2022 21:09:38 +0000 (16:09 -0500)] 
Wrap unchecked value box calls in xlat_idna() in MEM() (CID #1503962) (#4578)

3 years agoSet *err to -2 when the list isn't found in tmp_dcursor_init() (#4571)
James Jones [Wed, 22 Jun 2022 21:09:20 +0000 (16:09 -0500)] 
Set *err to -2 when the list isn't found in tmp_dcursor_init() (#4571)

This change honors the comments describing how err is handled, and
also means, given tmpl_find_vp()'s use of tmpl_dcursor_init(),
means callers of tmpl_find_vp() can check its return value
rather than having to look at the written vp (e.g. sometimes_return();
see CID #1503995).

3 years agofr_sbuff_extend_file(): update "end" of parent sbuffs (#4576)
Max Khon [Wed, 22 Jun 2022 21:02:06 +0000 (00:02 +0300)] 
fr_sbuff_extend_file(): update "end" of parent sbuffs (#4576)

This fixes parsing when streaming from file and parsed object (string)
spans fhe I/O buffer boundary.

3 years agoAnnotate to assure coverity that buffers are initialized (CID #1504042, #1504436...
James Jones [Wed, 22 Jun 2022 20:59:41 +0000 (15:59 -0500)] 
Annotate to assure coverity that buffers are initialized (CID #1504042, #1504436) (#4543)

3 years agoNew optional lightweight Acct-On/Off strategy with helper SP and view (#4550)
Terry Burton [Wed, 22 Jun 2022 20:59:12 +0000 (21:59 +0100)] 
New optional lightweight Acct-On/Off strategy with helper SP and view (#4550)

Currently supported by MySQL, PostgreSQL and SQLite.

3 years agoBUILD_DIR isn't available if we're building packages. Closes #4575
Arran Cudbard-Bell [Wed, 22 Jun 2022 20:56:25 +0000 (15:56 -0500)] 
BUILD_DIR isn't available if we're building packages.  Closes #4575

3 years agosbuff->shifted should be reinitialised to 0 with each new sbuff in the chain
Arran Cudbard-Bell [Wed, 22 Jun 2022 20:15:08 +0000 (15:15 -0500)] 
sbuff->shifted should be reinitialised to 0 with each new sbuff in the chain

This breaks the file streaming sbuff, so record the shifted count separately in the fr_sbuff_uctx_file_t structure

3 years agoOptional include
Arran Cudbard-Bell [Wed, 22 Jun 2022 13:51:25 +0000 (08:51 -0500)] 
Optional include

3 years agosimplify and quiet clang scan
Alan T. DeKok [Wed, 22 Jun 2022 12:51:52 +0000 (08:51 -0400)] 
simplify and quiet clang scan

3 years agomore cleanups
Alan T. DeKok [Wed, 22 Jun 2022 12:37:38 +0000 (08:37 -0400)] 
more cleanups

3 years agominor cleanups
Alan T. DeKok [Wed, 22 Jun 2022 12:31:04 +0000 (08:31 -0400)] 
minor cleanups

3 years agobreak out tokenize regex RHS into its own function
Alan T. DeKok [Tue, 21 Jun 2022 23:16:24 +0000 (19:16 -0400)] 
break out tokenize regex RHS into its own function

3 years agomore minimization of function arguments
Alan T. DeKok [Tue, 21 Jun 2022 23:13:18 +0000 (19:13 -0400)] 
more minimization of function arguments

3 years agosimplify logic
Alan T. DeKok [Tue, 21 Jun 2022 22:37:02 +0000 (18:37 -0400)] 
simplify logic

and remove function arguments which are no longer needed.

3 years agoAdd tests for section name resolution
Arran Cudbard-Bell [Tue, 21 Jun 2022 21:40:03 +0000 (16:40 -0500)] 
Add tests for section name resolution

3 years agosudo isn't always available
Arran Cudbard-Bell [Tue, 21 Jun 2022 21:00:05 +0000 (16:00 -0500)] 
sudo isn't always available

3 years agodon't compile regexes for the first pass parsing
Alan T. DeKok [Tue, 21 Jun 2022 21:02:36 +0000 (17:02 -0400)] 
don't compile regexes for the first pass parsing

3 years agowrite out the builddep logs in case we need them
Arran Cudbard-Bell [Tue, 21 Jun 2022 20:47:08 +0000 (15:47 -0500)] 
write out the builddep logs in case we need them

3 years agoProbably didn't want to commit this
Arran Cudbard-Bell [Tue, 21 Jun 2022 20:34:53 +0000 (15:34 -0500)] 
Probably didn't want to commit this

3 years agoGive up on rpm includes for now, we'll look at it again later
Arran Cudbard-Bell [Tue, 21 Jun 2022 20:33:57 +0000 (15:33 -0500)] 
Give up on rpm includes for now, we'll look at it again later

3 years agoSpelling
Arran Cudbard-Bell [Tue, 21 Jun 2022 20:33:13 +0000 (15:33 -0500)] 
Spelling

3 years agoNope...
Arran Cudbard-Bell [Tue, 21 Jun 2022 16:35:40 +0000 (11:35 -0500)] 
Nope...

3 years agoTry again to fix spec include paths
Arran Cudbard-Bell [Tue, 21 Jun 2022 16:26:36 +0000 (11:26 -0500)] 
Try again to fix spec include paths

3 years agoSee if that makes rpmbuild happier...
Arran Cudbard-Bell [Tue, 21 Jun 2022 16:15:26 +0000 (11:15 -0500)] 
See if that makes rpmbuild happier...

3 years agomore clearly separate pre/post expansion parsing.
Alan T. DeKok [Tue, 21 Jun 2022 15:26:19 +0000 (11:26 -0400)] 
more clearly separate pre/post expansion parsing.

We first parse the condition *without* doing variable expansion.
this lets us know how big the condition is.

We then expand the variables and re-parse the condition.

This two-pass method is a temporary hack until we get the new
xlat expressions working.

3 years agoTypo
Arran Cudbard-Bell [Tue, 21 Jun 2022 14:53:42 +0000 (09:53 -0500)] 
Typo

3 years agoAutomatically allocate a frame ctx when asked
Arran Cudbard-Bell [Tue, 21 Jun 2022 14:41:25 +0000 (09:41 -0500)] 
Automatically allocate a frame ctx when asked

3 years agoshut up compiler
Alan T. DeKok [Tue, 21 Jun 2022 12:51:55 +0000 (08:51 -0400)] 
shut up compiler

3 years agoFix RPM spec and "make rpm" (#4572)
Max Khon [Tue, 21 Jun 2022 12:14:35 +0000 (15:14 +0300)] 
Fix RPM spec and "make rpm" (#4572)

3 years agodefine the macro, and use the correct one for DNS
Alan T. DeKok [Mon, 20 Jun 2022 23:28:56 +0000 (19:28 -0400)] 
define the macro, and use the correct one for DNS

3 years agodisable the new code for now
Alan T. DeKok [Mon, 20 Jun 2022 23:16:12 +0000 (19:16 -0400)] 
disable the new code for now

3 years agodisable the new code for now
Alan T. DeKok [Mon, 20 Jun 2022 23:16:12 +0000 (19:16 -0400)] 
disable the new code for now

3 years agouse "==" and not "="
Alan T. DeKok [Mon, 20 Jun 2022 22:40:35 +0000 (18:40 -0400)] 
use "==" and not "="

3 years agoquiet compiler
Alan T. DeKok [Mon, 20 Jun 2022 22:39:15 +0000 (18:39 -0400)] 
quiet compiler

3 years agoalways initialize output
Alan T. DeKok [Mon, 20 Jun 2022 21:30:57 +0000 (17:30 -0400)] 
always initialize output

3 years agoadd xlat conditions, but ifdef'd out for now
Alan T. DeKok [Mon, 20 Jun 2022 19:50:10 +0000 (15:50 -0400)] 
add xlat conditions, but ifdef'd out for now

3 years agoalso parse xlat conditions
Alan T. DeKok [Mon, 20 Jun 2022 15:31:40 +0000 (11:31 -0400)] 
also parse xlat conditions

temporarily, so that we don't let the new code rot

3 years agomost keywords should use stack-local contexts
Alan T. DeKok [Mon, 20 Jun 2022 15:31:06 +0000 (11:31 -0400)] 
most keywords should use stack-local contexts

so that they are automatically cleaned up

3 years agoskip this test until we rewrite it completely
Alan T. DeKok [Mon, 20 Jun 2022 13:51:56 +0000 (09:51 -0400)] 
skip this test until we rewrite it completely

the LHS should be able to be xlat'd names, but the new edit sections
do it differently

3 years agohoist call to cf_expand_variables() to cf_file.c
Alan T. DeKok [Mon, 20 Jun 2022 11:54:58 +0000 (07:54 -0400)] 
hoist call to cf_expand_variables() to cf_file.c

in preparation for moving to xlat expressions

3 years agoadd sbuff_char_word to match Perls \w
Alan T. DeKok [Sun, 19 Jun 2022 13:20:11 +0000 (09:20 -0400)] 
add sbuff_char_word to match Perls \w

For now, no unicode / UTF-8 support.  Sorry.  :(

3 years agonote todo
Alan T. DeKok [Fri, 17 Jun 2022 12:23:29 +0000 (08:23 -0400)] 
note todo

3 years agowe shouldn't be copying structural groups.
Alan T. DeKok [Sun, 12 Jun 2022 15:14:30 +0000 (11:14 -0400)] 
we shouldn't be copying structural groups.

We may change this later, but for now let's disallow it until all
of the tests pass.

3 years agohandle existence checks for leaf types
Alan T. DeKok [Sun, 12 Jun 2022 15:08:28 +0000 (11:08 -0400)] 
handle existence checks for leaf types

and update results in output list.

3 years agoallow casts for expressions
Alan T. DeKok [Thu, 9 Jun 2022 00:39:33 +0000 (20:39 -0400)] 
allow casts for expressions

(uint32) ( a + b + c...)

which is a bit different from casting a bare tmpl

3 years agohacks to check input terminal sequences.
Alan T. DeKok [Tue, 7 Jun 2022 22:42:20 +0000 (18:42 -0400)] 
hacks to check input terminal sequences.

These really need to be cleaned up, as when we're in the middle
of parsing an expression like

(foo......)

we do NOT want to pay attention to input terminals.  We've hit our
tokenizer, and WE decide what the tokens are.

3 years agoRm and ignore kafka/all.mk
Arran Cudbard-Bell [Mon, 20 Jun 2022 15:46:21 +0000 (10:46 -0500)] 
Rm and ignore kafka/all.mk

3 years agoAdd type from format inference for time deltas
Arran Cudbard-Bell [Mon, 20 Jun 2022 14:20:54 +0000 (09:20 -0500)] 
Add type from format inference for time deltas

3 years agoFR_TYPE_REQUIRED is redundant if there's a default
Arran Cudbard-Bell [Fri, 17 Jun 2022 23:32:07 +0000 (18:32 -0500)] 
FR_TYPE_REQUIRED is redundant if there's a default

3 years agoLimit when the documentation builds run
Arran Cudbard-Bell [Fri, 17 Jun 2022 22:31:28 +0000 (17:31 -0500)] 
Limit when the documentation builds run

3 years agoAdd the start of a kafka producer
Arran Cudbard-Bell [Sat, 18 Jun 2022 01:34:25 +0000 (20:34 -0500)] 
Add the start of a kafka producer

Adds a basic configuration mapping system for librdkafka

3 years agoAdd functions to concat talloced arrays of strings
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:39:58 +0000 (16:39 -0500)] 
Add functions to concat talloced arrays of strings

3 years agoFR_TYPE_REQUIRED is redundant when we have a default
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:39:38 +0000 (16:39 -0500)] 
FR_TYPE_REQUIRED is redundant when we have a default

3 years agosubs should be mutable
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:39:23 +0000 (16:39 -0500)] 
subs should be mutable

3 years agoBundle the dictionary files with WASM code
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:39:08 +0000 (16:39 -0500)] 
Bundle the dictionary files with WASM code

3 years agoAdd support for mapping tables which map strings to string
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:38:50 +0000 (16:38 -0500)] 
Add support for mapping tables which map strings to string

3 years agoAdd useful utility functions
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:38:20 +0000 (16:38 -0500)] 
Add useful utility functions

3 years agoMore support for dynamic defaults
Arran Cudbard-Bell [Fri, 17 Jun 2022 21:37:04 +0000 (16:37 -0500)] 
More support for dynamic defaults

3 years agoinitialize 'c'
Alan T. DeKok [Fri, 17 Jun 2022 14:05:08 +0000 (10:05 -0400)] 
initialize 'c'

3 years agohoist unresolved xlats, too
Alan T. DeKok [Thu, 9 Jun 2022 00:51:23 +0000 (20:51 -0400)] 
hoist unresolved xlats, too

3 years agoadd "cast" xlat, for cases where we don't have the full parser
Alan T. DeKok [Wed, 8 Jun 2022 23:58:24 +0000 (19:58 -0400)] 
add "cast" xlat, for cases where we don't have the full parser

3 years agofix regex flag handling
Alan T. DeKok [Wed, 8 Jun 2022 21:08:55 +0000 (17:08 -0400)] 
fix regex flag handling

3 years agopass in flags, too
Alan T. DeKok [Wed, 8 Jun 2022 15:23:09 +0000 (11:23 -0400)] 
pass in flags, too

3 years agodon't stop on ret>0, stop *recursing*
Alan T. DeKok [Wed, 8 Jun 2022 13:28:16 +0000 (09:28 -0400)] 
don't stop on ret>0, stop *recursing*

and continue with the next node

3 years agowalk function arguments first.
Alan T. DeKok [Wed, 8 Jun 2022 13:26:12 +0000 (09:26 -0400)] 
walk function arguments first.

because the instantiation function can move the arguments into
it's private data structure

3 years agorename to be clearer
Alan T. DeKok [Tue, 7 Jun 2022 22:43:59 +0000 (18:43 -0400)] 
rename to be clearer

3 years agoadd tmpl_value_list_insert_tail() which does casting, too.
Alan T. DeKok [Tue, 7 Jun 2022 22:35:27 +0000 (18:35 -0400)] 
add tmpl_value_list_insert_tail() which does casting, too.

instead of similar code scattered everywhere.

3 years agoallow if (!fail) to work correctly.
Alan T. DeKok [Tue, 7 Jun 2022 22:33:57 +0000 (18:33 -0400)] 
allow if (!fail) to work correctly.

3 years agoallocate from the correct parent
Alan T. DeKok [Tue, 7 Jun 2022 21:33:56 +0000 (17:33 -0400)] 
allocate from the correct parent