Piotr Gregor [Thu, 27 Sep 2018 16:29:26 +0000 (16:29 +0000)]
FS-11421: [core,mod_sofia] Fix rtp_pass_codecs_on_stream_change to process all sdp settings in the re-invite -- add new filter_codecs app and fix some races and negotiation bugs #resolve
Mike Jerris [Fri, 31 May 2019 18:22:28 +0000 (13:22 -0500)]
Merge pull request #1738 in FS/freeswitch from ~THEHUNMONKGROUP/freeswitch:bugfix/FS-11874-faulty-logic-for-checking-addition-of-multiple-mediastream-objects to master
Chad Phillips [Fri, 31 May 2019 18:07:11 +0000 (11:07 -0700)]
Fix FS-11874
Verto JS libs allow passing an attachStreams array of MediaStream objects, which are then supposed to be added to the peer connection in the order they are supplied in the array.
However, there is a faulty logic check prior to actually adding the streams, where 'options.attachStream' is checked for length instead of 'options.attachStreams'.
Mike Jerris [Fri, 31 May 2019 17:55:51 +0000 (12:55 -0500)]
Merge pull request #1737 in FS/freeswitch from ~THEHUNMONKGROUP/freeswitch:bugfix/FS-11873-addstream-adds-audio-video-tracks-in-random-order-use-spec-compliant-addtrack to master
Chad Phillips [Fri, 31 May 2019 17:52:18 +0000 (10:52 -0700)]
Fix FS-11873: addStream() adds audio/video tracks in random order
addStream() is a deprecated WebRTC API method, and only works via shimming on some platforms. Internally, it is inconsistent in building an offer SDP in the order which FreeSWITCH expects it, which is audio m-lines first.
This can result in intermittent m-line ordering errors on the client.
Instead addTrack() can be used to force the media tracks to be added to the peer in the order FreeSWITCH expects.
Andrey Volk [Wed, 29 May 2019 21:56:13 +0000 (16:56 -0500)]
Merge pull request #1735 in FS/freeswitch from ~MITCH.CAPPER/freeswitch:FS-11865-fix_mod_com_729_bin_url_change_pr to master
* commit '1f0dea990b47bc154027d75d563d2af92079e1d7':
FS-11865 [mod_com_729] change to use latest version for mod_com_g729 bins so url does not go stale and update new binary paths
Mike Jerris [Fri, 17 May 2019 16:39:25 +0000 (11:39 -0500)]
Merge pull request #1728 in FS/freeswitch from ~ANDYWOLK/freeswitch:FS-11849-add-mod_av-based-on-ffmpeg-and-openh264-to-msi-package-on-windows to master
Mike Jerris [Tue, 14 May 2019 15:11:01 +0000 (10:11 -0500)]
Merge pull request #1718 in FS/freeswitch from ~INFOMIND/freeswitch:bugfix/FS-11826-mod_conference-channel-variables_join to master
* commit 'b7bce76da5b496400bbd9cce1f53b0be5b4b0ae1':
FS-11826 [mod_conference] conference_member.c: channel variables (conference_join_) Fixes variables being seen as empty and proper range on conference_join_energy_level
David Grant [Sun, 5 May 2019 03:48:47 +0000 (22:48 -0500)]
FS-11826 [mod_conference] conference_member.c: channel variables (conference_join_) Fixes variables being seen as empty and proper range on conference_join_energy_level
Sebastian Kemper [Sun, 14 Apr 2019 17:23:41 +0000 (19:23 +0200)]
FS-11783: [mod_say_ja] quiet overflow warning
With -Wformat-overflow gcc warns about calls to formatted input/output
function "sprintf" that might overflow the destination buffer.
In this case gcc does not know the upper bound of tm_min and assumes
that up to 11 bytes might be written to buffer (3 bytes). But we know
that tm_min can only be within the range 0 to 59.
mod_say_ja.c: In function 'ja_say_time':
mod_say_ja.c:376:35: error: '%d' directive writing between 2 and 10 bytes into a region of size 3 [-Werror=format-overflow=]
sprintf(buffer, "%d", tm.tm_min);
^~
mod_say_ja.c:376:34: note: directive argument in the range [11, 2147483647]
sprintf(buffer, "%d", tm.tm_min);
^~~~
mod_say_ja.c:376:18: note: 'sprintf' output between 3 and 11 bytes into a destination of size 3
sprintf(buffer, "%d", tm.tm_min);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This commits adds a hint for gcc, which silences the warning.
Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
Sebastian Kemper [Sun, 14 Apr 2019 17:11:58 +0000 (19:11 +0200)]
FS-11783: [core] quiet gcc truncation warning
With -Wstringop-truncation gcc warns about calls to bounded string
manipulation function "strncpy" that may either truncate the copied
string or leave the destination unchanged. To avoid the warning when the
result is not expected to be NUL-terminated, it is suggested to call
"memcpy" instead.
src/switch_core_media.c: In function 'switch_core_media_patch_sdp':
src/switch_core_media.c:11854:4: error: 'strncpy' output truncated before terminating nul copying 2 bytes from a string of the same length [-Werror=stringop-truncation]
strncpy(q, strchr(a_engine->adv_sdp_ip, ':') ? "6 " : "4 ", 2);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This commit follows gcc's recommendation.
Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
Mike Jerris [Wed, 3 Apr 2019 16:38:33 +0000 (11:38 -0500)]
Merge pull request #1706 in FS/freeswitch from ~ANDYWOLK/freeswitch:feature/FS-11759-update-libks-to-1.2.0-and-signalwire-client-c-to-1.1.0-on-windows to master
Mike Jerris [Mon, 1 Apr 2019 21:18:58 +0000 (16:18 -0500)]
Merge pull request #1698 in FS/freeswitch from ~ANDYWOLK/freeswitch:bugfix/FS-11729-wix-project-fails-to-find-mergemodule-folder-due-to-incorrect-version-in-path-fixed to master
projects / thirdparty / freeswitch.git / log
