Bruno Haible [Sun, 3 May 2026 12:27:16 +0000 (14:27 +0200)]
hash: Use the counted_by attribute.
* lib/hash.c (struct hash_table): Mark the bucket field as counted_by
n_buckets. Swap these fields (needed for clang, see
<https://discourse.llvm.org/t/rfc-forward-referencing-a-struct-member-within-bounds-annotations/85510>).
Bruno Haible [Sun, 3 May 2026 11:54:51 +0000 (13:54 +0200)]
array-set: Use the counted_by attribute.
* lib/gl_array_set.c (struct gl_set_impl): Mark the elements field as
counted_by count. Swap these fields (needed for clang).
(gl_array_nx_add): Increase set->count before writing into
set->elements.
Bruno Haible [Sun, 3 May 2026 11:53:34 +0000 (13:53 +0200)]
array-oset: Use the counted_by attribute.
* lib/gl_array_oset.c (struct gl_oset_impl): Mark the elements field as
counted_by count. Swap these fields (needed for clang).
(gl_array_nx_add_at): Increase set->count before writing into
set->elements.
Bruno Haible [Sun, 3 May 2026 11:52:05 +0000 (13:52 +0200)]
array-omap: Use the counted_by attribute.
* lib/gl_array_omap.c (struct gl_omap_impl): Mark the pairs field as
counted_by count. Swap these fields (needed for clang).
(gl_array_nx_add_at): Increase map->count before writing into
map->pairs.
Bruno Haible [Sun, 3 May 2026 11:50:43 +0000 (13:50 +0200)]
array-map: Use the counted_by attribute.
* lib/gl_array_map.c (struct gl_map_impl): Mark the pairs field as
counted_by count. Swap these fields (needed for clang).
(gl_array_nx_getput): Increase map->count before writing into
map->pairs.
Bruno Haible [Sun, 3 May 2026 09:41:31 +0000 (11:41 +0200)]
array-list: Use the counted_by attribute.
* lib/gl_array_list.c (struct gl_list_impl): Mark the elements field as
counted_by count. Swap these fields (needed for clang).
(gl_array_nx_add_first, gl_array_nx_add_last, gl_array_nx_add_before,
gl_array_nx_add_after, gl_array_nx_add_at): Increase list->count before
writing into list->elements.
Bruno Haible [Sun, 3 May 2026 08:52:33 +0000 (10:52 +0200)]
exclude: Use the counted_by attribute.
* lib/exclude.c (struct exclude_pattern): Mark the exclude field as
counted_by exclude_count. Swap these fields (needed for clang, see
<https://discourse.llvm.org/t/rfc-forward-referencing-a-struct-member-within-bounds-annotations/85510>).
(new_exclude_segment): Update.
(add_exclude): Increase pat->exclude_count before writing into
pat->exclude.
Bruno Haible [Sun, 3 May 2026 08:40:52 +0000 (10:40 +0200)]
dfa: Use the counted_by attribute.
* lib/dfa.c (struct mb_char_classes): Mark the chars field as counted_by
nchars. Swap these fields (needed for clang, see
<https://discourse.llvm.org/t/rfc-forward-referencing-a-struct-member-within-bounds-annotations/85510>).
(parse_bracket_exp): Increase dfa->lex.brack.nchars before writing into
dfa->lex.brack.chars.
Bruno Haible [Sun, 3 May 2026 06:51:08 +0000 (08:51 +0200)]
argp: Use the counted_by attribute.
* lib/argp-help.c (struct hol): Mark the entries fields as counted_by
num_entries. Swap these fields (needed for clang, see
<https://discourse.llvm.org/t/rfc-forward-referencing-a-struct-member-within-bounds-annotations/85510>).
Bruno Haible [Fri, 1 May 2026 20:35:13 +0000 (22:35 +0200)]
Improve comments about GCC bugs.
* m4/nullptr.m4 (gl_NULLPTR): Add info about gcc bug 114780.
* modules/uniname/uniname (Makefile.am): Add info about gcc bug 110112.
* tests/test-intprops.c: Correct info about gcc bug 68971.
Paul Eggert [Fri, 1 May 2026 16:03:49 +0000 (09:03 -0700)]
manywarnings: GCC 16 changes
* build-aux/gcc-warning.spec: Add options introduced in GCC 16.
Remove -Wfree-labels (not limited to objc), -Wuseless-cast
(not limited to c++ and objc++).
* m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -Wfree-labels,
-Wkeyword-macro (new to GCC 16), -Wuseless-casts.
Paul Eggert [Fri, 1 May 2026 16:02:37 +0000 (09:02 -0700)]
manywarnings: simplify C warning audits
* build-aux/gcc-warning.spec: Omit many c++, objc, obcj++,
fortran warnings as we no longer need to track them here.
Mark a few of these warnings as now being defaults (for C too).
* m4/manywarnings.m4: In comment that says how to audit this file,
use ‘gcc --help=c,warnings’ and ‘gcc --help=common,warnings’
instead of ‘gcc --help=warnings’, as the latter outputs irrelevant
warnings about c++, objc, obcj++, fortran.
Bruno Haible [Thu, 30 Apr 2026 20:53:21 +0000 (22:53 +0200)]
getlocalename_l-simple tests: Avoid test failure on NetBSD.
* tests/test-getlocalename_l.c (FAKE_COLLATE): New macro.
(main): If FAKE_COLLATE is true, don't compare the result of
getlocalename_l (LC_COLLATE, ...).
* doc/posix-functions/getlocalename_l.texi: Mention the NetBSD bug.
Paul Eggert [Thu, 30 Apr 2026 00:10:56 +0000 (17:10 -0700)]
stdbit-h: namespace cleanup port to G++ 15
For the namespace cleanup, don’t assume that the system <stdbit.h>
defines size_t etc. unless it also defines
__STDC_VERSION_STDBIT_H__. This works around problems with C++
compilers where ‘#include <stdbit.h>’ is a no-op, such as g++ 15.2.1.
Problem reported by Bruno Haible in:
https://lists.gnu.org/r/bug-gnulib/2026-04/msg00203.html
It also lets us simplify the code by removing a special case for
the Intel icpx C++ compiler.
* lib/stdbit.in.h: When deciding whether <stdbit.h> works,
use (defined __STDC_VERSION_STDBIT_H__) rather than @HAVE_STDBIT_H@.
This fixes problems when <stdbit.h> works for C so @HAVE_STDBIT_H@
is 1, whereas <stdbit.h> does nothing for C++.
(__STDC_VERSION_STDBIT_H__): Move definition to end.
Paul Eggert [Wed, 29 Apr 2026 22:11:50 +0000 (15:11 -0700)]
stdbit-h: <stddef.h> namespace cleanup
* lib/stdbit.in.h: Include <stddef.h> only if the stdc_memreverse8
module is also used, since it’s the only one that needs size_t.
Define __need_size_t before including <stddef.h>, so that <stddef.h>
defines only size_t on GNU platforms.
Paul Eggert [Wed, 29 Apr 2026 20:58:50 +0000 (13:58 -0700)]
stdbit-h: include <stdint.h> only on module req
This is another attempt to tighten up the <stdbit.h> namespace
on GNU platforms, and follows up on previous C++ fixes here.
* lib/stdbit.in.h: Include <stdint.h> only when also using a
module like stdc_memreverse8 with an API that uses <stdint.h>
types that are not otherwise defined.
This should work better with portable code, as code that merely
wants u?int(_least)?N_t should include <stdint.h>, not <stdbit.h>.
(_GL_STDBIT_UINT_FAST16 _GL_STDBIT_UINT_FAST32)
(_GL_STDBIT_UINT_FAST64): Simplify logic by defining them to the
<stdint.h> equivalents whenever stdint.h is included.
Bruno Haible [Wed, 29 Apr 2026 14:31:30 +0000 (16:31 +0200)]
mbrtoc32-regular: Strengthen the configure test.
* m4/mbrtoc32-regular.m4: New file.
* modules/mbrtoc32-regular (Files): Add it.
(configure.ac): Invoke gl_FUNC_MBRTOC32_REGULAR.
* m4/mbrtoc32.m4 (gl_FUNC_MBRTOC32): Set gl_cv_func_mbrtoc32_regular.
If it's "no" or "guessing no", set REPLACE_MBRTOC32=1.
Bruno Haible [Tue, 28 Apr 2026 23:52:17 +0000 (01:52 +0200)]
error-h: Support multiple gnulib-tool invocations in the same package.
* lib/error.in.h (GNULIB_defined_error, GNULIB_defined_error_at_line):
New macros.
(verror): Test GNULIB_defined_verror, for consistency with the idiom.
(verror_at_line): Test GNULIB_defined_verror_at_line, for consistency
with the idiom.
Bruno Haible [Tue, 28 Apr 2026 23:23:23 +0000 (01:23 +0200)]
stdbit-h: Fix syntax errors in C++ mode (regression 2026-03-16).
* lib/stdbit.in.h: Include <stddef.h> also for the stdc_memreverse8
module. Include <stdint.h> also when HAVE_STDBIT_H is 1 and
__UINT_FAST64_TYPE__ is defined and some module needs it.
Bruno Haible [Tue, 28 Apr 2026 09:06:24 +0000 (11:06 +0200)]
c-strtod tests: Improve last patch.
* tests/test-c-strtof-mt.c: Revert addition of dead code.
* tests/test-c-strtod-mt.c: Likewise.
* tests/test-c-strtold-mt.c: Likewise.
* tests/test-c-strtof-mt.sh: Don't assume that if one invocation of the
test program has exit code 77, the other invocation will have exit code
77 as well.
* tests/test-c-strtod-mt.sh: Likewise.
* tests/test-c-strtold-mt.sh: Likewise.
Paul Eggert [Mon, 27 Apr 2026 21:55:39 +0000 (14:55 -0700)]
regex: port to non-GNU malloc
This is for Gawk, which does not use malloc-gnu.
* lib/regex.c (_GL_USE_STDLIB_ALLOC) [!_LIBC]:
Define, since this module is now safe for AIX-like malloc.
* lib/regex_internal.h (re_malloc) [!_LIBC && !HAVE_MALLOC_0_NONNULL]:
Don’t pass 0 to malloc.
Paul Eggert [Mon, 27 Apr 2026 21:15:40 +0000 (14:15 -0700)]
regex: SSIZE_MAX porting
* lib/regex_internal.h (IDX_MAX) [_REGEX_LARGE_OFFSETS]:
Port to non-POSIX platforms where limits.h does not define SSIZE_MAX.
This is for Gawk, which does not use Gnulib limits.h.
Paul Eggert [Mon, 27 Apr 2026 20:05:32 +0000 (13:05 -0700)]
idx: cleaner namespace on GNU
* lib/idx.h: Include <stddef.h>, <stdint.h> only if needed.
(idx_t, IDX_MAX): Rely on builtin macros __PTRDIFF_TYPE__,
__PTRDIFF_MAX__ if present; this avoids polluting the namespace on
GNUish systems.
Paul Eggert [Sun, 26 Apr 2026 22:09:00 +0000 (15:09 -0700)]
localename-unsafe: respect --disable-threads
Respect --disable-threads on native MS-Windows.
* lib/localename-unsafe.c (GLWTHREAD_MUTEX_INIT, glwthread_mutex_t)
(glwthread_mutex_lock, glwthread_mutex_unlock)
[AVOID_ANY_THREADS && _WIN32 && !__CYGWIN]:
Instead of including "windows-mutex.h", provide no-op substitutes
for its symbols used here.
Paul Eggert [Sat, 25 Apr 2026 22:25:09 +0000 (15:25 -0700)]
c-strtod-tests: port to single-threaded builds
* tests/test-c-strtod-mt.c:
* tests/test-c-strtof-mt.c:
* tests/test-c-strtold-mt.c:
(main): The tests make no sense when single-threaded, so skip them
by exiting with status 77.
* tests/test-c-strtod-mt.sh:
* tests/test-c-strtof-mt.sh:
* tests/test-c-strtold-mt.sh:
Exit with the failing test’s status, so that if it exits with
status 77 then we do too.
Paul Eggert [Sat, 25 Apr 2026 22:19:27 +0000 (15:19 -0700)]
cond: always include glthread/lock.h
* lib/glthread/cond.h: Revert my 2026-03-31 namespace cleanup
patch, which was incorrect because this header’s
gl_cond_timedwait_func function uses lock_t even when threading is
disabled.
Paul Eggert [Sat, 25 Apr 2026 22:15:48 +0000 (15:15 -0700)]
thread: better nonreturn fix for gl_thread_create
* lib/glthread/thread.c (gl_thread_create):
Define as a function only if multithreading.
This is cleaner than my previous patch today that sometimes made
it _Noreturn, as the function’s definition and declaration now always
agree on noreturnedness, and it pushes the noreturnedness issue up
to the caller. Also, it suppresses GCC’s “warning: function
declared 'noreturn' has a 'return' statement”.
Paul Eggert [Sat, 25 Apr 2026 16:40:41 +0000 (09:40 -0700)]
thread: pacify gcc -Wunused-value
* lib/glthread/thread.h (glthread_atfork, glthread_sigmask)
(glthread_create, glthread_join): Evaluate arguments even when
these macros are no-ops. Type-check the arguments too. This is
cleaner anyway, in case the args have the wrong types (or have
side effects!).
Bruno Haible [Sat, 25 Apr 2026 09:26:37 +0000 (11:26 +0200)]
regex: Fix link error on macOS and FreeBSD (regression yesterday).
* modules/regex (Link): Add $(LIBUNISTRING), $(LIBC32CONV).
* modules/regex-tests (Makefile.am): Link test-regex with
$(LIBUNISTRING) and $(LIBC32CONV).
Paul Eggert [Sat, 25 Apr 2026 00:28:58 +0000 (17:28 -0700)]
regex: be consistent with dfa
In the regex code, use the char32_t functions instead of the
wchar_t functions, so that regex stays in sync with dfa.
This should fix a bug in Gnu grep reported by Dennis Clarke for
OpenBSD <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=80774#47>.
A similar bug occurs in some macOS releases.
* modules/regex (Depends-on): Replace btowc, iswctype, mbrtowc,
wchar-h, wcrtomb, wctype-h, and wctype with btoc32,
c32_apply_type_test, c32_get_type_test, c32isalnum, c32rtomb,
c32tolower, c32toupper, mbrtoc32-regular, uchar-h.
* lib/regex_internal.h [!_LIBC]: Do not include <wchar.h>, <wctype.h>.
Instead, include <uchar.h> and #define wchar_t, wctype_t,
__wctype, __iswalnum, __iswctype, __towlower, __towupper, __btowc,
__mbrtowc, and __wcrtomb to their char32_t counterparts.
Paul Eggert [Sat, 25 Apr 2026 00:14:22 +0000 (17:14 -0700)]
dfa: always use char32_t not wchar_t
This should help merges changes from Gawk, which always uses the
char32_t API though that’s sometimes implemented with the wchar_t
API even on platforms where wchar_t and char32_t act differently.
The idea is to use char32_t uniformly in both the dfa and regex
modules, so that they get consistent answers on all platforms.
* lib/dfa.c, lib/localeinfo.c, lib/localeinfo.h: If GAWK, do not
include <wctype.h> or redefine the Gnulib char32_t types and
functions to be wchar.h and wctype.h functions or define mbszero
and streq, as I think I have a better way to do this with Gawk
that is less intrusive here; instead, always include <uchar.h>.
* lib/dfa.c: Do not include <wchar.h>. Include "getext.h" before
including "xalloc.h" and "localinfo.h", as Gnulib doesn’t care
about the order and this works better with Gawk’s way of overriding Gnulib.
(parse_bracket_exp): Use && instead of &; either is correct and
both are equally fast nowadays but && triggers a warning in some
Gawk compiles.
* lib/dfa.h (_GL_ATTRIBUTE_MALLOC, _GL_ATTRIBUTE_DEALLOC)
(_GL_ATTRIBUTE_DEALLOC_FREE)
(_GL_ATTRIBUTE_RETURNS_NONNULL) [!_GL_ATTRIBUTE_MALLOC]:
Remove, as Gawk’s custom.h can define them.
* lib/localeinfo.c: Go back to using <verify.h> and ‘verify’
instead of using static_assert which Gawk can’t easily use because
it does not use Gnulib’s assert-h module.
* lib/localeinfo.h: Do not include <limits.h>, avoding some
namespace pollution.
(struct localeinfo): Use (unsigned char) -1 instead of UCHAR_MAX
to avoid the need to include <limits.h>.
* modules/dfa (Depends-on): Remove wchar-h.
Paul Eggert [Fri, 24 Apr 2026 23:00:34 +0000 (16:00 -0700)]
uchar-h: <string.h> etc. namespace cleanup
This is only a partial cleanup; to be cleaner we’d need to
move declarations of Gnulib extensions like c32isalpha
into a separate .h file. However, if no Gnulib modules that
extend <uchar.h> are used, Gnulib <uchar.h> is now pretty clean on
recent GNUish platforms.
* lib/uchar.in.h: On GNUish platforms, include <stdint.h>,
<wchar.h>, <wctype.h> only if needed. Do not include <string.h>,
as we never need it directly: even if we use <string.h>’s memset
via mbszero, <wchar.h> should include <string.h> if needed, as
<wchar.h> defines mbszero. Move a static_assert from here to tests,
as the static_assert uses a symbol that is no longer guaranteed
to be visible.
* modules/uchar-h (Depends-on): Do not depend on assert-h.
* tests/test-uchar-h.c: Move a static_assert here from lib/uchar.in.h,
and include <wchar.h> so that wchar_t is guaranteed to be visible.
Paul Eggert [Fri, 24 Apr 2026 21:09:31 +0000 (14:09 -0700)]
doc: document namespace pollution allowed by POSIX
In the manual, document where POSIX.1-2024 allows namespace pollution.
Although it might be nice to add something like GNULIB_POSIXCHECK to
detect when Gnulib-using code is unportable in this area, I don’t
offhand see a good way to do that.
Bruno Haible [Fri, 24 Apr 2026 13:31:00 +0000 (15:31 +0200)]
version-etc: Optionally emit another line for the man page.
* lib/version-etc.c: Include <stdlib.h>.
(emit_bug_reporting_address): Terminate the "Report bugs to" sentence,
as suggested in
https://www.gnu.org/software/gettext/manual/html_node/Bug-Report-Address.html.
Add a "Report any translation bugs to" sentence, but only when producing
a man page.
Bruno Haible [Fri, 24 Apr 2026 13:57:52 +0000 (15:57 +0200)]
bcp47: Fix handling of variants of length 4.
Reported by Patrice Dumas <pertusus@gnu.org> in
<https://lists.gnu.org/archive/html/bug-gnulib/2026-04/msg00154.html>.
* lib/bcp47.c (bcp47_to_xpg): Don't parse a variant of length 4 that
contains some digits as a script.
* tests/test-bcp47.c (main): Add a test case with a variant of length 4.
Paul Eggert [Thu, 23 Apr 2026 19:59:52 +0000 (12:59 -0700)]
wchar-h: <string.h> namespace cleanup
Do not pollute <wchar.h> includers with <string.h> names
on GCC-compatible platforms.
* lib/wchar.in.h (_GL_WCHAR_MEMSET) [@GNULIB_MBSZERO@]: New macro.
(mbszero): Use it.
Jim Meyering [Mon, 20 Apr 2026 02:36:03 +0000 (19:36 -0700)]
maint.mk: fix sc_Wundef_boolean race with parallel syntax-check
With highly parallel "make syntax-check", sc_Wundef_boolean's
in_files='config.h' was matched as an unanchored, unescaped regex
by "find | grep -E", so the '.' matched any character and the lack
of anchoring matched anywhere in a path. This made it match the
.sc-start-sc_*config_h* marker files created by parallel rules.
Symptom: I saw see these go by:
grep: ./.sc-start-sc_require_config_h_first: No such file or directory
grep: ./.sc-start-sc_prohibit_have_config_h: No such file or directory
grep: ./.sc-start-sc_require_config_h: No such file or directory
* top/maint.mk (sc_Wundef_boolean): Use '(^|/)config\.h$' rather
than bare 'config.h' as the in_files ERE.
Paul Eggert [Sun, 19 Apr 2026 18:12:16 +0000 (11:12 -0700)]
readutmp: greeters are not users
* lib/readutmp.c (read_utmp_from_systemd):
Do not merely treat a "manager*" class as a login process.
Instead, treat all non-"user*" processes as login processes.
With current systemd, this changes the treatment of "greeter",
"lock-screen", "background", "background-light", and "none"
classes so that they are now considered to be login processes, not
user processes.
Jim Meyering [Sun, 19 Apr 2026 16:52:26 +0000 (09:52 -0700)]
regex: avoid a UBSAN failure: remove an unnecessary DEBUG_ASSERT
* lib/regex_internal.c (re_node_set_insert): Remove the DEBUG_ASSERT
and instead return early for an attempt to insert an ELEM that is
already present in the set. Relax the function's comment that says
there should be no duplicate. This function is called from many
places and has been working fine. With its nontrivial backrefs,
the sample regexp apparently elicits enough backtracking retries
and state-set merges to trigger this duplicate insertion attempt.
Reported by Bruno Haible in
https://lists.gnu.org/r/bug-gnulib/2026-04/msg00138.html
Paul Eggert [Fri, 17 Apr 2026 16:14:49 +0000 (09:14 -0700)]
doc: doc FTS_NOSTAT with FIFO, not directory
* lib/fts.in.h (FTS_NOSTAT): Use a FIFO, not a directory,
in the commentary’s example. This is a better example
because directories never have FTS_NSOK.
Bruno Haible [Wed, 15 Apr 2026 11:45:58 +0000 (13:45 +0200)]
sigdelay: Add tests.
* tests/test-sigdelay1.c: New file, based on
tests/test-pthread_sigmask1.c.
* tests/test-sigdelay2.c: New file, based on
tests/test-pthread_sigmask2.c.
* modules/sigdelay-tests: New file.
Bruno Haible [Wed, 15 Apr 2026 11:45:44 +0000 (13:45 +0200)]
pthread_sigmask tests: Enhance test.
* tests/test-pthread_sigmask2.c (killer_thread1): Renamed from
killer_thread.
(killer_thread2): New variable.
(killer_thread1_func): Renamed from killer_thread_func.
(killer_thread2_func): New function.
(main): Add a second test with killer_thread2.
Bruno Haible [Mon, 13 Apr 2026 21:44:24 +0000 (23:44 +0200)]
stdbit-h: Port to Intel icpx C++ compiler.
* lib/stdbit.in.h: With the Intel icpx C++ compiler, include <stddef.h>
and <stdint.h>, and define the __STDC_ENDIAN_* macros.
* doc/posix-headers/stdbit.texi: Document the Intel icpx bug.
Paul Eggert [Mon, 13 Apr 2026 21:01:36 +0000 (14:01 -0700)]
error-h: port to Intel OneAPI icx 2026.0.0
Problem reported by Harmen Stoppels in:
https://lists.gnu.org/r/bug-gnulib/2026-04/msg00085.html
* m4/error_h.m4 (gl_ERROR_H): Plant an alarm in case error infloops.