]>
git.ipfire.org Git - thirdparty/kea.git/log
Marcin Siodelski [Thu, 16 May 2013 08:28:19 +0000 (10:28 +0200)]
[2786] Always validate the contents of the buffer when provided.
Marcin Siodelski [Thu, 16 May 2013 07:53:40 +0000 (09:53 +0200)]
[2786] Minor: added option code to the exception string.
Marcin Siodelski [Thu, 16 May 2013 07:44:58 +0000 (09:44 +0200)]
[2876] Minor: added paranthesis in the return statement.
JINMEI Tatuya [Thu, 16 May 2013 05:41:27 +0000 (22:41 -0700)]
[2946] get access to base class's static method via 'this' pointer
as some compilers don't allow direct use of Base::method.
Paul Selkirk [Thu, 16 May 2013 03:39:14 +0000 (23:39 -0400)]
Merge branch 'trac2522' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2522
Conflicts:
src/lib/dns/gen-rdatacode.py.in
JINMEI Tatuya [Wed, 15 May 2013 00:30:03 +0000 (17:30 -0700)]
[2522] some simple suggested fixes:
- use the unnamed namespace for the entire content to hide as many things as
possible.
- define rdata_tsig inside the fixture class to avoid initialization fiasco.
(to make it possible, also make toWireCommonChecks a member function).
JINMEI Tatuya [Wed, 15 May 2013 00:27:09 +0000 (17:27 -0700)]
[2522] trivial style fix
JINMEI Tatuya [Wed, 15 May 2013 00:06:17 +0000 (17:06 -0700)]
[2522] minor style fixes
JINMEI Tatuya [Tue, 14 May 2013 23:36:12 +0000 (16:36 -0700)]
[2522] trivial style cleanup: folded long lines
Paul Selkirk [Wed, 8 May 2013 15:29:02 +0000 (11:29 -0400)]
[2522] fix a typo
Paul Selkirk [Wed, 8 May 2013 14:59:40 +0000 (10:59 -0400)]
[2522] initialize impl_ directly in TSIG lexer constructor
Paul Selkirk [Wed, 8 May 2013 04:35:22 +0000 (00:35 -0400)]
[2522] TSIG algorigthm can be a reference, maybe a bit more efficient
Paul Selkirk [Wed, 8 May 2013 03:58:42 +0000 (23:58 -0400)]
[2522] convert TSIG string constructor tests to checkFromText
Paul Selkirk [Wed, 8 May 2013 02:13:22 +0000 (22:13 -0400)]
[2522] more TSIG unit tests
Paul Selkirk [Tue, 7 May 2013 19:59:29 +0000 (15:59 -0400)]
[2522] add MasterLexer constructor for TSIG
Paul Selkirk [Tue, 7 May 2013 17:16:17 +0000 (13:16 -0400)]
[2522] fix RP unit test
Paul Selkirk [Tue, 7 May 2013 17:08:27 +0000 (13:08 -0400)]
[2522] more MINFO unit tests
Paul Selkirk [Mon, 6 May 2013 14:30:04 +0000 (10:30 -0400)]
[2522] add MasterLexer constructor for MINFO
Paul Selkirk [Mon, 6 May 2013 14:28:55 +0000 (10:28 -0400)]
[2522] normalize some RP documentation comments
Paul Selkirk [Sat, 4 May 2013 23:25:30 +0000 (19:25 -0400)]
[2522] add MasterLexer constructor for RP
JINMEI Tatuya [Thu, 16 May 2013 00:09:25 +0000 (17:09 -0700)]
[2946] pass shared_ptr, not a reference to deadline pointer.
I suspect the previous version could cause the same type of use-after-free
bug, although I couldn't come up with an effective test scenario.
JINMEI Tatuya [Thu, 16 May 2013 00:03:49 +0000 (17:03 -0700)]
[2946] documentation update
JINMEI Tatuya [Wed, 15 May 2013 23:57:07 +0000 (16:57 -0700)]
[2946] mix enable_shared_from_this in SyncUDPServer to prevent use-after-free.
to enforce this style of creation, introduce a static factory method and
hide the constructor as private.
JINMEI Tatuya [Wed, 15 May 2013 23:42:08 +0000 (16:42 -0700)]
[2946] added a test case to reproduce the use-after-free situation
JINMEI Tatuya [Wed, 15 May 2013 19:00:20 +0000 (12:00 -0700)]
[2946] use shared_ptr of DNSServer objects for tests
Marcin Siodelski [Wed, 15 May 2013 19:31:07 +0000 (21:31 +0200)]
[2786] Option factory function uses iterators to create OptionCustom.
JINMEI Tatuya [Wed, 15 May 2013 18:31:57 +0000 (11:31 -0700)]
[2916] corrected handling of aux socket wrt exception safety
JINMEI Tatuya [Wed, 15 May 2013 18:27:21 +0000 (11:27 -0700)]
[2916] clarified what would happen if write blocks, and then return from test.
it should be safe to continue as clarified in the comment, but it's probably
better to eliminate any possibility of hangup.
JINMEI Tatuya [Wed, 15 May 2013 18:22:18 +0000 (11:22 -0700)]
[2916] reset global IOService to NULL at end of test for safer operation
JINMEI Tatuya [Wed, 15 May 2013 18:16:33 +0000 (11:16 -0700)]
[2916] clear alarm in the test's destructor.
JINMEI Tatuya [Wed, 15 May 2013 17:44:45 +0000 (10:44 -0700)]
[2836] style fixes: unify short lines
JINMEI Tatuya [Wed, 15 May 2013 17:30:03 +0000 (10:30 -0700)]
[2836] style fix: unify two short lines
JINMEI Tatuya [Wed, 15 May 2013 16:57:29 +0000 (09:57 -0700)]
[2836] corrected minor typo in doxygen doc
Thomas Markwalder [Wed, 15 May 2013 16:45:38 +0000 (12:45 -0400)]
[2954] Removed inadvertant addition of executable, d2srv_unittests.
Thomas Markwalder [Wed, 15 May 2013 16:41:42 +0000 (12:41 -0400)]
[2594] Moved d2Srv to d2, removed "Srv" and "srv" from file names
and source. Corrected other review items.
JINMEI Tatuya [Wed, 15 May 2013 16:40:07 +0000 (09:40 -0700)]
[2836] make tests safer when USE_SHARED_MEMORY is undefined.
- explicitly include config.h in these tests
- move helper function only used with USE_SHARED_MEMORY inside the ifdef block
JINMEI Tatuya [Wed, 15 May 2013 15:59:28 +0000 (08:59 -0700)]
[master] Merge branch 'trac2899-2'
JINMEI Tatuya [Wed, 15 May 2013 15:53:49 +0000 (08:53 -0700)]
[master] Merge branch 'trac2823-regression'
Marcin Siodelski [Wed, 15 May 2013 12:07:48 +0000 (14:07 +0200)]
[2786] Address review comments.
Michal 'vorner' Vaner [Wed, 15 May 2013 11:25:03 +0000 (13:25 +0200)]
[2836] Conditional code compilation
Skip some code if no shared memory support is present.
Michal 'vorner' Vaner [Wed, 15 May 2013 11:17:22 +0000 (13:17 +0200)]
[2836] Update Id generation
Use bigger type, check it never overflows.
Michal 'vorner' Vaner [Wed, 15 May 2013 11:17:09 +0000 (13:17 +0200)]
[2836] Update the docs about trees
Michal 'vorner' Vaner [Wed, 15 May 2013 10:58:20 +0000 (12:58 +0200)]
[2836] More retries on segment growing
Michal 'vorner' Vaner [Wed, 15 May 2013 10:55:20 +0000 (12:55 +0200)]
[2836] Don't leak memory on exception
If we throw an exception from the constructor, destructor is not called.
Call the clean-up manually there, so we don't leak memory.
Mukund Sivaraman [Wed, 15 May 2013 09:25:58 +0000 (14:55 +0530)]
[2823-regression] Make a minor comment update
Mukund Sivaraman [Wed, 15 May 2013 09:24:30 +0000 (14:54 +0530)]
[2823-regression] Fix test name in a comment
Michal 'vorner' Vaner [Wed, 15 May 2013 09:04:17 +0000 (11:04 +0200)]
[2836] Set the segment holder separately
Only allocate the memory for segment holder in the constructor, set it
in separate method. The allocation might throw.
Michal 'vorner' Vaner [Wed, 15 May 2013 07:54:44 +0000 (09:54 +0200)]
Merge branch 'master' into work/grow
Conflicts:
src/lib/datasrc/memory/zone_writer.cc
src/lib/datasrc/tests/memory/Makefile.am
src/lib/datasrc/tests/memory/zone_data_updater_unittest.cc
src/lib/datasrc/tests/memory/zone_finder_unittest.cc
JINMEI Tatuya [Wed, 15 May 2013 00:30:03 +0000 (17:30 -0700)]
[2522] some simple suggested fixes:
- use the unnamed namespace for the entire content to hide as many things as
possible.
- define rdata_tsig inside the fixture class to avoid initialization fiasco.
(to make it possible, also make toWireCommonChecks a member function).
JINMEI Tatuya [Wed, 15 May 2013 00:27:09 +0000 (17:27 -0700)]
[2522] trivial style fix
JINMEI Tatuya [Wed, 15 May 2013 00:06:17 +0000 (17:06 -0700)]
[2522] minor style fixes
JINMEI Tatuya [Tue, 14 May 2013 23:36:12 +0000 (16:36 -0700)]
[2522] trivial style cleanup: folded long lines
JINMEI Tatuya [Tue, 14 May 2013 22:52:00 +0000 (15:52 -0700)]
[2916] a bit more documentation
JINMEI Tatuya [Tue, 14 May 2013 22:50:19 +0000 (15:50 -0700)]
[2916] more documentation
JINMEI Tatuya [Tue, 14 May 2013 22:40:20 +0000 (15:40 -0700)]
[2916] make readCompleted a free function; it doesn't need LocalSocket attr.
JINMEI Tatuya [Tue, 14 May 2013 22:14:49 +0000 (15:14 -0700)]
[2916] catch invalid FD
Jeremy C. Reed [Tue, 14 May 2013 22:08:28 +0000 (17:08 -0500)]
[trac2653] escape double-dash so isn't converted to ndash entity
because can't copy and paste as it was
JINMEI Tatuya [Tue, 14 May 2013 21:05:21 +0000 (14:05 -0700)]
[2916] some more documentation
JINMEI Tatuya [Tue, 14 May 2013 21:04:57 +0000 (14:04 -0700)]
[2916] simplified callback call signatures
Thomas Markwalder [Tue, 14 May 2013 20:53:39 +0000 (16:53 -0400)]
[2954] Created the initial server source directory, configuration,
and make files; and process framework for the DHCP-DDNS daemon,
b10-d2srv.
JINMEI Tatuya [Tue, 14 May 2013 18:52:30 +0000 (11:52 -0700)]
[2836] style fix: adjusted '*' position
Thomas Markwalder [Tue, 14 May 2013 18:38:45 +0000 (14:38 -0400)]
[master] Merge branch 'trac2355'
JINMEI Tatuya [Tue, 14 May 2013 16:40:41 +0000 (09:40 -0700)]
[master] changelog for #2851
JINMEI Tatuya [Tue, 14 May 2013 16:28:35 +0000 (09:28 -0700)]
[master] Merge branch 'trac2851'
Mukund Sivaraman [Tue, 14 May 2013 13:20:29 +0000 (18:50 +0530)]
Merge branch 'trac2850_2'
JINMEI Tatuya [Tue, 14 May 2013 04:33:33 +0000 (21:33 -0700)]
[2850] removed now-unused inclusion and using for boost::scoped_ptr
JINMEI Tatuya [Mon, 13 May 2013 22:40:41 +0000 (15:40 -0700)]
[2916] added tests and implementation of the LocalSocket class
Thomas Markwalder [Mon, 13 May 2013 20:07:02 +0000 (16:07 -0400)]
[2355] Cleaned up some minor issues spotted in review.
Stephen Morris [Mon, 13 May 2013 14:56:58 +0000 (15:56 +0100)]
[2653] Added documentation as to how to create the test DHCP database
Mukund Sivaraman [Mon, 13 May 2013 14:30:57 +0000 (20:00 +0530)]
[2850] Update comment that it doesn't actually fail
Stephen Morris [Mon, 13 May 2013 14:11:06 +0000 (15:11 +0100)]
[master] Merge branch 'trac2909'
Marcin Siodelski [Mon, 13 May 2013 14:05:58 +0000 (16:05 +0200)]
[2786] Minor: todo comment added.
Marcin Siodelski [Mon, 13 May 2013 14:02:21 +0000 (16:02 +0200)]
[2786] Use OptionString class to represent options with a string.
Marcin Siodelski [Mon, 13 May 2013 13:03:15 +0000 (15:03 +0200)]
[2786] Implemented unpack() function of OptionString class.
Michal 'vorner' Vaner [Mon, 13 May 2013 13:00:51 +0000 (15:00 +0200)]
[2836] Attempt a test for whole zone loading
Attempt to write a test that loads a bunch of zones, probably causing a
relocation.
However, it currently crashes and does so before the relocation happens,
which is strange. It does not crash with the local segment, only with
the mapped, which is stranger.
Marcin Siodelski [Mon, 13 May 2013 12:55:31 +0000 (14:55 +0200)]
[2786] Implemented pack function of OptionString class.
Michal 'vorner' Vaner [Mon, 13 May 2013 12:52:42 +0000 (14:52 +0200)]
[2836] Clarify comment of test.
Michal 'vorner' Vaner [Mon, 13 May 2013 12:45:17 +0000 (14:45 +0200)]
[2836] The updater is never NULL in destructor
So remove the condition to check it. Keep an assert there, just in case
there was a reason originally, so we know about it.
Michal 'vorner' Vaner [Mon, 13 May 2013 12:42:03 +0000 (14:42 +0200)]
[2836] Less hacky way to access the zone data in tests
Store it separately as named address and access it every time, instead
of sneaking into the updater internal.
Marcin Siodelski [Mon, 13 May 2013 12:21:19 +0000 (14:21 +0200)]
[2786] Implemented unit tests for OptionString.
Michal 'vorner' Vaner [Mon, 13 May 2013 12:14:20 +0000 (14:14 +0200)]
[2836] Provide virtual destructor
Just to be sure
Michal 'vorner' Vaner [Mon, 13 May 2013 12:10:17 +0000 (14:10 +0200)]
[2836] Disable tests without shared memory
Disable tests using the shared memory utilities (eg. mapped segment)
when there's no shared memory support.
Michal 'vorner' Vaner [Mon, 13 May 2013 11:55:33 +0000 (13:55 +0200)]
[2836] Check for collision on the named address
Michal 'vorner' Vaner [Mon, 13 May 2013 11:19:54 +0000 (13:19 +0200)]
[2836] Store the address for whole lifetime
Store the named address for the whole lifetime of the zone data updater.
This should be better for performance.
Michal 'vorner' Vaner [Mon, 13 May 2013 11:05:19 +0000 (13:05 +0200)]
[2836] Clarify exception thrown from DomainTree::insert
Michal 'vorner' Vaner [Mon, 13 May 2013 11:00:01 +0000 (13:00 +0200)]
[2836] Retry addition to zone table
Currently untested, as there's no reasonable way to create a zone table
with mapped segment :-(.
Michal 'vorner' Vaner [Mon, 13 May 2013 10:56:31 +0000 (12:56 +0200)]
[2836] Note that a method may throw
Mukund Sivaraman [Mon, 13 May 2013 10:42:13 +0000 (16:12 +0530)]
[2850] Remove unnecessary setup of named addresses
... now that we handle this with an offset_ptr inside setNamedAddress()
itself.
Mukund Sivaraman [Mon, 13 May 2013 08:36:58 +0000 (14:06 +0530)]
[2850] Fix MemorySegmentMapped::allMemoryDeallocated() and make it non-const
Mukund Sivaraman [Mon, 13 May 2013 08:17:45 +0000 (13:47 +0530)]
[2850] Looks like flush() finalizes base_sgmt_, so we free before that
Mukund Sivaraman [Mon, 13 May 2013 07:59:05 +0000 (13:29 +0530)]
[2850] Pre-reserve some memory to workaround relocations in setNamedAddress()
This commit introduces a problem that allMemoryDeallocated() doesn't
work anymore, because the reserved memory is freed only when the segment
is destroyed.
One workaround is to temporarily release and re-reserve this memory in
allMemoryDeallocated(), but that would make it a non-const method. I
don't see any other clean way of doing this.
JINMEI Tatuya [Fri, 10 May 2013 23:52:06 +0000 (16:52 -0700)]
[2836-2] use managed_mapped_file to cause remap at different addr.
the original setup was not really portable and quite dangerous, making
a very large file.
JINMEI Tatuya [Fri, 10 May 2013 23:39:32 +0000 (16:39 -0700)]
[2836-2] make sure remapping boost segment even if grow() fails.
otherwise, subsequent cleanup to be exception safe will cause a crash.
and, if the remap fails simply abort(); there's no hope to recover from
this situation reasonably. and clarify in shrinkToFit() why it behaves
differently.
JINMEI Tatuya [Fri, 10 May 2013 23:21:37 +0000 (16:21 -0700)]
[2836-2] make sure flush()ing the base segment before grow/shrink
I was confused at the time I removed it in #2831. these were actually
necessary.
Jeremy C. Reed [Fri, 10 May 2013 17:26:44 +0000 (12:26 -0500)]
[master] update master version datestamp and fix date for 1.0.0beta2 release
Mukund Sivaraman [Fri, 10 May 2013 14:25:40 +0000 (19:55 +0530)]
[2850] Throw std::bad_alloc if ZoneTable::create() throws MemorySegmentGrown
We don't attempt to recover in this case.
Also change some error handling to simply asserts.
Mukund Sivaraman [Fri, 10 May 2013 14:18:07 +0000 (19:48 +0530)]
[2850] Make more updates to ZoneTableSegment API documentation
Mukund Sivaraman [Fri, 10 May 2013 13:58:58 +0000 (19:28 +0530)]
[2850] Make more updates to ZoneTableSegment API documentation
Mukund Sivaraman [Fri, 10 May 2013 13:48:33 +0000 (19:18 +0530)]
[2850] Update Makefile.am for renamed files
Mukund Sivaraman [Fri, 10 May 2013 13:46:27 +0000 (19:16 +0530)]
[2850] Update ZoneTableSegment API documentation