]> git.ipfire.org Git - thirdparty/kea.git/log
thirdparty/kea.git
13 years ago[2786] Always validate the contents of the buffer when provided.
Marcin Siodelski [Thu, 16 May 2013 08:28:19 +0000 (10:28 +0200)] 
[2786] Always validate the contents of the buffer when provided.

13 years ago[2786] Minor: added option code to the exception string.
Marcin Siodelski [Thu, 16 May 2013 07:53:40 +0000 (09:53 +0200)] 
[2786] Minor: added option code to the exception string.

13 years ago[2876] Minor: added paranthesis in the return statement.
Marcin Siodelski [Thu, 16 May 2013 07:44:58 +0000 (09:44 +0200)] 
[2876] Minor: added paranthesis in the return statement.

13 years ago[2946] get access to base class's static method via 'this' pointer
JINMEI Tatuya [Thu, 16 May 2013 05:41:27 +0000 (22:41 -0700)] 
[2946] get access to base class's static method via 'this' pointer

as some compilers don't allow direct use of Base::method.

13 years agoMerge branch 'trac2522' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2522
Paul Selkirk [Thu, 16 May 2013 03:39:14 +0000 (23:39 -0400)] 
Merge branch 'trac2522' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2522

Conflicts:
src/lib/dns/gen-rdatacode.py.in

13 years ago[2522] some simple suggested fixes:
JINMEI Tatuya [Wed, 15 May 2013 00:30:03 +0000 (17:30 -0700)] 
[2522] some simple suggested fixes:

- use the unnamed namespace for the entire content to hide as many things as
  possible.
- define rdata_tsig inside the fixture class to avoid initialization fiasco.
  (to make it possible, also make toWireCommonChecks a member function).

13 years ago[2522] trivial style fix
JINMEI Tatuya [Wed, 15 May 2013 00:27:09 +0000 (17:27 -0700)] 
[2522] trivial style fix

13 years ago[2522] minor style fixes
JINMEI Tatuya [Wed, 15 May 2013 00:06:17 +0000 (17:06 -0700)] 
[2522] minor style fixes

13 years ago[2522] trivial style cleanup: folded long lines
JINMEI Tatuya [Tue, 14 May 2013 23:36:12 +0000 (16:36 -0700)] 
[2522] trivial style cleanup: folded long lines

13 years ago[2522] fix a typo
Paul Selkirk [Wed, 8 May 2013 15:29:02 +0000 (11:29 -0400)] 
[2522] fix a typo

13 years ago[2522] initialize impl_ directly in TSIG lexer constructor
Paul Selkirk [Wed, 8 May 2013 14:59:40 +0000 (10:59 -0400)] 
[2522] initialize impl_ directly in TSIG lexer constructor

13 years ago[2522] TSIG algorigthm can be a reference, maybe a bit more efficient
Paul Selkirk [Wed, 8 May 2013 04:35:22 +0000 (00:35 -0400)] 
[2522] TSIG algorigthm can be a reference, maybe a bit more efficient

13 years ago[2522] convert TSIG string constructor tests to checkFromText
Paul Selkirk [Wed, 8 May 2013 03:58:42 +0000 (23:58 -0400)] 
[2522] convert TSIG string constructor tests to checkFromText

13 years ago[2522] more TSIG unit tests
Paul Selkirk [Wed, 8 May 2013 02:13:22 +0000 (22:13 -0400)] 
[2522] more TSIG unit tests

13 years ago[2522] add MasterLexer constructor for TSIG
Paul Selkirk [Tue, 7 May 2013 19:59:29 +0000 (15:59 -0400)] 
[2522] add MasterLexer constructor for TSIG

13 years ago[2522] fix RP unit test
Paul Selkirk [Tue, 7 May 2013 17:16:17 +0000 (13:16 -0400)] 
[2522] fix RP unit test

13 years ago[2522] more MINFO unit tests
Paul Selkirk [Tue, 7 May 2013 17:08:27 +0000 (13:08 -0400)] 
[2522] more MINFO unit tests

13 years ago[2522] add MasterLexer constructor for MINFO
Paul Selkirk [Mon, 6 May 2013 14:30:04 +0000 (10:30 -0400)] 
[2522] add MasterLexer constructor for MINFO

13 years ago[2522] normalize some RP documentation comments
Paul Selkirk [Mon, 6 May 2013 14:28:55 +0000 (10:28 -0400)] 
[2522] normalize some RP documentation comments

13 years ago[2522] add MasterLexer constructor for RP
Paul Selkirk [Sat, 4 May 2013 23:25:30 +0000 (19:25 -0400)] 
[2522] add MasterLexer constructor for RP

13 years ago[2946] pass shared_ptr, not a reference to deadline pointer.
JINMEI Tatuya [Thu, 16 May 2013 00:09:25 +0000 (17:09 -0700)] 
[2946] pass shared_ptr, not a reference to deadline pointer.

I suspect the previous version could cause the same type of use-after-free
bug, although I couldn't come up with an effective test scenario.

13 years ago[2946] documentation update
JINMEI Tatuya [Thu, 16 May 2013 00:03:49 +0000 (17:03 -0700)] 
[2946] documentation update

13 years ago[2946] mix enable_shared_from_this in SyncUDPServer to prevent use-after-free.
JINMEI Tatuya [Wed, 15 May 2013 23:57:07 +0000 (16:57 -0700)] 
[2946] mix enable_shared_from_this in SyncUDPServer to prevent use-after-free.

to enforce this style of creation, introduce a static factory method and
hide the constructor as private.

13 years ago[2946] added a test case to reproduce the use-after-free situation
JINMEI Tatuya [Wed, 15 May 2013 23:42:08 +0000 (16:42 -0700)] 
[2946] added a test case to reproduce the use-after-free situation

13 years ago[2946] use shared_ptr of DNSServer objects for tests
JINMEI Tatuya [Wed, 15 May 2013 19:00:20 +0000 (12:00 -0700)] 
[2946] use shared_ptr of DNSServer objects for tests

13 years ago[2786] Option factory function uses iterators to create OptionCustom.
Marcin Siodelski [Wed, 15 May 2013 19:31:07 +0000 (21:31 +0200)] 
[2786] Option factory function uses iterators to create OptionCustom.

13 years ago[2916] corrected handling of aux socket wrt exception safety
JINMEI Tatuya [Wed, 15 May 2013 18:31:57 +0000 (11:31 -0700)] 
[2916] corrected handling of aux socket wrt exception safety

13 years ago[2916] clarified what would happen if write blocks, and then return from test.
JINMEI Tatuya [Wed, 15 May 2013 18:27:21 +0000 (11:27 -0700)] 
[2916] clarified what would happen if write blocks, and then return from test.

it should be safe to continue as clarified in the comment, but it's probably
better to eliminate any possibility of hangup.

13 years ago[2916] reset global IOService to NULL at end of test for safer operation
JINMEI Tatuya [Wed, 15 May 2013 18:22:18 +0000 (11:22 -0700)] 
[2916] reset global IOService to NULL at end of test for safer operation

13 years ago[2916] clear alarm in the test's destructor.
JINMEI Tatuya [Wed, 15 May 2013 18:16:33 +0000 (11:16 -0700)] 
[2916] clear alarm in the test's destructor.

13 years ago[2836] style fixes: unify short lines
JINMEI Tatuya [Wed, 15 May 2013 17:44:45 +0000 (10:44 -0700)] 
[2836] style fixes: unify short lines

13 years ago[2836] style fix: unify two short lines
JINMEI Tatuya [Wed, 15 May 2013 17:30:03 +0000 (10:30 -0700)] 
[2836] style fix: unify two short lines

13 years ago[2836] corrected minor typo in doxygen doc
JINMEI Tatuya [Wed, 15 May 2013 16:57:29 +0000 (09:57 -0700)] 
[2836] corrected minor typo in doxygen doc

13 years ago[2954] Removed inadvertant addition of executable, d2srv_unittests.
Thomas Markwalder [Wed, 15 May 2013 16:45:38 +0000 (12:45 -0400)] 
[2954] Removed inadvertant addition of executable, d2srv_unittests.

13 years ago[2594] Moved d2Srv to d2, removed "Srv" and "srv" from file names
Thomas Markwalder [Wed, 15 May 2013 16:41:42 +0000 (12:41 -0400)] 
[2594] Moved d2Srv to d2, removed "Srv" and "srv" from file names
and source. Corrected other review items.

13 years ago[2836] make tests safer when USE_SHARED_MEMORY is undefined.
JINMEI Tatuya [Wed, 15 May 2013 16:40:07 +0000 (09:40 -0700)] 
[2836] make tests safer when USE_SHARED_MEMORY is undefined.

- explicitly include config.h in these tests
- move helper function only used with USE_SHARED_MEMORY inside the ifdef block

13 years ago[master] Merge branch 'trac2899-2'
JINMEI Tatuya [Wed, 15 May 2013 15:59:28 +0000 (08:59 -0700)] 
[master] Merge branch 'trac2899-2'

13 years ago[master] Merge branch 'trac2823-regression'
JINMEI Tatuya [Wed, 15 May 2013 15:53:49 +0000 (08:53 -0700)] 
[master] Merge branch 'trac2823-regression'

13 years ago[2786] Address review comments.
Marcin Siodelski [Wed, 15 May 2013 12:07:48 +0000 (14:07 +0200)] 
[2786] Address review comments.

13 years ago[2836] Conditional code compilation
Michal 'vorner' Vaner [Wed, 15 May 2013 11:25:03 +0000 (13:25 +0200)] 
[2836] Conditional code compilation

Skip some code if no shared memory support is present.

13 years ago[2836] Update Id generation
Michal 'vorner' Vaner [Wed, 15 May 2013 11:17:22 +0000 (13:17 +0200)] 
[2836] Update Id generation

Use bigger type, check it never overflows.

13 years ago[2836] Update the docs about trees
Michal 'vorner' Vaner [Wed, 15 May 2013 11:17:09 +0000 (13:17 +0200)] 
[2836] Update the docs about trees

13 years ago[2836] More retries on segment growing
Michal 'vorner' Vaner [Wed, 15 May 2013 10:58:20 +0000 (12:58 +0200)] 
[2836] More retries on segment growing

13 years ago[2836] Don't leak memory on exception
Michal 'vorner' Vaner [Wed, 15 May 2013 10:55:20 +0000 (12:55 +0200)] 
[2836] Don't leak memory on exception

If we throw an exception from the constructor, destructor is not called.
Call the clean-up manually there, so we don't leak memory.

13 years ago[2823-regression] Make a minor comment update
Mukund Sivaraman [Wed, 15 May 2013 09:25:58 +0000 (14:55 +0530)] 
[2823-regression] Make a minor comment update

13 years ago[2823-regression] Fix test name in a comment
Mukund Sivaraman [Wed, 15 May 2013 09:24:30 +0000 (14:54 +0530)] 
[2823-regression] Fix test name in a comment

13 years ago[2836] Set the segment holder separately
Michal 'vorner' Vaner [Wed, 15 May 2013 09:04:17 +0000 (11:04 +0200)] 
[2836] Set the segment holder separately

Only allocate the memory for segment holder in the constructor, set it
in separate method. The allocation might throw.

13 years agoMerge branch 'master' into work/grow
Michal 'vorner' Vaner [Wed, 15 May 2013 07:54:44 +0000 (09:54 +0200)] 
Merge branch 'master' into work/grow

Conflicts:
src/lib/datasrc/memory/zone_writer.cc
src/lib/datasrc/tests/memory/Makefile.am
src/lib/datasrc/tests/memory/zone_data_updater_unittest.cc
src/lib/datasrc/tests/memory/zone_finder_unittest.cc

13 years ago[2522] some simple suggested fixes:
JINMEI Tatuya [Wed, 15 May 2013 00:30:03 +0000 (17:30 -0700)] 
[2522] some simple suggested fixes:

- use the unnamed namespace for the entire content to hide as many things as
  possible.
- define rdata_tsig inside the fixture class to avoid initialization fiasco.
  (to make it possible, also make toWireCommonChecks a member function).

13 years ago[2522] trivial style fix
JINMEI Tatuya [Wed, 15 May 2013 00:27:09 +0000 (17:27 -0700)] 
[2522] trivial style fix

13 years ago[2522] minor style fixes
JINMEI Tatuya [Wed, 15 May 2013 00:06:17 +0000 (17:06 -0700)] 
[2522] minor style fixes

13 years ago[2522] trivial style cleanup: folded long lines
JINMEI Tatuya [Tue, 14 May 2013 23:36:12 +0000 (16:36 -0700)] 
[2522] trivial style cleanup: folded long lines

13 years ago[2916] a bit more documentation
JINMEI Tatuya [Tue, 14 May 2013 22:52:00 +0000 (15:52 -0700)] 
[2916] a bit more documentation

13 years ago[2916] more documentation
JINMEI Tatuya [Tue, 14 May 2013 22:50:19 +0000 (15:50 -0700)] 
[2916] more documentation

13 years ago[2916] make readCompleted a free function; it doesn't need LocalSocket attr.
JINMEI Tatuya [Tue, 14 May 2013 22:40:20 +0000 (15:40 -0700)] 
[2916] make readCompleted a free function; it doesn't need LocalSocket attr.

13 years ago[2916] catch invalid FD
JINMEI Tatuya [Tue, 14 May 2013 22:14:49 +0000 (15:14 -0700)] 
[2916] catch invalid FD

13 years ago[trac2653] escape double-dash so isn't converted to ndash entity
Jeremy C. Reed [Tue, 14 May 2013 22:08:28 +0000 (17:08 -0500)] 
[trac2653] escape double-dash so isn't converted to ndash entity

because can't copy and paste as it was

13 years ago[2916] some more documentation
JINMEI Tatuya [Tue, 14 May 2013 21:05:21 +0000 (14:05 -0700)] 
[2916] some more documentation

13 years ago[2916] simplified callback call signatures
JINMEI Tatuya [Tue, 14 May 2013 21:04:57 +0000 (14:04 -0700)] 
[2916] simplified callback call signatures

13 years ago[2954] Created the initial server source directory, configuration,
Thomas Markwalder [Tue, 14 May 2013 20:53:39 +0000 (16:53 -0400)] 
[2954] Created the initial server source directory, configuration,
and make files; and process framework for the DHCP-DDNS daemon,
b10-d2srv.

13 years ago[2836] style fix: adjusted '*' position
JINMEI Tatuya [Tue, 14 May 2013 18:52:30 +0000 (11:52 -0700)] 
[2836] style fix: adjusted '*' position

13 years ago[master] Merge branch 'trac2355'
Thomas Markwalder [Tue, 14 May 2013 18:38:45 +0000 (14:38 -0400)] 
[master] Merge branch 'trac2355'

13 years ago[master] changelog for #2851
JINMEI Tatuya [Tue, 14 May 2013 16:40:41 +0000 (09:40 -0700)] 
[master] changelog for #2851

13 years ago[master] Merge branch 'trac2851'
JINMEI Tatuya [Tue, 14 May 2013 16:28:35 +0000 (09:28 -0700)] 
[master] Merge branch 'trac2851'

13 years agoMerge branch 'trac2850_2'
Mukund Sivaraman [Tue, 14 May 2013 13:20:29 +0000 (18:50 +0530)] 
Merge branch 'trac2850_2'

13 years ago[2850] removed now-unused inclusion and using for boost::scoped_ptr
JINMEI Tatuya [Tue, 14 May 2013 04:33:33 +0000 (21:33 -0700)] 
[2850] removed now-unused inclusion and using for boost::scoped_ptr

13 years ago[2916] added tests and implementation of the LocalSocket class
JINMEI Tatuya [Mon, 13 May 2013 22:40:41 +0000 (15:40 -0700)] 
[2916] added tests and implementation of the LocalSocket class

13 years ago[2355] Cleaned up some minor issues spotted in review.
Thomas Markwalder [Mon, 13 May 2013 20:07:02 +0000 (16:07 -0400)] 
[2355] Cleaned up some minor issues spotted in review.

13 years ago[2653] Added documentation as to how to create the test DHCP database
Stephen Morris [Mon, 13 May 2013 14:56:58 +0000 (15:56 +0100)] 
[2653] Added documentation as to how to create the test DHCP database

13 years ago[2850] Update comment that it doesn't actually fail
Mukund Sivaraman [Mon, 13 May 2013 14:30:57 +0000 (20:00 +0530)] 
[2850] Update comment that it doesn't actually fail

13 years ago[master] Merge branch 'trac2909'
Stephen Morris [Mon, 13 May 2013 14:11:06 +0000 (15:11 +0100)] 
[master] Merge branch 'trac2909'

13 years ago[2786] Minor: todo comment added.
Marcin Siodelski [Mon, 13 May 2013 14:05:58 +0000 (16:05 +0200)] 
[2786] Minor: todo comment added.

13 years ago[2786] Use OptionString class to represent options with a string.
Marcin Siodelski [Mon, 13 May 2013 14:02:21 +0000 (16:02 +0200)] 
[2786] Use OptionString class to represent options with a string.

13 years ago[2786] Implemented unpack() function of OptionString class.
Marcin Siodelski [Mon, 13 May 2013 13:03:15 +0000 (15:03 +0200)] 
[2786] Implemented unpack() function of OptionString class.

13 years ago[2836] Attempt a test for whole zone loading
Michal 'vorner' Vaner [Mon, 13 May 2013 13:00:51 +0000 (15:00 +0200)] 
[2836] Attempt a test for whole zone loading

Attempt to write a test that loads a bunch of zones, probably causing a
relocation.

However, it currently crashes and does so before the relocation happens,
which is strange. It does not crash with the local segment, only with
the mapped, which is stranger.

13 years ago[2786] Implemented pack function of OptionString class.
Marcin Siodelski [Mon, 13 May 2013 12:55:31 +0000 (14:55 +0200)] 
[2786] Implemented pack function of OptionString class.

13 years ago[2836] Clarify comment of test.
Michal 'vorner' Vaner [Mon, 13 May 2013 12:52:42 +0000 (14:52 +0200)] 
[2836] Clarify comment of test.

13 years ago[2836] The updater is never NULL in destructor
Michal 'vorner' Vaner [Mon, 13 May 2013 12:45:17 +0000 (14:45 +0200)] 
[2836] The updater is never NULL in destructor

So remove the condition to check it. Keep an assert there, just in case
there was a reason originally, so we know about it.

13 years ago[2836] Less hacky way to access the zone data in tests
Michal 'vorner' Vaner [Mon, 13 May 2013 12:42:03 +0000 (14:42 +0200)] 
[2836] Less hacky way to access the zone data in tests

Store it separately as named address and access it every time, instead
of sneaking into the updater internal.

13 years ago[2786] Implemented unit tests for OptionString.
Marcin Siodelski [Mon, 13 May 2013 12:21:19 +0000 (14:21 +0200)] 
[2786] Implemented unit tests for OptionString.

13 years ago[2836] Provide virtual destructor
Michal 'vorner' Vaner [Mon, 13 May 2013 12:14:20 +0000 (14:14 +0200)] 
[2836] Provide virtual destructor

Just to be sure

13 years ago[2836] Disable tests without shared memory
Michal 'vorner' Vaner [Mon, 13 May 2013 12:10:17 +0000 (14:10 +0200)] 
[2836] Disable tests without shared memory

Disable tests using the shared memory utilities (eg. mapped segment)
when there's no shared memory support.

13 years ago[2836] Check for collision on the named address
Michal 'vorner' Vaner [Mon, 13 May 2013 11:55:33 +0000 (13:55 +0200)] 
[2836] Check for collision on the named address

13 years ago[2836] Store the address for whole lifetime
Michal 'vorner' Vaner [Mon, 13 May 2013 11:19:54 +0000 (13:19 +0200)] 
[2836] Store the address for whole lifetime

Store the named address for the whole lifetime of the zone data updater.
This should be better for performance.

13 years ago[2836] Clarify exception thrown from DomainTree::insert
Michal 'vorner' Vaner [Mon, 13 May 2013 11:05:19 +0000 (13:05 +0200)] 
[2836] Clarify exception thrown from DomainTree::insert

13 years ago[2836] Retry addition to zone table
Michal 'vorner' Vaner [Mon, 13 May 2013 11:00:01 +0000 (13:00 +0200)] 
[2836] Retry addition to zone table

Currently untested, as there's no reasonable way to create a zone table
with mapped segment :-(.

13 years ago[2836] Note that a method may throw
Michal 'vorner' Vaner [Mon, 13 May 2013 10:56:31 +0000 (12:56 +0200)] 
[2836] Note that a method may throw

13 years ago[2850] Remove unnecessary setup of named addresses
Mukund Sivaraman [Mon, 13 May 2013 10:42:13 +0000 (16:12 +0530)] 
[2850] Remove unnecessary setup of named addresses

... now that we handle this with an offset_ptr inside setNamedAddress()
itself.

13 years ago[2850] Fix MemorySegmentMapped::allMemoryDeallocated() and make it non-const
Mukund Sivaraman [Mon, 13 May 2013 08:36:58 +0000 (14:06 +0530)] 
[2850] Fix MemorySegmentMapped::allMemoryDeallocated() and make it non-const

13 years ago[2850] Looks like flush() finalizes base_sgmt_, so we free before that
Mukund Sivaraman [Mon, 13 May 2013 08:17:45 +0000 (13:47 +0530)] 
[2850] Looks like flush() finalizes base_sgmt_, so we free before that

13 years ago[2850] Pre-reserve some memory to workaround relocations in setNamedAddress()
Mukund Sivaraman [Mon, 13 May 2013 07:59:05 +0000 (13:29 +0530)] 
[2850] Pre-reserve some memory to workaround relocations in setNamedAddress()

This commit introduces a problem that allMemoryDeallocated() doesn't
work anymore, because the reserved memory is freed only when the segment
is destroyed.

One workaround is to temporarily release and re-reserve this memory in
allMemoryDeallocated(), but that would make it a non-const method.  I
don't see any other clean way of doing this.

13 years ago[2836-2] use managed_mapped_file to cause remap at different addr.
JINMEI Tatuya [Fri, 10 May 2013 23:52:06 +0000 (16:52 -0700)] 
[2836-2] use managed_mapped_file to cause remap at different addr.

the original setup was not really portable and quite dangerous, making
a very large file.

13 years ago[2836-2] make sure remapping boost segment even if grow() fails.
JINMEI Tatuya [Fri, 10 May 2013 23:39:32 +0000 (16:39 -0700)] 
[2836-2] make sure remapping boost segment even if grow() fails.

otherwise, subsequent cleanup to be exception safe will cause a crash.
and, if the remap fails simply abort(); there's no hope to recover from
this situation reasonably.  and clarify in shrinkToFit() why it behaves
differently.

13 years ago[2836-2] make sure flush()ing the base segment before grow/shrink
JINMEI Tatuya [Fri, 10 May 2013 23:21:37 +0000 (16:21 -0700)] 
[2836-2] make sure flush()ing the base segment before grow/shrink

I was confused at the time I removed it in #2831.  these were actually
necessary.

13 years ago[master] update master version datestamp and fix date for 1.0.0beta2 release
Jeremy C. Reed [Fri, 10 May 2013 17:26:44 +0000 (12:26 -0500)] 
[master] update master version datestamp and fix date for 1.0.0beta2 release

13 years ago[2850] Throw std::bad_alloc if ZoneTable::create() throws MemorySegmentGrown
Mukund Sivaraman [Fri, 10 May 2013 14:25:40 +0000 (19:55 +0530)] 
[2850] Throw std::bad_alloc if ZoneTable::create() throws MemorySegmentGrown

We don't attempt to recover in this case.

Also change some error handling to simply asserts.

13 years ago[2850] Make more updates to ZoneTableSegment API documentation
Mukund Sivaraman [Fri, 10 May 2013 14:18:07 +0000 (19:48 +0530)] 
[2850] Make more updates to ZoneTableSegment API documentation

13 years ago[2850] Make more updates to ZoneTableSegment API documentation
Mukund Sivaraman [Fri, 10 May 2013 13:58:58 +0000 (19:28 +0530)] 
[2850] Make more updates to ZoneTableSegment API documentation

13 years ago[2850] Update Makefile.am for renamed files
Mukund Sivaraman [Fri, 10 May 2013 13:48:33 +0000 (19:18 +0530)] 
[2850] Update Makefile.am for renamed files

13 years ago[2850] Update ZoneTableSegment API documentation
Mukund Sivaraman [Fri, 10 May 2013 13:46:27 +0000 (19:16 +0530)] 
[2850] Update ZoneTableSegment API documentation