]>
git.ipfire.org Git - thirdparty/kea.git/log
Mukund Sivaraman [Fri, 10 May 2013 12:52:46 +0000 (18:22 +0530)]
[2850] Add API doc comments about plans to make reset(), etc. non-virtual
Mukund Sivaraman [Fri, 10 May 2013 12:48:39 +0000 (18:18 +0530)]
[2850] Add explicit include for zone_table_segment.h
Mukund Sivaraman [Fri, 10 May 2013 12:39:41 +0000 (18:09 +0530)]
[2850] Add default case for switch on MemorySegmentOpenMode
Michal 'vorner' Vaner [Fri, 10 May 2013 11:37:12 +0000 (13:37 +0200)]
[2836] Make segment holder survive relocation
Let the SegmentObjectHolder store the object's address in the segment's
named addresses, so it moves correctly when the segment is relocated.
Mukund Sivaraman [Fri, 10 May 2013 09:52:21 +0000 (15:22 +0530)]
[2850] Add tests to check that resetHeader() is called by ZoneWriter class
Initially I thought it was not possible to test this as
ZoneTableSegment::create() was used to create the zone table segment,
but it seems it's possible to do it this way using a mock class.
Michal 'vorner' Vaner [Fri, 10 May 2013 08:23:06 +0000 (10:23 +0200)]
[2836] Test that segment holder survives relocation
Test that the SegmentObjectHolder survives when the segment relocates
itself and correctly releases all its memory.
Mukund Sivaraman [Fri, 10 May 2013 03:01:04 +0000 (08:31 +0530)]
[2850] Change style of code to fix buildbot failures
JINMEI Tatuya [Thu, 9 May 2013 22:32:31 +0000 (15:32 -0700)]
[2899] renamed namespace for InterprocessSync "interprocess" for consistency.
JINMEI Tatuya [Thu, 9 May 2013 20:20:30 +0000 (13:20 -0700)]
[2899] Merge branch 'trac2899' into trac2899-2
JINMEI Tatuya [Thu, 9 May 2013 20:21:05 +0000 (20:21 +0000)]
[2899] explicitly LDADD libb10-threads from log lock test
seems to be necessary for some OS. also explicitly include the relevant
header file.
JINMEI Tatuya [Thu, 9 May 2013 20:20:15 +0000 (13:20 -0700)]
[2899] Merge branch 'trac2823-regression' into trac2899-2
Tomek Mrugalski [Thu, 9 May 2013 15:12:18 +0000 (17:12 +0200)]
[master] Merge branch 'trac2898' (DHCPv6 relayed traffic)
Conflicts:
src/lib/dhcp/tests/pkt6_unittest.cc
Tomek Mrugalski [Thu, 9 May 2013 13:43:20 +0000 (15:43 +0200)]
Merge branch 'trac2898' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2898
Tomek Mrugalski [Thu, 9 May 2013 13:43:02 +0000 (15:43 +0200)]
[2898] comment updated in one dhcp6/config_parser test
Mukund Sivaraman [Thu, 9 May 2013 13:10:37 +0000 (18:40 +0530)]
[2850] Add isUsable() and getImplType() methods
It would be better if these were static (to save on space and also to
use them inside ZoneTableSegment::create()), but unfortunately we cannot
make it virtual then. Another option would be to pass a static string
from ZoneTableSegment::create() onto the ZoneTableSegment constructor
and make it a non-virtual base class method.
Mukund Sivaraman [Thu, 9 May 2013 12:38:27 +0000 (18:08 +0530)]
[2850] Rename MemorySegmentTest to MemorySegmentMock (to not resemble a fixture)
Mukund Sivaraman [Thu, 9 May 2013 12:28:31 +0000 (17:58 +0530)]
[2850] Rename ZoneTableSegmentTest to ZoneTableSegmentMock (to not resemble a fixture)
Mukund Sivaraman [Thu, 9 May 2013 12:14:49 +0000 (17:44 +0530)]
[2850] Destroy ZoneTableSegment object upon exception (see full log)
Ideally, this should use something like a SegmentObjectHolder, but a
SegmentObjectHolder takes unnecessary arguments. In this limited
usecase, ZoneTableSegment::destroy() just calls its destructor, so
std::auto_ptr should be ok here.
Stephen Morris [Thu, 9 May 2013 09:54:56 +0000 (10:54 +0100)]
[2909] Updated schema_copy.h to more accurately reflect the database schema
When the MySql lease manager tests create the database, they now also
create all the indexes as well.
Mukund Sivaraman [Thu, 9 May 2013 09:28:15 +0000 (14:58 +0530)]
[2850] Add CREATE over corrupted file testcase
Mukund Sivaraman [Thu, 9 May 2013 09:20:40 +0000 (14:50 +0530)]
[2850] Check that the old data is still available after the corruption tests
Mukund Sivaraman [Thu, 9 May 2013 08:52:27 +0000 (14:22 +0530)]
[2850] Remove obsolete comment (isWritable() no longer throws)
Mukund Sivaraman [Thu, 9 May 2013 08:50:51 +0000 (14:20 +0530)]
[2850] Add a test for clear() on an uninitialized segment
Mukund Sivaraman [Thu, 9 May 2013 08:10:44 +0000 (13:40 +0530)]
[2850] Add resetHeader() method
JINMEI Tatuya [Thu, 9 May 2013 06:05:14 +0000 (23:05 -0700)]
[master] exit from SyncUDPServer::handleRead immediately if stopped.
while not really correct, this seems to work as a workaround for the crash
problem reported in #2946.
okayed on jabber.
JINMEI Tatuya [Thu, 9 May 2013 05:08:27 +0000 (22:08 -0700)]
[master] don't initialize test data objects in namescope level.
this caused statici initialization fiasco for some build, e.g.:
http://git.bind10.isc.org/~tester/builder/BIND10/
20130508225127 -MacOSX10.6-x86_64-Clang-Static/logs/unittests.out
string objects moved inside the compare tests did not actually cause harm
in this environment, but should be generally better to be initialized
this way for the same reason.
while it's not a kind of 5-line patch, it should be pretty straightforward,
so I'm committing it at my discretion.
JINMEI Tatuya [Thu, 9 May 2013 03:21:58 +0000 (20:21 -0700)]
[2899] added a README file explaining the intent of the interproc stuff
JINMEI Tatuya [Thu, 9 May 2013 03:15:10 +0000 (20:15 -0700)]
[2899] hide the interprocess stuff from public log API more.
- not include the header file, but use a forward declaration
- added a note that setInterprocessSync shouldn't be used by normal apps
JINMEI Tatuya [Thu, 9 May 2013 00:16:42 +0000 (17:16 -0700)]
[2899] move interprocess-lock related things under lib/log/interprocess
also
- a utility for tests using multi processes was moved under lib/util/unittests
- other Makefile adjustments
Jeremy C. Reed [Wed, 8 May 2013 23:29:23 +0000 (18:29 -0500)]
[trac2945] miscellaneous doxygen warnings worked on
Still have lots to do.
Some of these marked with TODO indicating needing further work
(but better than it was before).
JINMEI Tatuya [Wed, 8 May 2013 23:03:14 +0000 (16:03 -0700)]
[2851] check return value of insertZone of mock data source, just in case.
JINMEI Tatuya [Wed, 8 May 2013 22:47:10 +0000 (15:47 -0700)]
[2851] added missing parameter description.
JINMEI Tatuya [Wed, 8 May 2013 22:45:40 +0000 (15:45 -0700)]
[2851] corrected an error code in documentation (a simple typo)
JINMEI Tatuya [Wed, 8 May 2013 22:41:49 +0000 (15:41 -0700)]
[2851] use "non writable" instead of read-only for a test case on this.
in some sense they mean the same thing, but technically there's a subtle
difference between them; "non writable" includes the case the cache (segment)
isn't usable at atll. calling it "read-only" is not really correct.
JINMEI Tatuya [Wed, 8 May 2013 22:39:19 +0000 (15:39 -0700)]
[2851] updated description of NOT_WRITABLE.
"yet" seemed to be confusing; while we could explain it more, it's probably
not much of interest for the caller anyway, and this is expected to be
a concise description. so I chose it rather simpler.
JINMEI Tatuya [Wed, 8 May 2013 22:37:47 +0000 (15:37 -0700)]
[2851] added a new test case for reloading a zone added to the datasrc later
JINMEI Tatuya [Wed, 8 May 2013 22:25:51 +0000 (15:25 -0700)]
[2851] updated comment wording for reloadZoneGone test.
it now doesn't throw an exception but reject the attempt with an error code.
JINMEI Tatuya [Wed, 8 May 2013 21:58:18 +0000 (14:58 -0700)]
[2836] style fixes: constify, folded a long line.
JINMEI Tatuya [Wed, 8 May 2013 21:26:32 +0000 (14:26 -0700)]
[2836] style fixes: add () for return
JINMEI Tatuya [Wed, 8 May 2013 20:57:53 +0000 (13:57 -0700)]
[2836] editorial cleanup: removed an unnecessary semicolon.
Stephen Morris [Wed, 8 May 2013 17:33:25 +0000 (18:33 +0100)]
[2898] Minor editing changes to DHCPv6 relay text
Paul Selkirk [Wed, 8 May 2013 15:37:31 +0000 (11:37 -0400)]
Merge branch 'trac2521'
Conflicts:
src/lib/dns/gen-rdatacode.py.in
Paul Selkirk [Wed, 8 May 2013 15:29:02 +0000 (11:29 -0400)]
[2522] fix a typo
Paul Selkirk [Wed, 8 May 2013 14:59:40 +0000 (10:59 -0400)]
[2522] initialize impl_ directly in TSIG lexer constructor
Mukund Sivaraman [Wed, 8 May 2013 12:06:45 +0000 (17:36 +0530)]
[2850] Include <cerrno> for errno
Mukund Sivaraman [Wed, 8 May 2013 12:05:50 +0000 (17:35 +0530)]
[2850] Simplify the corruption of checksum
Mukund Sivaraman [Wed, 8 May 2013 12:01:06 +0000 (17:31 +0530)]
[2850] Use pre-created test data so that it's not confusing to check
Mukund Sivaraman [Wed, 8 May 2013 11:38:53 +0000 (17:08 +0530)]
[2850] Remove unnecessary use of scoped_ptr
Mukund Sivaraman [Wed, 8 May 2013 11:32:16 +0000 (17:02 +0530)]
[2850] Handle current_filename_ assignment causing an exception
Mukund Sivaraman [Wed, 8 May 2013 11:24:30 +0000 (16:54 +0530)]
[2850] Make getHeader() return the current address of header
It could have been relocated since its construction.
Mukund Sivaraman [Wed, 8 May 2013 11:13:41 +0000 (16:43 +0530)]
[2850] Remove obsolete comment
Mukund Sivaraman [Wed, 8 May 2013 11:00:17 +0000 (16:30 +0530)]
[2850] Fix address name generation
Stephen Morris [Wed, 8 May 2013 10:54:45 +0000 (11:54 +0100)]
[2467] Merge branch 'master' into trac2467
Conflicts:
src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
src/lib/dhcp/tests/iface_mgr_unittest.cc
Tomek Mrugalski [Wed, 8 May 2013 09:30:50 +0000 (11:30 +0200)]
[2898] Compilation fix after recent changes.
Tomek Mrugalski [Wed, 8 May 2013 09:22:40 +0000 (11:22 +0200)]
[2898] pair<a,b> replaced with make_pair
Tomek Mrugalski [Wed, 8 May 2013 09:21:59 +0000 (11:21 +0200)]
[2898] Second part of changes after review
JINMEI Tatuya [Wed, 8 May 2013 07:20:18 +0000 (00:20 -0700)]
[2823-regression] make test_polling_init indepent from ordering of "getstat"s
with multi-module setup, it can sometimes fail with python3.3 due to its
unpredictable hash values (and the internal ordering of dictionaries).
JINMEI Tatuya [Wed, 8 May 2013 07:18:54 +0000 (00:18 -0700)]
[2823-regression] mock mccs.check_command for MyStatsHttpd.
our tests basically shouldn't call this method, but, as commented, it could
still happen on some buggy OSes. we need to work around it.
JINMEI Tatuya [Wed, 8 May 2013 07:16:11 +0000 (00:16 -0700)]
[2823-regression] shutdown MyStatsHttpd running on a separate thread
the dangling threads do not necessarily do harm (test failure, etc),
but show confusing behaviors such as leaked exception. explicit shutdown
should prevent these (for a longer term, we should really stop using threads
for the http-handler tests)
Paul Selkirk [Wed, 8 May 2013 04:35:22 +0000 (00:35 -0400)]
[2522] TSIG algorigthm can be a reference, maybe a bit more efficient
Paul Selkirk [Wed, 8 May 2013 03:58:42 +0000 (23:58 -0400)]
[2522] convert TSIG string constructor tests to checkFromText
JINMEI Tatuya [Wed, 8 May 2013 03:43:17 +0000 (20:43 -0700)]
[master] use AF_UNIX socket.socket object instead of socket.socketpair()[0]
for "dummy" socket. in python3.1 the latter is of _socket.socket, which
breaks the assumption of a test.
okayed on bind10-dev.
Paul Selkirk [Wed, 8 May 2013 02:13:22 +0000 (22:13 -0400)]
[2522] more TSIG unit tests
Paul Selkirk [Tue, 7 May 2013 22:12:00 +0000 (18:12 -0400)]
[2521] add 0-length check to DHCID from-wire constructor
JINMEI Tatuya [Tue, 7 May 2013 20:42:40 +0000 (13:42 -0700)]
[2851] untabify
JINMEI Tatuya [Tue, 7 May 2013 20:32:05 +0000 (13:32 -0700)]
[master] tweak TestOSEnv just like stats-httpd_test to suppress log leak
also renamed the stats-httpd_test counterpart; it seemed to be tenntatively
named and left unchanged, so doesn't really make sense for what it does.
these should be trivial, so I'm committing this at my discretion.
JINMEI Tatuya [Tue, 7 May 2013 20:25:37 +0000 (13:25 -0700)]
[master] Merge branch 'trac2823'
JINMEI Tatuya [Tue, 7 May 2013 20:21:51 +0000 (13:21 -0700)]
[2850] style cleanups: spacing, combining short lines
Paul Selkirk [Tue, 7 May 2013 19:59:29 +0000 (15:59 -0400)]
[2522] add MasterLexer constructor for TSIG
Tomek Mrugalski [Tue, 7 May 2013 17:46:57 +0000 (19:46 +0200)]
[2898] First set of changes after review
Paul Selkirk [Tue, 7 May 2013 17:16:17 +0000 (13:16 -0400)]
[2522] fix RP unit test
Paul Selkirk [Tue, 7 May 2013 17:08:27 +0000 (13:08 -0400)]
[2522] more MINFO unit tests
JINMEI Tatuya [Tue, 7 May 2013 16:50:00 +0000 (09:50 -0700)]
[2850] minor style cleanups: constify and brace position
Michal 'vorner' Vaner [Tue, 7 May 2013 13:28:36 +0000 (15:28 +0200)]
[2823] Don't use private prefix in local scope
For one, it makes no sense (it won't be visible from outside the
function anyway), for another, it didn't work, because it was called
from different scope (inside the FailingStatsHttpd class) and mangling
the name wrongly.
Thomas Markwalder [Tue, 7 May 2013 13:22:02 +0000 (09:22 -0400)]
[2355] Added logic to bypass large value test for Uint32BitParser on 32-bit
platforms.
JINMEI Tatuya [Tue, 7 May 2013 06:03:40 +0000 (23:03 -0700)]
[2850] unrelated cleanup: make some test methods non public when possible
also clarify TearDown is inherited by explicitly adding 'virtual'.
Naoki Kambe [Tue, 7 May 2013 01:53:50 +0000 (10:53 +0900)]
[master] changelog for #2252
Naoki Kambe [Tue, 7 May 2013 01:48:55 +0000 (10:48 +0900)]
[master] Merge branch 'trac2252'
Naoki Kambe [Tue, 7 May 2013 00:47:56 +0000 (09:47 +0900)]
[2252] wording cleanups, and omission of the repeated same notes
(The original patch is proposed by Jinmei-san.)
JINMEI Tatuya [Tue, 7 May 2013 00:27:01 +0000 (17:27 -0700)]
[2850] style cleanup: added () for returned values
JINMEI Tatuya [Mon, 6 May 2013 23:22:21 +0000 (16:22 -0700)]
[2823] updated test_init_hterr so it also checks close_mccs is called.
JINMEI Tatuya [Mon, 6 May 2013 22:57:09 +0000 (15:57 -0700)]
[2823] use assertIs(Not)None wherever possible
JINMEI Tatuya [Mon, 6 May 2013 22:53:54 +0000 (15:53 -0700)]
[2823] clarify the purpose of mock auth statistics spec and data
Thomas Markwalder [Mon, 6 May 2013 20:29:57 +0000 (16:29 -0400)]
[2355] CfgMgr.addOptionDefs unit test was failing with duplicat definition
exception under Ubuntu. Added logic to reset all of CfgMgr data between tests. Did not fail under Mac OS-X. New unit tests added for options definition tests were leaving data in CfgMgr.
Paul Selkirk [Mon, 6 May 2013 18:55:30 +0000 (14:55 -0400)]
[2521] remove an unused Rdata_DHCID_Test method
Paul Selkirk [Mon, 6 May 2013 18:50:35 +0000 (14:50 -0400)]
[2521] better way of handling empty DHCID RDATA
Paul Selkirk [Mon, 6 May 2013 18:36:11 +0000 (14:36 -0400)]
[2521] RRSIG signer can be a reference, maybe a bit more efficient
Paul Selkirk [Mon, 6 May 2013 18:27:56 +0000 (14:27 -0400)]
[2521] DHCDID RDATA cannot be empty
JINMEI Tatuya [Mon, 6 May 2013 17:56:27 +0000 (10:56 -0700)]
[2823] avoid hardcoded constant test time data to be compared with local time
it would only pass at the same time zone as that of the original developer.
JINMEI Tatuya [Mon, 6 May 2013 17:45:08 +0000 (10:45 -0700)]
[2823] removed a bogus return at the top of a test case
it was a leftover from an intermediate attempt; the test should pass
without it.
Thomas Markwalder [Mon, 6 May 2013 15:45:27 +0000 (11:45 -0400)]
[2355] Minor changes in response to review comments.
Paul Selkirk [Mon, 6 May 2013 14:30:04 +0000 (10:30 -0400)]
[2522] add MasterLexer constructor for MINFO
Paul Selkirk [Mon, 6 May 2013 14:28:55 +0000 (10:28 -0400)]
[2522] normalize some RP documentation comments
Naoki Kambe [Mon, 6 May 2013 11:30:29 +0000 (20:30 +0900)]
[2252] .Xfrout.socket.unixdomain.open is either expected to be 0 or 1, and add notes
Naoki Kambe [Mon, 6 May 2013 10:56:30 +0000 (19:56 +0900)]
[2252] revert poll-interval to the default value
Mukund Sivaraman [Mon, 6 May 2013 08:24:40 +0000 (13:54 +0530)]
[2850] Add corruption tests
Mukund Sivaraman [Mon, 6 May 2013 08:24:22 +0000 (13:54 +0530)]
[2850] Add a sync() method and make reset() and the destructor call it
This is so that checksums and such are synchronized.
Mukund Sivaraman [Mon, 6 May 2013 08:23:09 +0000 (13:53 +0530)]
[2850] Unify code
Mukund Sivaraman [Mon, 6 May 2013 08:22:52 +0000 (13:52 +0530)]
[2850] Fix type of checksum
Mukund Sivaraman [Mon, 6 May 2013 07:14:06 +0000 (12:44 +0530)]
[2850] Fix ZoneTableSegmentMappedTest.resetBadConfig test