]>
git.ipfire.org Git - thirdparty/kea.git/log
Marcin Siodelski [Wed, 17 Oct 2012 11:18:25 +0000 (13:18 +0200)]
[2270] Corrected some minor typos.
Michal 'vorner' Vaner [Wed, 17 Oct 2012 11:11:05 +0000 (13:11 +0200)]
[2207] Style: correct capitalization
Michal 'vorner' Vaner [Wed, 17 Oct 2012 11:10:08 +0000 (13:10 +0200)]
[2207] Test it cleans up automatically
Michal 'vorner' Vaner [Wed, 17 Oct 2012 10:59:23 +0000 (12:59 +0200)]
[2207] Throw better exception
Michal 'vorner' Vaner [Wed, 17 Oct 2012 10:49:49 +0000 (12:49 +0200)]
[2207] The parameter of local writer is Local as well
But the benefit of this change is questionable.
Michal 'vorner' Vaner [Wed, 17 Oct 2012 10:43:55 +0000 (12:43 +0200)]
[2207] Provide strong exception guarantee
Michal 'vorner' Vaner [Wed, 17 Oct 2012 10:23:33 +0000 (12:23 +0200)]
[2207] Update docs of ZoneWriterLocal
They were outdated, for previous version of the interface.
Michal 'vorner' Vaner [Wed, 17 Oct 2012 10:15:05 +0000 (12:15 +0200)]
[2207] Split off the local Writer
Into a separate file. It is not needed to be too public.
Michal 'vorner' Vaner [Wed, 17 Oct 2012 09:58:51 +0000 (11:58 +0200)]
[2207] Better documentation for LoadAction
Michal 'vorner' Vaner [Wed, 17 Oct 2012 09:17:20 +0000 (11:17 +0200)]
[2207] Style: Lines between comments and definitions
Michal 'vorner' Vaner [Wed, 17 Oct 2012 09:14:30 +0000 (11:14 +0200)]
[2207] Rename ZoneUpdater -> ZoneWriter
According to the review, Updater might be misleading.
JINMEI Tatuya [Wed, 17 Oct 2012 02:51:25 +0000 (19:51 -0700)]
[2205] create DataSrcClientsMgr in auth's main() just to confirm it starts/ends
it currently does nothing user-visible.
JINMEI Tatuya [Wed, 17 Oct 2012 00:30:18 +0000 (17:30 -0700)]
[2205] make AUTH_DATASRC_CLIENTS_BUILDER_COMMAND more readable using text.
also explicitly reject invalid command ID, which should be internal bug.
JINMEI Tatuya [Wed, 17 Oct 2012 00:12:46 +0000 (17:12 -0700)]
[2205] overall documentation updates
JINMEI Tatuya [Tue, 16 Oct 2012 22:45:01 +0000 (15:45 -0700)]
[2205] cleanups: use more specific internal namespaces and reorder code
mainly for better readability. no functional change.
JINMEI Tatuya [Tue, 16 Oct 2012 21:15:49 +0000 (14:15 -0700)]
[2207] fixed a minor typo in doc
Mukund Sivaraman [Tue, 16 Oct 2012 19:31:14 +0000 (01:01 +0530)]
Revert "Merge branch 'master' into trac2198_2"
This reverts commit
f8181bb72251fd3d5f33e157d1f2a2a75a58d765 , reversing
changes made to
453b58784344390cbc5375624e6e92a86b4ff3f1 .
Mukund Sivaraman [Tue, 16 Oct 2012 19:29:03 +0000 (00:59 +0530)]
Revert "[master] Link -lpthread in libb10-threads target"
This reverts commit
8d321e3ea9f85227296cfac94a9ce79c7db70fdf .
Mukund Sivaraman [Tue, 16 Oct 2012 19:28:45 +0000 (00:58 +0530)]
Revert "[master] Check for EDEADLK too when using Mutex::tryLock()"
This reverts commit
42c638e07a45b69d902a51b35838ae21ac19d116 .
Mukund Sivaraman [Tue, 16 Oct 2012 19:28:31 +0000 (00:58 +0530)]
Revert "[master] Avoid static destruction fiasco with InterprocessSyncFile and logger"
This reverts commit
34701adba7f7390640c70ba769cdb0b20f01f82c .
Mukund Sivaraman [Tue, 16 Oct 2012 18:47:08 +0000 (00:17 +0530)]
[master] Avoid static destruction fiasco with InterprocessSyncFile and logger
JINMEI Tatuya [Tue, 16 Oct 2012 17:41:42 +0000 (10:41 -0700)]
[2223] editorial: a missing period in comment
Mukund Sivaraman [Tue, 16 Oct 2012 06:24:19 +0000 (11:54 +0530)]
[master] Check for EDEADLK too when using Mutex::tryLock()
Stephen Morris [Tue, 16 Oct 2012 15:39:32 +0000 (16:39 +0100)]
[2342] Added MySQL lease manager and null implementation
Also includes first unit test, which fails.
Marcin Siodelski [Tue, 16 Oct 2012 15:09:47 +0000 (17:09 +0200)]
[2316] Added option collection to the Subnet class.
Jelte Jansen [Tue, 16 Oct 2012 14:09:24 +0000 (16:09 +0200)]
[2349] document member in test class
Jelte Jansen [Tue, 16 Oct 2012 13:54:11 +0000 (15:54 +0200)]
[2349] Revert pimpl classes, make abstract base class
saves a second dynamic allocation (and more importantly, one that couldn't be freed)
Jelte Jansen [Tue, 16 Oct 2012 12:43:42 +0000 (14:43 +0200)]
[2223] some minor cleanups in final review
JINMEI Tatuya [Tue, 16 Oct 2012 06:00:28 +0000 (23:00 -0700)]
[2205] make sure wating for builder thread in the mgr destructor.
on second thought I realized we need to synchronize them because the builder
thread refers to the main thread's class member variables.
shutdown() method is now meaningless so deprecated for now.
Mukund Sivaraman [Tue, 16 Oct 2012 05:04:31 +0000 (10:34 +0530)]
[master] Link -lpthread in libb10-threads target
JINMEI Tatuya [Tue, 16 Oct 2012 03:46:30 +0000 (20:46 -0700)]
[2205] cover the case where Thread.wait() throws.
Mukund Sivaraman [Tue, 16 Oct 2012 01:05:50 +0000 (06:35 +0530)]
Merge branch 'master' into trac2268
JINMEI Tatuya [Tue, 16 Oct 2012 00:35:07 +0000 (17:35 -0700)]
[2205] catch exceptions inside builder and log it.
Mukund Sivaraman [Tue, 16 Oct 2012 00:31:22 +0000 (06:01 +0530)]
Merge branch 'master' into trac2198_2
Mukund Sivaraman [Tue, 16 Oct 2012 00:30:19 +0000 (06:00 +0530)]
[2198] Don't return anything from thread functions
JINMEI Tatuya [Mon, 15 Oct 2012 23:31:18 +0000 (16:31 -0700)]
[2205] handle the case where manager is destroyed without shutdown()
JINMEI Tatuya [Mon, 15 Oct 2012 23:10:12 +0000 (16:10 -0700)]
[2205] small refactoring: extracting send-command part to a thread
we'll use this pattern for other commands.
JINMEI Tatuya [Mon, 15 Oct 2012 23:04:46 +0000 (16:04 -0700)]
[2205] added a test case using a real thread
JINMEI Tatuya [Mon, 15 Oct 2012 22:52:48 +0000 (15:52 -0700)]
[2205] (unrelated small fix) don't define constants in .h. see also #2358.
JINMEI Tatuya [Mon, 15 Oct 2012 22:06:21 +0000 (15:06 -0700)]
[2205] supported manager's shutdown command
JINMEI Tatuya [Mon, 15 Oct 2012 21:30:11 +0000 (14:30 -0700)]
[2205] introduce DataSrcClientsMgr, tested initial startup.
JINMEI Tatuya [Mon, 15 Oct 2012 20:45:53 +0000 (13:45 -0700)]
[2332] added comments about missing pthread_cond_xxx variants
JINMEI Tatuya [Mon, 15 Oct 2012 20:42:24 +0000 (13:42 -0700)]
[2332] fixing typos and wording in doc
JINMEI Tatuya [Mon, 15 Oct 2012 20:39:32 +0000 (13:39 -0700)]
[2332] updated doc for wait() on what should happen if mutex isn't locked.
mentioning pthread_cond_wait() seems to be confusing, so I'd rather
just describing what this method does.
JINMEI Tatuya [Mon, 15 Oct 2012 20:31:04 +0000 (13:31 -0700)]
[2332] Make sure preUnlockAction() doesn't throw when it shouldn't.
adding a parameter to control that.
JINMEI Tatuya [Mon, 15 Oct 2012 20:16:24 +0000 (13:16 -0700)]
[master] added changelog for #1858
JINMEI Tatuya [Mon, 15 Oct 2012 20:13:45 +0000 (13:13 -0700)]
[master] Merge branch 'trac1858'
commit.
JINMEI Tatuya [Mon, 15 Oct 2012 18:21:47 +0000 (11:21 -0700)]
[2332] changed the type of Locker::mutex_ to a reference.
may not be a big deal in such a simple case, but just as suggested in review.
JINMEI Tatuya [Mon, 15 Oct 2012 18:17:21 +0000 (11:17 -0700)]
[2332] renamed a too-short test name a possibly better one
JINMEI Tatuya [Mon, 15 Oct 2012 18:14:56 +0000 (11:14 -0700)]
[2332] use EXPECT_DEATH_IF_SUPPORTED instead of ifdef.
avoiding ifdef is generally better, and _IF_SUPPORTED seems to have been
supported since googletest 1.4 and should be commonly available for us.
JINMEI Tatuya [Mon, 15 Oct 2012 17:16:51 +0000 (10:16 -0700)]
[2223] style fix: brace position
JINMEI Tatuya [Mon, 15 Oct 2012 16:50:00 +0000 (09:50 -0700)]
[2268] use textToRRset instead of building RRset manually
this will make the test code a bit more concise.
Jelte Jansen [Mon, 15 Oct 2012 15:22:05 +0000 (17:22 +0200)]
[2349] forgot to remove a line from makefile as well
Jelte Jansen [Mon, 15 Oct 2012 14:09:50 +0000 (16:09 +0200)]
[2349] forgot to remove a line from configure.ac
Tomek Mrugalski [Mon, 15 Oct 2012 13:55:19 +0000 (15:55 +0200)]
[master] Using the default value of second parameter for substr
Jelte Jansen [Mon, 15 Oct 2012 13:49:39 +0000 (15:49 +0200)]
[2349] Documentation for the pimpling of two classes
Jelte Jansen [Mon, 15 Oct 2012 12:57:05 +0000 (14:57 +0200)]
[2223] completely pull out sigs and check entire set
Stephen Morris [Mon, 15 Oct 2012 11:29:17 +0000 (12:29 +0100)]
[2342] Separate out lease manager creation into separate factory functions
Michal 'vorner' Vaner [Mon, 15 Oct 2012 10:14:04 +0000 (12:14 +0200)]
[2207] Implementation of the getZoneReloader
The concrete version for local table segment and reloader.
Michal 'vorner' Vaner [Mon, 15 Oct 2012 10:13:49 +0000 (12:13 +0200)]
[2207] Docs and capitalization fix
Michal 'vorner' Vaner [Mon, 15 Oct 2012 10:13:06 +0000 (12:13 +0200)]
[2207] Tests for the getZoneReloader
Michal 'vorner' Vaner [Mon, 15 Oct 2012 09:28:35 +0000 (11:28 +0200)]
[2207] interface of the getZoneReloader
Mukund Sivaraman [Mon, 15 Oct 2012 04:31:18 +0000 (10:01 +0530)]
[2198] Update comment
Mukund Sivaraman [Mon, 15 Oct 2012 04:29:22 +0000 (09:59 +0530)]
[2198] Test the non-blocking variant of Mutex::Locker
Mukund Sivaraman [Mon, 15 Oct 2012 04:08:39 +0000 (09:38 +0530)]
[2198] Check pthread_mutex_trylock()'s return value
Mukund Sivaraman [Sun, 14 Oct 2012 18:33:13 +0000 (00:03 +0530)]
[2198] Revert include to local
Mukund Sivaraman [Sun, 14 Oct 2012 16:52:35 +0000 (22:22 +0530)]
[2198] Stop using direct lock methods on Mutex inside InterprocessSyncFile
Mukund Sivaraman [Sun, 14 Oct 2012 16:49:47 +0000 (22:19 +0530)]
[2198] Make direct methods on Mutex private
Mukund Sivaraman [Sun, 14 Oct 2012 16:47:29 +0000 (22:17 +0530)]
[2198] Add a block argument to Mutex::Locker constructor
Mukund Sivaraman [Sun, 14 Oct 2012 16:46:41 +0000 (22:16 +0530)]
[2198] Add AlreadyLocked exception to Mutex::Locker
Mukund Sivaraman [Sun, 14 Oct 2012 14:43:42 +0000 (20:13 +0530)]
Merge branch 'master' into trac2302
Mukund Sivaraman [Sun, 14 Oct 2012 14:29:55 +0000 (19:59 +0530)]
[2268] Make minor code cleanup
Mukund Sivaraman [Sun, 14 Oct 2012 14:15:37 +0000 (19:45 +0530)]
[2168] Untabify
Mukund Sivaraman [Sun, 14 Oct 2012 14:14:41 +0000 (19:44 +0530)]
[2268] Remove per-test iterator classes and use MockVectorIterator instead
Mukund Sivaraman [Sun, 14 Oct 2012 14:03:46 +0000 (19:33 +0530)]
[2268] Add MockVectorIterator class
Michal 'vorner' Vaner [Sat, 13 Oct 2012 11:03:26 +0000 (13:03 +0200)]
[2207] Deprecate InstallAction
As we want to directly modify the ZoneTable in ZoneReloaderLocal
(because it is memory-type dependant), we don't need the InstallAction
for anything. If we don't need it, we don't pass it as constructor
parameter -- it'll be called from a factory anyway and the factory may
know we don't need it.
Also adding a setTable() method to ZoneTableHeader. The header had no
way to specify the table currently and we need it for the tests. The
method is currently tentative, we'll probably replace it by something.
Michal 'vorner' Vaner [Sat, 13 Oct 2012 09:48:18 +0000 (11:48 +0200)]
[2207] Check the load action returns something
NULL makes no sense, so throw in that case.
Michal 'vorner' Vaner [Sat, 13 Oct 2012 09:38:58 +0000 (11:38 +0200)]
[2207] Change signature of LoadAction
We allocate the ZoneData in the LoadAction, to match what happens in
ticket #2268 -- there's a function to load zone which allocates it
itself, we want to use it.
Michal 'vorner' Vaner [Sat, 13 Oct 2012 09:21:44 +0000 (11:21 +0200)]
[2207] Rename updater to reloader
This might be less confusing.
JINMEI Tatuya [Sat, 13 Oct 2012 02:44:18 +0000 (19:44 -0700)]
[2205] added DataSrcClientsBuilder class, main part of configurator thread
JINMEI Tatuya [Fri, 12 Oct 2012 21:32:53 +0000 (14:32 -0700)]
[2205] Merge branch 'trac2332' into trac2205
JINMEI Tatuya [Fri, 12 Oct 2012 21:32:22 +0000 (14:32 -0700)]
[2332] missing cleanup: removed an unused function.
JINMEI Tatuya [Fri, 12 Oct 2012 21:30:21 +0000 (14:30 -0700)]
[2205] Merge branch 'trac2332' into trac2205
JINMEI Tatuya [Fri, 12 Oct 2012 20:48:46 +0000 (13:48 -0700)]
[1858] (unrelated cleanup) removed BIND10_START_AS_NON_ROOT_AUTH log.
with the introduction of socket creation this log message hasn't been
making sense. It would be rather confusing and harmful.
JINMEI Tatuya [Fri, 12 Oct 2012 18:49:07 +0000 (11:49 -0700)]
[2268] minor editorial cleanups
Jelte Jansen [Fri, 12 Oct 2012 15:04:15 +0000 (17:04 +0200)]
Tomek Mrugalski [Fri, 12 Oct 2012 13:06:23 +0000 (15:06 +0200)]
[2270] Comment about code overlap added.
Tomek Mrugalski [Fri, 12 Oct 2012 12:55:59 +0000 (14:55 +0200)]
[2270] Documentation for DHCPv4 config. parser written.
Jelte Jansen [Fri, 12 Oct 2012 12:19:19 +0000 (14:19 +0200)]
[2349] clean up ForwardQuery objects in tests
an attempt to clean up memory; ForwardQuery objects are supposed to delete themselves when they are no longer needed, but due to the direct calls in tests this often does not happen.
To keep internals in recursive_query to a minimum, I did add something to the API; ForwardQuery is now a public class, a pointer of which is returned by RecursiveQuery::forward. Tests that mess around can then delete the query themselves, and the way these are handled does not have to be changed.
Ideally, we should however not need unscoped allocated memory in the first place; we either need to use a centrally managed pool of objects to (re)use, or we need to change the entire design that needs these objects in the first place.
However, these are both non-trivial, and probably better suited in the main resolver work that has been planned.
Tomek Mrugalski [Fri, 12 Oct 2012 11:53:10 +0000 (13:53 +0200)]
[2270] DHCPv6 pool parser fix.
Tomek Mrugalski [Fri, 12 Oct 2012 11:52:36 +0000 (13:52 +0200)]
[2270] DHCPv4 parser fixes. Tests now pass.
Marcin Siodelski [Fri, 12 Oct 2012 07:28:40 +0000 (09:28 +0200)]
[2304] Minor additions in comments.
Yoshitaka Aharen [Fri, 12 Oct 2012 07:17:20 +0000 (16:17 +0900)]
[2155] added some notes to the mapping tables of counter item
Marcin Siodelski [Fri, 12 Oct 2012 07:02:33 +0000 (09:02 +0200)]
[2304] Fixes for the code review.
Includes adding missing tests for signed integer values
Yoshitaka Aharen [Fri, 12 Oct 2012 05:21:15 +0000 (14:21 +0900)]
[2155] update test case according to the review comment
Mukund Sivaraman [Fri, 12 Oct 2012 05:00:12 +0000 (10:30 +0530)]
[2268] Remove obsolete comment (the bug was fixed)
Mukund Sivaraman [Fri, 12 Oct 2012 04:40:11 +0000 (10:10 +0530)]
[2268] Move FileNameDeleter out of InMemoryClient
Mukund Sivaraman [Fri, 12 Oct 2012 04:37:13 +0000 (10:07 +0530)]
[2268] Update API doc
Mukund Sivaraman [Fri, 12 Oct 2012 04:37:04 +0000 (10:07 +0530)]
[2268] Move ZoneDataLoader into an unnamed namespace
Mukund Sivaraman [Fri, 12 Oct 2012 04:24:54 +0000 (09:54 +0530)]
[2268] Move ZoneDataLoader class out of its header