[1899] Allow other RRtypes in nsec3 table (for RRSIGs)
* The unique constraint on NSEC3 owner per zone is now removed
* NSEC3 RRSIGs are now returned next to their RR set
* Test was adjusted to check for RRSIGs too
JINMEI Tatuya [Mon, 8 Oct 2012 06:53:26 +0000 (23:53 -0700)]
[clang-build] added workaround for the clang++ "unused arguments" warn/error.
by specifying -Qunused-arguments. Also, as a cleanup for better organization
I moved compiler specific settings to earlier part of configure.ac, where
this workaround was added.
I believe the sense of the change is correct, but it has effects on
other OSes, so it's probably better to use clang specific workaround
(will commit it later).
I believe the sense of the change is correct, but it has effects on
other OSes, so it's probably better to use clang specific workaround
(will commit it later).
JINMEI Tatuya [Sat, 6 Oct 2012 00:04:28 +0000 (17:04 -0700)]
[2204] cleanup: removed unused func, and renamed "ClientList" with "DataSrc".
getClientListClasses() was removed. It's not used anymore.
a few methods named with "ClientList" were renamed with adding "DataSrc".
The resulting names are a bit long, but since there's no namespace
qualification, simply saying "client" can be confusing (it could be
interpreted to mean DNS clients, for example).
JINMEI Tatuya [Fri, 5 Oct 2012 23:02:01 +0000 (16:02 -0700)]
[2204] completely replaced setClientList with swapDataSrcClientLists.
the test cases using setClientList were updated so they use
swapDataSrcClientLists (some of them work as a test for the "swap" itself).
now we don't need setClientList, so it was removed.
JINMEI Tatuya [Fri, 5 Oct 2012 22:15:18 +0000 (15:15 -0700)]
[2204] simplify configureDataSource by always creating a new lists and swap.
so we don't have to worry about what are in the current lists or rollback
operations.
swapDataSrcClientLists() is newly introduced for AuthSrv. No direc tests
yet (technically bad in terms TDD but the definition is very simple), which
will be provided in the next step.
the lock is now moved inside swapDataSrcClientLists().
note: even though this version builds everything, the amount of work
should be mostly the same because the only save is to create the empty
ClientList when the new and old have the same class of client. The expensive
part is ClientList::configure(). This version doesn't need any more call
to configure() than the old version.
JINMEI Tatuya [Fri, 5 Oct 2012 05:19:27 +0000 (22:19 -0700)]
[2244] rename Componet.running() is_running() for consistency.
this branch introduced is_failed() (and failed() was already defined for
a different a purpose), so for consistency it would be better to name
the running version is_xxx too.
JINMEI Tatuya [Fri, 5 Oct 2012 00:27:15 +0000 (17:27 -0700)]
[2244] added a test case that reproduces one aspect of the problem.
the configurator should be able to delete a component to be removed
even if the it's failing (unexpectedly). The current implementation
doesn't handle that condition correctly.
JINMEI Tatuya [Thu, 4 Oct 2012 21:30:31 +0000 (14:30 -0700)]
[2284] minor comment update about in-memory finder context's getFinder().
with the cleanup in this ticket we can now actually return NULL, but
intermediate status of other #2283 tickets will require non NULL values.
So, it's probably better to keep the behavior with referring to #2283,
instead of #2284.
JINMEI Tatuya [Thu, 4 Oct 2012 00:28:41 +0000 (17:28 -0700)]
[2203] a piggy back fix: prevent redundant initial data configuration.
this addresses the issue described in #2291. Still not really clean,
but thanks to boost::bind we can centralize all the code logic in the
callback, so I think it's now less likely that we forget cleaning it up
when the hack is not necessary.
JINMEI Tatuya [Thu, 4 Oct 2012 00:17:36 +0000 (17:17 -0700)]
[2203] changed configurator class to a simple function.
as it's now completely stateless and can work independently.
the common specialization for the main implementation is defined in a
new created .cc file.
JINMEI Tatuya [Wed, 3 Oct 2012 22:24:22 +0000 (15:24 -0700)]
[2203] refactoring 2nd step: configurator can now be a separate object.
i.e., it's not a singleton any more.
testReconfigure() method isn't needed any more because it doesn't hold
CC session internally.
DatasrcConfiguratorTest.initialization test currently fails and is
disabled for now. The plan is to make the class completely stateless,
at which point we don't even have to think about initialization or cleanup,
and then the test will be able to be removed.