[#2330] fixed the getAllSharedNetworks6Test and disabled mysql as being broken

[#2330] Addressed review comments

src/lib/dhcpsrv/testutils/generic_backend_unittest.*
    GenericBackendTest - Refactored to provide audit entry testing and logging

src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.*
src/lib/dhcpsrv/testutils/generic_cb_dhcp6_unittest.*
    Removed refactored stuff

[#2330] added more checks and fixed indentation and spaces

[#2330] Added missing tests

    mysql_cb_dhcp6_unittes.cc
    - added in missing beginning tests

[#2330] Refactor CB V6 unit tests

src/lib/dhcpsrv/testutils/generic_cb_dhcp6_unittest.cc
src/lib/dhcpsrv/testutils/generic_cb_dhcp6_unittest.h
    new files

src/lib/dhcpsrv/testutils/Makefile.am
    Added generic_cb_dhcp6_unittest.h generic_cb_dhcp6_unittest.cc

src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp6_unittest.cc
    Moved common setup and UT test code to generic classes

[#2308] Clean up ChangeLog

[#2308] Added ChangeLog

[#2308] Removed misleading DHCP4_NCR_CREATE log statement from kea-dhcp4

modified:
    src/bin/dhcp4/dhcp4_messages.cc
    src/bin/dhcp4/dhcp4_messages.h
    src/bin/dhcp4/dhcp4_messages.mes
    src/bin/dhcp4/dhcp4_srv.cc

[#2322] fixed comment and removed double spaces

[#2322]  Addressed review comments

src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
    Minor cleanup

[#2322] addressed review comments

[#2322] Fix shellcheck complaint

modified:   pgsql_tests.sh.in

[#2322] Updated the ARM

    doc/sphinx/arm/config-backend.rst
    doc/sphinx/arm/dhcp4-srv.rst

[#2322] Adds client classes to Postgresql CB v4

configure.ac
    added src/share/database/scripts/pgsql/upgrade_009_to_010.sh

src/bin/admin/tests/pgsql_tests.sh.in
    pgsql_upgrade_8_0_to_9_0()
    pgsql_upgrade_9_0_to_10_0()
    - added/improved upgrade tests

src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
    Implemented client class functions

src/hooks/dhcp/pgsql_cb/pgsql_query_macros_dhcp.h
    Modified client class related queries

src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_dhcp4_unittest.cc
    TEST_F(PgSqlConfigBackendDHCPv4Test, setAndGetAllClientClasses4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, getClientClass4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, createUpdateClientClass4OptionsTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, getModifiedClientClasses4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, deleteClientClass4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, deleteAllClientClasses4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, clientClassDependencies4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, multipleAuditEntriesTest)
    - new tests

src/lib/pgsql/pgsql_connection.h
    Updated schema version to 10.0

src/share/database/scripts/pgsql/Makefile.am
    Added upgrade_009_to_010.sh

src/share/database/scripts/pgsql/dhcpdb_create.pgsql
    Schema updated to 10.0:
    Replace setClientClass<4/6>Order()
    - wrong local variable type, replace int constants with
    boolean constants

    dhcp<4/6>_client_class_dependency tables -
    - primary key needs to be composite to allow muliptle rows per class id

    func_dhcp<4/6>_client_class_check_dependency_BINS() - trigger functions
    need to return NEW not NULL

[#2326] fix are-scripts-in-sync.py not showing added or missing lines

[#2326] fix are-scripts-in-sync.py matching wrong lines

[#2328] Bump version in configure.ac after 2.1.3 release

[#2323] PostgreSQL CB function needs cast to BIGINT

src/share/database/scripts/pgsql/dhcpdb_create.pgsql
src/share/database/scripts/pgsql/upgrade_008_to_009.sh.in

    Add cast to BIGINT to gmt_epoch(). Postgresql 9x is unhappy without it.

[#2320] release changes

[#2317] bump lib versions for 2.1.3

[#95] Added a ChangeLog entry, rolled back CI changes

.gitlab-ci.yml - rolled back changes to avoid issues
with SQL script checking

[#95] Make V4 Client class fetches simply return

src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
    Class fetches do nothing rather than throw

src/lib/pgsql/tests/pgsql_exchange_unittest.cc
    Changed insane time test to use portable but
    still insane time value

[#95] Fix time handling and make installable

src/hooks/dhcp/pgsql_cb/pgsql_query_macros_dhcp.h
    Use gmt_epoch() to fetch timestamps

src/lib/pgsql/pgsql_exchange.*
    PsqlBindArray::addTimestamp()
    PsqlBindArray::addTimestamp()
    - use convertLocaltoDatabaseTime()

    PgSqlExchange::convertLocalToDatabaseTime()
    - new function for converting local times

src/lib/pgsql/tests/pgsql_basics.*
    Add LOCALTIME_COL column

src/lib/pgsql/tests/pgsql_exchange_unittest.cc
    Update unit tests

src/share/database/scripts/pgsql/dhcpdb_create.pgsql
src/share/database/scripts/pgsql/upgrade_008_to_009.sh.in
src/share/database/scripts/pgsql/dhcpdb_drop.pgsql
    Add gmt_epoch() function

src/share/database/scripts/pgsql/wipe_data.sh.in
    Fix order of tables

[#95] Enable installation

    src/hooks/dhcp/pgsql_cb/Makefile.am
        Enable library installation

    src/hooks/dhcp/pgsql_cb/pgsql_cb_callouts.cc
        Enable registration

[#95] Work around an issue with schema compare script

.gitlab-ci.yml
    Change dhcpdb_create-upgrade-consistency to allow failures
    per Andrei.  The script incorrectly detects a contextual
    change.

[#95] addressed review

[#95] Additional review comments

Supplied missing function implementations

src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc
    PgSqlConfigBackendImpl::getOption(...subnet_id)
    PgSqlConfigBackendImpl::getOption(...pool_id)
    PgSqlConfigBackendImpl::getOption(...shared_network_name)
    - implemented

[#95] Addressed minor review comments

src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
    Explicitly handle ddns-replace-cient-name-mode binding

src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.cc
    GenericConfigBackendDHCPv4Test::testNewAuditEntry(0
    - Fail on empty tag list.

src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.h
    Add doxygen

src/share/database/scripts/pgsql/dhcpdb_create.pgsql
src/share/database/scripts/pgsql/upgrade_008_to_009.sh.in
    Fix function discrepancies on argument types

[#95] fixed comments and indentation

[#95] fixed comments and indentation

[#95] Use auto const& on tag loops

modified:
    pgsql_cb_dhcp4.cc
    pgsql_cb_impl.cc

[#95] Adds v4 support for networks,subnets,pools,options

    configure.ac
        added pgsql/upgrade_008_to_009.sh

    src/share/database/scripts/pgsql/dhcpdb_create.pgsql
    src/share/database/scripts/pgsql/upgrade_008_to_009.sh.in
        Corrected typo dhcp4_option_def_server_option_def_id_fkey
        Add missing cascade to constraint on dhcp4/6_subnet_server tables.
        Dropped extraneous dhcp4/6_shared_network_ADEL triggers

        Replaced createOptionAuditDHCP4() and
        createOptionAuditDHCP6() with corrected local variable type

    src/bin/admin/tests/pgsql_tests.sh.in
        updated expected schema version
        added pgsql_upgrade_8_0_to_9_0()

    src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
        Disabled TEST_F(MySqlConfigBackendDHCPv4Test, getAllSharedNetworks4Test)

    src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
        implemented functions for shared-networks, subnets,
        pools, options, and option-defs

    src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.*
        PgSqlConfigBackendImpl::
        setRelays()
        setRequireClasses()
        - new convenience functions

        getAllOptions()
        getOptions()
        - implemented

        Changed reference tracking from bool to counter
        processOptionRow()
        addOptionValueBinding() -  corrected buffer handling

    src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_dhcp4_unittest.cc
        Added tests subnets, shared networks, pools, options, option defs,

    src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.*
        GenericConfigBackendDHCPv4Test::testNewAuditEntry() new variant which
        accepts a list of expected audit entries

        GenericConfigBackendDHCPv4Test::getAllSharedNetworks4Test() - now
        tests for an expected list of audit entries

[#1695] added ChangeLog

[#1695] updated documentation

[#1695] added support for RAI relay suboption 11 (RAI_OPTION_SERVER_ID_OVERRIDE)

[#2054] updated json example

[#2054] added ChangeLog

[#2054] added counters for subnets as well

[#2054] updated documentation

[#2054] added stats counter for allocation failures

[#2288] added ChangeLog

[#2288] only hide maxver and maxsize

[#2288] formatting

[#2288] omit output parameters if destination is not file

[#2262] added ChangeLog

[#2262] fixed keactrl when netconf is not enabled

avoid referencing netconf related param without building it

[#95] Fix a minor typo.

[#95] Fixed commentary typo

modified:   src/lib/pgsql/pgsql_exchange.cc

[#95] fixed typo

[#95] addressed some review comments and formatting

[#95] Change PsqlBindArray::insert() to duplicate value

src/lib/pgsql/pgsql_exchange.*
    PsqlBindArray::insert(const std::string& value, size_t index)
    - now creates an internal copy of the string value

[#95] use ASSERT_NO_THROW_LOG in generic CB tests

src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.cc
    Replaced EXPECT_NO_THROW, ASSERT_NO_THROW with ASSERT_NO_THROW_LOG
    - greatly simplifies diagnosing issues

[#95] Postgresql v4 backend now supports global parameters

    Added support for global paramters and new convenience
    class, PgSqlResultRowWorker

src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
    PgSqlConfigBackendDHCPv4Impl::getGlobalParameter4()
    PgSqlConfigBackendDHCPv4Impl::createUpdateGlobalParameter4()
    - implemented

src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc
    PgSqlConfigBackendImpl::getRecentAuditEntries()
    PgSqlConfigBackendImpl::getServers()
    - now uses PgSqlResultRowWorker

    PgSqlConfigBackendImpl::getGlobalParameters()
    - implemented

src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_dhcp4_unittest.cc
    TEST_F(PgSqlConfigBackendDHCPv4Test, getAndDeleteAllServersTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, createUpdateDeleteGlobalParameter4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, globalParameters4WithServerTagsTest)
    TEST_F(PgSqlConfigBackendDHCPv4Test, getAllGlobalParameters4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, getModifiedGlobalParameters4Test)
    TEST_F(PgSqlConfigBackendDHCPv4Test, nullKeyErrorTest)
    - new tests

src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.cc
    GenericConfigBackendDHCPv4Test::nullKeyErrorTest()
    - only checks exception type, since messages between backends
    are different

src/lib/pgsql/pgsql_exchange.*
    PgSqlExchange::convertFromBytea()
    - new function outputs a vector

    PgSqlExchange::getTripletValue()
    PgSqlExchange::getTripletValue()
    - new functions

    PgSqlResultRowWorker
    - new convenience class for accessing columns in a
    result set row

src/lib/pgsql/tests/pgsql_basics.cc
    Added new columns to basics table

src/lib/pgsql/tests/pgsql_exchange_unittest.cc
    TEST_F(PgSqlBasicsTest, tripleTest)
    TEST_F(PgSqlBasicsTest, resultRowWorker)
    - new tests

[#2294] add quotes

[#2294] also check server global variables ssl_ca, ssl_cert and ssl_key

[#2250] format else statement

[#2250] expect newer error messages in TLS tests

[#2285] Use addTempBinary in PgSQL CB addOptionValueBinding()

modified:   src/hooks/dhcp/pgsql_cb/pgsql_cb_impl.cc

[#2285] Addressed further comments

src/lib/pgsql/pgsql_exchange.*
    PsqlBindArray::addTempBinary() - new function

src/lib/pgsql/tests/pgsql_exchange_unittest.cc
    TEST(PsqlBindArray, addDataTest) - added use of
    addTempBinary()

[#2285] Addressed review comments, fixed doxygen

    Minor changes

modified:
    src/lib/dhcpsrv/pgsql_host_data_source.cc
    src/lib/pgsql/pgsql_exchange.h

[#2285] Fixed out of scope error in PgSql code in dhcpsrv

src/lib/dhcpsrv/pgsql_host_data_source.cc
    PgSqlHostDataSource::del()
    - use PsqlBindArray::addTempString()

src/lib/dhcpsrv/pgsql_lease_mgr.cc
    PgSqlLeaseStatsQuery::start()
    - use PsqlBindArray::addTempString()

[#2036] regenerated parser files

[#2036] added ChangeLog

[#2036] fixed header guards

[#2036] addressed comment

[#2036] make host reservations lookup before lease lookup configurable

[#1334] Moved ClientClasses to multi index

[#2275] minor adjustments

[#2275] Refactored MySQL CB DHCPv4 unit tests

src/hooks/dhcp/mysql_cb/tests/mysql_cb_dhcp4_unittest.cc
    Refactored to use GenericConfigBackendDHCPv4Test,
    moved individual tests into functions in GenericConfigBackendDHCPv4Test

src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_dhcp4_unittest.cc

src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.*
    Added functions for individual tests taken from
    mysql_cb_dhcp4_unittest.cc

src/lib/dhcpsrv/testutils/mysql_generic_backend_unittest.*
    MySqlGenericBackendTest::countRows() - chagned to static

[#2275] Refactored pgsql_cb unit tests

    Created common classes for testing config backend.
    Refactored pgsql_cb using said classes.

new files:
    src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.cc
    src/lib/dhcpsrv/testutils/generic_cb_dhcp4_unittest.h
    src/lib/dhcpsrv/testutils/generic_cb_recovery_unittest.cc
    src/lib/dhcpsrv/testutils/generic_cb_recovery_unittest.h

src/lib/dhcpsrv/testutils/Makefile.am
    - added new files

src/lib/dhcpsrv/testutils/pgsql_generic_backend_unittest.cc
src/lib/dhcpsrv/testutils/pgsql_generic_backend_unittest.h
    - made countRows static

src/hooks/dhcp/pgsql_cb/tests/pgsql_cb_dhcp4_unittest.cc
    - refactored using new classes

[#2292] bump version to 2.1.3-git

[#2290] release changes

[#2290] release changes

Change caption after review

[#2238] different wordsmithing in BNF extract script

[#2238] Change "REST API" to "RESTful API" for consistency

[#2238] Text edits

[#2238] Text edits

[#2238] Text edits

[#2238] Text edits

[#2238] Text edits

[#2238] Text edits

[#2238] Text edits

[#2281] bump lib versions for 2.1.2

[#2225] fix mysql test not matching reference text

[#2246] Additional review comments

src/lib/dhcpsrv/client_class_def.cc
    ClientClassDictionary::createOptions() - modified to merge
    the client and external option definitions together prior
    to creating class options.

src/lib/dhcpsrv/tests/cb_ctl_dhcp_unittest.cc
    Tests for a custom client option defined and specified
    in a class.

Apply 2 suggestion(s) to 2 file(s)

[#2246] addressed review

[#2246] Create class options after loading from CB

src/lib/dhcpsrv/cb_ctl_dhcp4.cc
    CBControlDHCPv4::databaseConfigApply()
    - now calls ClientClassDictionary::createOptions()

src/lib/dhcpsrv/cb_ctl_dhcp6.cc
    CBControlDHCPv6::databaseConfigApply()
    - now calls ClientClassDictionary::createOptions()

src/lib/dhcpsrv/client_class_def.*
    ClientClassDictionary::createOptions() - new function
    which recreates all options in each class in a dicationary

src/lib/dhcpsrv/tests/cb_ctl_dhcp_unittest.cc
    Updated tests

src/lib/dhcpsrv/tests/client_class_def_unittest.cc
    TEST(ClientClassDictionary, createOptions) - new test

[#2284] more formatting

[#2284] fixed indentation and spaces

[#2284] Typo in ChangeLog

[#2284] Fixed asserts in PostgresSQL support code
src/hooks/dhcp/pgsql_cb/pgsql_cb_dhcp4.cc
    Fixed an incorrect tagged statement

src/lib/pgsql/pgsql_connection.*
    PgSqlConnection::executePreparedStatement() - new convenience
    function to executing prepared statements

    PgSqlConnection::selectQuery()
    PgSqlConnection::insertQuery()
    PgSqlConnection::updateDeleteQuery()
    - now calls executePreparedStatement()

src/lib/pgsql/pgsql_exchange.cc
    PsqlBindArray::toText() - emits text for empty array

src/lib/pgsql/tests/pgsql_connection_unittest.cc
    TEST_F(PgSqlConnectionTest, executePreparedStatement) - new test

[#2283] exit early when packing a zero length OpaqueDataTuple

[#2225] allow PGPASSWORD to be set from outside admin-utils.sh

[#2225] fix argument check in admin-utils.sh

[#2225] Restored $# check

[#2225] kea-admin: change double quote location

[#2225] Checkpoint: comments addressed but a bug was inherited