]> git.ipfire.org Git - thirdparty/kea.git/log
thirdparty/kea.git
6 years ago[#893] enable command line parameters
Razvan Becheriu [Mon, 16 Mar 2020 16:01:57 +0000 (18:01 +0200)] 
[#893] enable command line parameters

6 years ago[#893] enable command line parameters
Razvan Becheriu [Mon, 16 Mar 2020 15:42:45 +0000 (17:42 +0200)] 
[#893] enable command line parameters

6 years ago[#931] addressed review comments
Razvan Becheriu [Fri, 13 Mar 2020 13:48:39 +0000 (15:48 +0200)] 
[#931] addressed review comments

6 years ago[#931] addressed review comments
Razvan Becheriu [Fri, 13 Mar 2020 13:41:31 +0000 (15:41 +0200)] 
[#931] addressed review comments

6 years agorenamed file
Wlodek Wencel [Fri, 13 Mar 2020 08:53:57 +0000 (09:53 +0100)] 
renamed file

6 years ago[#931] renamed files
Wlodek Wencel [Tue, 10 Mar 2020 10:04:15 +0000 (11:04 +0100)] 
[#931] renamed files

6 years ago[#931] addressed review comments
Wlodek Wencel [Tue, 10 Mar 2020 09:18:01 +0000 (10:18 +0100)] 
[#931] addressed review comments

6 years ago[#931] simulate v4 traffic from different subnets
Wlodek Wencel [Mon, 2 Mar 2020 12:59:11 +0000 (13:59 +0100)] 
[#931] simulate v4 traffic from different subnets

6 years ago[#1016] updated ChangeLog
Razvan Becheriu [Mon, 9 Mar 2020 15:39:58 +0000 (17:39 +0200)] 
[#1016] updated ChangeLog

6 years ago[#1016] added doxygen
Razvan Becheriu [Sat, 7 Mar 2020 18:21:27 +0000 (20:21 +0200)] 
[#1016] added doxygen

6 years ago[#1016] addressed review
Razvan Becheriu [Sat, 7 Mar 2020 14:45:03 +0000 (16:45 +0200)] 
[#1016] addressed review

6 years ago[#1016] fixed compilation
Razvan Becheriu [Fri, 6 Mar 2020 21:28:17 +0000 (23:28 +0200)] 
[#1016] fixed compilation

6 years ago[#1016] fixed compilation
Razvan Becheriu [Fri, 6 Mar 2020 21:17:04 +0000 (23:17 +0200)] 
[#1016] fixed compilation

6 years ago[#1016] removed unnecessary files
Razvan Becheriu [Fri, 6 Mar 2020 21:10:18 +0000 (23:10 +0200)] 
[#1016] removed unnecessary files

6 years ago[#1016] moved critical section to lib util
Razvan Becheriu [Fri, 6 Mar 2020 13:12:42 +0000 (15:12 +0200)] 
[#1016] moved critical section to lib util

6 years ago[#1016] minor changes
Razvan Becheriu [Thu, 27 Feb 2020 13:11:16 +0000 (15:11 +0200)] 
[#1016] minor changes

6 years ago[#1016] fixed unittests
Razvan Becheriu [Thu, 27 Feb 2020 12:46:41 +0000 (14:46 +0200)] 
[#1016] fixed unittests

6 years ago[#1016] minor changes
Razvan Becheriu [Thu, 27 Feb 2020 11:54:06 +0000 (13:54 +0200)] 
[#1016] minor changes

6 years ago[#1016] added more checks
Razvan Becheriu [Thu, 27 Feb 2020 10:52:59 +0000 (12:52 +0200)] 
[#1016] added more checks

6 years ago[#1016] implemented override flag to support interleaved critical sections
Razvan Becheriu [Thu, 27 Feb 2020 09:31:59 +0000 (11:31 +0200)] 
[#1016] implemented override flag to support interleaved critical sections

6 years ago[#1016] implemented startPktProcessing and stopPktProcessing
Razvan Becheriu [Fri, 21 Feb 2020 16:51:06 +0000 (18:51 +0200)] 
[#1016] implemented startPktProcessing and stopPktProcessing

6 years ago[#1124] Reversed order for v6 also
Thomas Markwalder [Tue, 3 Mar 2020 16:04:00 +0000 (11:04 -0500)] 
[#1124] Reversed order for v6 also

modified:
    alloc_engine.cc

6 years ago[#1124] Addressed v4 code review
Thomas Markwalder [Tue, 3 Mar 2020 13:51:13 +0000 (08:51 -0500)] 
[#1124] Addressed v4 code review

    Minor cleanup in alloc_engine.cc.

6 years ago[#1124] Change the order of HR vs lease lookup during v4 lease allocation
Thomas Markwalder [Thu, 20 Feb 2020 20:39:15 +0000 (15:39 -0500)] 
[#1124] Change the order of HR vs lease lookup during v4 lease allocation

src/lib/dhcpsrv/alloc_engine.cc
    AllocEngine::allocateUnreservedLease4() - rather than first testing for a
    host reservation and then looking for an existing lease, we reverse the
    order, thus worrying about HRs only if there is no existing lease.

6 years ago[#608] Fixed typos
Thomas Markwalder [Wed, 4 Mar 2020 13:22:50 +0000 (08:22 -0500)] 
[#608] Fixed typos

6 years ago[#608] Addressed review comments
Thomas Markwalder [Tue, 3 Mar 2020 19:55:09 +0000 (14:55 -0500)] 
[#608] Addressed review comments

src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
    TEST_F(CSVLeaseFile4Test, embeddedEscapes)  - new test

src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
    TEST_F(CSVLeaseFile6Test, embeddedEscapes) - new test

src/lib/util/csv_file.cc
    CSVRow::escapeCharacters() - now automatically also escapes
    first char of escape_tag to preserve input that happens to match
    escape tag

src/lib/util/tests/csv_file_unittest.cc
    TEST(CSVRowTest, escapeUnescape) - added embedded escape tests

plus misc clean up

6 years ago[#608] Added unit test case
Thomas Markwalder [Tue, 25 Feb 2020 11:59:37 +0000 (06:59 -0500)] 
[#608] Added unit test case

    modified:   csv_file_unittest.cc

6 years ago[#608] Added ChangeLog entry
Thomas Markwalder [Mon, 24 Feb 2020 20:32:41 +0000 (15:32 -0500)] 
[#608] Added ChangeLog entry

6 years ago[#608] Memfile now tolerates commas in hostname and user-context columns
Thomas Markwalder [Mon, 24 Feb 2020 20:21:52 +0000 (15:21 -0500)] 
[#608] Memfile now tolerates commas in hostname and user-context columns

Commas in hostname and user-context columns are now escaped as
"&#x2c" when written out, and unescaped when read back in.

src/lib/util/csv_file.*
    CSVRow::escapeCharacters()
    CSVRow::unescapeCharacters()
    CSVRow::readAtEscaped()
    CSVRow::writeAtEscaped() - new functions
    CSVRow::parse() - replaced boost::split() faster, simplified parsing

src/lib/util/tests/csv_file_unittest.cc
    TEST(CSVRowTest, escapeUnescape) - new test
    updated other tests

src/lib/dhcpsrv/csv_lease_file4.cc
    CSVLeaseFile4 now uses CSVRow::writeAtEscaped() and CSVRow::readAtEscaped() for
    hostname and user-context columns

src/lib/dhcpsrv/csv_lease_file6.cc
    CSVLeaseFile6 now uses CSVRow::writeAtEscaped() and CSVRow::readAtEscaped() for
    hostname and user-context columns

src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
    TEST_F(CSVLeaseFile4Test, embeddedCommas) - new test

src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
    TEST_F(CSVLeaseFile6Test, embeddedCommas) - new test

6 years ago[#1115] Fixed name collision
Thomas Markwalder [Tue, 3 Mar 2020 18:41:25 +0000 (13:41 -0500)] 
[#1115] Fixed name collision

src/bin/dhcp4/ctrl_dhcp4_srv.*
src/bin/dhcp4/ctrl_dhcp6_srv.*
    renamed shutdown(exit_value) -> shutdownServer(exit_value)

6 years ago[#1115] Addressed review comments
Thomas Markwalder [Tue, 3 Mar 2020 16:54:16 +0000 (11:54 -0500)] 
[#1115] Addressed review comments

src/bin/agent/tests/ca_controller_unittests.cc
   TEST_F(CtrlAgentControllerTest, shutdown) - new test

src/lib/process/daemon.h
    Daemon::shutdown() restored to virtual

Other Minor cleanups

6 years ago[#1115] Updated doc and added ChangeLog
Thomas Markwalder [Mon, 2 Mar 2020 14:32:17 +0000 (09:32 -0500)] 
[#1115] Updated doc and added ChangeLog

modified:
    ChangeLog
    doc/sphinx/api/shutdown.json
    doc/sphinx/arm/ctrl-channel.rst

6 years ago[#1115] shutdown command exit-value arg, exit w/failure on db loss
Thomas Markwalder [Fri, 28 Feb 2020 21:04:28 +0000 (16:04 -0500)] 
[#1115] shutdown command exit-value arg, exit w/failure on db loss

Added exit-value argument to shutdown command.
kea-dhcpX servers now exit with EXIT_FAILURE status on db loss

src/lib/process/daemon.*
    Daemon::exit_value_,  new member with getter/setter

src/lib/process/d_controller.*
    DControllerBase::launch() - now returns getExitValue()
    DControllerBase::shutdownHandler() - uses exit-value argument to set exit
    value

src/lib/process/tests/daemon_unittest.cc
    TEST_F(DaemonTest, exitValue)  - new test

src/bin/agent/main.cc
    Use launch() return value for exit value.

src/bin/agent/tests/ca_controller_unittests.cc
    TEST_F(CtrlAgentControllerTest, shutdownExitValue)  - new test

src/bin/d2/main.cc
    Use launch() return value for exit value.

src/bin/d2/tests/d2_command_unittest.cc
    TEST_F(CtrlChannelD2Test, shutdownExitValue)  - new test

src/bin/dhcp4/ctrl_dhcp4_srv.*
    ControlledDhcpv4Srv::
        commandShutdownHandler() - handle exit-value argument
        shutdown(int exit_value) - added exit_value parameter
        dbReconnect() - call shutdown(EXIT_FAILURE)
        dbLostCallback() - call shutdown(EXIT_FAILURE)

src/bin/dhcp4/dhcp4_srv.*
    Dhcp4Srv::run() - returns int Daemon::exit_value instead of bool

src/bin/dhcp4/main.cc
    Use run() return value for exit value.

src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
    TEST_F(CtrlChannelDhcpv4SrvTest, commands) - revamped test

src/bin/dhcp6/ctrl_dhcp6_srv.*
    ControlledDhcpv6Srv::
        commandShutdownHandler() - use exit-value argument to set exit value
        shutdown(int exit_value) - added exit_value parameter
        dbReconnect() - call shutdown(EXIT_FAILURE)
        dbLostCallback() - call shutdown(EXIT_FAILURE)

src/bin/dhcp6/dhcp6_srv.*
    Dhcp6Srv::run() - returns int Daemon::exit_value instead of bool

src/bin/dhcp6/main.cc
    Use run() return value for exit value.

src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
    TEST_F(CtrlDhcpv6SrvTest, commands) - revamped test

6 years ago[#1088] updated ChangeLog
Razvan Becheriu [Thu, 27 Feb 2020 07:11:44 +0000 (09:11 +0200)] 
[#1088] updated ChangeLog

6 years ago[#1088] addressed review
Razvan Becheriu [Tue, 25 Feb 2020 12:31:07 +0000 (14:31 +0200)] 
[#1088] addressed review

6 years ago[#1088] addressed review
Razvan Becheriu [Mon, 24 Feb 2020 17:08:30 +0000 (19:08 +0200)] 
[#1088] addressed review

6 years ago[#1088] addressed review
Razvan Becheriu [Mon, 24 Feb 2020 17:02:00 +0000 (19:02 +0200)] 
[#1088] addressed review

6 years ago[#1088] addressed review
Razvan Becheriu [Mon, 24 Feb 2020 16:45:11 +0000 (18:45 +0200)] 
[#1088] addressed review

6 years ago[#1088] addressed review
Razvan Becheriu [Mon, 24 Feb 2020 16:38:59 +0000 (18:38 +0200)] 
[#1088] addressed review

6 years ago[#1088] fixed compilation
Razvan Becheriu [Thu, 20 Feb 2020 09:58:42 +0000 (11:58 +0200)] 
[#1088] fixed compilation

6 years ago[#1088] handle pack/unpack for bootp and ha
Razvan Becheriu [Thu, 20 Feb 2020 09:26:52 +0000 (11:26 +0200)] 
[#1088] handle pack/unpack for bootp and ha

6 years ago[#1088] fixed comments
Razvan Becheriu [Mon, 17 Feb 2020 15:17:24 +0000 (17:17 +0200)] 
[#1088] fixed comments

6 years ago[#1088] check callout status before processing
Razvan Becheriu [Mon, 17 Feb 2020 08:12:19 +0000 (10:12 +0200)] 
[#1088] check callout status before processing

6 years ago[#1103] Ensure fuzz.dox is included in tarball
Stephen Morris [Tue, 18 Feb 2020 10:32:50 +0000 (10:32 +0000)] 
[#1103] Ensure fuzz.dox is included in tarball

This developer documentation was inadvertently omitted from the
distribution tarball.

6 years ago[#1103] Remove sample fuzz packets
Stephen Morris [Tue, 18 Feb 2020 10:51:19 +0000 (10:51 +0000)] 
[#1103] Remove sample fuzz packets

Remove these as fuzz testing is not something that most people will do
and they are not used in ISC fuzz testing (a more extensive set of seeds
is used).  In addition, it is easy enough to generate sample packets for
the fuzzer (something that is described in the developer documentation).
Indeed, with AFL, any file (not necessarily a DHCP packet) can be used
as a seed and useful results obtained.

6 years ago[#1128] version bump up Kea-1.7.5
Wlodek Wencel [Tue, 25 Feb 2020 16:17:00 +0000 (17:17 +0100)] 
[#1128] version bump up

6 years ago[#1128] lib versions changed
Wlodek Wencel [Tue, 25 Feb 2020 11:21:37 +0000 (12:21 +0100)] 
[#1128] lib versions changed

6 years ago[#1128] lib versions changed
Wlodek Wencel [Tue, 25 Feb 2020 10:18:48 +0000 (11:18 +0100)] 
[#1128] lib versions changed

6 years ago[#1128] 1.7.4 pre prelease changes
Wlodek Wencel [Tue, 25 Feb 2020 07:33:30 +0000 (08:33 +0100)] 
[#1128] 1.7.4 pre prelease changes

6 years ago[#160] Addressed revie comments
Tomek Mrugalski [Mon, 24 Feb 2020 15:10:41 +0000 (16:10 +0100)] 
[#160] Addressed revie comments

 - care => caution
 - ip6tables => iptables

6 years ago[#160] Running non-rooted kea described
Tomek Mrugalski [Fri, 21 Feb 2020 13:48:34 +0000 (14:48 +0100)] 
[#160] Running non-rooted kea described

6 years ago[#1049] Minor classification doc update
Tomek Mrugalski [Fri, 21 Feb 2020 11:50:20 +0000 (12:50 +0100)] 
[#1049] Minor classification doc update

6 years ago[#947] updated ChangeLog
Razvan Becheriu [Fri, 21 Feb 2020 16:37:00 +0000 (18:37 +0200)] 
[#947] updated ChangeLog

6 years ago[#947] added ChangeLog
Razvan Becheriu [Thu, 20 Feb 2020 05:53:34 +0000 (07:53 +0200)] 
[#947] added ChangeLog

6 years ago[#947] added ChangeLog
Razvan Becheriu [Wed, 19 Feb 2020 17:42:09 +0000 (19:42 +0200)] 
[#947] added ChangeLog

6 years ago[#947] added ChangeLog
Razvan Becheriu [Wed, 19 Feb 2020 17:35:00 +0000 (19:35 +0200)] 
[#947] added ChangeLog

6 years ago[#892] Fixed shellcheck in gitlab-ci
Tomek Mrugalski [Fri, 21 Feb 2020 16:06:31 +0000 (17:06 +0100)] 
[#892] Fixed shellcheck in gitlab-ci

6 years ago[#892] added ChangeLog
Razvan Becheriu [Fri, 21 Feb 2020 16:00:47 +0000 (18:00 +0200)] 
[#892] added ChangeLog

6 years ago[#892] addressed review comments
Razvan Becheriu [Fri, 21 Feb 2020 11:38:07 +0000 (13:38 +0200)] 
[#892] addressed review comments

6 years ago[#892] addressed review comments
Razvan Becheriu [Wed, 19 Feb 2020 16:41:41 +0000 (18:41 +0200)] 
[#892] addressed review comments

6 years ago[#892] addressed review comments
Razvan Becheriu [Wed, 19 Feb 2020 09:27:23 +0000 (11:27 +0200)] 
[#892] addressed review comments

6 years ago[#892] fixed compilation
Razvan Becheriu [Tue, 18 Feb 2020 07:48:53 +0000 (09:48 +0200)] 
[#892] fixed compilation

6 years ago[#892] refactored
Razvan Becheriu [Tue, 18 Feb 2020 07:30:17 +0000 (09:30 +0200)] 
[#892] refactored

6 years ago[#892] refactored
Razvan Becheriu [Tue, 11 Feb 2020 08:17:07 +0000 (10:17 +0200)] 
[#892] refactored

6 years ago[#892] minor changes
Razvan Becheriu [Fri, 7 Feb 2020 09:11:17 +0000 (11:11 +0200)] 
[#892] minor changes

6 years ago[#892] refactored
Razvan Becheriu [Thu, 6 Feb 2020 17:48:54 +0000 (19:48 +0200)] 
[#892] refactored

6 years ago[#892] fixed command line parameters
Razvan Becheriu [Thu, 6 Feb 2020 12:29:10 +0000 (14:29 +0200)] 
[#892] fixed command line parameters

6 years ago[#892] fixed compilation
Razvan Becheriu [Thu, 6 Feb 2020 10:18:53 +0000 (12:18 +0200)] 
[#892] fixed compilation

6 years ago[#892] handle parking
Razvan Becheriu [Thu, 6 Feb 2020 09:17:48 +0000 (11:17 +0200)] 
[#892] handle parking

6 years ago[#892] minor changes
Razvan Becheriu [Wed, 5 Feb 2020 15:14:15 +0000 (17:14 +0200)] 
[#892] minor changes

6 years ago[#892] create pkt thread pool and handle processing using multiple threads
Razvan Becheriu [Wed, 5 Feb 2020 12:15:07 +0000 (14:15 +0200)] 
[#892] create pkt thread pool and handle processing using multiple threads

6 years ago[#1048] Addressed review comments
Thomas Markwalder [Fri, 21 Feb 2020 12:01:43 +0000 (07:01 -0500)] 
[#1048] Addressed review comments

    Corrected typo in commentary.

6 years ago[#1048] Added ChangeLog entry
Thomas Markwalder [Fri, 21 Feb 2020 11:59:59 +0000 (06:59 -0500)] 
[#1048] Added ChangeLog entry

6 years ago[#1048] Fixed new doc formatting
Thomas Markwalder [Fri, 14 Feb 2020 19:03:56 +0000 (14:03 -0500)] 
[#1048] Fixed new doc formatting

6 years ago[#1048] Enable host sanitizing by default
Thomas Markwalder [Fri, 14 Feb 2020 18:54:45 +0000 (13:54 -0500)] 
[#1048] Enable host sanitizing by default

src/lib/util/strutil.cc
    StringSanitizerImpl::scrub() - modified non-USE_REGEX code to
    handle embedded nuls.

src/lib/util/tests/strutil_unittest.cc
    Updated tests

src/bin/dhcp4/tests/fqdn_unittest.cc
src/bin/dhcp4/tests/get_config_unittest.cc
src/bin/dhcp6/tests/fqdn_unittest.cc
src/bin/dhcp6/tests/get_config_unittest.cc
    updated testing

src/lib/dhcpsrv/parsers/simple_parser4.cc
src/lib/dhcpsrv/parsers/simple_parser6.cc
    Added global default values

doc/sphinx/arm/dhcp6-srv.rst
doc/sphinx/arm/dhcp4-srv.rst
    Updated sanitizing text

6 years ago[#1071] Changelog updated
Tomek Mrugalski [Fri, 21 Feb 2020 08:49:24 +0000 (09:49 +0100)] 
[#1071] Changelog updated

6 years ago[#1071] Fix for danger running on wrong runner
Tomek Mrugalski [Fri, 21 Feb 2020 08:40:36 +0000 (09:40 +0100)] 
[#1071] Fix for danger running on wrong runner

6 years ago[#1071] refactored
Razvan Becheriu [Thu, 23 Jan 2020 12:40:49 +0000 (14:40 +0200)] 
[#1071] refactored

6 years ago[#1071] fixed compilation for mysql 8.x
Razvan Becheriu [Thu, 23 Jan 2020 09:28:19 +0000 (11:28 +0200)] 
[#1071] fixed compilation for mysql 8.x

6 years ago[#1071] static assert if sizeof(bool) is not 1
Razvan Becheriu [Thu, 23 Jan 2020 07:05:42 +0000 (09:05 +0200)] 
[#1071] static assert if sizeof(bool) is not 1

6 years ago[#1071] Leftover #endif removed
Tomek Mrugalski [Wed, 22 Jan 2020 16:43:29 +0000 (17:43 +0100)] 
[#1071] Leftover #endif removed

6 years ago[#1071] always cast to target type
Razvan Becheriu [Tue, 21 Jan 2020 14:44:13 +0000 (16:44 +0200)] 
[#1071] always cast to target type

6 years ago[#1021] fixed doxygen
Razvan Becheriu [Thu, 20 Feb 2020 06:47:07 +0000 (08:47 +0200)] 
[#1021] fixed doxygen

6 years ago[#1021] fixed doxygen
Razvan Becheriu [Thu, 20 Feb 2020 06:42:06 +0000 (08:42 +0200)] 
[#1021] fixed doxygen

6 years ago[#1021] fixed doxygen
Razvan Becheriu [Thu, 20 Feb 2020 06:34:19 +0000 (08:34 +0200)] 
[#1021] fixed doxygen

6 years ago[#1021] fixed doxygen
Razvan Becheriu [Thu, 20 Feb 2020 06:31:58 +0000 (08:31 +0200)] 
[#1021] fixed doxygen

6 years ago[#1021] changed option parameter
Razvan Becheriu [Wed, 19 Feb 2020 11:29:41 +0000 (13:29 +0200)] 
[#1021] changed option parameter

6 years ago[#1021] fixed compilation
Razvan Becheriu [Wed, 19 Feb 2020 11:15:57 +0000 (13:15 +0200)] 
[#1021] fixed compilation

6 years ago[#1021] rebased and addressed review
Razvan Becheriu [Wed, 19 Feb 2020 10:48:07 +0000 (12:48 +0200)] 
[#1021] rebased and addressed review

6 years ago[#1021] removed mutex
Wlodek Wencel [Wed, 19 Feb 2020 08:54:59 +0000 (09:54 +0100)] 
[#1021] removed mutex

6 years ago[#1021] added stats, extended tests, mutex
Wlodek Wencel [Tue, 18 Feb 2020 21:56:16 +0000 (22:56 +0100)] 
[#1021] added stats, extended tests, mutex

6 years ago[#1021] deque changed to set, mutex added
Wlodek Wencel [Mon, 17 Feb 2020 22:45:29 +0000 (23:45 +0100)] 
[#1021] deque changed to set, mutex added

6 years ago[#1021] unit tests for unique address
Wlodek Wencel [Mon, 10 Feb 2020 14:17:36 +0000 (15:17 +0100)] 
[#1021] unit tests for unique address

6 years ago[#1021] [1021] added address uniqueness checks
Wlodek Wencel [Mon, 10 Feb 2020 09:52:58 +0000 (10:52 +0100)] 
[#1021] [1021] added address uniqueness checks

6 years ago[#947] addressed review
Razvan Becheriu [Wed, 12 Feb 2020 17:19:58 +0000 (19:19 +0200)] 
[#947] addressed review

6 years ago[#947] addressed review
Razvan Becheriu [Wed, 12 Feb 2020 17:17:20 +0000 (19:17 +0200)] 
[#947] addressed review

6 years ago[#947] addressed review
Razvan Becheriu [Wed, 12 Feb 2020 15:49:42 +0000 (17:49 +0200)] 
[#947] addressed review

6 years ago[#947] addressed review
Razvan Becheriu [Wed, 12 Feb 2020 15:47:17 +0000 (17:47 +0200)] 
[#947] addressed review

6 years ago[#947] addressed review
Razvan Becheriu [Wed, 12 Feb 2020 15:39:47 +0000 (17:39 +0200)] 
[#947] addressed review

6 years ago[#947] addressed review
Razvan Becheriu [Wed, 12 Feb 2020 15:08:27 +0000 (17:08 +0200)] 
[#947] addressed review