]> git.ipfire.org Git - thirdparty/open-vm-tools.git/log
thirdparty/open-vm-tools.git
5 years agoL10n drop for open-vm-tools 10.2.0.
John Wolfe [Tue, 6 Oct 2020 21:30:54 +0000 (14:30 -0700)] 
L10n drop for open-vm-tools 10.2.0.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 6 Oct 2020 21:30:54 +0000 (14:30 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 6 Oct 2020 21:30:54 +0000 (14:30 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 6 Oct 2020 21:30:54 +0000 (14:30 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoAdding the vgauthImport utility to open-vm-tools.
John Wolfe [Tue, 6 Oct 2020 21:30:54 +0000 (14:30 -0700)] 
Adding the vgauthImport utility to open-vm-tools.

The vmware-alias-import utility is not currently packaged with the
open-vm-tools bundle; this change adds the utility.  It is built
only if vgauth is enabled.

5 years agoAdded 9/22/2020 devel branch changes to the ChangeLog.
John Wolfe [Tue, 22 Sep 2020 22:29:51 +0000 (15:29 -0700)] 
Added 9/22/2020 devel branch changes to the ChangeLog.

5 years agoFix the exit code when toolbox-cmd disk shrink is canceled.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Fix the exit code when toolbox-cmd disk shrink is canceled.

The toolbox-cmd disk shrink operation was exiting with status 0
when a SIGINT is received.  A non-zero exit status is expected.
Change the exit code to 130, which is the appropriate value
according to TLDP: https://tldp.org/LDP/abs/html/exitcodes.html

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoFix memory leaks in guestInfo/diskInfo.c.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Fix memory leaks in guestInfo/diskInfo.c.

When checking for IDE, SATA and SAS disk drives, the glib GMatchInfo is
passed to a g_regex_match() function inside a for loop.  It was not
properly passed to g_match_info_free() before subsequently being reused.

This addresses https://github.com/vmware/open-vm-tools/issues/452

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:07 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoFix a minor memory leak in VIX Listfiles().
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Fix a minor memory leak in VIX Listfiles().

The GError structure is not cleared in an error code path, which
leads to a minor memory leak.  Explicitly call g_clear_error().

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoChanges to common header files not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Changes to common header files not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:06 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agohgfsServerOplockMonitor.c HgfsOplockUnmonitorFileChange():
John Wolfe [Tue, 22 Sep 2020 21:54:05 +0000 (14:54 -0700)] 
hgfsServerOplockMonitor.c  HgfsOplockUnmonitorFileChange():

There is no need to cancel the monitor action if the oplock monitor
module has already been destroyed.   Avoid a possible NULL pointer
dereference.

5 years agoChanges to common source files not directly applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:05 +0000 (14:54 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:05 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoUpdate the development tools version for the next major point release.
John Wolfe [Tue, 22 Sep 2020 21:54:05 +0000 (14:54 -0700)] 
Update the development tools version for the next major point release.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 22 Sep 2020 21:54:05 +0000 (14:54 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoFix a potential null pointer dereference in asyncsocket.
John Wolfe [Tue, 22 Sep 2020 21:54:05 +0000 (14:54 -0700)] 
Fix a potential null pointer dereference in asyncsocket.

5 years agoCaptured the "devel" change log history since the start of the "stable-11.1.x"
John Wolfe [Tue, 22 Sep 2020 15:20:25 +0000 (08:20 -0700)] 
Captured the "devel" change log history since the start of the "stable-11.1.x"
branch.

5 years agoUpdated the ChangeLog with the changes targeted for OVT 11.2.0 from
John Wolfe [Tue, 22 Sep 2020 14:58:10 +0000 (07:58 -0700)] 
Updated the ChangeLog with the changes targeted for OVT 11.2.0 from
the "devel" branch.

Note: These may include changes deemed urgent enough to be cross ported to
      the "stable-11.1.x" branch.

5 years agoCommon source file changes not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:06 +0000 (12:11 -0700)] 
Common source file changes not applicable to open-vm-tools.

5 years agoChanges to Common source files not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:06 +0000 (12:11 -0700)] 
Changes to Common source files not applicable to open-vm-tools.

5 years agoGuestOS: Add Flatcar Linux (64-bit only) as a new guest.
John Wolfe [Fri, 11 Sep 2020 19:11:06 +0000 (12:11 -0700)] 
GuestOS: Add Flatcar Linux (64-bit only) as a new guest.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:06 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon source file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:06 +0000 (12:11 -0700)] 
Common source file change not applicable to open-vm-tools.

5 years agohostinfo.h: stop including x86cpuid.h
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
hostinfo.h: stop including x86cpuid.h

With the removal of Hostinfo_GetAllCpuid in an earlier change, hostinfo.h
can stop including x86cpuid.h and only needs vendor IDs from x86vendor.h.

Unfortunately, quite a few source files depended in hostinfo.h's automatic
inclusion of x86cpuid.h. Fix them to include what they need.

The lib/include/guestStats.h is a special case that happened to succeed because
of a warning that was disabled in x86cpuid.h which also happens to have
been included earlier than this header.  Re-disable the warning.

5 years agoEnsuring vmtools utilities are only used in a VMware virtual environment.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Ensuring vmtools utilities are only used in a VMware virtual environment.

Several utilities do not check that their running environment is in a
VMware hypervisor.  Add checks and generate error messages if the
running environment is a physical machine.  Some makefiles were altered
o resolve dependency issues.

5 years agoVGAuth: vgauthd service fails if vgauth.conf samlSchemaDir has trailing whitespace
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
VGAuth: vgauthd service fails if vgauth.conf samlSchemaDir has trailing whitespace

When reading the vgauth.conf samlSchemaDir, remove any trailing whitespace.
Also remove trailing whitespace when reading any preference string.

5 years agoAdditional clean up of vmware_pack files.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Additional clean up of vmware_pack files.

5 years agoUpdating authors for OVT contributions
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Updating authors for OVT contributions

https://github.com/vmware/open-vm-tools/pull/432

5 years agoChanging permissions of tools configuration example file.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Changing permissions of tools configuration example file.

Also made a small change to another makefile for more consistency in style.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoAdditional clean up of vmware_pack files.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Additional clean up of vmware_pack files.

5 years agoAdditional clean up of vmware_pack files.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Additional clean up of vmware_pack files.

5 years agoAdditional clean up of vmware_pack files.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Additional clean up of vmware_pack files.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoChange to common header file not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:05 +0000 (12:11 -0700)] 
Change to common header file not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoBack out earlier common header file changes.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Back out earlier common header file changes.

5 years agoBackout the previous header file change.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Backout the previous header file change.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoChanges to common header files not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Changes to common header files not applicable to open-vm-tools.

5 years agoReplace a bogus URL provided in a vmcheck.c error message.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Replace a bogus URL provided in a vmcheck.c error message.

Previously the URL "http://www.vmware.com/info?id=99" appeared in
an error message in the vmware_checkvm binary to refer to VMware Tools
updating information that may change from one release to the next.
That information is now available from the single VMware Tools URL"
https://docs.vmware.com/en/VMware-Tools/index.html.

5 years agoGet rid of more vmware_pack files.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Get rid of more vmware_pack files.

gcc supports the Microsoft-style "pragma pack" syntax.
Standardize on it.  The conversion is somewhat non-trivial,
as gcc requires "pragma" to be before or after a statement,
not in the middle.

5 years agoCommon source file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Common source file change not applicable to open-vm-tools.

5 years agoLog Facility: Infrastructure changes for module level filtering
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Log Facility: Infrastructure changes for module level filtering

Additional changes to log.h and loglevel_userVars.h

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoRemove PANIC() macro in favor of Panic() or VERIFY()
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Remove PANIC() macro in favor of Panic() or VERIFY()

5 years agoRecord usage of VMware Tools version 11.1.6
John Wolfe [Fri, 11 Sep 2020 19:11:04 +0000 (12:11 -0700)] 
Record usage of VMware Tools version 11.1.6

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoChanges to common header files not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Changes to common header files not applicable to open-vm-tools.

5 years agoAdding null check for results passed to log function.
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Adding null check for results passed to log function.

In several files, replies/results from RPC functions can possibly be
null if the function fails.  This changeset adds a function-like macro
which does the null checks and is applied to the replies when passed
into logging functions.

5 years agoEnsure the servicediscovery plugin isn't enabled in an open-vm-tools build for non...
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Ensure the servicediscovery plugin isn't enabled in an open-vm-tools build for non Linux OS.

The servicediscovery plugin is supported only on Linux platforms.  This
change checks that this plugin is enabled only if the OS is Linux.
Otherwise, an error message is printed.

5 years agoTools consumes loglevel_user.h
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Tools consumes loglevel_user.h

Adding lib/include/loglevel_userVars.h.

5 years agoSplit out the log level defs from the log level vars.
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Split out the log level defs from the log level vars.

This way the Log Facility can use the same name space as LOG for its
domain specific level filtering by including loglevel_userVars.h directly.

5 years agoBackout the previous log level defines change.
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Backout the previous log level defines change.

5 years agoSplit out the log level defs from the log level vars.
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Split out the log level defs from the log level vars.

5 years agoGet rid of vmware_pack files (devices edition)
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Get rid of vmware_pack files (devices edition)

gcc supports the Microsoft-style "pragma pack" syntax.
Standardize on it.  The conversion is somewhat non-trivial,
as gcc requires "pragma" to be before or after a statement,
not in the middle.

5 years agovm_assert.h: Remove unused PANIC_BUG
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
vm_assert.h: Remove unused PANIC_BUG

5 years agoSwap out Log+PANIC for Panic
John Wolfe [Fri, 11 Sep 2020 19:11:03 +0000 (12:11 -0700)] 
Swap out Log+PANIC for Panic

Just call Panic with an appropriate string instead of a Log+PANIC.

5 years agoLOG: Keep the LOG_LEVEL entries sorted
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
LOG: Keep the LOG_LEVEL entries sorted

This is the first in a series of changes to the Log Facility that will add
the ability to have domain specific filtering (e.g. foobar domain can have
log calls which are filtered by domain (name) and level).  This will make
LOG like abilities usable in all build types, even a release build.

The LOG_LEVEL entries are difficult to find since they are in a jumbled
order.  The existing grouping isn't useful as many of the modules are shared.
Create one big sorted list.

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoRemoving unnecessary code from rpc header file.
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Removing unnecessary code from rpc header file.

Several macros related to VMDB are no longer needed in the guestrpc
header file.  This change deletes those unused macros.

5 years agoImprove the logging for deployPkg in a few workflows
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Improve the logging for deployPkg in a few workflows

When executing Perl script in Linux Guest OS customization, log an
error if the execution fails.

5 years agoAdd --cmdfile argument
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Add --cmdfile argument

Some OSes (Windows) have a relatively small cmdline limit.
Expose a cmdfile argument which works like --cmd, but
reads the input from a file.  This allows RPCs which can
have huge arguments (guestVars, namespaceDB, DataSets) to work.

5 years agoCommon source file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Common source file change not applicable to open-vm-tools.

5 years agoFix a stack-use-after-scope issue in FileLockScanDirectory.
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Fix a stack-use-after-scope issue in FileLockScanDirectory.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 11 Sep 2020 19:11:02 +0000 (12:11 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoMerge branch 'stable-11.1.x' - bring ChangeLog up to date
John Wolfe [Wed, 2 Sep 2020 20:13:08 +0000 (13:13 -0700)] 
Merge branch 'stable-11.1.x' - bring ChangeLog up to date

5 years agoUpdate ChangeLog with 11.1.0 and 11.1.5 changes on this branch stable-11.1.x
John Wolfe [Wed, 2 Sep 2020 20:10:27 +0000 (13:10 -0700)] 
Update ChangeLog with 11.1.0 and 11.1.5 changes on this branch

5 years agoMerge branch 'stable-11.1.x' for the 11.1.5 release
John Wolfe [Wed, 19 Aug 2020 20:51:37 +0000 (13:51 -0700)] 
Merge branch 'stable-11.1.x' for the 11.1.5 release

5 years agoRelease Notes for 11.1.5 stable-11.1.5
John Wolfe [Wed, 19 Aug 2020 19:16:02 +0000 (12:16 -0700)] 
Release Notes for 11.1.5

5 years agoUpdate version to 11.1.5 and set final build numbers
John Wolfe [Wed, 19 Aug 2020 17:47:36 +0000 (10:47 -0700)] 
Update version to 11.1.5 and set final build numbers

5 years agoRemove duplicate global definitions.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Remove duplicate global definitions.

Remove duplicate and unused global definitions for
GDK_SELECTION_TYPE_TIMESTAMP and GDK_SELECTION_TYPE_UTF8_STRING.

This fix will address https://github.com/vmware/open-vm-tools/issues/451

5 years agoFix Coverity-reported dead code issue.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Fix Coverity-reported dead code issue.

The underlying problem was that retryCount was being zeroed on every
iteration of the while loop.  Zero it before entering the loop instead.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCode cleanup to address a Coverity issue.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Code cleanup to address a Coverity issue.

Coverity reports a "dereference after NULL check" in
BkdoorChannelStart.  However, at the point of dereference
it's known that chan->inStarted is TRUE, which means chan->in
is guaranteed to be non-NULL, so it's not a bug.

Still, given that an input channel, if present, must have been
started before calling BkdoorChannelStart, it's possible to do
some code cleanup that will also get Coverity to stop reporting
the issue.  Change what's currently a test into an ASSERT, test
chan->in rather than chan->inStarted, and add comments to make
it clearer what's going on.

5 years agoImplement the Set_option handler in appInfo plugin.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Implement the Set_option handler in appInfo plugin.

* Add a handler for Set_option in the appInfo plugin.
  The poll loop will be immediately turned off when
  the feature is turned off at the host side.
  The poll loop will be immediately turned on when
  the feature is turned on at the host side.

* Add code to handle VM vmotion to an older host that
  doesn't have logic to send 'set_option'.

* Fix some miscellaneous issues in the appinfo plugin.
  Use the proper @param and @return statements in the
  function documentation for AppInfoServerSetOption.

  Reorganize an "if" code block.

5 years agoFix a Coverity-reported NULL pointer issue.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Fix a Coverity-reported NULL pointer issue.

5 years agoFix a dereference after null check reported by Coverity.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Fix a dereference after null check reported by Coverity.

Original Description:
| Fix dereference after null check reported by Coverity.
|
| Remove a superfluous NULL pointer test that causes Coverity
| to report a dereference after null check.
|
| QA Notes:
| Testing Done:
| - Sandboxes:
| -- obj: Build 36442558 queued (vgauth-sdk/main):
|    https://buildweb.eng.vmware.com/sb/36442558/
| -- obj: Build 36442647 queued (tools/main):
|    https://buildweb.eng.vmware.com/sb/36442647/
| Documentation Notes:
| Bug Number: 2571476
| Reviewed by: jwolfe, lemke, stanguturi
| Approved by:
| Mailto:
| Review URL: https://reviewboard.eng.vmware.com/r/1668542/
| SVS Submit Restricted: Yes
| Post Submit Tests:

5 years agoServiceDiscovery: Replacing deprecated 'netstat' command with 'ss'
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
ServiceDiscovery: Replacing deprecated 'netstat' command with 'ss'

Updating the Linux serviceDiscovery scripts to use "ss" in place of
the deprecated "netstat" command.

5 years agoPick up the LSB distro file for ALT Linux
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
Pick up the LSB distro file for ALT Linux

Improve the documentation of the Linux identification routine so others
know that nothing needs to be changed in the field.
Only VMware needs to add identification codes.

https://github.com/vmware/open-vm-tools/pull/431

5 years agoServiceDiscovery: Deleting keys from NDB by chunks to reduce RPC calls.
John Wolfe [Wed, 19 Aug 2020 17:01:17 +0000 (10:01 -0700)] 
ServiceDiscovery: Deleting keys from NDB by chunks to reduce RPC calls.

Setting chunk size to 25 keys at a time.

5 years agoMake peeking back into the stack work for back traces
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
Make peeking back into the stack work for back traces

GCC 10 doesn't like peeking back before the end of an arrary (which
is used to peek into the stack).  Fix this.

https://github.com/vmware/open-vm-tools/issues/429

5 years ago[AppInfo] Tweak the gather loop only for a real config reload.
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
[AppInfo] Tweak the gather loop only for a real config reload.

The poll loop for appInfo is being tweaked (destroyed and recreated)
for every tools.conf reload, even when nothing related to appinfo changed.
This may cause a few scenarios where the 'application information'
will never be collected inside the guest.  Tweak the loop only when there
is a real appinfo related config change in the tools.conf file.

5 years agoDirective argument is null from GCC 9.3.0
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
Directive argument is null from GCC 9.3.0

There are paths that do not properly deal with NULL in FileMakeTempEx2Work.
Fix this.

https://github.com/vmware/open-vm-tools/issues/428