]> git.ipfire.org Git - thirdparty/open-vm-tools.git/log
thirdparty/open-vm-tools.git
5 years agoFree old ununsed loggers when tools.conf changes.
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
Free old ununsed loggers when tools.conf changes.

Existing unused loggers are leaked when there is a change
in logging configuration.  Added a check to free the loggers
that are not used after tools.conf is modified.

5 years agoThe SDMP plugin generates a warning message every 5 minutes when there is no
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
The SDMP plugin generates a warning message every 5 minutes when there is no
Namespace DB instance created on a VM.  Change the log level to
debug to solve the problem.

5 years agoserviceDiscovery: Updating 'get-versions.sh' script
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
serviceDiscovery: Updating 'get-versions.sh' script

The following changes have been made:

1. Environment variable 'ALIVE_BASE' is used to construct the path of
   the file where vcops version is stored.  The variable is not available
   when running the script inside serviceDiscovery plugin process, so a
   hardcoded path is used.

2. Added command to retrieve tcserver version

5 years agoPrepare the branch for VMware Tools 11.1.5 update builds.
John Wolfe [Wed, 19 Aug 2020 17:01:16 +0000 (10:01 -0700)] 
Prepare the branch for VMware Tools 11.1.5 update builds.

Set the open-vm-tools version number to 11.1.5.

5 years agoUpdate copyright dates.
John Wolfe [Tue, 18 Aug 2020 14:46:26 +0000 (07:46 -0700)] 
Update copyright dates.

5 years agoRemove the guestApp.h header file that is not needed in conf.h
John Wolfe [Tue, 18 Aug 2020 14:14:12 +0000 (07:14 -0700)] 
Remove the guestApp.h header file that is not needed in conf.h

The configuration header file conf.h includes the guestapp header file
guestApp.h, but there are no related references to the guestapp header
file.  This change removes the unnecessary header file.
The guestApp.h header file is included in the few source files with
a dependency on it.

5 years agoIncluding appinfo and servicediscovery settings in configuration file
John Wolfe [Tue, 18 Aug 2020 14:14:12 +0000 (07:14 -0700)] 
Including appinfo and servicediscovery settings in configuration file

Adding the default configuration settings to the tools.conf sample.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:12 +0000 (07:14 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years ago[HGFS Server] Add file attributes/symlink check status cache using oplock support
John Wolfe [Tue, 18 Aug 2020 14:14:12 +0000 (07:14 -0700)] 
[HGFS Server] Add file attributes/symlink check status cache using oplock support

An investigation found that while copying a group of small files from host
to guest using the shared folder, the HGFS_OP_GETATTR_V3 message was handled
in HGFS server 276,140 times over a period of ~35 seconds.

Caching the file attributes in HGFS on the server-side can reduce the time
significantly (from experimental results, 35s => 8s).

It was also discovered that Posix_RealPath is called repeatedly to check
whether a path is a symlink, since HgfsServerGetLocalNameInfo is called when
handling a series of requests.

Integrate a key-value cache to HGFS server to cache the symlink check results
and file attributes, using the file path as the key.  This task will be divided
into multiple change:

1. Add oplock support
2. Add a customized LRU cache in HGFS server for file attributes and
   symlink check results

-  New files:
   hgfsCache.h/c: implements a customized LRU cache which is built by
                  combining two data structures: a doubly linked list and
                  a hash table.

-  The cache will be allocated only when oplock is enabled.
-  The cache relies on the file change monitor provided by oplock to ensure
   there is no stale data.  When adding an entry into the cache, also
   register the file change callback to oplock.  Upon receiving the file change
   callback, invalidate the cache.  Once the cache is full, remove the LRU
   entry and unregister the file change callback for it.

5 years agoChange to common header files not applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Change to common header files not applicable to open-vm-tools.

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoDefine "Unknown Command" Macro to replace hard coded strings in rpc files
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Define "Unknown Command" Macro to replace hard coded strings in rpc files

This changeset finds all instances of the hardcoded string "Unknown Command"
in a few rpc files and replaces it with a macro defined in a shared header
file.

5 years agoChanges to common header files not directly applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Changes to common header files not directly applicable to open-vm-tools.

5 years agoChanges to common header files not applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Changes to common header files not applicable to open-vm-tools.

5 years agoFix log recursion issue in DestroyRpcChannel()
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Fix log recursion issue in DestroyRpcChannel()

Avoid calling g_xxx() logging routines in any function directly or
indirectly invoked from VmxGuestLog().  Change the g_debug() call in
DestroyRpcChannel() to a Debug() call.

5 years agoChanges to common source files not directly applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

5 years agoRemove #include for headers that are not needed in serviceDiscovery.c file.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Remove #include for headers that are not needed in serviceDiscovery.c file.

5 years agoChanges to common source files not directly applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

5 years agoRemoving windows header file which is not needed for OVT build
John Wolfe [Tue, 18 Aug 2020 14:14:11 +0000 (07:14 -0700)] 
Removing windows header file which is not needed for OVT build

Changeset deletes code which references a Windows specific
header file and cleans up some whitespace.

5 years agoAdding vmtools library dependency to deploypkg library
John Wolfe [Tue, 18 Aug 2020 14:14:10 +0000 (07:14 -0700)] 
Adding vmtools library dependency to deploypkg library

Some functions are not found in shared libraries when linking,
which generates several warnings.  Added a library with
the needed functions to the list of dependencies.

5 years agoBackout the previous common souce file changes.
John Wolfe [Tue, 18 Aug 2020 14:14:10 +0000 (07:14 -0700)] 
Backout the previous common souce file changes.

Restore files to original state

5 years agoChanges to common source files not directly applicable to open-vm-tools.
John Wolfe [Tue, 18 Aug 2020 14:14:10 +0000 (07:14 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

5 years agoUpdate the copyright
John Wolfe [Wed, 12 Aug 2020 04:26:23 +0000 (21:26 -0700)] 
Update the copyright

5 years agoBackout the previous common souce file changes.
John Wolfe [Fri, 7 Aug 2020 19:03:26 +0000 (12:03 -0700)] 
Backout the previous common souce file changes.

5 years agoChanges to common source files not directly applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:26 +0000 (12:03 -0700)] 
Changes to common source files not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:26 +0000 (12:03 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoAddress some Log spew for toolsdeployPkg.log
John Wolfe [Fri, 7 Aug 2020 19:03:26 +0000 (12:03 -0700)] 
Address some Log spew for toolsdeployPkg.log

1. Remove the extra '\n' at the tail of logging messages in imgcust.
2. Update the log printting function, do not add '\n' if the original
   log message has already included it.

5 years agoAdd copyright header to service discovery scripts
John Wolfe [Fri, 7 Aug 2020 19:03:26 +0000 (12:03 -0700)] 
Add copyright header to service discovery scripts

5 years agocommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:26 +0000 (12:03 -0700)] 
common header file change not applicable to open-vm-tools.

5 years agoCommon source file changes not directly applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Common source file changes not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoUpdating the copyright date on a few files.
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Updating the copyright date on a few files.

5 years agoResubmit the gcc baseline to 4.1 bump.
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Resubmit the gcc baseline to 4.1 bump.

5 years agoBackout the previous gcc-4.1 enforcement.
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Backout the previous gcc-4.1 enforcement.

5 years agoBump gcc baseline to 4.1
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
Bump gcc baseline to 4.1

5 years ago[HGFS Server] Support oplock inside HGFS server for Windows host
John Wolfe [Fri, 7 Aug 2020 19:03:25 +0000 (12:03 -0700)] 
[HGFS Server] Support oplock inside HGFS server for Windows host

Missed two source files for previous HGFS Server changeset.

5 years ago[HGFS Server] Support oplock inside HGFS server for Windows host
John Wolfe [Fri, 7 Aug 2020 19:03:24 +0000 (12:03 -0700)] 
[HGFS Server] Support oplock inside HGFS server for Windows host

The motivation for this change is to cache file/directory related information
in host side, for example the file/directory attributes.  To make the cache
correct, we will use the oplock(Windows)/lease(Linux) to monitor the
file/directory change event.  When the file/directory changes, the item in
cache will be invalidated.

In this change, two new functions are defined:
- HgfsOplockMonitorFileChange
   This function is used to monitor the change event for a file/directory,
   and the callback will be called if file/directory is changed.
- HgfsOplockUnmonitorFileChange
   This function is used to cancel the change event monitoring.

This patch only implements the oplock support for Windows host, the support
for Linux will be delivered in another patch.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 7 Aug 2020 19:03:24 +0000 (12:03 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoThe new table driven guest identification code did not handle Red Hat
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
The new table driven guest identification code did not handle Red Hat
properly.  It needs to be checked for before Enterprise Linux.

5 years agoChanges to common header files not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
Changes to common header files not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoRemove duplicate global definitions.
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
Remove duplicate global definitions.

Remove duplicate and unused global definitions for
GDK_SELECTION_TYPE_TIMESTAMP and GDK_SELECTION_TYPE_UTF8_STRING.

This fix will address https://github.com/vmware/open-vm-tools/issues/451

5 years agoChanges to common header files not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
Changes to common header files not applicable to open-vm-tools.

5 years agoserviceDiscovery: Double quoting script variables that might contain whitespaces.
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
serviceDiscovery: Double quoting script variables that might contain whitespaces.

5 years agoUpdate to the tools.conf sample file not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:35 +0000 (13:36 -0700)] 
Update to the tools.conf sample file not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoChanges to common header files not directly applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Changes to common header files not directly applicable to open-vm-tools.

5 years ago[Coverity] Remove superfluous condition in if statement
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
[Coverity] Remove superfluous condition in if statement

5 years agoRewrite Linux guest shortname identification
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Rewrite Linux guest shortname identification

Replaced guest identification with easy to maintain tables
as well as added general table search abstractions for easy
maintainability.

5 years agoGOSC event doesn't report at once after customization process timer is reached
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
GOSC event doesn't report at once after customization process timer is reached

When process timer is reached, the command process is killed and function
ProcessRead is called to read all the output till EOF.  But EOF can't be
reached immediately.  The reason is pre-customization script is launched
by perl script, and killing perl script process doesn't kill the
pre-customization script process.
This code update includes:
1. Do not read stdout/stderr when gosc command process exits abnormally
   to avoid the EOF blocking.
2. Add READSTATUS_PENDING_TO_EOF in enum ReadStatus to avoid the confusion
   with READSTATUS_PENDING.
3. Close the write ends of pipes (stdout[1]/stderr[1]) for child command
   process before it exists.
4. In processPosix.c, the write ends of pipes have been closed in line 180,
   181, so the read ends should be closed in line 254, 255.
5. Add explicit note for the beginning and the end of the perl script log.

5 years agoCommon hesder file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Common hesder file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:34 +0000 (13:36 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Fri, 31 Jul 2020 20:36:33 +0000 (13:36 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoFix memory leak issue for "vmtoolsd" binary on receiving SIGINT or SIGUSR1.
John Wolfe [Tue, 21 Jul 2020 18:53:01 +0000 (11:53 -0700)] 
Fix memory leak issue for "vmtoolsd" binary on receiving SIGINT or SIGUSR1.

Valgrind complains of a memory leak issue on receiving SIGINT or SIGUSR1
signal, because we lost call to RpcIn_Destruct(chan->in) in
RpcChannelTeardown().  It just happens to be released only at service
shutdown or on receiving SIGUSR1 signal; not a major concern.
Cleaning up the code.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:01 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years ago[CLI] "removeAll" missing in first line of vmware-vgauth-cmd help info
John Wolfe [Tue, 21 Jul 2020 18:53:01 +0000 (11:53 -0700)] 
[CLI] "removeAll" missing in first line of vmware-vgauth-cmd help info

5 years agoRemove unnecessary FreeBSD strings
John Wolfe [Tue, 21 Jul 2020 18:53:01 +0000 (11:53 -0700)] 
Remove unnecessary FreeBSD strings

5 years agoUnknown Linux, later than 5 should report 5, not 4
John Wolfe [Tue, 21 Jul 2020 18:53:01 +0000 (11:53 -0700)] 
Unknown Linux, later than 5 should report 5, not 4

We want to report the highest version we know about in the short name.

5 years agoImprove the LSB distro identification table documentation
John Wolfe [Tue, 21 Jul 2020 18:53:01 +0000 (11:53 -0700)] 
Improve the LSB distro identification table documentation

Explain the LSB distro identification table and provide directions
about when to use it.

5 years agoFix a comment about POSIX/Linux guest identification
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Fix a comment about POSIX/Linux guest identification

The comment is not clear.  Fix this.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon source file changes not directly applicable to open-vm-tools at this time.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common source file changes not directly applicable to open-vm-tools at this time.

5 years agohostinfoPosix: remove NOT_IMPLEMENTED() when NO_IOPL
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
hostinfoPosix: remove NOT_IMPLEMENTED() when NO_IOPL

When running "vmtoolsd -b pidfile" on Linux arm64, we hit this error:

   [error] [vmsvc] NOT_IMPLEMENTED hostinfoPosix.c:2526

Linux arm64 does not implement iopl() and the Hostinfo_ResetProcessState()
is raising a NOT_IMPLEMENTED() because of that.  However if there's no iopl(),
there is no reason to drop IO privileges, so we can just skip that code.

This change also restores usage of getloadavg() for non Android arm64
platforms: ESX vmx and tools for Linux arm64.

5 years agoResubmit - Move vgauth to gcc6 and openssl-1.1.1e.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Resubmit - Move vgauth to gcc6 and openssl-1.1.1e.

5 years agoServiceDiscovery: Reducing scope of local variables in checkForWrite().
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
ServiceDiscovery: Reducing scope of local variables in checkForWrite().

Reducing scope of variables 'clientTimeStamp', 'clientInterval' and
'currentTime' in function 'checkForWrite()'.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:53:00 +0000 (11:53 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoBackout the previous vgauth changes for openssl 1.1.1.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Backout the previous vgauth changes for openssl 1.1.1.

5 years agoMove vgauth to gcc6 and openssl-1.1.1.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Move vgauth to gcc6 and openssl-1.1.1.

5 years agovmware-toolsbox-cmd: Fix illegal read memory issue reported by Valgrind
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
vmware-toolsbox-cmd: Fix illegal read memory issue reported by Valgrind

Replace the static function MsgUnescape() and its memmove() call that moves
1 byte beyond the termination '\0' with glib's g_strcompress().

5 years agoBackout the immediately previous changes to common files.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Backout the immediately previous changes to common files.

5 years agoCommon source file changes not directly applicable to open-vm-tools at this time.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Common source file changes not directly applicable to open-vm-tools at this time.

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoChanges to common source files not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Changes to common source files not applicable to open-vm-tools.

5 years agoopen-vm-tools: Propagate new gdk-pixbuf-xlib include location #438
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
open-vm-tools: Propagate new gdk-pixbuf-xlib include location #438

From github PR #438 (https://github.com/vmware/open-vm-tools/pull/438).

5 years agoCommon header file change not directly applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Common header file change not directly applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:59 +0000 (11:52 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:58 +0000 (11:52 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCommon header file change not applicable to open-vm-tools.
John Wolfe [Tue, 21 Jul 2020 18:52:58 +0000 (11:52 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoFix misc. issues in appinfo plugin source.
Oliver Kurth [Fri, 12 Jun 2020 03:43:21 +0000 (20:43 -0700)] 
Fix misc. issues in appinfo plugin source.

Used the proper @param and @return statements in the
function documentation for AppInfoServerSetOption.

Re-organized an if code block.

5 years agoServiceDiscovery: Replacing deprecated 'netstat' command with 'ss'
Oliver Kurth [Fri, 12 Jun 2020 03:43:21 +0000 (20:43 -0700)] 
ServiceDiscovery: Replacing deprecated 'netstat' command with 'ss'

Updating the Linux serviceDiscovery scripts to use "ss" in place of
the deprecated "netstat" command.

5 years agoCode cleanup to address a Coverity issue.
Oliver Kurth [Fri, 12 Jun 2020 03:43:21 +0000 (20:43 -0700)] 
Code cleanup to address a Coverity issue.

Coverity reports a "dereference after NULL check" in
BkdoorChannelStart.  However, at the point of dereference
it's known that chan->inStarted is TRUE, which means chan->in
is guaranteed to be non-NULL, so it's not a bug.

Still, given that an input channel, if present, must have been
started before calling BkdoorChannelStart, it's possible to do
some code cleanup that will also get Coverity to stop reporting
the issue.  Change what's currently a test into an ASSERT, test
chan->in rather than chan->inStarted, and add comments to make
it clearer what's going on.

5 years agoCommon header file change not applicable to open-vm-toold.
Oliver Kurth [Fri, 12 Jun 2020 03:43:21 +0000 (20:43 -0700)] 
Common header file change not applicable to open-vm-toold.

5 years agoFix Coverity-reported dead code issue.
Oliver Kurth [Fri, 12 Jun 2020 03:43:21 +0000 (20:43 -0700)] 
Fix Coverity-reported dead code issue.

The underlying problem was that retryCount was being zeroed on every
iteration of the while loop.  Zero it before entering the loop instead.

5 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Fri, 12 Jun 2020 03:43:20 +0000 (20:43 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoCorrect an issue reported by Coverity.
Oliver Kurth [Fri, 12 Jun 2020 03:43:20 +0000 (20:43 -0700)] 
Correct an issue reported by Coverity.

lib/asyncsocket/asyncsocket.c:
 - AsyncSocket_SetKeepAlive() calls AsyncSocket_GetFd() which may return
   a negative result.  If that should happen, simply return FALSE.

5 years agoopen-vm-tools: add distribution specific pam config files
Oliver Kurth [Wed, 10 Jun 2020 19:05:46 +0000 (12:05 -0700)] 
open-vm-tools: add distribution specific pam config files

Add distribution specific pam config files for Debian/Ubuntu,
SuSE and Redhat/Fedora/CentOS.  Install a generic file by default,
with comments to KB article.  The distribution files are intended
to be used by OS vendors in their open-vm-tools packages.

5 years agoUpdate the AUTHORS file for OVT an contribution.
Oliver Kurth [Wed, 10 Jun 2020 19:05:46 +0000 (12:05 -0700)] 
Update the AUTHORS file for OVT an contribution.

https://github.com/vmware/open-vm-tools/pull/431

5 years agoAppinfo.h: Add define for APP_INFO_GUESTINFO_KEY
Oliver Kurth [Wed, 10 Jun 2020 19:05:46 +0000 (12:05 -0700)] 
Appinfo.h:  Add define for APP_INFO_GUESTINFO_KEY

5 years agoCommon header file change not applicable to open-vm-tools.
Oliver Kurth [Wed, 10 Jun 2020 19:05:46 +0000 (12:05 -0700)] 
Common header file change not applicable to open-vm-tools.

5 years agoImprove Linux guest identification function documentation.
Oliver Kurth [Wed, 10 Jun 2020 19:05:46 +0000 (12:05 -0700)] 
Improve Linux guest identification function documentation.

Make it clear that the "short name" of a Linux distro has a default
value and that the default value should not be overwritten unless
VMware does this.

If someone cheats and sends down an unsupported "short name", the
guestMapper will protect the software stack, mapping the unsupported
"short name" to that of the guestOS config found in the VMX file.
We know that is OK since the VM couldn't power on and run the guest
unless it was valid.

All older, supported ESXi have updates that contain the guestMapper.

If the guestMapper is not in place - an older, unpatched release -
the software stack can become confused causing problems and crashes.

Change augments https://github.com/vmware/open-vm-tools/pull/431