Merge pull request #16233 from horazont/fix/doc-dnssec-soa-edit-notes

docs: fix markup for list of "Important Notes"

dnsdist: Fix formatting, ignore complexity for now

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

docs: Add trailing period

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

docs: Indent list

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

docs: link algorithm rollover from DNSSEC operational instructions

I probably would've missed it anyway, because that section of the
document has strong "motivational / introductory text" vibes which make
my brain auto-skip it, but at least there's a chance now.

Signed-off-by: Jonas Schäfer <jonas@zombofant.net>

docs: fix markup for list of "Important Notes"

This had me confused while reading, because the list wasn't rendered as
list (but as a paragraph) and I wondered why starting with 00 would
increase the chance of overflow...

Signed-off-by: Jonas Schäfer <jonas@zombofant.net>

rec: silence rust warning

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

luawrapper: don't segfault on failure in traceback handler

Signed-off-by: Peter van Dijk <peter.van.dijk@powerdns.com>

Merge pull request #16231 from omoerbeek/rec-unit-test-test

ci: Check return status of rec unit test run when using meson

Merge pull request #16227 from omoerbeek/unkeep-keeper-in-rec

Do not include dnsseckeeper.hh and ueberbackend.hh  in rec

Firts stab at docs

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add tests, list gnutls as dependency

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Allow runtime setting of TLS config tables by using rec_control reload-yaml

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Provide TLS config by lookup on name or subnet.

With settable verification mode, provider, subject name and some more.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Link in gnutls provider and provide verify error status method for it

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Add code to get certificate validation status (openssl only ATM)

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

dnsdist: Hopefully slightly reduce the complexity of `processQueryAfterRules`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Properly handle exceptions when processing timeout rules

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Check return status of rec unit test run when using meson

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Explicitly include file for openssl version number

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

dnsdist: Add regression tests for the pool's zero scope bindings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Do not use inverted logic for the pool's zero scope state

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Add unit tests for server consistency

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Try to appease clang-tidy

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix a caching bug when all servers are down and the query was received over TCP

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Speed up cache hits by skipping the LB policy when possible

We use to execute the load-balancing policy to select a backend before
doing the cache lookup, because in some corner cases the selected
backend might have settings that impact our cache lookup. In practice
most configurations have a consistent set of settings for all servers
in a given pool, so it makes no sense to waste CPU cycles selecting a
backend if we are going to get a hit from the cache.
This PR adds a bit of code to check if a pool is in a consistent state,
and if it is it delays the execution of the load-balancing policy to
after the cache lookup, skipping it entirely for cache hits.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16225 from miodvallat/a_ldap_oddity

auth: logic botch in ldap backend

Merge pull request #16226 from miodvallat/ldap_punk

auth: remove dead ldap code

Fix test-signers: if there's no ref to OpenSSL it fails

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16224 from rgacogne/ddist-xsk-typo-doc

dnsdist: Fix a typo in the XSK documentation

Merge pull request #15924 from rgacogne/ddist-refactor-server-pools

dnsdist: Refactor server pools and load-balancing policies

Correctly handle reconnection in several routines.

If the search failed with a LDAPNoConnection exception and reconnection
is successful, we would recurse to reiterate the operation, but then would
proceed with the exist logic operating on uninitialized data.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Remove long deprecated and/or unused code.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

dnsdist: Add actual link to `newServer` in the XSK docs

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

auth/rec: seperate out dnssec constants from DNSSECKeeper by moving them to a DNSSEC class

This allows not having ueberbackend.hh in rec, it makes no sense including that file in rec

A bit of churn in rec, but all mechanical

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16223 from miodvallat/doctweaks

auth: minor doc tweak

Mention that unix socket support for webserver-address requires 5.0.

Fixes: #16222
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Move test-protozero-trace.cc to toplevel and add it in the autotools build where it was missing

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

protobuf logger: print opentelemetry id's in hex, implement proper arg parser

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

dnsdist: Add package urls to our SBOMs

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Yet another clang-tidy fix

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix a typo in the XSK documentation

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: add support for TCP Fast Open on macOS

This uses Apple's connectx() API instead of UNIX connect() API.

Signed-off-by: Karel Bilek <kb@karelbilek.com>

dnsdist: Appease clang-tidy

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix typo

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

spell-check: Remove 'splitsetup'

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Add regression tests for Lua pool bindings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Remove a very outdated example of how to do split-setup

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Apply suggestions from code review

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Document the new behaviour for custom LB policies written in Lua

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix CodeQL warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Simplify the least outstanding policy

The servers can no longer be updated under our feet, so we only need
one pass.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Refactor load-balancing policies

Since we no longer need to increase the reference counter of the
returned backend (the runtime configuration cannot be updated be
updated under our feet anymore), we can return the position of the
selected backend in the initial array instead, significantly
reducing the performance cost of the load-balancing policies.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Only set the DNSQuestion packet cache after a cache miss

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Server pools are no longer ref counted

Since the refactoring of the runtime configuration, the content of
a Server Pool is now in effect immutable, we have to create a new
copy and update it, so we no longer have to lock and reference count
Server Pools and their content.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16191 from rgacogne/ddist-test-meson-dist

build-and-test-all: Build dnsdist and recursor via a release tarball

dnsdist: Fix parameter names in `dnsdist_ffi_dnsquestion_set_alternate_name`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Remove empty trailing line

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix clang-tidy warnings, test more cases

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Refactor the FFI "alternate name" interface

So we can use it without making the query asynchronous when we
don't have to.

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

gh actions - misc-dailies: fix pip name normalization when validating hashes

Fix a secondary domain type check.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #16205 from rgacogne/ddist-fix-settag-dynblock-doc

dnsdist: The dynamic block tag name is set via `tagName`, not `tagKey`

When copying/migrating zones, only complain about comments if there are any.

Fixes: #16201
Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

Merge pull request #15929 from miodvallat/cement

grow auth source tarballs fatter

test: Add IPCrypt2 tests

Merge pull request #16204 from omoerbeek/rec-fix-dist

rec: we need a usable cargo for sdist so do not download (and install) rust but use package

chore: Switch from string to sockaddr for ipcrypt

feat(dnsdist): Add IPCrypt2 PFX to tests

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

feat(dnsdist): Add IPCrypt2 PFX mode to RemoteResponseLogAction

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

feat(dnsdist): Add IPCrypt2 PFX mode to RemoteLogAction

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

feat: import ipcrypt2 library

This corresponds to release 1.1.8 in https://github.com/ipcrypt-std/ipcrypt2

Signed-off-by: Pieter Lexis <pieter.lexis@powerdns.com>

rec: Fix "Avoid generating doc files in a sdist based build" check in out-of-tree builds

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

build-and-test-all: Test rec release tarball via meson instead of autotools

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16200 from omoerbeek/rec-coverity-20251002

rec: fix a few issues reported by coverity, all minor

rec: Fix out-of-tree builds with autotools

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Actually do not install rust at all

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

dnsdist: The dynamic block tag name is set via `tagName`, not `tagKey`

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16192 from rgacogne/ddist-health-check-latency-metric

dnsdist: Add a metric for the latency of the latest health-check

rec: we need a usable cargo for sdist so download (and install) rust later

The install is needed for meson setup, which does not run the found executable,
so the error of a missing lib was never spotted.

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16195 from miodvallat/cnt_spl_a_dmn

auth: missing space in error message

rec: fix a few issues reported by coverity, all minor

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #16198 from Smoothengineer/master

Fixed grammar in README.md

Fixed grammar in README.md

Signed-off-by: Smoothengineer <160827599+Smoothengineer@users.noreply.github.com>

Be sure to add the meson build files to the contents of `make dist'.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

sort EXTRA_DIST

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

This does not try to generate the man pages if they are found in the tarball

Same method as dnsdist and rec

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>

Merge pull request #15267 from romeroalx/store-packages-additional-repo

gh actions: upload packages to an additional repository

Merge pull request #16194 from omoerbeek/rec-commands

rec: rework command dispatcher to be table based

Support new SVCB parameters: ohttp, dohpath, tls-supported-groups

Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>

build-and-test-all: Fix code coverage generation from meson dist tarball

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

build-and-test-all: Fix bugs

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

dnsdist: Fix out-of-tree autotools builds

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

build-and-test-all: No longer run dnsdist autotools build from distdir

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

build-and-test-all: We always need Rust to build the dnsdist release tarball

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

build-and-test-all: Build dnsdist via a release tarball

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>

Merge pull request #16153 from rgacogne/ddist-docs-eol

dnsdist: Simplify EOL page

Merge pull request #16193 from miodvallat/air_freshness

lmdb: optional memory-only freshness check timestamp

Add missing space in error message.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

dnsdist: Update the EOL text as suggested by Otto

Co-authored-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>