Ray Strode [Mon, 2 Jun 2008 19:40:42 +0000 (15:40 -0400)]
Add some comments and macros to krh's nifty new gradient code
It took me a while to understand how the gradient code was
preventing banding, so this commit just adds some comments
explaing how it works, and moves some constants to preprocessor
defines for clarity
Ray Strode [Mon, 2 Jun 2008 15:03:28 +0000 (11:03 -0400)]
add new answer object for giving a deferred response
Right now we have this hack tower of function pointers
cutting through layers of code to get the password
from the splash plugin to the client. I'd like to cut
most of that out by just having one answer object that
the bottom layer and the the top layer know directly,
without the middle layers having to get too involved.
Ray Strode [Thu, 29 May 2008 20:54:00 +0000 (16:54 -0400)]
Allow distro/system builder to specify path to logo
Previously we've just hard coded the location to the fedora
logo. Now it's a configure time flag. We also have a configure
time flag for a background color that goes with the logo, but
none of the splash plugins make use of it yet.
Ray Strode [Thu, 29 May 2008 19:01:03 +0000 (15:01 -0400)]
Fix bug in union and intersection functions
The x and y values of the flush area are bogus just after
a flush when the flush area has a width of 0. We need to
special case that situation to perform the union/intersection
operations without looking at x and y.
Ray Strode [Thu, 29 May 2008 04:46:02 +0000 (00:46 -0400)]
Have window manage frame buffer instead of plugins
This is a first step toward making the window provide
an draw handler interface, so we can hide the details
of pause/unpause, resetting raw mode, and graphics mode,
etc from the individual plugins.
Ray Strode [Thu, 29 May 2008 04:16:08 +0000 (00:16 -0400)]
Set up event loop exit handler in plugins on show success
Previously we were setting up the exit handler at the top
of the show vtable function. This meant having to remove
the exit handler if the show fails. It's much easier to
not set up the handler until after we know we're going to
succeed.
Since the individual plugins are aware of the window object
anyway, they can register their own on_backspace et al handlers
without going through the ply_splash_plugin_t layer.
Ray Strode [Wed, 28 May 2008 22:02:23 +0000 (18:02 -0400)]
Update spec file to be more current
Package the individual plugins as subpackages and
get the file lists up to date. Also, drop
plymouth-update-initrd %post call since it's not
meant to be used in packages
Ray Strode [Wed, 28 May 2008 21:16:57 +0000 (17:16 -0400)]
Add ctrl-u and ctrl-w to erase password line
Right now we do it in the cheesiest way possible, by
calling the backspace function over and over again on
behalf of the user. It might make more sense to export
another window callback specifically for erase line. It
probably doesn't make sense to do that until we fix the
TODO item:
- have plugins hook into line editing through window
directly, instead of via vtable functions
Ray Strode [Wed, 28 May 2008 20:38:10 +0000 (16:38 -0400)]
Use more descriptive format for control code #defines
The previous format was just the ascii value directly
in octal. I'm getting sick of typing 'man ascii' to look
it up though. The new format is just, e.g.,
('\100' ^ 'U')
which not only means I can add new entries without looking
them up, but also has the added advantage that it looks
sort of similiar to, e.g., ^U, which is a common notation
for respresenting control characters.
Ray Strode [Wed, 28 May 2008 17:50:49 +0000 (13:50 -0400)]
Add the ability to toggle off graphics mode with ctrl-T
When debugging it's useful to be able to force text mode so
text messages become visible on screen. ctrl-t and ctrl-v
combined make it a lot easier to see what's going on.
Ray Strode [Wed, 28 May 2008 14:50:38 +0000 (10:50 -0400)]
Read /proc/cmdline and enable debugging if plymouth:debug is there
Currently we toggle verbose messges if the user presses ctrl-v.
That's fine, but doesn't help to debug problems that happen before
a splash screen is shown. This provides a mechanism to enable messages
earlier
Ray Strode [Tue, 27 May 2008 21:52:27 +0000 (17:52 -0400)]
Compute correct offset when copying from shadow buffer to frame buffer
When I added commit c12164c1622a2209fe07555e682cc479c6854e7e
to copy an entire row at a time to the framebuffer, I miscalculated the
offset to copy from/to. Their may be uninitialized data at the
beginning and end of the temporary row buffer, if only part of the row
is getting copied. We need to make sure we jump passed that junk in
memory and copy just the part that got filled in.
Ray Strode [Tue, 27 May 2008 18:28:48 +0000 (14:28 -0400)]
Add new array type to make managing arrays easier
This is just a thin wrapper around the buffer object,
that keeps the data in terms of "elements" instead of
bytes, and always null terminates the result.
Ray Strode [Tue, 27 May 2008 18:24:58 +0000 (14:24 -0400)]
Add new ply_buffer_steal_bytes method
This function disowns the bytes in the buffer and returns
them to the caller. It's useful for freeing the buffer, but
keeping the bytes around without doing a copy.
Ray Strode [Sat, 24 May 2008 05:39:27 +0000 (01:39 -0400)]
Copy and modify fedora-fade-in to new spinfinity plugin
The idea is to make a plugin that matches mockups done by
Mike Langlie. The mockups feature a throbber that spins
in the shape of an infinity sign. This is just a placeholder.
Most of the mockup isn't implemented yet.
Ray Strode [Fri, 23 May 2008 19:39:47 +0000 (15:39 -0400)]
Update TODO
Add:
- Add limited text support
- Make --ask-for-password take a prompt message
- consider making details plugin have stdin hooked
up to the pty instead of tty so input works
- consider making details plugin go back to pretty
plugin if user presses escape
Ray Strode [Fri, 23 May 2008 05:00:28 +0000 (01:00 -0400)]
Move keyboard handling to window so we can do line editing
The logic for line editing is a little complicated, so it's
best not to duplicate it across all the plugins. Now we
manage it all from the window. The plugins now access the
various editing events via there vtable, but that's an
extra layer of indirection that doesn't matter given that
we pass the window to the plugins anyway. We should drop
that and just have the plugins register for edit events
directly.
Ray Strode [Thu, 22 May 2008 21:01:09 +0000 (17:01 -0400)]
Add new ply_buffer_remove_bytes_at_end
This function is like ply_buffer_remove_bytes, but it
truncates away the end of the buffer instead of shifting
the contents over the start of the buffer.