Andrew Tridgell [Thu, 29 Oct 1998 05:01:47 +0000 (05:01 +0000)]
changes to get rsync working on a CRAY J90. This machine doesn't have
a 4 byte integer type (short is 8 bytes). I needed to use a new md4
implementation (I used the portable one I wrote for Samba).
Andrew Tridgell [Wed, 28 Oct 1998 10:43:31 +0000 (10:43 +0000)]
syslog support in rsync daemon has been broken since I added the "log
file" option. I wonder why noone reported it? Or did everyone just use
"log file" ?
David Dykstra [Tue, 27 Oct 1998 16:07:51 +0000 (16:07 +0000)]
- Define bindir and mandir as per gnu makefile standards
- Add install-strip target as per gnu makefile standards
Contributed by Fred Sanchez <wsanchez@apple.com>
David Dykstra [Mon, 26 Oct 1998 22:03:18 +0000 (22:03 +0000)]
Fix bug in --include and --include-from which didn't work as advertised;
could only include files before if "+ " was explicitly prefixed on files
from any exclude or include option. Also simplified the code by removing
the "orig" exclude_struct element, and reduced the number of bytes
transferred from client to server by never including "- " prefixes in the
transmitted exclude list because exclusion is the default.
David Dykstra [Mon, 26 Oct 1998 21:51:47 +0000 (21:51 +0000)]
Add "use chroot" and "pid file" rsyncd.conf options. The former allows one
to disable the use of chroot so rsync --daemon can be run as a non-root
user (if a non-privileged --port is used). The latter allows one to
specify a file in which to write the process id of the daemon, which is
useful when rsync --daemon is not run from inetd.
David Dykstra [Mon, 26 Oct 1998 21:42:38 +0000 (21:42 +0000)]
Add --compare-dest option which enables specifying an additional destination
for comparisons when syncing. Useful for syncing into a scratch area and
doing a flash-cutover when it is completed.
Andrew Tridgell [Thu, 27 Aug 1998 05:07:52 +0000 (05:07 +0000)]
removed the limit on the read buffer size until I fully understand the
interactions with ssh. The old ssh freezes have shown up again and
some debugging (with help from James Welborn) showed that the cause
was the read buffer hitting maximum size. I think this means that ssh
must be misbehaving about blocking IO.
This change gets rid of the freezes at the expense of memory
usage. Where it would have frozen it uses more memory instead.
Andrew Tridgell [Mon, 20 Jul 1998 05:36:25 +0000 (05:36 +0000)]
I think I might havefinally fixed the rsync hanging bug. It was caused
by a read during an io_flush() triggered during a readfd(). A simple
logic bug in the io code :(
Andrew Tridgell [Sun, 19 Jul 1998 05:22:05 +0000 (05:22 +0000)]
- defer the error message from the options parsing until after the
socket is multiplexed. This allows clients sending new options which
the remote server doesn't understand to get a sensible error message.
Andrew Tridgell [Sun, 19 Jul 1998 04:50:48 +0000 (04:50 +0000)]
- close stdout and stderr and reopen then as /dev/null when running as
a daemon. This prevents library functions (such as getopt) stuffing up
our protocol stream when errors are detected.
- defer the error message from the options parsing until after the
socket is multiplexed. This allows clients sending new options which
the remote server doesn't understand to get a sensible error message.
Andrew Tridgell [Fri, 17 Jul 1998 14:05:57 +0000 (14:05 +0000)]
check whether there is a / before a : in the rsync command line. If
there is then assume that the : is from a filename, not a host:dir
separator. This allows you to copy files with a : in them. (suggestion
from pfeifer@wait.de)
Andrew Tridgell [Fri, 17 Jul 1998 13:18:32 +0000 (13:18 +0000)]
make rsync behave more like GNU cp with regard to file permissions
when -p (preserve permissions) isn't set.
It works by taking the sending file permissions and masking them with
the umask to create the destination file permissions. (There is really
no "correct" way of doing this but at least we now behave like GNU cp
which fits the principle of least surprise.)
Andrew Tridgell [Thu, 2 Jul 1998 10:57:20 +0000 (10:57 +0000)]
- use explicit flushes instead of setlinebuf. I've had reports of
verbose info not being line buffered to files.
- add a call to localtime() in open_log() in order to prime the C
libraries timezone cache before the chroot(). This should fix the
problem of rsyncd log entries being in GMT time.
Andrew Tridgell [Thu, 2 Jul 1998 01:27:14 +0000 (01:27 +0000)]
enable output buffering in the recv generator. This makes a
significant difference when the transport is ssh as ssh will otherwise
output a complete frame for each checksum record, which increases the
checksum data in size by a factor of around 4.
Andrew Tridgell [Wed, 1 Jul 1998 11:03:50 +0000 (11:03 +0000)]
- only keep a partial file if some literal data has been transferred,
this prevents a second interrupted transfer from reducing the size of
the transferred file.
- set SIGUSR1 to SIG_IGN early to prevent a race condition that
prevents the --partial code from working properly
Andrew Tridgell [Fri, 19 Jun 1998 00:55:19 +0000 (00:55 +0000)]
if we get EWOULDBLOCK on a write then reduce the amount of data we are
trying to write. This guarantees that the maximum amount of data that
can be written at any one time is written.
Andrew Tridgell [Thu, 18 Jun 1998 12:17:23 +0000 (12:17 +0000)]
fixed a race condition in rsync that opened a security hole. The
temporary files were being created with the same permissions as the
original file. So if the file was setuid but not owned by the user
doing the transfer then there was a window of opportunity for a
malicious user to execute it with the wrong permissions while it was
being transferred.
Andrew Tridgell [Wed, 3 Jun 1998 02:47:52 +0000 (02:47 +0000)]
the tag table should be of type int* not tag*.
This bug resulted in rsync being much less efficient that it could be
for files with more than 64k blocks. With the adaptive block size code
giving a maximum block size of 16k this means that files larger than
1GB were handled very inefficiently. The transfer was still accurate,
just slow.
Andrew Tridgell [Mon, 1 Jun 1998 13:39:54 +0000 (13:39 +0000)]
replace calls to strcmp() with a u_strcmp() function that uses only
unsigned comparisons. Transferring files between two machines that
treated strcmp() differently led to the files being given the wrong
name at the destination if the filenames had characters > 128 (such as
Kanji characters) and the source and destination machines treated
strcmp() differently (ie. one treated strings as signed and the other
as unsigned).
We now treat all string comparisons for file list sorting as unsigned.