]> git.ipfire.org Git - thirdparty/shairport-sync.git/log
thirdparty/shairport-sync.git
7 years agoFurther adjustments to the silence thread -- make the sleep time 30 ms, thus if the...
Mike Brady [Mon, 17 Dec 2018 17:11:46 +0000 (17:11 +0000)] 
Further adjustments to the silence thread -- make the sleep time 30 ms, thus if the queue goes below 60 ms of samples, silence will be inserted unless an audio write occurred within the last 30 ms.

7 years agoadjust minimum interval between last audio write and writing silence.
Mike Brady [Mon, 17 Dec 2018 16:50:36 +0000 (16:50 +0000)] 
adjust minimum interval between last audio write and writing silence.

7 years agoNeed to use an untimed play for the silence buffer filler.
Mike Brady [Mon, 17 Dec 2018 16:44:19 +0000 (16:44 +0000)] 
Need to use an untimed play for the silence buffer filler.

7 years agoDon't send silence into the alsa device within the scanner's sleep time of the last...
Mike Brady [Mon, 17 Dec 2018 16:31:03 +0000 (16:31 +0000)] 
Don't send silence into the alsa device within the scanner's sleep time of the last legitimate write to it. This is to stop the scanner inserting silent frames while the player is flushing fames.

7 years agoDon't add dither if volume control is set to max.
Mike Brady [Mon, 17 Dec 2018 13:14:40 +0000 (13:14 +0000)] 
Don't add dither if volume control is set to max.

7 years agouse dither if using software mixer (i.e. no hardware mixer and not ignoring the volum...
Mike Brady [Mon, 17 Dec 2018 11:31:28 +0000 (11:31 +0000)] 
use dither if using software mixer (i.e. no hardware mixer and not ignoring the volume control) -- fix a mistake in accounting for the ignore_volume_control setting.

7 years agouse dither if using software mixer (i.e. no hardware mixer and not ignoring the volum...
Mike Brady [Mon, 17 Dec 2018 11:30:23 +0000 (11:30 +0000)] 
use dither if using software mixer (i.e. no hardware mixer and not ignoring the volume control) -- fix a mistake in accounting for the ignore_volume_control setting.

7 years agoUpdate RELEASENOTES.md
Mike Brady [Sat, 15 Dec 2018 17:50:01 +0000 (17:50 +0000)] 
Update RELEASENOTES.md

7 years agoMove the keep_dac_busy in to a configuration setting. Always start the keep_dac_busy...
Mike Brady [Sat, 15 Dec 2018 15:36:44 +0000 (15:36 +0000)] 
Move the keep_dac_busy in to a configuration setting. Always start the keep_dac_busy thread and check if the keep_dac_busy is set. Don't dither is ignore volume control is set.

7 years agoUpdate RELEASENOTES.md
Mike Brady [Fri, 14 Dec 2018 16:10:09 +0000 (16:10 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Fri, 14 Dec 2018 16:07:50 +0000 (16:07 +0000)] 
Update RELEASENOTES.md

7 years agoBring in the "disable_standby_mode" feature on alsa to stop some DACs making popping...
Mike Brady [Fri, 14 Dec 2018 15:28:32 +0000 (15:28 +0000)] 
Bring in the "disable_standby_mode" feature on alsa to stop some DACs making popping noises. Fix dither generation.

7 years agoFix dither, add dither to silences during lead-in, interpolatied frames and keeping...
Mike Brady [Fri, 14 Dec 2018 15:07:38 +0000 (15:07 +0000)] 
Fix dither, add dither to silences during lead-in, interpolatied frames and keeping out of standby, only if the output device doesn't use a mixer. Check configuration at initialisation.

7 years agoFix dither, add dither to silences during lead-in, interpolatied frames and keeping...
Mike Brady [Fri, 14 Dec 2018 15:07:00 +0000 (15:07 +0000)] 
Fix dither, add dither to silences during lead-in, interpolatied frames and keeping out of standby, only if the output device doesn't use a mixer. Check configuration at initialisation.

7 years agoDon't drop the audio during a flush -- it creates a clunk.
Mike Brady [Thu, 13 Dec 2018 16:59:18 +0000 (16:59 +0000)] 
Don't drop the audio during a flush -- it creates a clunk.

7 years agoUpdate shairport-sync.conf
Mike Brady [Thu, 13 Dec 2018 15:42:51 +0000 (15:42 +0000)] 
Update shairport-sync.conf

7 years agoExperimentally, add the ability to prevent the DAC making popping noises by feeding...
Mike Brady [Thu, 13 Dec 2018 14:48:21 +0000 (14:48 +0000)] 
Experimentally, add the ability to prevent the DAC making popping noises by feeding it with silence instead of allowing it to stop.

7 years agoExperimentally, add the ability to prevent the DAC making popping noises by feeding...
Mike Brady [Thu, 13 Dec 2018 14:47:52 +0000 (14:47 +0000)] 
Experimentally, add the ability to prevent the DAC making popping noises by feeding it with silence instead of allowing it to stop.

7 years agoUpdate RELEASENOTES.md
Mike Brady [Wed, 12 Dec 2018 22:21:40 +0000 (22:21 +0000)] 
Update RELEASENOTES.md

7 years agoRemove connection with common.h -- works properly.
Mike Brady [Wed, 12 Dec 2018 22:07:55 +0000 (22:07 +0000)] 
Remove connection with common.h -- works properly.

7 years agoFix a compilation error w.r.t. debuglev and fix a complation warning.
Mike Brady [Wed, 12 Dec 2018 21:46:59 +0000 (21:46 +0000)] 
Fix a compilation error w.r.t. debuglev and fix a complation warning.

7 years agoFix a compilation error w.r.t. debuglev and fix a complation warning.
Mike Brady [Wed, 12 Dec 2018 21:21:54 +0000 (21:21 +0000)] 
Fix a compilation error w.r.t. debuglev and fix a complation warning.

7 years agoUpdate RELEASENOTES.md
Mike Brady [Wed, 12 Dec 2018 14:50:25 +0000 (14:50 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Wed, 12 Dec 2018 14:49:37 +0000 (14:49 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate INSTALL.md
Mike Brady [Tue, 11 Dec 2018 20:45:27 +0000 (20:45 +0000)] 
Update INSTALL.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Tue, 11 Dec 2018 17:07:16 +0000 (17:07 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Tue, 11 Dec 2018 17:05:12 +0000 (17:05 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Tue, 11 Dec 2018 16:42:55 +0000 (16:42 +0000)] 
Update RELEASENOTES.md

7 years agoStay with the standard delay call for the present time.
Mike Brady [Tue, 11 Dec 2018 16:25:53 +0000 (16:25 +0000)] 
Stay with the standard delay call for the present time.

7 years agoCleaned up unfixable errors code and examples, updated configuration settings.
Mike Brady [Tue, 11 Dec 2018 11:28:08 +0000 (11:28 +0000)] 
Cleaned up unfixable errors code and examples, updated configuration settings.

7 years agoFurther debug tidy-ups and update the configuration file.
Mike Brady [Tue, 11 Dec 2018 11:26:39 +0000 (11:26 +0000)] 
Further debug tidy-ups and update the configuration file.

7 years agoTidy up some debug messages and warnings, remove old diagnostic codes and settings.
Mike Brady [Tue, 11 Dec 2018 10:56:36 +0000 (10:56 +0000)] 
Tidy up some debug messages and warnings, remove old diagnostic codes and settings.

7 years agoConnect up the stall response to the external command calling -- add a single argumen...
Mike Brady [Mon, 10 Dec 2018 22:28:52 +0000 (22:28 +0000)] 
Connect up the stall response to the external command calling -- add a single argument to the unfixable error call.

7 years agoSet stall threshold to 200 ms.
Mike Brady [Mon, 10 Dec 2018 12:38:48 +0000 (12:38 +0000)] 
Set stall threshold to 200 ms.

7 years agoAdd stall detection to the alsa subsystem.
Mike Brady [Mon, 10 Dec 2018 10:50:08 +0000 (10:50 +0000)] 
Add stall detection to the alsa subsystem.

7 years agoadd delay to debug output.
Mike Brady [Sun, 9 Dec 2018 08:58:47 +0000 (08:58 +0000)] 
add delay to debug output.

7 years agoGet timings of play / flush / delay calls.
Mike Brady [Sun, 9 Dec 2018 08:45:10 +0000 (08:45 +0000)] 
Get timings of play / flush / delay calls.

7 years agoTime opening of the device
Mike Brady [Sat, 8 Dec 2018 22:30:34 +0000 (22:30 +0000)] 
Time opening of the device

7 years agoInitial shot at tidying up the avahi monitoring for DACP Id port information to make...
Mike Brady [Sat, 8 Dec 2018 21:55:49 +0000 (21:55 +0000)] 
Initial shot at tidying up the avahi monitoring for DACP Id port information to make it survive abnormal temrination of play sessions.

7 years agoFix small error in uncancellable sleep -- it was calling itself!
Mike Brady [Sat, 8 Dec 2018 17:48:47 +0000 (17:48 +0000)] 
Fix small error in uncancellable sleep -- it was calling itself!

7 years agoFix RTSP timeout and add timing checks for interfacing with the ALSA subsystem. Add...
Mike Brady [Sat, 8 Dec 2018 14:37:36 +0000 (14:37 +0000)] 
Fix RTSP timeout and add timing checks for interfacing with the ALSA subsystem. Add entries to the configuration file.

7 years agoSmall changes in unstable.
Mike Brady [Sat, 8 Dec 2018 14:26:08 +0000 (14:26 +0000)] 
Small changes in unstable.

Merge branch 'unstable' into development

7 years agoMake the idle timeout on the RTSP link the same as the overall timeout -- 30 seconds...
Mike Brady [Sat, 8 Dec 2018 14:13:04 +0000 (14:13 +0000)] 
Make the idle timeout on the RTSP link the same as the overall timeout -- 30 seconds is a bit short. Add checks to the alsa interface timing -- 15 ms to write a packet of frames, 1 ms to ask for the delay.

7 years agoMake the idle timeout on the RTSP link the same as the overall timeout -- 30 seconds...
Mike Brady [Sat, 8 Dec 2018 14:12:33 +0000 (14:12 +0000)] 
Make the idle timeout on the RTSP link the same as the overall timeout -- 30 seconds is a bit short. Add checks to the alsa interface timing -- 15 ms to write a packet of frames, 1 ms to ask for the delay.

7 years agoAdd timing to writing to the DAC
Mike Brady [Sat, 8 Dec 2018 12:58:01 +0000 (12:58 +0000)] 
Add timing to writing to the DAC

7 years agoUpdate RELEASENOTES.md
Mike Brady [Fri, 7 Dec 2018 12:38:12 +0000 (12:38 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Fri, 7 Dec 2018 12:28:20 +0000 (12:28 +0000)] 
Update RELEASENOTES.md

7 years agoUpdate RELEASENOTES.md
Mike Brady [Fri, 7 Dec 2018 12:25:50 +0000 (12:25 +0000)] 
Update RELEASENOTES.md

7 years agoBring it up to date with what's happened in development.
Mike Brady [Thu, 6 Dec 2018 16:08:39 +0000 (16:08 +0000)] 
Bring it up to date with what's happened in development.
Merge branch 'development' into unstable

7 years agoContinue to use the ordinary snd_pcm_delay call.
Mike Brady [Thu, 6 Dec 2018 15:39:19 +0000 (15:39 +0000)] 
Continue to use the ordinary snd_pcm_delay call.

7 years agoAdd the ability to call a program if an unfixable error is detected. The only unfixia...
Mike Brady [Thu, 6 Dec 2018 14:49:36 +0000 (14:49 +0000)] 
Add the ability to call a program if an unfixable error is detected. The only unfixialbe error at present is then a play session can't be cancelled.

Merge branch 'more_danger' into development

7 years agoThe run_this_if_an_unfixable_error_is_detected script is definitely working and can...
Mike Brady [Thu, 6 Dec 2018 14:46:57 +0000 (14:46 +0000)] 
The run_this_if_an_unfixable_error_is_detected script is definitely working and can restart the device. A sudoers entry is necessary to allow the shairport-sync user to 'sudo reboot --no-wall' without needing a password.

7 years agoEnsure watchdog always starts with the starting time of the thread. Add watchdog...
Mike Brady [Tue, 4 Dec 2018 17:25:40 +0000 (17:25 +0000)] 
Ensure watchdog always starts with the starting time of the thread. Add watchdog bark count. On the third bark, execute an unfixable error script if present.

7 years agoEnsure watchdog always starts with the starting time of the thread. Add watchdog...
Mike Brady [Tue, 4 Dec 2018 17:25:15 +0000 (17:25 +0000)] 
Ensure watchdog always starts with the starting time of the thread. Add watchdog bark count. On the third bark, execute an unfixable error script if present.

7 years agoShorten the delays to 100 ms
Mike Brady [Tue, 4 Dec 2018 08:56:29 +0000 (08:56 +0000)] 
Shorten the delays to 100 ms

7 years agoAdd a 30 second timout on the read function on an RTSP thread.
Mike Brady [Mon, 3 Dec 2018 18:42:49 +0000 (18:42 +0000)] 
Add a 30 second timout on the read function on an RTSP thread.

7 years agoMake the stop requester volatile, duh.
Mike Brady [Mon, 3 Dec 2018 18:01:54 +0000 (18:01 +0000)] 
Make the stop requester volatile, duh.

7 years agoTry to ensure that any alsa command sequences are uncancellable. Leave a little time...
Mike Brady [Mon, 3 Dec 2018 17:00:12 +0000 (17:00 +0000)] 
Try to ensure that any alsa command sequences are uncancellable. Leave a little time afterwards where possible.

7 years agoMake sure that shared watchdog count is correctly updated in the rtsp_conn_info struc...
Mike Brady [Mon, 3 Dec 2018 16:52:32 +0000 (16:52 +0000)] 
Make sure that shared watchdog count is correctly updated in the rtsp_conn_info structure!

7 years agoEnsure no pthread cancellation can occur during an ALSA-related call.
Mike Brady [Mon, 3 Dec 2018 12:44:57 +0000 (12:44 +0000)] 
Ensure no pthread cancellation can occur during an ALSA-related call.

7 years agoFix an error caused by using an unsigned integer as a signed number. It may have...
Mike Brady [Mon, 3 Dec 2018 10:33:29 +0000 (10:33 +0000)] 
Fix an error caused by using an unsigned integer as a signed number. It may have been causing lots of conversation threads to wait for the (blocked) current playing thread to exit.

7 years agoStop using an unsigned integer for time when we want to watch if it goes negative...
Mike Brady [Sun, 2 Dec 2018 18:13:20 +0000 (18:13 +0000)] 
Stop using an unsigned integer for time when we want to watch if it goes negative. Only release the playing_conn if we already own it!

7 years agoMerge branch 'unstable' into development
Mike Brady [Sat, 1 Dec 2018 17:14:36 +0000 (17:14 +0000)] 
Merge branch 'unstable' into development

7 years agoFix a non-initialisation of parameters if no h/w mixer used. Add a few diagnostics...
Mike Brady [Sat, 1 Dec 2018 17:13:20 +0000 (17:13 +0000)] 
Fix a non-initialisation of parameters if no h/w mixer used. Add a few diagnostics, tidy up initial diagnostic message, add verbosity level and whether mixer used.

7 years agoFix a non-initialisation of parameters if no h/w mixer used. Add a few diagnostics...
Mike Brady [Sat, 1 Dec 2018 16:52:23 +0000 (16:52 +0000)] 
Fix a non-initialisation of parameters if no h/w mixer used. Add a few diagnostics, tidy up initial diagnostic message, add verbosity level and whether mixer used.

7 years agoMove UDP port cloure to the RTSP thread, don't allow calls to mdns_* to be cancelled...
Mike Brady [Fri, 30 Nov 2018 14:55:04 +0000 (14:55 +0000)] 
Move UDP port cloure to the RTSP thread, don't allow calls to mdns_* to be cancelled. Remove usage of (p)select in rtsp thread handling.

7 years agoMove closing of ports to the player thread cleanup. They can be bound without the...
Mike Brady [Thu, 29 Nov 2018 22:03:49 +0000 (22:03 +0000)] 
Move closing of ports to the player thread cleanup. They can be bound without the UDP threads ever having been called, so they must be closed when the player thread exits.

7 years agoMove cleanup push to start of RTSP initialisation. Take more care at startup and...
Mike Brady [Thu, 29 Nov 2018 17:14:40 +0000 (17:14 +0000)] 
Move cleanup push to start of RTSP initialisation. Take more care at startup and closedown to make stuff uncancellable.

7 years agoQuieten a debug message
Mike Brady [Thu, 29 Nov 2018 17:13:12 +0000 (17:13 +0000)] 
Quieten a debug message

7 years agoImprove player watchdog, improve clearing down of ports, improve handling of write...
Mike Brady [Thu, 29 Nov 2018 15:36:18 +0000 (15:36 +0000)] 
Improve player watchdog, improve clearing down of ports, improve handling of write- and read-erroes on the RTSP channel. Improve code for holding and releasing the player.

7 years agoAdds checks for posession of the player in order to handle flush, teardown requests.
Mike Brady [Thu, 29 Nov 2018 15:32:06 +0000 (15:32 +0000)] 
Adds checks for posession of the player in order to handle flush, teardown requests.

7 years agoCheck in SETUP and RECORD that the player is available, clean up setup code by removi...
Mike Brady [Thu, 29 Nov 2018 13:13:51 +0000 (13:13 +0000)] 
Check in SETUP and RECORD that the player is available, clean up setup code by removing gotos.

7 years agoQuieten a debug message
Mike Brady [Thu, 29 Nov 2018 13:12:53 +0000 (13:12 +0000)] 
Quieten a debug message

7 years agoClang formatted.
Mike Brady [Thu, 29 Nov 2018 12:18:07 +0000 (12:18 +0000)] 
Clang formatted.

7 years agoAdd an uncancellable usleep timer. Make the player and UDP thread cleanups uncancellable.
Mike Brady [Thu, 29 Nov 2018 11:37:56 +0000 (11:37 +0000)] 
Add an uncancellable usleep timer. Make the player and UDP thread cleanups uncancellable.

7 years agoAdd some debug messages to closing the UDP ports.
Mike Brady [Wed, 28 Nov 2018 19:49:12 +0000 (19:49 +0000)] 
Add some debug messages to closing the UDP ports.

7 years agoAdd SO_REUSEADDR to the UDP sockets. See if it makes any difference.
Mike Brady [Wed, 28 Nov 2018 19:39:11 +0000 (19:39 +0000)] 
Add SO_REUSEADDR to the UDP sockets. See if it makes any difference.

7 years agoMove watchdog to cover connection from start, not just from start of play. Start...
Mike Brady [Wed, 28 Nov 2018 17:18:03 +0000 (17:18 +0000)] 
Move watchdog to cover connection from start, not just from start of play. Start investigating UDP port allocation. Tidy up handling or RTSP write errors -- remove the pselect code from before a write.

7 years agoAdd extra diagnostic to capture a meg_write_response error.
Mike Brady [Tue, 27 Nov 2018 22:53:27 +0000 (22:53 +0000)] 
Add extra diagnostic to capture a meg_write_response error.

7 years agoTry to capture what happens after a write error.
Mike Brady [Tue, 27 Nov 2018 22:03:56 +0000 (22:03 +0000)] 
Try to capture what happens after a write error.

7 years agoQuieten a few debug messages.
Mike Brady [Tue, 27 Nov 2018 17:44:45 +0000 (17:44 +0000)] 
Quieten a few debug messages.

7 years agoQuieten a few debug messages.
Mike Brady [Tue, 27 Nov 2018 17:40:07 +0000 (17:40 +0000)] 
Quieten a few debug messages.

7 years agoAdd new watchdog thread for the player -- should be more reliable than the existing...
Mike Brady [Mon, 26 Nov 2018 19:33:22 +0000 (19:33 +0000)] 
Add new watchdog thread for the player -- should be more reliable than the existing code.

7 years agoAdd many improvements, including reliable interruption using new ports, safer pthread...
Mike Brady [Sat, 24 Nov 2018 22:40:13 +0000 (22:40 +0000)] 
Add many improvements, including reliable interruption using new ports, safer pthread_cancel usage.

7 years agoMake some alsa operation sequences un-cancellable. Make some cleanup sequences un...
Mike Brady [Sat, 24 Nov 2018 22:28:52 +0000 (22:28 +0000)] 
Make some alsa operation sequences un-cancellable. Make some cleanup sequences un-cancellable.

7 years agoChange order of header files (again?) to avoid OpenBSD compilation errors.
Mike Brady [Sat, 24 Nov 2018 11:35:16 +0000 (11:35 +0000)] 
Change order of header files (again?) to avoid OpenBSD compilation errors.

7 years agoUpdate FREEBSD.md
Mike Brady [Sat, 24 Nov 2018 11:30:39 +0000 (11:30 +0000)] 
Update FREEBSD.md

7 years agoclang-format
Mike Brady [Sat, 24 Nov 2018 11:16:57 +0000 (11:16 +0000)] 
clang-format

7 years agoSmall correction to port selection logic. If a new sesion waits for an existing sessi...
Mike Brady [Sat, 24 Nov 2018 11:06:20 +0000 (11:06 +0000)] 
Small correction to port selection logic. If a new sesion waits for an existing session to close that it hasn't interrupted, reset the ports base. Quieten some debug messages.

7 years agoRemove some unnecessary test code from the debug messaging.
Mike Brady [Fri, 23 Nov 2018 16:10:18 +0000 (16:10 +0000)] 
Remove some unnecessary test code from the debug messaging.

7 years agoQuieten a few debug messages.
Mike Brady [Fri, 23 Nov 2018 15:11:04 +0000 (15:11 +0000)] 
Quieten a few debug messages.

7 years agoStop going to verbosity level 3 on occasion. It's not so useful now.
Mike Brady [Fri, 23 Nov 2018 13:57:34 +0000 (13:57 +0000)] 
Stop going to verbosity level 3 on occasion. It's not so useful now.

7 years agoFix bugs in interrupting an existing session, and use fresh ports if necessary.
Mike Brady [Fri, 23 Nov 2018 13:40:42 +0000 (13:40 +0000)] 
Fix bugs in interrupting an existing session, and use fresh ports if necessary.

7 years agoFix off-by-one error in UDP range counting
Mike Brady [Fri, 23 Nov 2018 13:39:23 +0000 (13:39 +0000)] 
Fix off-by-one error in UDP range counting

7 years agoRotate usage of UDP ports if a session is interrupted. Avoids out-of-date packets...
Mike Brady [Fri, 23 Nov 2018 13:29:09 +0000 (13:29 +0000)] 
Rotate usage of UDP ports if a session is interrupted. Avoids out-of-date packets landing in a new session.

7 years agoexperimental
Mike Brady [Fri, 23 Nov 2018 08:53:27 +0000 (08:53 +0000)] 
experimental

7 years agoTry making dropping and closing the DAC un-cancelable to stop the bcm DMA problem...
Mike Brady [Thu, 22 Nov 2018 21:57:54 +0000 (21:57 +0000)] 
Try making dropping and closing the DAC un-cancelable to stop the bcm DMA problem. Add some diagnostics.

7 years agoUpdate shairport-sync.conf
Mike Brady [Thu, 22 Nov 2018 10:08:00 +0000 (10:08 +0000)] 
Update shairport-sync.conf

7 years agoUpdate with changes in the development branch
Mike Brady [Thu, 22 Nov 2018 09:51:04 +0000 (09:51 +0000)] 
Update with changes in the development branch

7 years agoAdd back in the ability to interrupt a session. Clean up a few debug messages.
Mike Brady [Wed, 21 Nov 2018 21:33:21 +0000 (21:33 +0000)] 
Add back in the ability to interrupt a session. Clean up a few debug messages.