]> git.ipfire.org Git - thirdparty/xz.git/log
thirdparty/xz.git
2 years agoAdd ifunc check to configure.ac
Hans Jansen [Thu, 22 Jun 2023 17:46:55 +0000 (19:46 +0200)] 
Add ifunc check to configure.ac

configure.ac will now verify if __attribute__((__ifunc__())) can be used in
the build system. If so, HAVE_FUNC_ATTRIBUTE_IFUNC will be defined to 1.

3 years agoCI: Add apt update command before installing dependencies.
Jia Tan [Tue, 6 Jun 2023 16:18:30 +0000 (00:18 +0800)] 
CI: Add apt update command before installing dependencies.

Without the extra command, all of the CI tests were automatically
failing because the Ubuntu servers could not be reached properly.

3 years agoUpdate THANKS.
Jia Tan [Tue, 6 Jun 2023 16:10:38 +0000 (00:10 +0800)] 
Update THANKS.

3 years agoCMake: Protects against double find_package
Benjamin Buch [Tue, 6 Jun 2023 13:32:45 +0000 (15:32 +0200)] 
CMake: Protects against double find_package

Boost iostream uses `find_package` in quiet mode and then again uses
`find_package` with required. This second call triggers a
`add_library cannot create imported target "ZLIB::ZLIB" because another
target with the same name already exists.`

This can simply be fixed by skipping the alias part on secondary
`find_package` runs.

3 years agoTranslations: Update the Esperanto translation.
Jia Tan [Wed, 31 May 2023 12:26:42 +0000 (20:26 +0800)] 
Translations: Update the Esperanto translation.

3 years agoTranslations: Update the Croatian translation.
Jia Tan [Wed, 31 May 2023 12:25:00 +0000 (20:25 +0800)] 
Translations: Update the Croatian translation.

3 years agoTranslations: Update the Chinese (simplified) translation.
Jia Tan [Wed, 31 May 2023 12:15:53 +0000 (20:15 +0800)] 
Translations: Update the Chinese (simplified) translation.

3 years agoTranslations: Update German translation of man pages.
Jia Tan [Wed, 17 May 2023 15:12:13 +0000 (23:12 +0800)] 
Translations: Update German translation of man pages.

3 years agoTranslations: Update the German translation.
Jia Tan [Wed, 17 May 2023 15:09:18 +0000 (23:09 +0800)] 
Translations: Update the German translation.

3 years agoTranslations: Update the Croatian translation.
Jia Tan [Wed, 17 May 2023 12:30:01 +0000 (20:30 +0800)] 
Translations: Update the Croatian translation.

3 years agoTranslations: Update Korean translation of man pages.
Jia Tan [Wed, 17 May 2023 12:26:54 +0000 (20:26 +0800)] 
Translations: Update Korean translation of man pages.

3 years agoTranslations: Update the Korean translation.
Jia Tan [Wed, 17 May 2023 12:13:01 +0000 (20:13 +0800)] 
Translations: Update the Korean translation.

3 years agoTranslations: Update the Spanish translation.
Jia Tan [Tue, 16 May 2023 15:49:09 +0000 (23:49 +0800)] 
Translations: Update the Spanish translation.

3 years agoTranslations: Update the Romanian translation.
Jia Tan [Tue, 16 May 2023 15:47:23 +0000 (23:47 +0800)] 
Translations: Update the Romanian translation.

3 years agoTranslations: Update Romanian translation of man pages.
Jia Tan [Tue, 16 May 2023 15:45:43 +0000 (23:45 +0800)] 
Translations: Update Romanian translation of man pages.

3 years agoTranslations: Update Ukrainian translation of man pages.
Jia Tan [Tue, 16 May 2023 15:43:51 +0000 (23:43 +0800)] 
Translations: Update Ukrainian translation of man pages.

3 years agoTranslations: Update the Ukrainian translation.
Jia Tan [Tue, 16 May 2023 15:37:54 +0000 (23:37 +0800)] 
Translations: Update the Ukrainian translation.

3 years agoTranslations: Update the Polish translation.
Jia Tan [Tue, 16 May 2023 15:07:35 +0000 (23:07 +0800)] 
Translations: Update the Polish translation.

3 years agoTranslations: Update the Swedish translation.
Jia Tan [Tue, 16 May 2023 14:52:14 +0000 (22:52 +0800)] 
Translations: Update the Swedish translation.

3 years agoTranslations: Update the Esperanto translation.
Jia Tan [Tue, 16 May 2023 13:21:38 +0000 (21:21 +0800)] 
Translations: Update the Esperanto translation.

3 years agoliblzma: Slightly rewords lzma_str_list_filters() documentation.
Jia Tan [Sat, 13 May 2023 13:21:54 +0000 (21:21 +0800)] 
liblzma: Slightly rewords lzma_str_list_filters() documentation.

Reword "options required" to "supported options". The previous may have
suggested that the options listed were all required anytime a filter is
used for encoding or decoding. The reword makes this more clear that
adjusting the options is optional.

3 years agoliblzma: Adds lzma_nothrow to MicroLZMA API functions.
Jia Tan [Thu, 11 May 2023 15:49:23 +0000 (23:49 +0800)] 
liblzma: Adds lzma_nothrow to MicroLZMA API functions.

None of the liblzma functions may throw an exception, so this
attribute should be applied to all liblzma API functions.

3 years agoliblzma: Exports lzma_mt_block_size() as an API function.
Jia Tan [Tue, 9 May 2023 12:20:06 +0000 (20:20 +0800)] 
liblzma: Exports lzma_mt_block_size() as an API function.

The lzma_mt_block_size() was previously just an internal function for
the multithreaded .xz encoder. It is used to provide a recommended Block
size for a given filter chain.

This function is helpful to determine the maximum Block size for the
multithreaded .xz encoder when one wants to change the filters between
blocks. Then, this determined Block size can be provided to
lzma_stream_encoder_mt() in the lzma_mt options parameter when
intializing the coder. This requires one to know all the filter chains
they are using before starting to encode (or at least the filter chain
that will need the largest Block size), but that isn't a bad limitation.

3 years agoliblzma: Creates IS_ENC_DICT_SIZE_VALID() macro.
Jia Tan [Mon, 8 May 2023 14:58:09 +0000 (22:58 +0800)] 
liblzma: Creates IS_ENC_DICT_SIZE_VALID() macro.

This creates an internal liblzma macro to test if the dictionary size
is valid for encoding.

3 years agoAdd NEWS for 5.4.3.
Jia Tan [Tue, 2 May 2023 12:39:56 +0000 (20:39 +0800)] 
Add NEWS for 5.4.3.

3 years agoAdd NEWS for 5.2.12.
Jia Tan [Tue, 2 May 2023 12:39:37 +0000 (20:39 +0800)] 
Add NEWS for 5.2.12.

3 years agoTranslations: Update the Croatian translation.
Jia Tan [Thu, 4 May 2023 12:38:52 +0000 (20:38 +0800)] 
Translations: Update the Croatian translation.

3 years agotuklib_integer.h: Reverts previous commit.
Jia Tan [Thu, 4 May 2023 12:30:25 +0000 (20:30 +0800)] 
tuklib_integer.h: Reverts previous commit.

Previous commit 6be460dde07113fe3f08f814b61ddc3264125a96 would cause an
error if the integer size was 32 bit.

3 years agotuklib_integer.h: Changes two other UINT_MAX == UINT32_MAX to >=.
Jia Tan [Thu, 4 May 2023 11:25:20 +0000 (19:25 +0800)] 
tuklib_integer.h: Changes two other UINT_MAX == UINT32_MAX to >=.

3 years agotuklib_integer.h: Fix a recent copypaste error in Clang detection.
Lasse Collin [Wed, 3 May 2023 19:46:42 +0000 (22:46 +0300)] 
tuklib_integer.h: Fix a recent copypaste error in Clang detection.

Wrong line was changed in 7062348bf35c1e4cbfee00ad9fffb4a21aa6eff7.
Also, this has >= instead of == since ints larger than 32 bits would
work too even if not relevant in practice.

3 years agoCI: Adds a build and test for small configuration.
Jia Tan [Tue, 25 Apr 2023 12:06:15 +0000 (20:06 +0800)] 
CI: Adds a build and test for small configuration.

3 years agoCI: ci_build.sh allows configuring small build.
Jia Tan [Tue, 25 Apr 2023 12:05:26 +0000 (20:05 +0800)] 
CI: ci_build.sh allows configuring small build.

3 years agoUpdate THANKS.
Jia Tan [Thu, 20 Apr 2023 12:15:00 +0000 (20:15 +0800)] 
Update THANKS.

3 years agoWindows: Include <intrin.h> when needed.
Jia Tan [Wed, 19 Apr 2023 14:22:16 +0000 (22:22 +0800)] 
Windows: Include <intrin.h> when needed.

Legacy Windows did not need to #include <intrin.h> to use the MSVC
intrinsics. Newer versions likely just issue a warning, but the MSVC
documentation says to include the header file for the intrinsics we use.

GCC and Clang can "pretend" to be MSVC on Windows, so extra checks are
needed in tuklib_integer.h to only include <intrin.h> when it will is
actually needed.

3 years agotuklib_integer: Use __builtin_clz() with Clang.
Jia Tan [Wed, 19 Apr 2023 13:59:03 +0000 (21:59 +0800)] 
tuklib_integer: Use __builtin_clz() with Clang.

Clang has support for __builtin_clz(), but previously Clang would
fallback to either the MSVC intrinsic or the regular C code. This was
discovered due to a bug where a new version of Clang required the
<intrin.h> header file in order to use the MSVC intrinsics.

Thanks to Anton Kochkov for notifying us about the bug.

3 years agoliblzma: Update project maintainers in lzma.h.
Lasse Collin [Fri, 14 Apr 2023 15:42:33 +0000 (18:42 +0300)] 
liblzma: Update project maintainers in lzma.h.

AUTHORS was updated earlier, lzma.h was simply forgotten.

3 years agoliblzma: Cleans up old commented out code.
Jia Tan [Thu, 13 Apr 2023 12:45:19 +0000 (20:45 +0800)] 
liblzma: Cleans up old commented out code.

3 years agoDocs: Add missing word to SECURITY.md.
Jia Tan [Fri, 7 Apr 2023 12:46:41 +0000 (20:46 +0800)] 
Docs: Add missing word to SECURITY.md.

3 years agoUpdate THANKS.
Jia Tan [Fri, 7 Apr 2023 12:43:22 +0000 (20:43 +0800)] 
Update THANKS.

3 years agoDocs: Minor edits to SECURITY.md.
Jia Tan [Fri, 7 Apr 2023 12:42:12 +0000 (20:42 +0800)] 
Docs: Minor edits to SECURITY.md.

3 years agoDocs: Create SECURITY.md
Gabriela Gutierrez [Fri, 7 Apr 2023 12:08:30 +0000 (12:08 +0000)] 
Docs: Create SECURITY.md

Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
3 years agoCI: Tests for disabling threading on CMake builds.
Jia Tan [Tue, 28 Mar 2023 14:48:24 +0000 (22:48 +0800)] 
CI: Tests for disabling threading on CMake builds.

3 years agoCI: Removes CMakeCache.txt between builds.
Jia Tan [Tue, 28 Mar 2023 14:45:42 +0000 (22:45 +0800)] 
CI: Removes CMakeCache.txt between builds.

If the cache file is not removed, CMake will not reset configurations
back to their default values. In order to make the tests independent, it
is simplest to purge the cache. Unfortunatly, this will slow down the
tests a little and repeat some checks.

3 years agoCMake: Update liblzma-config.cmake generation.
Jia Tan [Tue, 28 Mar 2023 14:32:40 +0000 (22:32 +0800)] 
CMake: Update liblzma-config.cmake generation.

Now that the threading is configurable, the liblzma CMake package only
needs the threading library when using POSIX threads.

3 years agoCMake: Allows setting thread method.
Jia Tan [Tue, 28 Mar 2023 14:25:33 +0000 (22:25 +0800)] 
CMake: Allows setting thread method.

The thread method is now configurable for the CMake build. It matches
the Autotools build by allowing ON (pick the best threading method),
OFF (no threading), posix, win95, and vista. If both Windows and
posix threading are both available, then ON will choose Windows
threading. Windows threading will also not use:

target_link_libraries(liblzma Threads::Threads)

since on systems like MinGW-w64 it would link the posix threads
without purpose.

3 years agoCI: Runs CMake feature tests.
Jia Tan [Fri, 24 Mar 2023 15:05:48 +0000 (23:05 +0800)] 
CI: Runs CMake feature tests.

Now, CMake will run similar feature disable tests that the Autotools
version did before. In order to do this without repeating lines in
ci.yml, it now makes sense to use the GitHub Workflow matrix to create
a loop.

3 years agoCI: ci_build.sh allows CMake features to be configured.
Jia Tan [Fri, 24 Mar 2023 12:35:11 +0000 (20:35 +0800)] 
CI: ci_build.sh allows CMake features to be configured.

Also included various clean ups for style and helper functions for
repeated work.

3 years agoCI: Change ci_build.sh to use bash instead of sh.
Jia Tan [Fri, 24 Mar 2023 12:06:33 +0000 (20:06 +0800)] 
CI: Change ci_build.sh to use bash instead of sh.

This script is only meant to be run as part of the CI build/test process
on machines that are known to have bash (Ubuntu and MacOS). If this
assumption changes in the future, then the bash specific commands will
need to be replaced with a more portable option. For now, it is
convenient to use bash commands.

3 years agoCMake: Only build xzdec if decoders are enabled.
Jia Tan [Fri, 24 Mar 2023 12:05:59 +0000 (20:05 +0800)] 
CMake: Only build xzdec if decoders are enabled.

3 years agoBuild: Removes redundant check for LZMA1 filter support.
Jia Tan [Wed, 22 Mar 2023 07:42:04 +0000 (15:42 +0800)] 
Build: Removes redundant check for LZMA1 filter support.

3 years agoCMake: Bump maximum policy version to 3.26.
Lasse Collin [Thu, 23 Mar 2023 13:14:29 +0000 (15:14 +0200)] 
CMake: Bump maximum policy version to 3.26.

It adds only one new policy related to FOLDERS which we don't use.
This makes it clear that the code is compatible with the policies
up to 3.26.

3 years agoCMake: Conditionally build xz list.* files if decoders are enabled.
Jia Tan [Tue, 21 Mar 2023 15:36:00 +0000 (23:36 +0800)] 
CMake: Conditionally build xz list.* files if decoders are enabled.

3 years agoCMake: Allow configuring features as cache variables.
Jia Tan [Sat, 25 Feb 2023 03:46:50 +0000 (11:46 +0800)] 
CMake: Allow configuring features as cache variables.

This allows users to change the features they build either in
CMakeCache.txt or by using a CMake GUI. The sources built for
liblzma are affected by this too, so only the necessary files
will be compiled.

3 years agoBuild: Add a comment that AC_PROG_CC_C99 is needed for Autoconf 2.69.
Lasse Collin [Tue, 21 Mar 2023 12:07:51 +0000 (14:07 +0200)] 
Build: Add a comment that AC_PROG_CC_C99 is needed for Autoconf 2.69.

It's obsolete in Autoconf >= 2.70 and just an alias for AC_PROG_CC
but Autoconf 2.69 requires AC_PROG_CC_C99 to get a C99 compiler.

3 years agoBuild: configure.ac: Use AS_IF and AS_CASE where required.
Lasse Collin [Tue, 21 Mar 2023 12:04:37 +0000 (14:04 +0200)] 
Build: configure.ac: Use AS_IF and AS_CASE where required.

This makes no functional difference in the generated configure
(at least with the Autotools versions I have installed) but this
change might prevent future bugs like the one that was just
fixed in the commit 5a5bd7f871818029d5ccbe189f087f591258c294.

3 years agoUpdate THANKS.
Lasse Collin [Tue, 21 Mar 2023 11:12:03 +0000 (13:12 +0200)] 
Update THANKS.

3 years agoBuild: Fix --disable-threads breaking the building of shared libs.
Lasse Collin [Tue, 21 Mar 2023 11:11:49 +0000 (13:11 +0200)] 
Build: Fix --disable-threads breaking the building of shared libs.

This is broken in the releases 5.2.6 to 5.4.2. A workaround
for these releases is to pass EGREP='grep -E' as an argument
to configure in addition to --disable-threads.

The problem appeared when m4/ax_pthread.m4 was updated in
the commit 6629ed929cc7d45a11e385f357ab58ec15e7e4ad which
introduced the use of AC_EGREP_CPP. AC_EGREP_CPP calls
AC_REQUIRE([AC_PROG_EGREP]) to set the shell variable EGREP
but this was only executed if POSIX threads were enabled.
Libtool code also has AC_REQUIRE([AC_PROG_EGREP]) but Autoconf
omits it as AC_PROG_EGREP has already been required earlier.
Thus, if not using POSIX threads, the shell variable EGREP
would be undefined in the Libtool code in configure.

ax_pthread.m4 is fine. The bug was in configure.ac which called
AX_PTHREAD conditionally in an incorrect way. Using AS_CASE
ensures that all AC_REQUIREs get always run.

Thanks to Frank Busse for reporting the bug.
Fixes: https://github.com/tukaani-project/xz/issues/45
3 years agoliblzma: Silence -Wsign-conversion in SSE2 code in memcmplen.h.
Lasse Collin [Sun, 19 Mar 2023 20:45:59 +0000 (22:45 +0200)] 
liblzma: Silence -Wsign-conversion in SSE2 code in memcmplen.h.

Thanks to Christian Hesse for reporting the issue.
Fixes: https://github.com/tukaani-project/xz/issues/44
3 years agoAdd NEWS for 5.4.2.
Jia Tan [Sat, 18 Mar 2023 14:10:57 +0000 (22:10 +0800)] 
Add NEWS for 5.4.2.

3 years agoAdd NEWS for 5.2.11.
Jia Tan [Sat, 18 Mar 2023 14:10:12 +0000 (22:10 +0800)] 
Add NEWS for 5.2.11.

3 years agoUpdate the copy of GNU GPLv3 from gnu.org to COPYING.GPLv3.
Lasse Collin [Sat, 18 Mar 2023 14:00:54 +0000 (16:00 +0200)] 
Update the copy of GNU GPLv3 from gnu.org to COPYING.GPLv3.

3 years agoChange a few HTTP URLs to HTTPS.
Lasse Collin [Sat, 18 Mar 2023 13:51:57 +0000 (15:51 +0200)] 
Change a few HTTP URLs to HTTPS.

The xz man page timestamp was intentionally left unchanged.

3 years agoCMake: Fix typo in a comment.
Jia Tan [Fri, 17 Mar 2023 16:40:28 +0000 (00:40 +0800)] 
CMake: Fix typo in a comment.

3 years agoWindows: build.bash: Copy liblzma API docs to the output package.
Lasse Collin [Fri, 17 Mar 2023 16:36:22 +0000 (18:36 +0200)] 
Windows: build.bash: Copy liblzma API docs to the output package.

3 years agoWindows: Add microlzma_*.c to the VS project files.
Lasse Collin [Fri, 17 Mar 2023 06:53:38 +0000 (08:53 +0200)] 
Windows: Add microlzma_*.c to the VS project files.

These should have been included in 5.3.2alpha already.

3 years agoCMake: Add microlzma_*.c to the build.
Lasse Collin [Fri, 17 Mar 2023 06:43:51 +0000 (08:43 +0200)] 
CMake: Add microlzma_*.c to the build.

These should have been included in 5.3.2alpha already.

3 years agoBuild: Update comments about unaligned access to mention 64-bit.
Lasse Collin [Fri, 17 Mar 2023 06:41:36 +0000 (08:41 +0200)] 
Build: Update comments about unaligned access to mention 64-bit.

3 years agoTests: Update .gitignore.
Lasse Collin [Thu, 16 Mar 2023 22:02:30 +0000 (00:02 +0200)] 
Tests: Update .gitignore.

3 years agopo4a/update-po: Display the script name consistently in error messages.
Lasse Collin [Tue, 14 Mar 2023 18:04:03 +0000 (20:04 +0200)] 
po4a/update-po: Display the script name consistently in error messages.

3 years agoDoc: Rename Doxygen HTML doc directory name liblzma => api.
Jia Tan [Thu, 16 Mar 2023 17:30:36 +0000 (01:30 +0800)] 
Doc: Rename Doxygen HTML doc directory name liblzma => api.

When the docs are installed, calling the directory "liblzma" is
confusing since multiple other files in the doc directory are for
liblzma. This should also make it more natural for distros when they
package the documentation.

3 years agoliblzma: Remove note from lzma_options_bcj about the ARM64 exception.
Jia Tan [Thu, 16 Mar 2023 14:07:15 +0000 (22:07 +0800)] 
liblzma: Remove note from lzma_options_bcj about the ARM64 exception.

This was left in by mistake since an early version of the ARM64 filter
used a different struct for its options.

3 years agoCI: Add doxygen as a dependency.
Jia Tan [Thu, 16 Mar 2023 13:44:02 +0000 (21:44 +0800)] 
CI: Add doxygen as a dependency.

Autogen now requires --no-doxygen or having doxygen installed to run
without errors.

3 years agoCOPYING: Add a note about the included Doxygen-generated HTML.
Lasse Collin [Wed, 15 Mar 2023 17:19:13 +0000 (19:19 +0200)] 
COPYING: Add a note about the included Doxygen-generated HTML.

3 years agoDoc: Update PACKAGERS with details about liblzma API docs install.
Jia Tan [Thu, 16 Mar 2023 13:41:09 +0000 (21:41 +0800)] 
Doc: Update PACKAGERS with details about liblzma API docs install.

3 years agoliblzma: Add set lzma.h as the main page for Doxygen documentation.
Jia Tan [Thu, 16 Mar 2023 13:38:32 +0000 (21:38 +0800)] 
liblzma: Add set lzma.h as the main page for Doxygen documentation.

The \mainpage command is used in the first block of comments in lzma.h.
This changes the previously nearly empty index.html to use the first
comment block in lzma.h for its contents.

lzma.h is no longer documented separately, but this is for the better
since lzma.h only defined a few macros that users do not need to use.
The individual API header files all have a disclaimer that they should
not be #included directly, so there should be no confusion on the fact
that lzma.h should be the only header used by applications.

Additionally, the note "See ../lzma.h for information about liblzma as
a whole." was removed since lzma.h is now the main page of the
generated HTML and does not have its own page anymore. So it would be
confusing in the HTML version and was only a "nice to have" when
browsing the source files.

3 years agoBuild: Generate doxygen documentation in autogen.sh.
Jia Tan [Thu, 16 Mar 2023 13:37:32 +0000 (21:37 +0800)] 
Build: Generate doxygen documentation in autogen.sh.

Another command line option (--no-doxygen) was added to disable
creating the doxygen documenation in cases where it not wanted or
if the doxygen tool is not installed.

3 years agoBuild: Create doxygen/update-doxygen script.
Jia Tan [Thu, 16 Mar 2023 13:35:55 +0000 (21:35 +0800)] 
Build: Create doxygen/update-doxygen script.

This is a helper script to generate the Doxygen documentation. It can be
run in 'liblzma' or 'internal' mode by setting the first argument. It
will default to 'liblzma' mode and only generate documentation for the
liblzma API header files.

The helper script will be run during the custom mydist hook when we
create releases. This hook already alters the source directory, so its
fine to do it here too. This way, we can include the Doxygen generated
files in the distrubtion and when installing.

In 'liblzma' mode, the JavaScript is stripped from the .html files and
the .js files are removed. This avoids license hassle from jQuery and
other libraries that Doxygen 1.9.6 puts into jquery.js in minified form.

3 years agoBuild: Install Doxygen docs and include in distribution if generated.
Jia Tan [Thu, 16 Mar 2023 13:34:36 +0000 (21:34 +0800)] 
Build: Install Doxygen docs and include in distribution if generated.

Added a install-data-local target to install the Doxygen documentation
only when it has been generated. In order to correctly remove the docs,
a corresponding uninstall-local target was added.

If the doxygen docs exist in the source tree, they will also be included
in the distribution now too.

3 years agoDoxygen: Refactor Doxyfile.in to doxygen/Doxyfile.
Lasse Collin [Thu, 16 Mar 2023 13:23:48 +0000 (21:23 +0800)] 
Doxygen: Refactor Doxyfile.in to doxygen/Doxyfile.

Instead of having Doxyfile.in configured by Autoconf, the Doxyfile
can have the tags that need to be configured piped into the doxygen
command through stdin with the overrides after Doxyfile's contents.

Going forward, the documentation should be generated in two different
modes: liblzma or internal.

liblzma is useful for most users. It is the documentation for just
the liblzma API header files. This is the default.

internal is for people who want to understand how xz and liblzma work.
It might be useful for people who want to contribute to the project.

3 years agoTests: Remove unused macros and functions.
Jia Tan [Tue, 28 Feb 2023 15:22:36 +0000 (23:22 +0800)] 
Tests: Remove unused macros and functions.

3 years agoliblzma: Defines masks for return values from lzma_index_checks().
Jia Tan [Thu, 29 Dec 2022 13:52:15 +0000 (21:52 +0800)] 
liblzma: Defines masks for return values from lzma_index_checks().

3 years agoTests: Refactors existing lzma_index tests.
Jia Tan [Thu, 12 Jan 2023 14:29:07 +0000 (22:29 +0800)] 
Tests: Refactors existing lzma_index tests.

Converts the existing lzma_index tests into tuktests and covers every
API function from index.h except for lzma_file_info_decoder, which can
be tested in the future.

3 years agoxz: Simplify the error-label in Capsicum sandbox code.
Lasse Collin [Sat, 11 Mar 2023 16:42:08 +0000 (18:42 +0200)] 
xz: Simplify the error-label in Capsicum sandbox code.

Also remove unneeded "sandbox_allowed = false;" as this code
will never be run more than once (making it work with multiple
input files isn't trivial).

3 years agoxz: Make Capsicum sandbox more strict with stdin and stdout.
Lasse Collin [Tue, 7 Mar 2023 17:59:23 +0000 (19:59 +0200)] 
xz: Make Capsicum sandbox more strict with stdin and stdout.

3 years agoRevert: "Add warning if Capsicum sandbox system calls are unsupported."
Jia Tan [Wed, 8 Mar 2023 15:08:46 +0000 (23:08 +0800)] 
Revert: "Add warning if Capsicum sandbox system calls are unsupported."

The warning causes the exit status to be 2, so this will cause problems
for many scripted use cases for xz. The sandbox usage is already very
limited already, so silently disabling this allows it to be more usable.

3 years agoxz: Fix -Wunused-label in io_sandbox_enter().
Jia Tan [Tue, 7 Mar 2023 12:02:22 +0000 (20:02 +0800)] 
xz: Fix -Wunused-label in io_sandbox_enter().

Thanks to Xin Li for recommending the fix.

3 years agoxz: Add warning if Capsicum sandbox system calls are unsupported.
Jia Tan [Mon, 6 Mar 2023 13:37:45 +0000 (21:37 +0800)] 
xz: Add warning if Capsicum sandbox system calls are unsupported.

The warning is only used when errno == ENOSYS. Otherwise, xz still
issues a fatal error.

3 years agoxz: Skip Capsicum sandbox system calls when they are unsupported.
Jia Tan [Mon, 6 Mar 2023 13:27:53 +0000 (21:27 +0800)] 
xz: Skip Capsicum sandbox system calls when they are unsupported.

If a system has the Capsicum header files but does not actually
implement the system calls, then this would render xz unusable. Instead,
we can check if errno == ENOSYS and not issue a fatal error.

3 years agoxz: Reorder cap_enter() to beginning of capsicum sandbox code.
Jia Tan [Mon, 6 Mar 2023 13:08:26 +0000 (21:08 +0800)] 
xz: Reorder cap_enter() to beginning of capsicum sandbox code.

cap_enter() puts the process into the sandbox. If later calls to
cap_rights_limit() fail, then the process can still have some extra
protections.

3 years agoliblzma: Clarify lzma_lzma_preset() documentation in lzma12.h.
Jia Tan [Fri, 24 Feb 2023 15:46:23 +0000 (23:46 +0800)] 
liblzma: Clarify lzma_lzma_preset() documentation in lzma12.h.

lzma_lzma_preset() does not guarentee that the lzma_options_lzma are
usable in an encoder even if it returns false (success). If liblzma
is built with default configurations, then the options will always be
usable. However if the match finders hc3, hc4, or bt4 are disabled, then
the options may not be usable depending on the preset level requested.

The documentation was updated to reflect this complexity, since this
behavior was unclear before.

3 years agoCMake: Require that the C compiler supports C99 or a newer standard.
Lasse Collin [Mon, 27 Feb 2023 16:38:35 +0000 (18:38 +0200)] 
CMake: Require that the C compiler supports C99 or a newer standard.

Thanks to autoantwort for reporting the issue and suggesting
a different patch:
https://github.com/tukaani-project/xz/pull/42

3 years agoTests: Small tweak to test-vli.c.
Jia Tan [Fri, 24 Feb 2023 10:10:37 +0000 (18:10 +0800)] 
Tests: Small tweak to test-vli.c.

The static global variables can be disabled if encoders and decoders
are not built. If they are not disabled and -Werror is used, it will
cause an usused warning as an error.

3 years agoliblzma: Replace '\n' -> newline in filter.h documentation.
Jia Tan [Mon, 6 Feb 2023 13:46:43 +0000 (21:46 +0800)] 
liblzma: Replace '\n' -> newline in filter.h documentation.

The '\n' renders as a newline when the comments are converted to html
by Doxygen.

3 years agoliblzma: Shorten return description for two functions in filter.h.
Jia Tan [Mon, 6 Feb 2023 13:45:37 +0000 (21:45 +0800)] 
liblzma: Shorten return description for two functions in filter.h.

Shorten the description for lzma_raw_encoder_memusage() and
lzma_raw_decoder_memusage().

3 years agoliblzma: Reword a few lines in filter.h
Jia Tan [Mon, 6 Feb 2023 13:44:45 +0000 (21:44 +0800)] 
liblzma: Reword a few lines in filter.h

3 years agoliblzma: Improve documentation in filter.h.
Jia Tan [Mon, 6 Feb 2023 13:35:06 +0000 (21:35 +0800)] 
liblzma: Improve documentation in filter.h.

All functions now explicitly specify parameter and return values.
The notes and code annotations were moved before the parameter and
return value descriptions for consistency.

Also, the description above lzma_filter_encoder_is_supported() about
not being able to list available filters was removed since
lzma_str_list_filters() will do this.

3 years agoUpdate THANKS.
Lasse Collin [Thu, 23 Feb 2023 18:46:16 +0000 (20:46 +0200)] 
Update THANKS.

3 years agoliblzma: Avoid null pointer + 0 (undefined behavior in C).
Lasse Collin [Tue, 21 Feb 2023 20:57:10 +0000 (22:57 +0200)] 
liblzma: Avoid null pointer + 0 (undefined behavior in C).

In the C99 and C17 standards, section 6.5.6 paragraph 8 means that
adding 0 to a null pointer is undefined behavior. As of writing,
"clang -fsanitize=undefined" (Clang 15) diagnoses this. However,
I'm not aware of any compiler that would take advantage of this
when optimizing (Clang 15 included). It's good to avoid this anyway
since compilers might some day infer that pointer arithmetic implies
that the pointer is not NULL. That is, the following foo() would then
unconditionally return 0, even for foo(NULL, 0):

    void bar(char *a, char *b);

    int foo(char *a, size_t n)
    {
        bar(a, a + n);
        return a == NULL;
    }

In contrast to C, C++ explicitly allows null pointer + 0. So if
the above is compiled as C++ then there is no undefined behavior
in the foo(NULL, 0) call.

To me it seems that changing the C standard would be the sane
thing to do (just add one sentence) as it would ensure that a huge
amount of old code won't break in the future. Based on web searches
it seems that a large number of codebases (where null pointer + 0
occurs) are being fixed instead to be future-proof in case compilers
will some day optimize based on it (like making the above foo(NULL, 0)
return 0) which in the worst case will cause security bugs.

Some projects don't plan to change it. For example, gnulib and thus
many GNU tools currently require that null pointer + 0 is defined:

    https://lists.gnu.org/archive/html/bug-gnulib/2021-11/msg00000.html

    https://www.gnu.org/software/gnulib/manual/html_node/Other-portability-assumptions.html

In XZ Utils null pointer + 0 issue should be fixed after this
commit. This adds a few if-statements and thus branches to avoid
null pointer + 0. These check for size > 0 instead of ptr != NULL
because this way bugs where size > 0 && ptr == NULL will likely
get caught quickly. None of them are in hot spots so it shouldn't
matter for performance.

A little less readable version would be replacing

    ptr + offset

with

    offset != 0 ? ptr + offset : ptr

or creating a macro for it:

    #define my_ptr_add(ptr, offset) \
            ((offset) != 0 ? ((ptr) + (offset)) : (ptr))

Checking for offset != 0 instead of ptr != NULL allows GCC >= 8.1,
Clang >= 7, and Clang-based ICX to optimize it to the very same code
as ptr + offset. That is, it won't create a branch. So for hot code
this could be a good solution to avoid null pointer + 0. Unfortunately
other compilers like ICC 2021 or MSVC 19.33 (VS2022) will create a
branch from my_ptr_add().

Thanks to Marcin Kowalczyk for reporting the problem:
https://github.com/tukaani-project/xz/issues/36

3 years agoliblzma: Adjust container.h for consistency with filter.h.
Jia Tan [Mon, 6 Feb 2023 16:00:44 +0000 (00:00 +0800)] 
liblzma: Adjust container.h for consistency with filter.h.

3 years agoliblzma: Fix small typos and reword a few things in filter.h.
Jia Tan [Mon, 6 Feb 2023 16:00:09 +0000 (00:00 +0800)] 
liblzma: Fix small typos and reword a few things in filter.h.