]> git.ipfire.org Git - thirdparty/knot-resolver.git/commit
dnstap: don't break request resolution on dnstap errors
authorVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 11 Mar 2021 14:23:28 +0000 (15:23 +0100)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Thu, 11 Mar 2021 14:30:55 +0000 (15:30 +0100)
commit060349c9d643c1e38940fbd874cf7415dee043ef
tree8e2828d14049a0f062d75fcd24907a22299b5159
parent4079a1a962cc528b30d8b0b330c329bf83d85fe8
dnstap: don't break request resolution on dnstap errors

This isn't a regression of 5.3.0 changes.
Layer functions are supposed to return new values for ctx->state,
but here we were sometimes returning kr_error(EFOO) which altered
processing of the request.

Our case: answers directly from policy module would not end up
finishing the request and we'd hit an assert at the end of processing.
NEWS
modules/dnstap/dnstap.c