]> git.ipfire.org Git - thirdparty/glibc.git/commit
nptl: Fix pthread_getattr_np when modules with execstack are allowed (BZ 32897)
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>
Thu, 24 Apr 2025 15:27:44 +0000 (12:27 -0300)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Mon, 28 Apr 2025 13:13:46 +0000 (10:13 -0300)
commit0c3425942374e72c3bcac28b2578117d36b0f9df
tree34cc4753eec69109e6ff938b7fd1f5d3cf9b12c2
parent4c966c078036abe0e36bd86c9eaeb4501e552977
nptl: Fix pthread_getattr_np when modules with execstack are allowed (BZ 32897)

The BZ 32653 fix (12a497c716f0a06be5946cabb8c3ec22a079771e) kept the
stack pointer zeroing from make_main_stack_executable on
_dl_make_stack_executable.  However, previously the 'stack_endp'
pointed to temporary variable created before the call of
_dl_map_object_from_fd; while now we use the __libc_stack_end
directly.

Since pthread_getattr_np relies on correct __libc_stack_end, if
_dl_make_stack_executable is called (for instance, when
glibc.rtld.execstack=2 is set) __libc_stack_end will be set to zero,
and the call will always fail.

The __libc_stack_end zero was used a mitigation hardening, but since
52a01100ad011293197637e42b5be1a479a2f4ae it is used solely on
pthread_getattr_np code.  So there is no point in zeroing anymore.

Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Sam James <sam@gentoo.org>
elf/dl-execstack-tunable.c
elf/dl-execstack.c
elf/dl-load.c
sysdeps/generic/ldsodefs.h
sysdeps/mach/hurd/dl-execstack.c
sysdeps/pthread/Makefile
sysdeps/pthread/tst-stack2-mod.c [new file with mode: 0644]
sysdeps/pthread/tst-stack2.c [new file with mode: 0644]
sysdeps/unix/sysv/linux/dl-execstack.c