]> git.ipfire.org Git - thirdparty/nftables.git/commit
payload: don't remove icmp family dependency in special cases
authorFlorian Westphal <fw@strlen.de>
Tue, 27 Mar 2018 08:18:18 +0000 (10:18 +0200)
committerFlorian Westphal <fw@strlen.de>
Tue, 27 Mar 2018 10:13:21 +0000 (12:13 +0200)
commit126706c23c0458b07d54550dc27561b30f8a43f2
tree6376c2007c5fe725d21219faf3f01e8501dbb222
parentdebb5c542918492545ca3243b49afeb0bde83609
payload: don't remove icmp family dependency in special cases

When using nftables to filter icmp-in-ipv6 or icmpv6-in-ipv4 we
erronously removed the dependency, i.e. "lis ruleset" shows

table ip6 filter { chain output {
type filter hook output priority 0; policy accept;
icmp type destination-unreachable
} }

but that won't restore because of ip vs ipv6 conflict.

After this patch, this lists as

 meta l4proto icmp icmp type destination-unreachable

instead.  We still remove the dependency in "ip" family.

Same applies to icmpv6-in-ip.

Reported-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
src/payload.c