]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commit
fix: wait for gulp tasks ends with the `finish` event 11205/head
authorNicolas Coden <nicolas@ncoden.fr>
Sun, 29 Apr 2018 13:26:38 +0000 (15:26 +0200)
committerNicolas Coden <nicolas@ncoden.fr>
Sun, 29 Apr 2018 13:26:38 +0000 (15:26 +0200)
commit1facce07e943e54fbecf35970dca43a86897f87a
treed83bd896875928c0c815ca12698243752221d106
parent4bcabc1614b6903ea82853ae77f45c8c0870ead2
fix: wait for gulp tasks ends with the `finish` event

`pipe(done)` is a mistake and pipe does not work that way.
`on('end')` may not be triggered because `end` is an interval stream event that does not reflect the whole gulp stream operation. Only `finish` should be used to wait for the operation end.

See: https://stackoverflow.com/a/41003102/4317384
gulp/tasks/customizer.js
gulp/tasks/deploy.js
gulp/tasks/test.js