]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:rpc_server/lsa: let LookupSids* behave like Windows 2022/2025
authorStefan Metzmacher <metze@samba.org>
Fri, 10 Mar 2023 14:05:15 +0000 (15:05 +0100)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 29 Jan 2025 01:14:40 +0000 (01:14 +0000)
commit218a0f067c894cbf61cde6183a269c0474d64ddc
treed9d3e04b625b92587157e68c7efd9590f40304f5
parent9f369c62317d74615834f99a088caababef685fc
s4:rpc_server/lsa: let LookupSids* behave like Windows 2022/2025

The important part is the INVALID_SID should not
cause an early exit of the loop.

We need to return the intact names array with the
correct count. And only return INVALID_SID
if we would otherwise return NONE_MAPPED.

For SOME_NOT_MAPPED we need to ignore invalid sids
and just pretend they are not mapped.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14213

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
selftest/knownfail.d/samba.tests.dcerpc.lsa [deleted file]
source4/rpc_server/lsa/lsa_lookup.c