]> git.ipfire.org Git - thirdparty/samba.git/commit
ldb/attrib_handler casefold: simplify space dropping
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 8 Dec 2020 09:00:55 +0000 (22:00 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 7 Apr 2021 03:16:39 +0000 (03:16 +0000)
commit24ddc1ca9cad95673bdd8023d99867707b37085f
tree7716ee0fc8ad7c478f255b4382f8b665b7ba29c0
parent2b2f4f519454beb6f2a46705675a62274019fc09
ldb/attrib_handler casefold: simplify space dropping

As seen in CVE-2021-20277, ldb_handler_fold() has been making mistakes
when collapsing spaces down to a single space.

This patch fixes the way it handles internal spaces (CVE-2021-20277
was about leading spaces), and involves a rewrite of the parsing loop.

The bug has a detailed description of the problem.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14656

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Apr  7 03:16:39 UTC 2021 on sn-devel-184
lib/ldb/common/attrib_handlers.c
lib/ldb/tests/ldb_match_test.c