]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Refactor some SIMD and popcount macros.
authorNathan Bossart <nathan@postgresql.org>
Wed, 21 Jan 2026 20:21:00 +0000 (14:21 -0600)
committerNathan Bossart <nathan@postgresql.org>
Wed, 21 Jan 2026 20:21:00 +0000 (14:21 -0600)
commit25dc4850747bb12e871af3589736463edd1d2aa6
treea0dcfeee190d93c0da8b6303cd1fc6fdc08ede5e
parent8c6653516c5ad23628cc50d4cee1e6446e7f758d
Refactor some SIMD and popcount macros.

This commit does the following:

* Removes TRY_POPCNT_X86_64.  We now assume that the required CPUID
intrinsics are available when HAVE_X86_64_POPCNTQ is defined, as we
have done since v16 for meson builds when
USE_SSE42_CRC32C_WITH_RUNTIME_CHECK is defined and since v17 when
USE_AVX512_POPCNT_WITH_RUNTIME_CHECK is defined.

* Moves the MSVC check for HAVE_X86_64_POPCNTQ to configure-time.
This way, we set it for all relevant platforms in one place.

* Moves the #defines for USE_SSE2 and USE_NEON to c.h so that they
can be used elsewhere without including simd.h.  Consequently, we
can remove the POPCNT_AARCH64 macro.

* Moves the #includes for pg_bitutils.h to below the system headers
in pg_popcount_{aarch64,x86}.c, since we no longer depend on macros
from pg_bitutils.h to decide which system headers to use.

Reviewed-by: John Naylor <johncnaylorls@gmail.com>
Discussion: https://postgr.es/m/aWf_InS1VrbeXAfP%40nathan
meson.build
src/include/c.h
src/include/port/pg_bitutils.h
src/include/port/simd.h
src/port/pg_bitutils.c
src/port/pg_popcount_aarch64.c
src/port/pg_popcount_x86.c