]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/i915: Fix conversion between clock ticks and nanoseconds
authorUmesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thu, 16 Oct 2025 00:03:51 +0000 (17:03 -0700)
committerUmesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thu, 16 Oct 2025 21:40:22 +0000 (14:40 -0700)
commit2ada9cb1df3f5405a01d013b708b1b0914efccfe
tree6d29ef86263887d2546c81e00a8b5e8db8796092
parentb03be3ef2d6aa46c14522a7792d515c61849066c
drm/i915: Fix conversion between clock ticks and nanoseconds

When tick values are large, the multiplication by NSEC_PER_SEC is larger
than 64 bits and results in bad conversions.

The issue is seen in PMU busyness counters that look like they have
wrapped around due to bad conversion. i915 PMU implementation returns
monotonically increasing counters. If a count is lesser than previous
one, it will only return the larger value until the smaller value
catches up. The user will see this as zero delta between two
measurements even though the engines are busy.

Fix it by using mul_u64_u32_div()

Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14955
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Link: https://lore.kernel.org/r/20251016000350.1152382-2-umesh.nerlige.ramappa@intel.com
drivers/gpu/drm/i915/gt/intel_gt_clock_utils.c