]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dm vdo: use a short static string for thread name prefix
authorMatthew Sakai <msakai@redhat.com>
Wed, 29 Jan 2025 23:26:05 +0000 (18:26 -0500)
committerMikulas Patocka <mpatocka@redhat.com>
Mon, 3 Feb 2025 13:10:37 +0000 (14:10 +0100)
commit3280c9313c9adce01550cc9f00edfb1dc7c744da
tree6cc084d819594b2a8671b16bb8c82c3b3e6f660f
parent8892606045fda29be7adfc5fba21bb1dfe079b93
dm vdo: use a short static string for thread name prefix

Also remove MODULE_NAME and a BUG_ON check, both unneeded.

This fixes a warning about string truncation in snprintf that
will never happen in practice:

drivers/md/dm-vdo/vdo.c: In function ‘vdo_make’:
drivers/md/dm-vdo/vdo.c:564:5: error: ‘%s’ directive output may be truncated writing up to 55 bytes into a region of size 16 [-Werror=format-truncation=]
    "%s%u", MODULE_NAME, instance);
     ^~
drivers/md/dm-vdo/vdo.c:563:2: note: ‘snprintf’ output between 2 and 66 bytes into a destination of size 16
  snprintf(vdo->thread_name_prefix, sizeof(vdo->thread_name_prefix),
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    "%s%u", MODULE_NAME, instance);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Matthew Sakai <msakai@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-vdo/vdo.c