]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Add check for invalid iothread_id in qemuDomainChgIOThread
authorJohn Ferlan <jferlan@redhat.com>
Thu, 13 Aug 2015 13:19:01 +0000 (09:19 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Tue, 18 Aug 2015 18:36:21 +0000 (14:36 -0400)
commit32c6b1908bbf8a1aa4a2692135e7d02a166a0317
tree80e2c9a8fed5e7098a6518b5c96c110043589616
parent53058e11aa1d5ba9e86153ed47e97c4988b5eef6
qemu: Add check for invalid iothread_id in qemuDomainChgIOThread

https://bugzilla.redhat.com/show_bug.cgi?id=1251886

Since iothread_id == 0 is an invalid value for QEMU let's point
that out specifically.  For the IOThreadDel code, the failure would
have ended up being a failure to find the IOThread ID; however, for
the IOThreadAdd code - an IOThread 0 was added and that isn't good.

It seems during many reviews/edits to the code the check for
iothread_id = 0 being invalid was lost - it could have originally
been in the API code, but requested to be moved - I cannot remember.
src/qemu/qemu_driver.c