]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
coresight: ETR: Fix ETR buffer use-after-free issue
authorXiaoqi Zhuang <xiaoqi.zhuang@oss.qualcomm.com>
Tue, 21 Oct 2025 08:45:25 +0000 (16:45 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Wed, 5 Nov 2025 16:06:06 +0000 (16:06 +0000)
commit35501ac3c7d40a7bb9568c2f89d6b56beaf9bed3
tree7969d342abee77dda459e6296dd915c82c442ee9
parentdcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
coresight: ETR: Fix ETR buffer use-after-free issue

When ETR is enabled as CS_MODE_SYSFS, if the buffer size is changed
and enabled again, currently sysfs_buf will point to the newly
allocated memory(buf_new) and free the old memory(buf_old). But the
etr_buf that is being used by the ETR remains pointed to buf_old, not
updated to buf_new. In this case, it will result in a memory
use-after-free issue.

Fix this by checking ETR's mode before updating and releasing buf_old,
if the mode is CS_MODE_SYSFS, then skip updating and releasing it.

Fixes: bd2767ec3df2 ("coresight: Fix run time warnings while reusing ETR buffer")
Signed-off-by: Xiaoqi Zhuang <xiaoqi.zhuang@oss.qualcomm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Tested-by: Leo Yan <leo.yan@arm.com>
Link: https://lore.kernel.org/r/20251021-fix_etr_issue-v3-1-99a2d066fee2@oss.qualcomm.com
drivers/hwtracing/coresight/coresight-tmc-etr.c