]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: don't use auto-generated NVRAM path in tests
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 23 Feb 2022 12:45:51 +0000 (12:45 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 23 Feb 2022 18:08:49 +0000 (18:08 +0000)
commit392292cd99ee275f986e9e21f325a9fee8e8bbfe
tree55fef35e0c2c991e3ffbd89cfa4f7346e235f1e0
parente5804d4cbf265511cfdc934fd7406d8a133ef1a0
tests: don't use auto-generated NVRAM path in tests

By using the auto-generated NVRAM path in test data files, we won't see
bugs where a user specified path gets accidentally overwritten by a
post-parse callback, or VM startup. For example, this caused us to miss
the bug fixed by:

  commit 24adb6c7a6cbd8ce5f9de67e6af5d89e0e57c270
  Author: Michal Prívozník <mprivozn@redhat.com>
  Date:   Wed Feb 23 08:50:44 2022 +0100

    qemu: Don't regenerate NVRAM path if parsed from domain XML

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
31 files changed:
tests/qemuxml2argvdata/aarch64-acpi-uefi.args
tests/qemuxml2argvdata/aarch64-acpi-uefi.xml
tests/qemuxml2argvdata/aarch64-noacpi-uefi.args
tests/qemuxml2argvdata/aarch64-noacpi-uefi.xml
tests/qemuxml2argvdata/aarch64-virt-graphics.aarch64-latest.args
tests/qemuxml2argvdata/aarch64-virt-graphics.xml
tests/qemuxml2argvdata/aarch64-virt-headless.aarch64-latest.args
tests/qemuxml2argvdata/aarch64-virt-headless.xml
tests/qemuxml2argvdata/bios-nvram-os-interleave.xml
tests/qemuxml2argvdata/bios-nvram-secure.args
tests/qemuxml2argvdata/bios-nvram-secure.xml
tests/qemuxml2argvdata/bios-nvram.args
tests/qemuxml2argvdata/bios-nvram.xml
tests/qemuxml2argvdata/hvf-aarch64-virt-headless.args
tests/qemuxml2argvdata/hvf-aarch64-virt-headless.xml
tests/qemuxml2argvdata/os-firmware-bios.xml
tests/qemuxml2argvdata/os-firmware-efi-secboot.x86_64-latest.args
tests/qemuxml2argvdata/os-firmware-efi-secboot.xml
tests/qemuxml2argvdata/os-firmware-efi.x86_64-latest.args
tests/qemuxml2argvdata/os-firmware-efi.xml
tests/qemuxml2argvdata/q35-acpi-uefi.args
tests/qemuxml2argvdata/q35-acpi-uefi.xml
tests/qemuxml2argvdata/q35-noacpi-uefi.xml
tests/qemuxml2xmloutdata/aarch64-virt-graphics.aarch64-latest.xml
tests/qemuxml2xmloutdata/aarch64-virt-headless.aarch64-latest.xml
tests/qemuxml2xmloutdata/bios-nvram-os-interleave.xml
tests/qemuxml2xmloutdata/bios-nvram.xml
tests/qemuxml2xmloutdata/hvf-aarch64-virt-headless.xml
tests/qemuxml2xmloutdata/os-firmware-bios.x86_64-latest.xml
tests/qemuxml2xmloutdata/os-firmware-efi-secboot.x86_64-latest.xml
tests/qemuxml2xmloutdata/os-firmware-efi.x86_64-latest.xml