]> git.ipfire.org Git - thirdparty/libvirt.git/commit
remote: forbid the --listen arg when systemd socket activation
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 22 Aug 2019 13:52:16 +0000 (14:52 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 27 Aug 2019 09:46:37 +0000 (10:46 +0100)
commit3a6a725b8f575890ee6c151ad1f46ea0ceea1f3b
tree32b8f0353e7eb28bc018fdc686586656ff788efd
parent581767a98ab5f674ac335d6c270efa8576bfdfbf
remote: forbid the --listen arg when systemd socket activation

When using systemd socket activation the --listen arg has no
effect. This is confusing to users upgrading from previous versions of
libvirt as their config is silently ignored. Turn use of --listen into a
fatal error when sockets are passed from systemd.

This helps the admin discover the change in behaviour and thus decide
whether to stick with socket activation or revert to previous behaviour.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/remote/libvirtd.pod
src/remote/remote_daemon.c