]> git.ipfire.org Git - thirdparty/libvirt.git/commit
build: use correct type for pid and similar types
authorEric Blake <eblake@redhat.com>
Fri, 10 Feb 2012 23:08:11 +0000 (16:08 -0700)
committerEric Blake <eblake@redhat.com>
Fri, 2 Mar 2012 13:57:43 +0000 (06:57 -0700)
commit3e2c3d8f6d5ca4a6135101cda3e73c51304af683
treee586d4a1a39ff74a95fdc3c08b1eb47833ae148e
parent5c3a15647d1c345b64326b97b3c21597f6f7e1ce
build: use correct type for pid and similar types

No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid
constructs like 'int pid'.  Our API in libvirt-qemu cannot be
changed without breaking ABI; but then again, libvirt-qemu can
only be used on systems that support UNIX sockets, which rules
out Windows (even if qemu could be compiled there) - so for all
points on the call chain that interact with this API decision,
we require a different variable name to make it clear that we
audited the use for safety.

Adding a syntax-check rule only solves half the battle; anywhere
that uses printf on a pid_t still needs to be converted, but that
will be a separate patch.

* cfg.mk (sc_correct_id_types): New syntax check.
* src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't
use pid_t for pid, and validate for overflow.
* include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name
for syntax check.
* src/vmware/vmware_conf.c (vmwareExtractPid): Likewise.
* src/driver.h (virDrvDomainQemuAttach): Likewise.
* tools/virsh.c (cmdQemuAttach): Likewise.
* src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise.
* src/qemu_protocol-structs (qemu_domain_attach_args): Likewise.
* src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal):
Likewise.
* src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise.
(qemuParseCommandLinePid): Use pid_t for pid.
* daemon/libvirtd.c (daemonForkIntoBackground): Likewise.
* src/conf/domain_conf.h (_virDomainObj): Likewise.
* src/probes.d (rpc_socket_new): Likewise.
* src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise.
* src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach):
Likewise.
* src/qemu/qemu_process.c (qemuProcessAttach): Likewise.
* src/qemu/qemu_process.h (qemuProcessAttach): Likewise.
* src/uml/uml_driver.c (umlGetProcessInfo): Likewise.
* src/util/virnetdev.h (virNetDevSetNamespace): Likewise.
* src/util/virnetdev.c (virNetDevSetNamespace): Likewise.
* tests/testutils.c (virtTestCaptureProgramOutput): Likewise.
* src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t,
and gid_t rather than int.
* src/security/security_dac.c (virSecurityDACSetOwnership): Likewise.
* src/conf/storage_conf.c (virStorageDefParsePerms): Avoid
compiler warning.
24 files changed:
cfg.mk
daemon/libvirtd.c
include/libvirt/libvirt-qemu.h
src/conf/domain_conf.h
src/conf/storage_conf.c
src/conf/storage_conf.h
src/driver.h
src/libvirt-qemu.c
src/probes.d
src/qemu/qemu_command.c
src/qemu/qemu_command.h
src/qemu/qemu_driver.c
src/qemu/qemu_process.c
src/qemu/qemu_process.h
src/qemu_protocol-structs
src/remote/qemu_protocol.x
src/security/security_dac.c
src/uml/uml_driver.c
src/util/cgroup.c
src/util/virnetdev.c
src/util/virnetdev.h
src/vmware/vmware_conf.c
tests/testutils.c
tools/virsh.c