]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mlxsw: spectrum: Fix memory leak in mlxsw_sp_flower_stats()
authorZilin Guan <zilin@seu.edu.cn>
Wed, 12 Nov 2025 05:21:14 +0000 (05:21 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 14 Nov 2025 01:25:33 +0000 (17:25 -0800)
commit407a06507c2358554958e8164dc97176feddcafc
treeea4bfa377d8b678550b52da6751513826afd49c4
parentf796a8dec9beafcc0f6f0d3478ed685a15c5e062
mlxsw: spectrum: Fix memory leak in mlxsw_sp_flower_stats()

The function mlxsw_sp_flower_stats() calls mlxsw_sp_acl_ruleset_get() to
obtain a ruleset reference. If the subsequent call to
mlxsw_sp_acl_rule_lookup() fails to find a rule, the function returns
an error without releasing the ruleset reference, causing a memory leak.

Fix this by using a goto to the existing error handling label, which
calls mlxsw_sp_acl_ruleset_put() to properly release the reference.

Fixes: 7c1b8eb175b69 ("mlxsw: spectrum: Add support for TC flower offload statistics")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20251112052114.1591695-1-zilin@seu.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c