]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commit
base.bbclass: Use bb.fatal() instead of raising FuncFailed
authorUlf Magnusson <ulfalizer@gmail.com>
Sat, 1 Oct 2016 02:46:50 +0000 (04:46 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 4 Oct 2016 15:29:04 +0000 (16:29 +0100)
commit4359ef089566375ccc502f587cd3be670a2d67f0
tree80f43ffb320e38496f700960870a88d99c7663e4
parent0c9ba38d929ebe5da2c2e0b2a605e6d12cc57266
base.bbclass: Use bb.fatal() instead of raising FuncFailed

This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.

Motivating quote below:

< kergoth> the *original* intent was for the function/task to error via
           whatever appropriate means, bb.fatal, whatever, and
           funcfailed was what you'd catch if you were calling
           exec_func/exec_task. that is, it's what those functions
           raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself

FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.

(From OE-Core rev: 9635af9785509a39c1ac2509740d46276119a0ca)

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/base.bbclass