]> git.ipfire.org Git - thirdparty/linux.git/commit
net: stmmac: Drop TBI/RTBI PCS flags
authorSerge Semin <fancer.lancer@gmail.com>
Wed, 29 May 2024 08:40:34 +0000 (09:40 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 31 May 2024 01:30:10 +0000 (18:30 -0700)
commit482b3c3ba757f8fb7368f208b411d2bad3004702
tree43dfb00517871616e736292961b548c1323bb3c6
parenta79d8fe2ff8e78e549dc86cc853a61b029404871
net: stmmac: Drop TBI/RTBI PCS flags

First of all the flags are never set by any of the driver parts. If nobody
have them set then the respective statements will always have the same
result. Thus the statements can be simplified or even dropped with no risk
to break things.

Secondly shall any of the TBI or RTBI flag is set the MDIO-bus
registration will be bypassed. Why? It really seems weird. It's perfectly
fine to have a TBI/RTBI-capable PHY configured over the MDIO bus
interface.

Based on the notes above the TBI/RTBI PCS flags can be freely dropped thus
simplifying the driver code.

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/E1sCErK-00EOPf-EP@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/common.h
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c