]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: snapshot: Don't attempt to resume cpus if they were not paused
authorPeter Krempa <pkrempa@redhat.com>
Wed, 14 Dec 2016 07:01:34 +0000 (08:01 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 15 Dec 2016 08:46:41 +0000 (09:46 +0100)
commit4b951d1e38259ff5d03e9eedb65095eead8099e1
tree1f79eb620752bdf25d576f11d6783b79a1deabd3
parente8f167a6236cff7430076849e7938b783f417bc5
qemu: snapshot: Don't attempt to resume cpus if they were not paused

External disk-only snapshots with recent enough qemu don't require
libvirt to pause the VM. The logic determining when to resume cpus was
slightly flawed and attempted to resume them even if they were not
paused by the snapshot code. This normally was not a problem, but with
locking enabled the code would attempt to acquire the lock twice.

The fallout of this bug would be a error from the API, but the actual
snapshot being created. The bug was introduced with when adding support
for external snapshots with memory (checkpoints) in commit f569b87.

Resolves problems described by:
https://bugzilla.redhat.com/show_bug.cgi?id=1403691
src/qemu/qemu_driver.c