]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: remove redundant needReply argument of qemuAgentCommand
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Thu, 5 Mar 2020 14:47:02 +0000 (17:47 +0300)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 12 Mar 2020 17:40:55 +0000 (18:40 +0100)
commit52532073d80776aa80257d5a1509524228da228d
treecede52361ec7b46524df712c3f7ff75accd56259
parentb47e3b9b5c556b7bc3c7d0d1a6452e0df8630653
qemu: remove redundant needReply argument of qemuAgentCommand

needReply added in [1] looks redundant. Indeed it is set to false only
when mon->await_event is set too (the only exception qemuAgentFSTrim
which is mistaken).

However it fixes the issue when qemuAgentCommand exits on error path and
mon->await_event is not reset. Let's instead reset mon->await_event properly.

Also remove "Woken up by event" debug message as it can be misleading.
We can get it also if monitor is closed due to serial changed event
currently. Anyway both qemuAgentClose and qemuAgentNotifyEvent log
itself.

[1] qemu: make sure agent returns error when required data are missing

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_agent.c