]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: stmmac: dwmac-rk: Fix disabling set_clock_selection
authorSebastian Reichel <sebastian.reichel@collabora.com>
Tue, 14 Oct 2025 15:49:34 +0000 (17:49 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Oct 2025 00:12:46 +0000 (17:12 -0700)
commit7f864458e9a6d2000b726d14b3d3a706ac92a3b0
tree261100dd156e843cd61bfbbdc97d50d165212158
parentbf29555f5bdc017bac22ca66fcb6c9f46ec8788f
net: stmmac: dwmac-rk: Fix disabling set_clock_selection

On all platforms set_clock_selection() writes to a GRF register. This
requires certain clocks running and thus should happen before the
clocks are disabled.

This has been noticed on RK3576 Sige5, which hangs during system suspend
when trying to suspend the second network interface. Note, that
suspending the first interface works, because the second device ensures
that the necessary clocks for the GRF are enabled.

Cc: stable@vger.kernel.org
Fixes: 2f2b60a0ec28 ("net: ethernet: stmmac: dwmac-rk: Add gmac support for rk3588")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251014-rockchip-network-clock-fix-v1-1-c257b4afdf75@collabora.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c