]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-42388: Fix subprocess.check_output input=None when text=True (GH-23467)
authorGregory P. Smith <greg@krypto.org>
Fri, 25 Dec 2020 04:57:21 +0000 (20:57 -0800)
committerGitHub <noreply@github.com>
Fri, 25 Dec 2020 04:57:21 +0000 (20:57 -0800)
commit64abf373444944a240274a9b6d66d1cb01ecfcdd
tree7cc3f785fec2389d6dd9b7bd05860e45ee3f459c
parent8badadec53cbf9dc049c5b54198c5689481e3f3f
bpo-42388: Fix subprocess.check_output input=None when text=True (GH-23467)

When the modern text= spelling of the universal_newlines= parameter was added
for Python 3.7, check_output's special case around input=None was overlooked.
So it behaved differently with universal_newlines=True vs text=True.  This
reconciles the behavior to be consistent and adds a test to guarantee it.

Also clarifies the existing check_output documentation.

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
Doc/library/subprocess.rst
Lib/subprocess.py
Lib/test/test_subprocess.py
Misc/NEWS.d/next/Library/2020-11-22-11-22-28.bpo-42388.LMgM6B.rst [new file with mode: 0644]