]> git.ipfire.org Git - thirdparty/samba.git/commit
tevent: Fix a race condition
authorVolker Lendecke <vl@samba.org>
Fri, 10 Nov 2017 20:22:26 +0000 (21:22 +0100)
committerKarolin Seeger <kseeger@samba.org>
Mon, 13 Nov 2017 13:23:54 +0000 (14:23 +0100)
commit6a43b1b17902c8fbc319e13f31f6c9177f38371c
treed5168689e752982a6668b5712722f3173d1fd64d
parentdf214a3808f25d45229f599a43886b71d482d4f5
tevent: Fix a race condition

We can't rely on tctx to exist after we unlocked the mutex. It took a
while, but this does lead to data corruption. If *tctx is replaced with
something where tctx->wakeup_fd points to a real, existing file
descriptor, we're screwed. And by screwed, this means file corruption
on disk.

Again. I am not tall enough for this business.

http://bholley.net/blog/2015/must-be-this-tall-to-write-multi-threaded-code.html

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13130

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Nov 11 03:20:09 CET 2017 on sn-devel-144

(cherry picked from commit 20cfcb7dbc5dd099384b76a76e3d35cf627100b6)

Autobuild-User(v4-6-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-6-test): Mon Nov 13 14:23:54 CET 2017 on sn-devel-144
lib/tevent/tevent_threads.c